From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A01C9469C5 for ; Tue, 1 Aug 2023 11:10:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB26A68C05A; Tue, 1 Aug 2023 14:10:07 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2012.outbound.protection.outlook.com [40.92.73.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B64E68C0A7 for ; Tue, 1 Aug 2023 14:10:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W264o9U53KfKp8ldt8DzKX766hoEinsnDaNqJ/pUJQDoyV9BTX84yyoejBb9eqzKbOqnCrmccNDEfEnrrmqCZT/cCaB68a+2xyOFN+QWCRb278Y237oW2zxe2vPd5/Mp77JZiQbomf/k4s408AmnVzcYtEO+7HJ3syakKKHcn0q/w3NGTsruMyp09AdsAalzQF06+wSqyRdzu95VRApj+ucAEITLALc8faZNaQh1zwO22dP36EKfje0lbSdWl6iVcROcY/7frJsX4sR5ZreM4IN3jqGKZ0xb4o2D9Qi4i1yNsKWIjsUfSMkcfaEHzS/eNjiSsg/ehrErH58s7fwFLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L5m4JzQvhHp54/oxZRyxC3MkBtdsggUh8vtUtgGjFiA=; b=PprSDOHDWiXxVkRm02DUB5XoT6GQE+2BPj/OJakr1s5AcNp35gyzeVDd0FYXv1xbc2VnHeUxyWQ0CoeuK+ZnBj8GyIImFnv4qU2Q5s/LuL2DWln5RBX/7+MjXzsHBp8Jf1ErhiZGD3QaEsdxCWuPDKHiEtIR9Vu0kRGcsxXDUHXwKStqxYpmyHXVhIsuAF4A4fJJaOvtqkvKO7WsDQvu05yxIW8GhAmKB2XUFMKJl3t2NbaxLS0Sa7bh619Se9hlonnF8Xgrs2Qu+1pLHy9xO5nnbwiyAJ5rNzEJvPuGc4IRYmeg1gdcpq+nId8Tq+kgSf6R7wKm5nt0rse4D57M2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L5m4JzQvhHp54/oxZRyxC3MkBtdsggUh8vtUtgGjFiA=; b=EBxoUnU8QTDl7jrdT3+VYamYzkYlvb3EcTkBL+YONeIb42HuuGxgJVwm9LsMrGetOKq62+5FacwbCOLKejCg1lw3bwBhNFz4KO/3dVFNTR5v5MsBsIWHE9eZpWDYKu/aDw7W37pcizOpu3cEtbJsV74V/mM2/uiS8rv8ARGVtLWZvh0l4yA0eQVpCoTCD3L2/NGNh5VFhDmg++TSACFCF72kPNY+MvGpvMXcdeRjpsFmJxD1rVHKeKcfiqik1fEN3FnezC3FNHP/XjPLJS8zF3kXubihyUu4zOLAV00+YeMJFn+i+j+n5507ZeTTFNzwEmL/2uLWWGt9Xg3SKwMJ5A== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0139.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:322::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 10:54:42 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 10:54:42 +0000 Message-ID: Date: Tue, 1 Aug 2023 12:55:49 +0200 To: ffmpeg-devel@ffmpeg.org References: <20230722234621.28731-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20230722234621.28731-1-michael@niedermayer.cc> X-TMN: [WRlGJRcaOblkhmytYv3qV/EcXacU+zY55hJxLphc1sw=] X-ClientProxiedBy: FRYP281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::24) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <423ffeb3-f195-2c75-e4b9-88a6912220e2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0139:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e65fb9e-de73-4cb3-9608-08db927db5c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UZclK/YlE9hEu2+tay8B4a+XijuMv/GhzOP2TyEWDmgc9LiNoFijxY/+pauLeJBumxN5xTWNO4o5+5MycMs30/ncLPe5LLO1GCI8OZJLekTxNwdhbRUKPpNtk1TAi1ZWv3u2mPLQggsLavE2eqH8+XkGc0Ffi80i6wtpEkmAkqyhHWxT2wLyBp4JAtMaEWWR70eCKgmHDepQmt3I3q3FboWaW9nDAwXY/YxHja4Sq9o56uSvCzna8EmOQHJTFYEgCfahOZjyOC+71DPQpnqxeTaPFJJDe2nkjnb/6gfPWpuev27qVwFUoqlWqWtXOOj/ve4WFTexhahZuxL7TMSu0JOSHlFE2jpxIpmnRzya15EA1JB3RRvMceuUl5+kEVVe1PvwEXO2zdbwvyKc3dbQ5BMRDUbA1ZojjhYZi24v86T2aRE09DYrpHyr1OSMLcKk7zcF4x0h29Pw6/O9c872WzCT25/0bxJ2gM6CBHRkK0zPBGXdL9L3dlHicExcjH80RwkNly6fBad0TRVAImqP6VzbVuQ7/6HrSbutzTM+KaWojRx207VAHow11HAbrZlT X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z25MTDF3TmdwMnJMZk9MYmJFUGlBbS9QN1c4RnRZSFJjdFhoWnpBbzkzNXEx?= =?utf-8?B?dGY3UndHU0JXMjFEc25pYm9qL3MyaEptazZlYm1paGV0amFKU3B2eUlmQ2dH?= =?utf-8?B?Zkgvd29xejNndzNNMlU0QUhML01rdnJxNzZtemIrU1RHbWxVeXZFcFJrM0xh?= =?utf-8?B?Rnh4WHRXYVliNUhCK1pYWklXWWhkU3Bxc1pSRm5taXpPYjZsU1lwOVg2ZmxE?= =?utf-8?B?a2JGNVNiOE52MFg3VzZrVzhMa1FucXBvamdzOGlMejlEdUtzUmdWWkxpKzdS?= =?utf-8?B?Z3EweGU3MDhKSUpiNEFGbkFtdkkvNHJmVGpoOFdkZ1ZOOVh1Rzl3TW1BbDRK?= =?utf-8?B?MUtwZGNEdmJhcDcwaTVEekdnY3pnVDlNUlpmaEJ0Tnp3K0xUSGRxMmhsbnpG?= =?utf-8?B?Rm1RNkRjSE45bSt4clJnUjJOZDBmNDVxbHAwdk43SG1peklKMmdIbzRUZ0pj?= =?utf-8?B?c0c0a3RLSWRqNm9FRG9CZ0J1aFFNODZ2MXk0SzJkMk1LdUg2cEhVQ0JxZmJT?= =?utf-8?B?a040Q0JsbTg1SlpaN1h1NkRqMGk3VEV0T0RpaUdDMStrcWhrRlBjN1RKYWN3?= =?utf-8?B?YUFGcTFnMEZaczN0YWhqQUtnR0V2ZlRUc0hNK0RGN1VUaHNvTWJXK1dQYlU4?= =?utf-8?B?RGt3RGUrWlVPVmxTRWhTNGNqaDZtb2l4T0xEUWNxVDBUWGcrMlVYUWExeWtt?= =?utf-8?B?LzQ0LzNYa3l1aTFBT1BVYk1vS0dpUUNwby9EWXhtb1dQV0F6V2lqQ0FLbWt5?= =?utf-8?B?NWw4b1FVUFhkNEZRdGJKdFdMZWNLNEdZK1I0eFFTOTVQRC9zMXFydlFVeTVl?= =?utf-8?B?SFlYV0ZSU0xDQ2M1aTBKdVdGNklBczNGMVJtVy9RMk9FeGVHY2MvQVlnTnh4?= =?utf-8?B?aTlDTXJMRFkwRXBDKzV2U1h6UkxFcXU1MU1FQUFubEhWTFJadDMrVmZ3SXFx?= =?utf-8?B?OWZkdzB2VC9MR1RyRWRod3JINkVBN0MrWjdvQU9xNzlEMXhVSWI4d2ozaFE2?= =?utf-8?B?Q0RIYVFjK0xPRG5ZYjd0bGJFbExUU2Z4cThiRDlSTEFCMGp1MkpSVTU2aWJl?= =?utf-8?B?OHJOWmNuSTljNWkzc2tBdEN4ZSs5bzJxUjYyVlpxME56Y25uSlE4OXB1L3BJ?= =?utf-8?B?K1p4NjBHWUxDL0FTTVJYekZTcURQa3VtNUhhYnR0NmdPQ0s5MExRVXppaEZJ?= =?utf-8?B?Y2Uxd2ZUN0YwbFZoNUpZQ3IyR0ZJaXR4bjl3VE9uV2ZENmI1eVlvSE5QSG01?= =?utf-8?B?MnhiZ3JFbVhKNUZDYXRnOE0xTDhTeG42dGppMjQrTys4ZkxWZ3RwR1FuV1hD?= =?utf-8?B?OWNRam9RaElXOTNvVzJadE13QnVEQ0c4d2tGbDBRdkJkVUtEOEtneUErZ2tT?= =?utf-8?B?Y3ZGN0hqOUgwSk1nSnpxdEVTckZSOS9rZkxlRHEvT05hQXY2N081ck1ieTlL?= =?utf-8?B?RFlQN0ZyT051TXljZzVwU1hybnZGM1JVVWhmUkh4TEJiNEFYRWQrYnhDeGU5?= =?utf-8?B?aEFBZ3hERnJ6ZXN0ZnoyV3N1S1pMOER2cXBlSURuNlYyZzlMWGNWdDlqZi9F?= =?utf-8?B?YXBhRTdEWWRvdmFGWU1kMVhiVHhXemovbUpDcTJoSGEyL1ZINlZMc1J0S0RN?= =?utf-8?B?TW1BWmFCcUNwTHBnQWV3ZmlJT1ZyTGpQQ2pzWGdVNGFySHdGVWR6MTdNRVlP?= =?utf-8?Q?EQApO7xrKOlrV5F4tQSf?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e65fb9e-de73-4cb3-9608-08db927db5c5 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 10:54:42.4594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0139 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/avr: Check sample rate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: 54979/clusterfuzz-testcase-minimized-ffmpeg_dem_AVR_fuzzer-6681035461230592 > Fixes: Timeout > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/avr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/avr.c b/libavformat/avr.c > index 1cc4d56bfb..3fe8614b25 100644 > --- a/libavformat/avr.c > +++ b/libavformat/avr.c > @@ -75,6 +75,9 @@ static int avr_read_header(AVFormatContext *s) > avio_skip(s->pb, 20); > avio_skip(s->pb, 64); > > + if (st->codecpar->sample_rate == 0) > + return AVERROR_INVALIDDATA; > + > st->codecpar->codec_id = ff_get_pcm_codec_id(bps, 0, 1, sign); > if (st->codecpar->codec_id == AV_CODEC_ID_NONE) { > avpriv_request_sample(s, "Bps %d and sign %d", bps, sign); Why don't you check this directly after having read the sample rate? That way the value would still be in a register. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".