From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D4BF446B37 for ; Fri, 4 Aug 2023 17:30:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0518168C6EE; Fri, 4 Aug 2023 20:30:06 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2086.outbound.protection.outlook.com [40.92.75.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 498BA680A6D for ; Fri, 4 Aug 2023 20:29:59 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5dJLcureERg+fI9kcKgZRRd/T0ZIDLvy0SdVYCMvPGeW6yFfkrCvooUtdbulFr57a3XmFT2dY+In9/+vI2/GNEb66KyY6y0yN1hylZcEA166EptXrpgZ86W3A6MKryRIO722LEAFJqxks4YPZQ7BRw8sBNJK13UOjF+y873/94LTNDS45XWXtK/difQfunw22VXO3vBDPejqm4YvNZookK4tSe5Wsutl/tI2ujkKdEETQ9Xxw48kfi/M6XugvlNO1HN10YOmlIyPwsjlpO2vhndLNKodpDOUnDYMeygO+6TulhhrvEWtJfowkER2lR7bqTsJ0gIDfgXgWSuJujwVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b78xjMnkeloM+QppXEKkLKkj1STNZupq2t82vEKJcqA=; b=TP2aaMlfCw+5z8ch9iOAmxOrJg3s1fsND0Ogwmrye4mSeYaRHjI7r1EWqAXgRF5Uw3RLRtJjRVQftBsAULApbll5KB55a3bN0B4/PT3PJcBh0uqqcFCscgi9qWHBsqY4ug8WdsAm9Zp70Z/4exVgF970WGPRc1VQnP9i3DU8buto8JLk3YIwihGnfhtR1ZBiui/x8J4cs/1qMafRAkeqkKT6G5XDJGv20gktxOLCZalxgTk/rxu9J85R0XsU1oPOUzbrK//fottMfdDqP7uK2nFUvXI1Fu+5EiybAKyUwdvb/XPXW0ZFZIxiFGWBMoVzDbtdx4zU90itECCxeNLBmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b78xjMnkeloM+QppXEKkLKkj1STNZupq2t82vEKJcqA=; b=NNxYPNgk2PoaZRVt5tm9PQy7WASwjcxpqX9PMlIqVTVbGDHcaJzuG9rfZyF1nZJyzvH4u4+qd9jn0eWDzCMmiClKwTmzR18mx+dHrTQqo77yijCnNMsLYzM5KJzdUAHMxaqd557lXzeT83/OC50TjsivB8SZo62QDnviU1EcFuAo449TGVpnYQ1zyupAkO0U6IURD53Mps2QCVGsLMQCyvfm1cbmHYmvHXDt6Av7N2PmPq38Jqj5YJK1dlaI8s7Mzld8AB1xnAIhnqsyZR9e19zy3sTLRnN+F9K8HbNK662WA31eCENbHR/88x2YdStt6gwEgJFDg4qp4HcNNo7zaw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0038.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:359::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 17:29:57 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c%7]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 17:29:57 +0000 Message-ID: Date: Fri, 4 Aug 2023 19:31:09 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [nUBeSmTtR5lMeoxGF1q4whjgANGANm+vu59t78ChkPQ=] X-ClientProxiedBy: ZR2P278CA0084.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:65::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <3c10ba5b-088f-3207-8b74-289c35640536@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0038:EE_ X-MS-Office365-Filtering-Correlation-Id: 08384249-c767-4882-8bdd-08db95106c65 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xWYVu1lKG8TowBi3Mv0YDLWG2939bkDdmq+FgHxt57ko7nXnK+LJXP8VjraBJhMRc2KxfOOl1n642H5sBnIns9EsR5kfXWHQTVwdIL4Fw02DRhMjz4W9jnd/H3u+qqZ12/u49qjnQmY+4WglNS7J7dYUGfRgwp8ygK3rthU803E+8b9gCvKKdUtd+tkbpmlyW3fcWIoT2dtLc6Mr6v7PAWmUym1h1U4bmPzGUpqrajn1djg7vphaj02bpBVDd1Owj7QkPd0XxKhhrBVBtaQT5drZC4HpgwFOyiErlsrDh5tmp/U7CekOuqJCZPOTrZcBwXyWg+IM2mTeLHJjhzBQu4W59Eh9VkNIGbXzVpSkT7je56tbLiuEOtiMHD8STqxKs+TLDrAtVb8KaJk7E8ANMABa4d5nMj7NgAPqYx8pAS+f8ZjZLffNFpeWjdpxWbxgpGAPw0kcW8v6arKTfSiZt/EBxPFs2tF24A3LRQtbN4jzhTvEKbfBpQf+CXCi+a+BQ0jhTe9D7RZGut6B4JCJ2thhqh5niO76qnt0bB7UqqJEE+C7fgWnnI6qJTRMQVQ4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2d0TzZCczdlZW04YldUTDZHd2h1V25EcmVNLzY3NVluSWJvVm9sTHd2RVI1?= =?utf-8?B?RERSWEFkWDdMQ3BJdU50enhTMkREZjRLaUxvVkNDSHcxTCtKeWwvdGc5YnJK?= =?utf-8?B?YXI1N2t2MTFQaDkyL3FHT3ZYbjF4QnBsN3VDbW5uZWswRytyL2FydmVZbnFI?= =?utf-8?B?MnlEVE5hOXBtMnJUbnkydWlqNVNVU1grYlhMMy9obElYTkNnQWhuZ1NCVkFn?= =?utf-8?B?WjZTSjY4emtCQTN4UytBR01uTm1ja0t0N2VFMTNmVnlJUDg0WStvV3poeWhm?= =?utf-8?B?d2Q5TTdPOG1YM3JabjcvaXVYaHFYRFBkT1JMSkhHZU1YV084dTBzU2ZxeHdp?= =?utf-8?B?Y2l0YUkxeUNpS0xGUCtkaVB2cVpWNHJMQmFLdUY4M2lXb1QwZ0MvWjlCRGEz?= =?utf-8?B?WkxjVUw4T2ltZ1JSU1F6dVVDdjVhYUVJSmE1ZXM5enFXYlJjTEZNQkdzNEFu?= =?utf-8?B?cE9lMnZFZ3p5NTVYVEE3TnBWb3lnT1pkRnlqdGZJam1zRHZaRmNYSTZVN250?= =?utf-8?B?L0RKV2RIamJzb2VudlFEU2FuREJlYVUzSE54eE1ldlV3SUVhczVrMUNmSHNt?= =?utf-8?B?dkZFN3VOd2VRcks3djlEdUtFU0gvZXdKT28rU2s1SEJKNDBkbWxhSWhoak9C?= =?utf-8?B?czRkOGJjTlR6bzYwdkhNVEdTM0dwUTlxYjlMYklXRXZPSHI2aklDQS9lWWxw?= =?utf-8?B?ZnN6R3NQb2IyZFBiekoyeGRSK0c1MUQwOWI2eEhTV1ZnektWRytIYkw3eWZK?= =?utf-8?B?Qnc3K3NtS0k2b0V0Z1VQeDhJSUs1ck5adkVESmZTTU9EZnhEamRDMVl3NWhR?= =?utf-8?B?VFNBc1JmZ3BBdjRwZEt1aEZuakNqVHM1emdXak02a2ZZdzRlYXFoaGFvUDg0?= =?utf-8?B?WEl1MHRnTms1WFlKWVNxaUtKb2FTQ2c2MlFlcW9PYnM1RWk3eVphRmZwVXhi?= =?utf-8?B?Um00dnNvUktqRDgzS2N1WHNWSXRPbVl2cC8xVmt0RkVPTUxmenZHbGUxT2ha?= =?utf-8?B?SzVqYVNhSndEOWgwSzdOK2tvWDBaRzJPQWEzUlV6N200TE5VbkMwMWFvVVQr?= =?utf-8?B?Nnhzdk9VSGIwejhrSElqc2lCVnZwNGVLeUJnbFJnOGtycnFIazNub1pIREZk?= =?utf-8?B?K09rblowU3o3N09DUnRNVnhoV3J2SVNlSisyTUcwcE5qc0lWMlhuOURlb1d2?= =?utf-8?B?alUrWnErN2dIZTRQaEQra05XQ1V4R29LZFBTV0JaU1g3VC9HZVJNNndSdzI0?= =?utf-8?B?MXNsQ08xWHAxWmI2eDUvWjNQZktwbUVZZjFEK0o2QU9rMmtXTDhEaldyY3RI?= =?utf-8?B?NzVvczBTT2xlVExHY3V4VzJLdnhadGtoQ2c4alF5R1VDdkV5TEQzZDFJeXJG?= =?utf-8?B?bzh1d3owK2V4WjBFN1M2QjlWWVIraDFrRUlJUExHdWNzY3oydndlL205QzBh?= =?utf-8?B?SUw3QTJuYkJ0cHlLd0FmUmhVajMyZkIvdU9rSzQvM21iT0U3bjZ6bWxpck12?= =?utf-8?B?NElPMzVEcG42aWlXOUlNR2FYcE8wK0pVbU96dmgxcjM3R0NHcFYvOHRScUxp?= =?utf-8?B?L2xNNGhEbkIwZWF5NGZIdkcvbG1jSGpOS1dycmhLTlE5L05hUG1LV0JNYnBp?= =?utf-8?B?Z25RWFdWd0N3YmNtUk5Tc2tPV2ZxRllWVG1IR2JDR1pqUnJZTXVBSW1TNm05?= =?utf-8?Q?44XHkBD3FdOgLX7ZcFfW?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08384249-c767-4882-8bdd-08db95106c65 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 17:29:57.5733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0038 Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > asivery: >> Signed-off-by: asivery >> --- >> libavformat/matroska.c | 1 + >> libavformat/matroskadec.c | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/libavformat/matroska.c b/libavformat/matroska.c >> index 90d94b65bf..37305a523c 100644 >> --- a/libavformat/matroska.c >> +++ b/libavformat/matroska.c >> @@ -55,6 +55,7 @@ const CodecTags ff_mkv_codec_tags[]={ >> {"A_REAL/ATRC" , AV_CODEC_ID_ATRAC3}, >> {"A_REAL/COOK" , AV_CODEC_ID_COOK}, >> {"A_REAL/SIPR" , AV_CODEC_ID_SIPR}, >> + {"A_ATRAC/AT1" , AV_CODEC_ID_ATRAC1}, >> {"A_TRUEHD" , AV_CODEC_ID_TRUEHD}, >> {"A_TTA1" , AV_CODEC_ID_TTA}, >> {"A_VORBIS" , AV_CODEC_ID_VORBIS}, >> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c >> index d582f566a2..0aa8e6f3b3 100644 >> --- a/libavformat/matroskadec.c >> +++ b/libavformat/matroskadec.c >> @@ -2795,6 +2795,8 @@ static int matroska_parse_tracks(AVFormatContext *s) >> track->audio.frame_size); >> if (!track->audio.buf) >> return AVERROR(ENOMEM); >> + } else if (codec_id == AV_CODEC_ID_ATRAC1) { >> + st->codecpar->block_align = track->audio.channels * 212; /* Constant ATRAC frame size */ >> } else if (codec_id == AV_CODEC_ID_FLAC && track->codec_priv.size) { >> ret = matroska_parse_flac(s, track, &extradata_offset); >> if (ret < 0) >> -- >> 2.34.1 > > This patch is broken. The indentation is off. > > - Andreas > Apart from this: The result of the multiplication may not fit into an int; looking at the other atrac1 code it seems that we only support mono and stereo files. Is this a limitation of FFmpeg or of the format? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".