From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 77A194A3F8 for ; Wed, 27 Mar 2024 16:16:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7199768D6A4; Wed, 27 Mar 2024 18:16:15 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2041.outbound.protection.outlook.com [40.92.91.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C1B268D582 for ; Wed, 27 Mar 2024 18:16:09 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mTUM3TgvkLeoM8XFrc+nWA3prXjJsWCYCKwN/qlQRf7ZypXX8j3qHA0BknkJA9mYdq0CdCiWs9vQCZSJM31gbZb7XcZ/CyMoHkOSKPGWJinjYHAAISPajSD+kKS7rdqeRRlq/priBgakq1ahDoZSG20pTcarhwK2V7qLT47lYYBexJterEHjR5iVSbA+D1sFqhZkfJCjfuhL9xDgs/iJ50ZuPgF4aeZWvIj0h9dQh37q85zR0diOaIJZizuJED1U6UlgwCXLmgeTiHCJehlNy96LRctTwJRrT91JBrjINlaNeZrECpsp+zA3MIxS1AQ99t+lUwZXl6CpFfMysswQFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fKv6UFZPxESrtduQxHK7m9T4x324cDpLmO+u1IUus4M=; b=WLGWW0JnNmPAqrgcjW//+B/FKE6TLV721kAhfnRWnl41Z9PH7JaJX/PVVvFGbV3wdbRnMWQvuBl5/4/bXbaHftZKs2otVqrfzvQe7Su9GLDIoP+OxOw0teUqAqGwOYu7H6rMVPq2TXeqH5LN7ezRmyKU6nrDsbNIP5L4hRgmHAr04gaMBwFepxTs+14LKxputi26cell53bugdMBCKov+/hzwvxxbpFyUR7jBJ4VICWF7b3sswdufHiW8spNu1JWh5XJ2z13aJklSq0JW0ZAIhlv2hePzd30HAV0xkjvpo88DPxl3+9l7ax8mfsTPosrX5S70zpEehcw5+UQz5zb4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fKv6UFZPxESrtduQxHK7m9T4x324cDpLmO+u1IUus4M=; b=Lv74jPMQzCrgVMp3FNrKyKmFUk/2OAiDr3zYCky9dHmcKB7lm2w+zhBQYtKl37epr/Bc8fpfe6k9sYmrF5uQfTPuPmHC13dQCtmMypYo+haL6rMUyUaB2NEidhfQNvtBT6PfUR36qdsKfNG1R7ro/VeNvn/ht23ILr16btUFfU4MXgplJLGFacAMe0VLforMUrYBeR7tRxw89OfDdxieKTEekp9QLQ3uNcwmIYE1VJzwvKNqreIVaq4SLAT9mvpqF5rqD11PBZWfG4nHsYNA/JzzGOUhtodx0HQbh14azsL2vMqs63v9+UXyV5KW/bBKiLrKBUP+pPBlupsBh98v9g== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0197.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:324::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 16:16:07 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.028; Wed, 27 Mar 2024 16:16:07 +0000 Message-ID: Date: Wed, 27 Mar 2024 17:16:05 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [QxyxmFGB2wpCDNHV7BMQFPdLjRQX14JDHUUVfAOUEyk=] X-ClientProxiedBy: AS4PR09CA0006.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <9482b567-a287-42de-abf1-894c614bd6c2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0197:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e4ba374-32df-4c97-82a9-08dc4e79355e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LWQ+Mr3V0yVCiTwk8TXO3kC/9GzDa/WM+znYPajAqHSOahDpjQvVJHAbSoJQlCBHbBRMehSrsTSFD2VoR4zgDZh2al7qUqTC4pHMlDsEDUnkhvedAe4U1dZzXFx+0RjgH7GnwfhDLZO8/7r63EPbK/ihtCYP+PRE/SR4owNBE7yCF39kUv4vWevnZO9v0Q+5wvVAWMPcqQSajX3cNhP5+rbw9w5XyUjBnfsloXqWnNB93oiqaU1Iekofrf7wwJFu0WOhxyum1+tXkAAI+VQh5AkItv53oXbw/hdY6DME4aImEVZA5FwBXtgpjdBYsUUNvwPs3Z8TziqX2VyCvIHJqjeJPkj40DTu1ULqUbB6AwhJLSP+34QOaGgl3wyUShBryLa0EnsuOb9ApAZlfOcr0lUyb/FiJwtDvbHFM/98yvP8kgx0evZ2W+C4AvXp8W1LhcAS0fnUZWMxFAq85Xtc59pSvHaU2UsIrV7d1AUgwneIbNjITl3JWbKX/HUYv9Hq6WMTAnmNDbnUDlc5/s8vIA95LRukwHuzIRmUCgeQ3hkPr3XBijo5B4QCGmZ0tJk/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2RleG96U2s5cjZKV05iZGtmM291V3cwOXlBdmlBTUQxMmp2cGlRVitMbm9u?= =?utf-8?B?VTM2bUdvYitwUzVYdWRTc2hZNVZJWCt0QlhlQkFGRFptREJBQTdJdFNlZUM2?= =?utf-8?B?L1NTNWpIdVVUYWgySS92bVlVN1FsMzRhQlk3TU5SQVRhNVNtWUVITDRjcThI?= =?utf-8?B?Tm45UGpQRXVYZWlqaS8rb3lLa3FORy9PakowMFlIelkzMlJxdlV6Y1FucXRV?= =?utf-8?B?Q3U3NEpQU0gwUStKeUc4L0ovRmY2VVc2d3RsN3BVNnZDdEJFTS80Tjc4eTRy?= =?utf-8?B?ZUV4WXNJSEM5RGpBa2VVYVA4bWw5RDBxQ3lNVXBTczc1RFczT1VmU3QxbFFM?= =?utf-8?B?TnVaZVlLc25aK0E5bVVqNFp3Vk9yR1o2eWhkRndLRXB2MzhWNllWZE5GdEd5?= =?utf-8?B?b2EzQlhhdFhaa2RFeTNCbnZFU0tlaXViV21zNTVtVm85QWpITUtkd3NEVTNB?= =?utf-8?B?NG9PcHp2cDFyMngyVHJPOUcraTJuYk9zZEhYTlNnU0JSWnJGVmtqS3ZST3Vt?= =?utf-8?B?YWw4K1FheE82YzFCeXJlV1IreDZseC9RbEV1K2RjL21UNEVxNDRkT0xRYVB1?= =?utf-8?B?NFE3c25IaGJOZzNsamlvWlV1aXdvS244VkZOaGlQYUg3RzFFYi9FSFBCTmw5?= =?utf-8?B?T29iaC9hNmRTYkhsbHZxS1JFczhackNMTm0rRVNRUnlsL2ZuZU1adm5PT244?= =?utf-8?B?akhxS2RvZ1FsSjhxOTZOV0ovS3FSOU1tK3BPcTFzZkZWOEVBZUFYUVprT0pv?= =?utf-8?B?T1hZS05STWdQL2lxSGlCMXo4NFVPUlFNTE5Nc0NVZURGZ2E4TzhoLzV1YWJS?= =?utf-8?B?SmdDL25wTUpzajBubmpOL2h0UkZDa1I4eHdWSXpzOVdkQ3F6cG1vZXh0NGVU?= =?utf-8?B?dEJYUmpYYU0vNzFzR29iZVdVZEV1V2QyelJzaGc3U05xNzhya3l3a0x6NTBW?= =?utf-8?B?VG43WkYwcFFINGpMMjNoUlViVGlhVmpJZDhyUmlxMEFCWkZSN0ozL21OVzcr?= =?utf-8?B?U0FHTElWUnY4S09IT1FzdktBZlJrbDQxZGt5WEFIVkhlRml0UUtmY1FaU0xG?= =?utf-8?B?YU9OTzYzSUNXRGpML2MrNDhHTFJ0b3lhQVYraUVZcUREbmhKc093a0ZwWWpa?= =?utf-8?B?Q3p6Umh0RFRaYXE5Z3FQSlZqSWJmS0FMand3YmdQb0gzazRPU1hud3BrcWli?= =?utf-8?B?RGZVd1JDRTZmT2xTL3JFNHVRVnBENjJKcmc1YllITSttbS9vVlBmNWltMmNM?= =?utf-8?B?SXlDWW9XVkZicU1VZ1ZWVXNTWWdBVEZIbWFyci9CSVNtNkNxd2FLOEF1M3Ri?= =?utf-8?B?K1lSZEMzbXVKaStMVWFZdjBFYzVmM2JBM3JyWGJKeHhwTXBaMmZMQTBQeXpI?= =?utf-8?B?MDN0Sk5Gb2VsZW8zMGlpcExlbFNydEZ1NmQ1azI0NnhSeSszdk9uaVBEWXR6?= =?utf-8?B?d0pyUkErcDR3RHg3VVZyTjhlbTV2QXltdk5YOGt0QmdneEk2K05vRVlzRlh1?= =?utf-8?B?ZHZiNHJZb1o5NGVFekhqUHNCcTlRa2NxRG1NUi9VOG1Sb3FXdklLQVlBWW54?= =?utf-8?B?OUp4ZXJES2hBNTE1ZDFMRmc2SW5tdk4zVEhwd0c4SU1zZk9qYkNYQmp5MEx5?= =?utf-8?B?SkZZU2dJUXhUZ0dna25ZSUpiVWJTQTh6L3JQQy95aThiOS9pT0FyZDR2QUNt?= =?utf-8?B?N2RQUnJlT1ZOUExMV2plcUFoTjlvdUVCZHFKWXJIV3lWMTl4MGpvc3h3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e4ba374-32df-4c97-82a9-08dc4e79355e X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 16:16:07.5592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0197 Subject: Re: [FFmpeg-devel] [PATCH 04/10] fftools/ffmpeg_sched: Explicitly return 0 on sch_enc_send() success X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Do not return the return value of the last enc_send_to_dst() > call, as this would treat the last call differently from the > earlier calls; furthermore, sch_enc_send() explicitly documents > to always return 0 on success. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_sched.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c > index ec88017e21..30b2355eb6 100644 > --- a/fftools/ffmpeg_sched.c > +++ b/fftools/ffmpeg_sched.c > @@ -2344,15 +2344,13 @@ int sch_enc_send(Scheduler *sch, unsigned enc_idx, AVPacket *pkt) > ret = enc_send_to_dst(sch, enc->dst[i], finished, to_send); > if (ret < 0) { > av_packet_unref(to_send); > - if (ret == AVERROR_EOF) { > - ret = 0; > + if (ret == AVERROR_EOF) > continue; > - } > return ret; > } > } > > - return ret; > + return 0; > } > > static int enc_done(Scheduler *sch, unsigned enc_idx) Will apply patches 4-12 of this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".