From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C6E8E4B45D for ; Wed, 5 Jun 2024 20:11:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A62668D6E0; Wed, 5 Jun 2024 23:11:03 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2030.outbound.protection.outlook.com [40.92.74.30]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24B5468D6B5 for ; Wed, 5 Jun 2024 23:10:57 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E9Dxsl5EzR7168ZlZvyOm2U71/HCdBllUrqDhjUlieL/hszw36UsFsHX533kDILHq+/6n9dHWTFjheUjbzZmciY+/mWSS0mv3otHrTEo7LyJQ46AhAPFDzElMqKVODJ45Dw67mvyOo2qKw77s39fe+LCRH4ra673h386+JbpD3gGbluJqd8WseYGgdNldoaEwF1h/ybKeE4+T6Qq79o0WZlnBsxjlBCLu6dI/rXDQetH5fI8PmqFrSuJF+itRzgmekXnIYXbqB2jsg/PuGfQgsDYzkK/hvJrERhJZs2JrhS66RGq7me66uZtmWSxPd405UFkrRXOPKE2T77s3/d0fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z6B6JpgOlREUe+ADnFj2i0EiOd87I0KIAQ8qdjEFAsM=; b=YKbWtrDsKJT3orWrrta2a6dS5iRxGYOavtgapZ+rfs8LRsK7L9KFPniw/9QoyYdd0NI3T9g3AdA8NirXhEpusAvcILEoTi7zk6+KMl2+PryvAhG0mcgICptx0tBWSO0X9hSGxV7zfW64HzBUkGyzZzoCh22xpbP6bjvVpXwKjuceoHqDbeje28tUkJ35i4Q7uVpJrEZRBj8i29J15JOUvHH1bR2nwqNiQucqmxh8UKd+B/+wKOZhIbt2FoHYL2tRYpHGjHy4mNyilc514CghhC4oy26/mbUgDvquKETYJ8ZW2tvhiDTCwjck9q/dh+RqTyBKE/kCxmZ1ceCX6kil5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z6B6JpgOlREUe+ADnFj2i0EiOd87I0KIAQ8qdjEFAsM=; b=mW8xCMbZgUmOXFKhuEzv6OAn6jiSXzcn6WXygpdYvoEYa3YfBn1xEN+xLnEZ9BugyC/Vp8y+4WvwfzKiZ1a7bfKiYz3s/M9tlOY+LNfJrhbP2OPDirdveIkpkY1FAd04caErtkhNI5ql1SG/XM8h3ZmC15F90lgHYHUTpfWF5+rVO5FX0MCAEuqfm6tlzjGBfP8/kTnpyvcyG/osslfWsvZsJCe3Wa9iJkvxBICvA9Wtx/fQRKt+HjtKaInktTwl7qAG0eHSbvaUeV35ZtFiyHN/uXuaifX+lGEAKmTU+384HhWRDbLveZVOMeiINh+QpJSkJKGXmZMQvSibGqDchg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0397.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Wed, 5 Jun 2024 20:10:53 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%4]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 20:10:53 +0000 Message-ID: Date: Wed, 5 Jun 2024 22:10:50 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240605183142.2831-1-jamrial@gmail.com> <20240605200803.2999-1-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240605200803.2999-1-jamrial@gmail.com> X-TMN: [fNBGrQHYBjaPetlPDwHqb5uX6kn4OwhiNlqv7ZBqEcs=] X-ClientProxiedBy: ZR0P278CA0140.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0397:EE_ X-MS-Office365-Filtering-Correlation-Id: e454b82a-d719-4466-df64-08dc859b9a0c X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: tuUlJ7oCED+s45wH7SHiUzciqRNJ4dRi1fu5radePeFRt654tqZqZScTzCz06ZDOZa4U4JSjCPdv3vCZak0IHaAWNNn3wTkvvpimSmqjnLag3LziJBe/7U4TWqGIqLJnhAOuxp4aLmzxy/zduxPdxZdJPHeRBoo0YbXKHbHSd/bhRKMGeRbls8aSlFV37PrANPsLe/Ds9CpL0mkJPzVMnuuutpxGTwaxtjsXI+f8vq7N3/0ustDHnzzJlQHY+tK7cZYXDT5uqBdT2qgknwWqf1fclDolH+lvCtbypfXUimPF+nK3XoLW4cPeBinN5J1dVDZkmB7WATquR6J8CLtm9eANd/MvFNZev9VB20JL/3nqPOxubKTgaVSlplJL4lgr/8YMl3kaVQRl1gbn1OEAG0SOodnC/5SHk79YrRO+tzjEB8zPDhygndNMpfF9eSpv8JXMDqxYqRq0ohs+mz5wHpbs2Pt3yk3xaBtICG5V2ZDKaRMpryEovvOv4Avvwhmb/m12/DUPqDX+4TN+M8ihnkW8PgEyIQEr/IPn2kShRHwvvKc16q6biJvYXSzAOcTq X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnFwRlozRzNoUGRES25NSStjNlhtOXZSZEhqTkpIdC9qWHpZbkxreThOR21m?= =?utf-8?B?M0Rzc0hpMzF4M3cvUXZXWlF0dUlGNVZNOWpvQjdJQ1dKbUxqNVVtaEUzZGpW?= =?utf-8?B?MkJqckhYbFFyTWZtQTBMYzBJYXlBUUhrQm5LZEhldUlKNWExTzNGVEYwTU1U?= =?utf-8?B?Y1YzZ1ZJMzJ0SWY4MEJVYktmRmpNMi9GNS9VV1EvcnY0SUZsNnhoMFZPaGRJ?= =?utf-8?B?Q0hQeEFIWTEyMlRRVDE0MEdyK28zZytiaFF6VmZ5bTcrcDNjbExXc0lpVnE5?= =?utf-8?B?dEVMZUJDMWNlVDNxQUxLU3N3Z2J4dXViRGFxWDdOV3BMbnJoWTJ1NVhKNjdR?= =?utf-8?B?RFluS2x4M3RNem5UeHQ3Ulp4QUtDbXhvejlCaGtnYkM1ZVRrTDBoZ1hnRDRZ?= =?utf-8?B?Si9scHFiN0xZMk1OaHRPODk1TTViRkVFbURuVVZnNmFmMUJSTkF3dlNOTEEv?= =?utf-8?B?NE5pYnl5OVllb3pWR01HS1dEbHNlU0l0bWJzZ2V5TzN5MXNmdU9Ib0NXQ3lR?= =?utf-8?B?R0pYZ0hzc0J1U01jdEdpcGhPTEsrTGdLdXpjeXcrSTExelF4d1ZtYkZ2dWRS?= =?utf-8?B?RTJqVi94emlPYzZ0NGVsVnRwSTJ2OW9ydmJQaTNURjlQSmVZYVJLMWpNVnc3?= =?utf-8?B?YVQ3STRvMnE3N3VtclJZUXQ5Z0VyVnVDSkMrSmlYWHdhazZSWjUyY0hUbTdn?= =?utf-8?B?bFl6TUJkTGtyYmY1L05KWG05aWhCdzgvNzJEcmR4Rm92V3ExeWRzdmZhcTRS?= =?utf-8?B?TnYwUDdvbUlONEpqa3NwUjNaMEJuWkdDd281LzBUT1RIRlBFK0twQWV5QW5x?= =?utf-8?B?U2tRaGRVelFCVFlicE90SVNoZjZyMXl1d0FzcEpFM1RXWUE4cm0rb3FwSjFh?= =?utf-8?B?NU16WjRWaW9aZ3B6Q1B3Nk9EbFZtMGNnYU9VUklJeW9xb1U0OXFVSVFjeGln?= =?utf-8?B?dnE5WGM2ZnUrQXNidkN6bnNRMjJwQjNHZ0c0NVczOXRUakdqd0RYUFBab0Nk?= =?utf-8?B?eDZmZDVjYWpRY3loR2pjM1BYVk02QkJMdStjbk1SRDd4R05pckk1K3dNZUl2?= =?utf-8?B?R3I1UGN5Y1htVzhnV21TWVFoT0xPNDhmcUo4aGw0NGFWMkVQeHBhOE9QZFlp?= =?utf-8?B?S2wvZVhmYThXaUp1TDZTQlpzbFoxT2x0eTU4NVZ2VFM3bmxTQWZmclFPT3hs?= =?utf-8?B?NHJYUHJMWjcySk14NFd6NWdSVGNhdFQ5YkNsbmZ1Q2V1dDdkMUcrUmxzbkV5?= =?utf-8?B?Wmk5UnE2K1dwazBvalFVU2RXQ3ZrZ25ZZWhyVURrMFpMQVhTWUxvdDEvU085?= =?utf-8?B?NUhMTWhYSHIrM3p4UXZRL0JvTnVuTkw4bVZWK0U2WWNUVVVrNE1WYWZ0SUNy?= =?utf-8?B?S3VDMllxQWtOVjlwNEs2QjlDb1A2K3NRS0VyTVFjOVhBVVZ3VzBVQzFPVEF5?= =?utf-8?B?ck1UejE0S0RlcVovTSs4aW94T05iQ1dTejRKODB5UlRzMi9NcUFrQzQvcGMw?= =?utf-8?B?eFU2dnBadi9Cd3JoQ0YxSUVwUVdCa2F4VWkrYWVHNGYxM2FHTEdYSzgxeHBJ?= =?utf-8?B?ZjZVR0Ewc1hmYW9Zc0lFbVEyM2FuYjZtUUtwUzlyL2paUXE4OXROQVFGdWlX?= =?utf-8?B?RWVzY3hMcnFIbCtyOTBmTnpEZWM4WElmWGdMT0xWTEZNRzAxNHQ5UUV2SFU3?= =?utf-8?B?THBRelBSOVpkbVhNWGQrcjY1OEhJQVJvRTgzRG10bnV2b2VVeHlzVWNnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e454b82a-d719-4466-df64-08dc859b9a0c X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 20:10:53.2685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0397 Subject: Re: [FFmpeg-devel] [PATCH] checkasm/sw_rgb: test rgb32/rgb32_1 to yuv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > Test all four pixel formats, but only bench the two native endian ones for a > given target. > > Signed-off-by: James Almer > --- > tests/checkasm/sw_rgb.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c > index b51d0836c3..cba6b87add 100644 > --- a/tests/checkasm/sw_rgb.c > +++ b/tests/checkasm/sw_rgb.c > @@ -187,11 +187,15 @@ static const int input_sizes[] = {8, 128, 1080, MAX_LINE_SIZE}; > static const enum AVPixelFormat rgb_formats[] = { > AV_PIX_FMT_RGB24, > AV_PIX_FMT_BGR24, > + AV_PIX_FMT_RGBA, > + AV_PIX_FMT_BGRA, > + AV_PIX_FMT_ABGR, > + AV_PIX_FMT_ARGB, > }; > > static void check_rgb_to_y(struct SwsContext *ctx) > { > - LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 3]); > + LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 4]); > LOCAL_ALIGNED_32(uint8_t, dst0_y, [MAX_LINE_SIZE * 2]); > LOCAL_ALIGNED_32(uint8_t, dst1_y, [MAX_LINE_SIZE * 2]); > > @@ -199,7 +203,7 @@ static void check_rgb_to_y(struct SwsContext *ctx) > const uint8_t *unused1, const uint8_t *unused2, int width, > uint32_t *rgb2yuv, void *opq); > > - randomize_buffers(src, MAX_LINE_SIZE * 3); > + randomize_buffers(src, MAX_LINE_SIZE * 4); > > for (int i = 0; i < FF_ARRAY_ELEMS(rgb_formats); i++) { > const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(rgb_formats[i]); > @@ -220,7 +224,10 @@ static void check_rgb_to_y(struct SwsContext *ctx) > if (memcmp(dst0_y, dst1_y, w * 2)) > fail(); > > - bench_new(dst1_y, src, NULL, NULL, w, ctx->input_rgb2yuv_table, NULL); > + if (desc->nb_components == 3 || > + // only bench native endian formats > + (ctx->srcFormat == AV_PIX_FMT_RGB32 || ctx->srcFormat == AV_PIX_FMT_RGB32_1)) > + bench_new(dst1_y, src, NULL, NULL, w, ctx->input_rgb2yuv_table, NULL); > } > } > } > @@ -228,7 +235,7 @@ static void check_rgb_to_y(struct SwsContext *ctx) > > static void check_rgb_to_uv(struct SwsContext *ctx) > { > - LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 3]); > + LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 4]); Doesn't this make the test less strict wrt overreading for tests that are only supposed to use MAX_LINE_SIZE * 3? > LOCAL_ALIGNED_32(uint8_t, dst0_u, [MAX_LINE_SIZE * 2]); > LOCAL_ALIGNED_32(uint8_t, dst0_v, [MAX_LINE_SIZE * 2]); > LOCAL_ALIGNED_32(uint8_t, dst1_u, [MAX_LINE_SIZE * 2]); > @@ -238,7 +245,7 @@ static void check_rgb_to_uv(struct SwsContext *ctx) > const uint8_t *src1, const uint8_t *src2, const uint8_t *src3, > int width, uint32_t *pal, void *opq); > > - randomize_buffers(src, MAX_LINE_SIZE * 3); > + randomize_buffers(src, MAX_LINE_SIZE * 4); > > for (int i = 0; i < 2 * FF_ARRAY_ELEMS(rgb_formats); i++) { > enum AVPixelFormat src_fmt = rgb_formats[i / 2]; > @@ -266,7 +273,10 @@ static void check_rgb_to_uv(struct SwsContext *ctx) > if (memcmp(dst0_u, dst1_u, w * 2) || memcmp(dst0_v, dst1_v, w * 2)) > fail(); > > - bench_new(dst1_u, dst1_v, NULL, src, src, w, ctx->input_rgb2yuv_table, NULL); > + if (desc->nb_components == 3 || > + // only bench native endian formats > + (ctx->srcFormat == AV_PIX_FMT_RGB32 || ctx->srcFormat == AV_PIX_FMT_RGB32_1)) > + bench_new(dst1_u, dst1_v, NULL, src, src, w, ctx->input_rgb2yuv_table, NULL); > } > } > } _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".