From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8571845534 for ; Tue, 31 Jan 2023 20:39:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0FCEF68BE7C; Tue, 31 Jan 2023 22:39:50 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2054.outbound.protection.outlook.com [40.92.74.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4B87568BCF8 for ; Tue, 31 Jan 2023 22:39:44 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/y+PR/xi5H/rRT/S50GOlpQSBmXE39/8Ik6rYp5DfRtujbAGyTdxXuE8D++FS7wU297DNma+uIi8dySflqT2sqHCI5fSzmqQBIvtjAl9x0Fpy9x/qSSEuTkVIl5Jiz34mhpNasCqAtXPblSpORgWpEKr9yhfQ8v6X++Z8y2TsY33UGNNQMSsQiUUfUik8691hQ4fjIhNLebRKi+f3s7Hq4PtPtlydtfSWCMScjUxokB73ulDJnxyjb+VfWxAaFBVmPX/clPvBE6OTJzYxeucmuHq0/HAKhdnfnq8ua8V2LUyHkeamcMgV4q5Gr51oXnFCdcuChrirH6xCAAy+Oniw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RN6b9obloXUsLvp7+AK+f+yhX2tAXvYcjR1ISXI1ReU=; b=Hg9+CvcyGLS/QeweF0PHCxo1aRlmPg7O0qqab3LVX4HY8Ez6jaSiecwZHSbswPkdNu8A4G/ctM6aVbOj9NWDoP7vUzoc6LX5V/EQR7GRKRhBfLvHswF6wlh+ZURtlxgioPip7Do6Y9fnM2v26XcwjZo2jxSb1SvnPz55q1ORHePZgXDV8g/Je3aJW/NbXFcXt6syqzd5HnL04FaMm01w4yCEbBNkqO6OYEwgwFy8hdbpQTiriNwb5YdgDzTLzzRSiM2RGSBiHQrH847qfFnv/qQf1keK/chrA9zyjIn/9zG8rmiWGeJoy7QTAw66Q9F+rfZ6su4NegFRjVJpzoVV5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RN6b9obloXUsLvp7+AK+f+yhX2tAXvYcjR1ISXI1ReU=; b=HPNs7lc9SwxIU/MDz4Mcw1KFcVLXPXCiSB+/OfWdvD9VMOW8kNdwJedDiQS1EomlxuUg4HkvvD2+tzezWQ0X1UmZ+RXatSs8vdhP6wAzDoXcOIE67ro3etOkzp/YnWPxb5YSTThzqmVWir5WsBlsIj0ERP+OxGN/rGsk86MMxz+Q2kjPFVpDvvhADptjQSU5cgt5xTwMOicziHHkMNIwF2UPBb4o2ZNP3liLUxtHMT04lRKGcs9mcfYt+z/dux+PD7sZ19iAhSf/ulyxYzk3zvkNINj5TnXdnPmTorjfOEtlQ4lMWwYwcbQapUj4X6R12ykkLzU/+LX62TtVXBRtUA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0840.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:549::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Tue, 31 Jan 2023 20:39:42 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::a65f:2ae7:256a:ab96]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::a65f:2ae7:256a:ab96%9]) with mapi id 15.20.6002.033; Tue, 31 Jan 2023 20:39:42 +0000 Message-ID: Date: Tue, 31 Jan 2023 21:40:11 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230130234527.13149-1-michael@niedermayer.cc> <20230130234527.13149-2-michael@niedermayer.cc> <20230131202730.GK1949656@pb2> From: Andreas Rheinhardt In-Reply-To: <20230131202730.GK1949656@pb2> X-TMN: [LVFISO2llOxhRqndKvyqmay5bqGqDEon] X-ClientProxiedBy: ZR0P278CA0020.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <251f63aa-89fb-0f6e-f208-105852923e68@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0840:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f9ce0d3-9ebe-45e3-abee-08db03cb4800 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ovXh9LSbF3F1GhMZiNEBA13rjpSKXlrLKPuAfjYJTzbMc4mUXQeV4y90blG/VJVqPRQ6YBdakrrQrwDxaelGeS9TGMjbIKfDnYhvTtg9chxuA62TApEXavExWeZRJwnwYl2Yzxd6/KT5Fvh9/r9pc/EEMGlLAepUlzaSWL46gy9DaSl02oixFsVlczrBAwQLQzT32U1UoZwf2KnGyfutgOilv8fdMB4HezN+Ie8uTYFv1qZv1uCM8uejyCfCocOdDjWZh8THd4AGaWTxw18nDwb6D1CaCDpfzqF1d2F5WjyAhk1wE2x6yjGderlffj0TL56gY0dUDsAuphPxm1E6pcNVDYZQO3SUSAJxS4JLNHgrTxCrx6XjBsuf1xQTCOZSQzjrJN/DNv5MLOiXMsqGqn3dtbnTbT0/4sZonCQ4efyXbUhVHJd4JRLgW4ks9G4LEELjv6yV1FE0Oa2T8/zUEs3FRE87oCmCugRkGwfaQBXa351KXMRvzJvbpiLtEB0RY1fT6DwondVWwXkQYkUQSq2NU4ZpNQWXQoli1ZZ9JwOYAXozQJ69TTOihMQSDLh25mk/P69pzs2gc9zCyAtCVgiMcsr6ize6NECrYkup2Xme//C4kV6sx9uiLIqe1+y0zmtyArGDqnpwu5pTF6LTAg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2FtN25XQk5xRFZjV2pkQWV4bTBueFdzNTRtWWM4TUdaeXJTdDZ0UWN2bkJi?= =?utf-8?B?bytDWnZ4QlN1Q0lMZVlpUzN6emVBSkxIRVFQaFdlTElkQTViVHVySXNQM29L?= =?utf-8?B?ZkV1UVJNdVk1aVluTnNPRnZpU3I3ekkrMGdkbzQvaGk4V3N5UGxHWmxhQmJz?= =?utf-8?B?VHFXVCsxNnNLRjdWVzJ5dzQ0M1NYYWpaaEFuMTRHakVERWNSeDUrQUI2MW5H?= =?utf-8?B?K1hnYlRYZFN1NnJYeWliNSs0Wm9oeUhQbUFqMTFkT2hHVFQ1SExjSmNuM1pl?= =?utf-8?B?NUxBYTJWZ005V0x5WjBJRzdsUi83Z1l0RGN3WWpiN3Nnc3dhRENoeUMwVzQz?= =?utf-8?B?Z1FPWm5qeTgxMjlMcVhUQjRlaC9BM012NzZ5bjk2M0Z5TDQwanorK2RYanp1?= =?utf-8?B?WDNtdjFzZmFEaEx0eFlIanV3Y2hjTG5UU2Fnb3Zzc1NyRHFQbzh1M3AwZi9v?= =?utf-8?B?b2l1ZHhINHdtZUlrNWNVKzFSS3VoNHRSL0psaWxqdm85a2xKMXRWUHlKd2N0?= =?utf-8?B?TittTXhJbFlVelFvU2FPSTcxV0NRZjZzNEJTV3o1N0owWWFqWjVaRk5iYzhk?= =?utf-8?B?TTIxekpGRDlDODBnUXlOakNYaXora1JsMGl5dS8vckoycUt3T20zKzlHdkFi?= =?utf-8?B?eWxmYjk5UDlRRGJnSUdMSTRzZ0tyRE5nOW9nWWk2NHZZWStLbmRKU3V2YXBx?= =?utf-8?B?S3ZwMkJnNVlXRTBoM2U3YU0xOHkyTEp4NGdCKzkxTVJHaFEzMFVEU0pCcTVu?= =?utf-8?B?QTJseW5laE9Kb3RNbWg4M2cxc0VlcG5EeXYyMTh4ZVFiME1EVDFXRGljSG5F?= =?utf-8?B?bjdrVzBvRkg0UnhWckJjU0Vva1BXck8rU1ljMFl0SnQ1OTRJMGdEZUN6bm1I?= =?utf-8?B?WXhlU1ZlWGJIbFdma1ZnaGNRQklHdXovSlQwVSt0WHlLaGpqYVJuYlcxZjds?= =?utf-8?B?MHYydkNmSjdCR0RRZm1RelUxSXcrVjVhSGhiUlBvSHdkNTVCRlh3ay9MajI0?= =?utf-8?B?ZTdYM2RzajN0clpiNTZRUHJsNjdwQ0l5VzJPSUJwOG1QRFU1MDBmRG9IWUUr?= =?utf-8?B?eWVpcVhYUjNRT3YyKzlEMVJwc1RTMEo4UmVRUmRVeHlDeGFyRHRhdjlHbFln?= =?utf-8?B?ZnRxTlRWUm9CMm5WZjBsNlBESTNxa2hKK1ZzN05WcnVIVFVib1hxSGdvMlZZ?= =?utf-8?B?TVJqemVTb0JWSUhMcm5hcjUrWmgxdHd6bE9FTVNXUS8xVVVwcGRianBhZm9O?= =?utf-8?B?UHlKOStXUHFZNnY3eXpUaWhsQjVMaVBzd1dYeTZqTEk5Mmxsd1JWS2swSlBF?= =?utf-8?B?Mzcwb0FnOVBIZHJtVVdyYkVuQXQyMWhFazdpb0dPeENhd3BvWkV2dWpRSjQw?= =?utf-8?B?VWtPU2tNR2pQd3lISVR6SERJMXluMjNIcHZlSEQvMllhQ21ZL3UyZWxGUFl6?= =?utf-8?B?MUpBb1pZZmxLWENPb2E1a2hybjN2TDhPT1pZa3FaS0JqRGhJNFRaSUZFOVRW?= =?utf-8?B?MWpZd01ROVRYVzJPTXdnWGJvMllnS1N0NEduTjI1MUVITkRkZXRIeld0V2F1?= =?utf-8?B?SUcybXZ6Z1NTamVFeXFMQW5OQkRLNEVTaTE2QUYrc1dQQUpIL2xSTk43ZXRV?= =?utf-8?B?dzR1eHlMc2ZSdjFZcHhsSFVvQUtCcThEZ2RDNDFOSk1FWWxLbDY0RnFWQ21r?= =?utf-8?B?U3lxbktwaGUxZnFsR2haUjdWQlRRdjdGdjIyNFRVclc1K1JnclVBYWw0d1pO?= =?utf-8?Q?EQdn4ywMcAm+DHQrFM=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f9ce0d3-9ebe-45e3-abee-08db03cb4800 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 20:39:42.6492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0840 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avformat/lafdec: Check if all data was read X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Tue, Jan 31, 2023 at 12:21:24PM +0100, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Fixes: OOM >>> Fixes: 54572/clusterfuzz-testcase-minimized-ffmpeg_dem_LAF_fuzzer-4974038870523904 >>> >>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavformat/lafdec.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libavformat/lafdec.c b/libavformat/lafdec.c >>> index d02b479c4d..b78ec3649c 100644 >>> --- a/libavformat/lafdec.c >>> +++ b/libavformat/lafdec.c >>> @@ -208,6 +208,8 @@ again: >>> ret = avio_read(pb, s->data, st_count * st->codecpar->sample_rate * bpp); >>> if (ret < 0) >>> return ret; >>> + if (ret != st_count * st->codecpar->sample_rate * bpp) >>> + return AVERROR_INVALIDDATA; >>> } >>> >>> st = ctx->streams[s->index]; >> >> ffio_read() > > I assume you mean ffio_read_size(), will use that > Yeah, I meant that. Sorry. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".