From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2CEDC4A9EA for ; Tue, 7 May 2024 15:14:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2118A68C296; Tue, 7 May 2024 18:14:29 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2030.outbound.protection.outlook.com [40.92.91.30]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 615E7688384 for ; Tue, 7 May 2024 18:14:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A5Uix8AepX2N8tX4G0k7imnH60hzISuXPID/+Yv0NuaEHd8WNP7b5Ck+jBBc+fKXiVZqgf+cmq9Mr3yBBDjrtHT2Urf6QcmlF3ZLh/xNjlmbBsRVzv7GAa37eK3mcX6sVqtajvbFOaEC9SxGmTSb1Oxi+Wic5ETG/mCl41SanRp+1NZ7QYBX55eF7FKc/pGhVO2A9EJ50rQHZ5cdhvRMIdstuXUIMs9AsxNehBBj5GpFza3yPLa48yTlPKkDfiVLlYt5qrlm5eJkhixrUTIAdOv6xS9ey9zqHOxt9qHlZbaywHGeV3lPs/Itn1smRsgrSEFFBOjaeDXFycUqQcNUlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x/FW6Qt2eDxlEyy6Mb9xfNIO+XqJWRjP7bverJMBscY=; b=K37Fv76SNV3dev27zsTRMwk+P0KldQTFu8Dz08lbQZKUgPK0Y5Q1rzWlA+XS/A321EDxkXxXWkNWeqVe/LI5rKZSiAqykvkRFwjbOci5q0YkpHVGJbyKGZ8GW7rR4hjhzuJ56lwp55qMWW7jZWOIPCzZrjXFOh029jAC8+F902SVkqJGr2qNTcf8n8hxPoruUiPwbiL0vlCyxSqf3ed5AKjJSwkcKNz28Lc4dElMd4g+m41KI8rdHPgmrbZNjpx8OvRtDEvg5vLzxEC868dMc6lt+AlAQMqVunIME+PD4+/nzZBSloW13T3p7nUw/V/m7m+rtCQyTJnzDMU0lU5Ofw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/FW6Qt2eDxlEyy6Mb9xfNIO+XqJWRjP7bverJMBscY=; b=QuecOTBGRufaG7pbW6i7OIJBbz+TsDEgg1+5N2ZZOi/Zc1MtT1zkKHI2QdBgFPLTJLKEO/1nERxPZkhHHOdNAuHcDmt0Z2eVVJbOTdR0S7ncYEPjHh3nd0aZ0/VtQPi7hcUOvoctKIiwlA2l2QisU/odXYlL7xCd47ZvXd0c9Jg4rjwmHd9V2xhJroS5o1uq5qe0BVyHsEcoOGohb2amMbN9CnIcpZPJsrKPHxA0qdvjJVAqcyYybZ6jRtGnu/jOmyoXGPm68gM7aOlBIBh+vR3iYSMEnT7NX7lQk+e7qyG8/Hqrdwu8n34zvecq7MA/QlcfuiMDVxsuxEBAz1imJg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB9P250MB0426.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:325::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 15:14:19 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 15:14:17 +0000 Message-ID: Date: Tue, 7 May 2024 17:14:15 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240507002723.1603-1-jamrial@gmail.com> <20240507150205.2039-1-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240507150205.2039-1-jamrial@gmail.com> X-TMN: [OtlAYD6OoFW9+cvXC4nRToiyi+DvkZ95seAmzrG66cA=] X-ClientProxiedBy: FR4P281CA0274.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e6::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <6bf5fe74-728a-49d4-9408-f9f57ecb4051@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB9P250MB0426:EE_ X-MS-Office365-Filtering-Correlation-Id: 5462bf57-8898-4bdd-6252-08dc6ea85d1c X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: 53ZRtV62GVjjALweWj6EGC5i+Xykzb9Gc09nYBb8MBm3ZbBeJ9O5HG2TYN4nbcfJ+ypkkPtrkUUmcjmRJoJha2SAnWfJ5pRz/lc0hw/ccInnKaPZPZVUsZSmRlNrAqe3MWkUsteZbv2UWtrqixWc36vwS7n1eLpstGB/d8Mwd6ouTz5hJ8R1tdHvKq44Y80FlQx2Lo196qp84ZNH0j8Z/O44rAMPwWls7ya9CjC3mIP/RvaDqNanSSZh5VwphE2+3vEvEUBdtaleyjJ1IsvvmM4LtOCb0e06FiMP0I3NDI+Nmb4Of9Q0aQTFJBZ4H6+wtnZtyr+H0RICXtQALGmRw9viq3KtrQitfnctizUYQdAw0L+fyt1FT9oxo8ZVyq2nuZtAosl0UUtc+BXu0IG/8XWvGpVKyIcJmODkSbe934lYBou+XmUHnF+fYodD/ARiNH80imYB/MR0YFy6uYrBKOoKGUJ0zmpmL4cr95I7Kkdb2JCTMQW6mUruzjjPtRSS8wbyckTBxYgTGUL7O3oFznHJYQU4ygX2BTRRCeKr030+os0BtwEeAsf7GnOnWbpm X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm9Sbnd2bDY5aFBDUHBQY25YVHpPdCtueGNlVXhScll2M2psYVJJejAvMlBL?= =?utf-8?B?NFVCOGhVL09RZjF2ak9OOGlqZFFaODlTK01lcXBXQVdTcGxFM0loVTFSRitN?= =?utf-8?B?OEljM3FicHlhcVZPLzhkU1pTRWpCSGlyZWwvM2pCS2ROd3gzcGhFQ2loTjBZ?= =?utf-8?B?VkRmT1JmTjZzWjdjOWZDTTl3dCtwSFBSaGdZc0FOY3kyczB0UVdwMERCMGlQ?= =?utf-8?B?WWIvMDlTckxhWmhoQTBNQjlVdnFXdlorbWxnSlB5R0VSVkE5V0prQ2ZKcTcz?= =?utf-8?B?WWVmL1o4dC9sNW9tOE1EalpRVXRKZU1HS1l5dmFwcGVlODZFSkY1OW84N2x4?= =?utf-8?B?VUhzVTVpWWVxQUpTdjUxb0hRd1ptc3pLVjk3OWR3UTlOMXMzcWJhTG5iMk9r?= =?utf-8?B?ZG9sampxeUxhdzJ2M3JhbGlZU1hKTEVhUUwydER3WWx0WTVxam4vcDJxU09w?= =?utf-8?B?RG1xUXd4blVqVllJU2RhbTY2TlphSU40cTlvUWFpU0p4L0dMaC8rZlBmR3N2?= =?utf-8?B?bHhDS3phYTVETEUwamIxU3JOa25MMW9RWkpwMU4xYUtValNLRUJDb0Y0bGlM?= =?utf-8?B?TmxJNjVSWXY0QlpLS3hsTG0vTTlpdFZ3WUsyMkhFUnJpVXNZekVEbWlZdkh4?= =?utf-8?B?M1BPd0RNdUpwaFdHUFRxYlZzeE5RdlB0MGNrdUtjWmluOE4rbUd5bGlZL0Jv?= =?utf-8?B?dkdtNm9IMXFHUjJUeERpZi9UQU5BNFZtc2tZZHJlTzJHMFNjS1NzaTlEbDQ3?= =?utf-8?B?TWk3OG1FZlZJM3N0c3ZyYWdJZWxoQjQyZHMvN0lHRlJXTXE2c1MyM3BxUFVy?= =?utf-8?B?ZHU5QUdOdTRlWWxUMXNteERVNGhTODdQTFR2MmkrVzJQc09KNFFscUVvek0w?= =?utf-8?B?S1lMd3JLSHR2OEo2Q1hPRjEvL2tQMFdmQlJhdk1ZY05wMnRhWWtwZ3JyQ2dD?= =?utf-8?B?R0hMS2ZIamUzcXMzVWVjNVYxa1dmcXZ0Z3VEZGZ2WmZnT3ltRDZrMFkrTmpQ?= =?utf-8?B?dGE1VjNzY1krM2pHSHN3S3NsazNGRWVsWnM1a0hiOTJIT0tGR1pUOTZCRy9q?= =?utf-8?B?c1JCTUFvVGc2djRpSXQxakFoakcyVTF5NWhyNjNEMGJwRW01WkVqaW9NYVBp?= =?utf-8?B?UVFkVVkvVGZrc0JBUk1UUDNvY2tnZFFPQVBiK2hNQlRERmtXOEh5NktTRWdm?= =?utf-8?B?RCt5VHh6NnVrVVJnc3o0a0FnTTVKVHdaSCt2MStqTjM3ZWNveG1tZDVRNUVN?= =?utf-8?B?ZFp5c3NXZExaUkIrNStPckd4NURCMmVQaGxaL0tnRHNxbURmamdVN2pPa0or?= =?utf-8?B?bjZjTXpPYWpvZFNPOFUvMTJ0WjlOTjVNR0pHQkNtNFh2ckF6OXhNMUlOUnZ1?= =?utf-8?B?SXJhL2RNRkEyYzhFNGx0bWFLRFlsVlRBSkZMMUNPSmNGNTc4OXRYbUt0TXJz?= =?utf-8?B?cGZncmxoNjdjVVp5TmpMWVZsNHRRYTV6aDNKUFJ6RDJQMEtxSXVwNVNZWUV2?= =?utf-8?B?ajQ4MTRoNkJTZW5nNTNyWmFZVkNmdytjV0RuNGcza0hwU2NlNDk5bDZJbm5a?= =?utf-8?B?KytJVW85UGlGQ0RaVk5XVzJ0alUvQlM4dElpU0xHU1NBMHdrUWJnYW1RLzFP?= =?utf-8?B?Si9rOHlmZGVtVW90THoyS1h6M3ZZRW0zY255d1c4VWJSMWJJQmFMSjhRa3J0?= =?utf-8?B?bHh0U2VzR2RGY2ExVDQ4clEvUUJXRlAwblZneDNsaVMybWpieGhrc1pRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5462bf57-8898-4bdd-6252-08dc6ea85d1c X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:14:17.7606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0426 Subject: Re: [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > The requirement is either 8 or 16 bytes alignment, not 32. > This should help finding bugs in asm implementations. > > Signed-off-by: James Almer > --- > tests/checkasm/blockdsp.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git a/tests/checkasm/blockdsp.c b/tests/checkasm/blockdsp.c > index ab87fc8fa4..f67a38d302 100644 > --- a/tests/checkasm/blockdsp.c > +++ b/tests/checkasm/blockdsp.c > @@ -29,11 +29,6 @@ > #include "libavutil/intreadwrite.h" > #include "libavutil/mem_internal.h" > > -typedef struct { > - const char *name; > - int size; > -} test; > - > #define randomize_buffers(size) \ > do { \ > int i; \ > @@ -58,18 +53,18 @@ do { \ > } while (0) > > static void check_fill(BlockDSPContext *h){ > - const test tests[] = { > - {"fill_block_tab[0]", 16}, > - {"fill_block_tab[1]", 8}, > - }; > - LOCAL_ALIGNED_32(uint8_t, buf0, [16 * 16]); > - LOCAL_ALIGNED_32(uint8_t, buf1, [16 * 16]); > + LOCAL_ALIGNED_16(uint8_t, buf0_16, [16 * 16]); > + LOCAL_ALIGNED_16(uint8_t, buf1_16, [16 * 16]); > + LOCAL_ALIGNED_8(uint8_t, buf0_8, [8 * 8]); > + LOCAL_ALIGNED_8(uint8_t, buf1_8, [8 * 8]); > > - for (size_t t = 0; t < FF_ARRAY_ELEMS(tests); ++t) { > - int n = tests[t].size; > + for (int t = 0; t < 2; ++t) { > + uint8_t *buf0 = t ? buf0_8 : buf0_16; > + uint8_t *buf1 = t ? buf1_8 : buf1_16; > + int n = 16 - 8 * t; > declare_func(void, uint8_t *block, uint8_t value, > ptrdiff_t line_size, int h); > - if (check_func(h->fill_block_tab[t], "blockdsp.%s", tests[t].name)) { > + if (check_func(h->fill_block_tab[t], "blockdsp.fill_block_tab[%d]", t)) { > uint8_t value = rnd(); > memset(buf0, 0, sizeof(*buf0) * n * n); > memset(buf1, 0, sizeof(*buf0) * n * n); 1. I wouldn't be surprised if the *_8 buffers were still 16 byte aligned. You should probably force 8 byte alignment by using a 16 byte-aligned buffer with an offset of eight. 2. Can you also extend this test to actually test the case of stride != width? (And negative strides.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".