From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 533704A7FC for ; Wed, 10 Apr 2024 08:09:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D30068D1C0; Wed, 10 Apr 2024 11:09:10 +0300 (EEST) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2048.outbound.protection.outlook.com [40.92.50.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D542368CC41 for ; Wed, 10 Apr 2024 11:09:03 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pru6tzaMjeebv4sACDAWqibBz3+Za6rMUIQ9/EnCfhk/rWhomPYl7owvOacgiVz2vFRBFfGwwYvPHafohmxHI0zz5Ahj/DK7AA3YDK7FAQ/J0EhVWnm2MF36heM4h6ZQCgvQ1Ct9450lZ4zUtiyqsMJi/4ugzXWXOSJvrKPPIIVndTqSofsm7PLEkIDm+BeddQExygiAt2TIebcHVoYfKt4M7W+N68E42uueVzUdynTZ7PygJtacA+Yuyc0Dm7jUNjF6BiFt8sm0kUKLt0XIfz1A4Ujg816YkH9eLadh8RAwLRzKgV+ZsktrpUJxT6GW0LwotnCPJjJm7eYapAM1RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+a9SN4pShYhxE+eY5k/qtFL55HaLKhGRK1G0vRaJAg=; b=XdjHgM8qslrFwFrcXgBqcHTFtpSsRFIsCPPD1+x1LEaKM5M5HAEhk/a/cshMQQc9SaVL88Sh2ON/kAd/O7Ftqk08UzfPsgSxxlx9wfYabdz81UeUK/VwFm7UqAqNC+vz1KYnlSEm7VWz+4Q4//VLBTE/Ya8y294/+VbiYpxPoLXutVpxCCZOBtNKGRqGlcUWxSjCHtBbuYGGNu3cjV/yspeEPiiVvi8FHxEPXRuURLs4yF0vYQIIoGRQ2eX08DVJ6XkXaniQs8s/zNkGwsKyrp2zH5U0/wxF8bEQqh6R76Aa4blVgqjhdBG+Ys9QpJixjJiUvtpm0zJVes0ypad9Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S+a9SN4pShYhxE+eY5k/qtFL55HaLKhGRK1G0vRaJAg=; b=Y1twwvC6zCOjMHtGQfCeG5v/3xJOANKjNAmeHnce4ODxjHAlHiHM8a7CaX88mFbE2GwZK6TxZsoY4xxZYUtEun3J4Ufn+QThyp4Now7ECMqmUn1rfkc8oVpZ7DngnjCH38phZL9aRClXfQ9CZNOSrTwkWpWzAEBtS0UoxerkcA/hnE1dA1sCQiIFWtv5ku497R9DwKSND4G6PKoAXeIkd/oLGYldFqJXZkwQl4zblNgUMRl8f1ukSbx0/X+vBoVxUl3MpQ6FEkHogiSHrXAM3rpFPCaEQxsnWEXNOu44vfb3P9FAKB7uBTDQPHujbV1CrGDW4YtLBk7zZlAhZR0A4w== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PAXP250MB0518.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 08:09:01 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Wed, 10 Apr 2024 08:09:01 +0000 Message-ID: Date: Wed, 10 Apr 2024 10:09:00 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <171273246715.22242.7277960037711067953@lain.khirnov.net> <171273594562.22242.12579179149940227185@lain.khirnov.net> <171273638339.22242.1059676662908196338@lain.khirnov.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <171273638339.22242.1059676662908196338@lain.khirnov.net> X-TMN: [4YvgPZhZfqqNtiHgwZyVSifOVGKF5qp6laCPbr0kBL0=] X-ClientProxiedBy: AS9P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::26) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <78344d88-3303-48dd-acec-c6eeea5edaa2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PAXP250MB0518:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b333413-3656-4bd4-21cd-08dc59357b3f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sf68QBvrKHmJ+rc5BJ1On7ns4IG5vjA6We1Q7bT99MY1N43hJlJkzPEXeFyG2AxcftletBFUE6fUr3Opdg9Pok+xQBdCU1njg0CNQXgzkwAEic0qWee1eKCVfNyhD1x2AQOLEHa/eIlDstNexo38DZHRsUe03CzkkE66T67NytATxR67+CIjuCJXOBbZTH8uqQKc2zUERBLWAKylMx9ud7CCZal0xGh9jjWFlu34yH0j0bmwmihKWA5eceTF1NazMZ8XIv/19qB4fHVnPKhT+9gBAy4up5CQlCSSnJwqVkXyyVxxiCbMdlq0G0UBvN4EQV83iKTXyzkty00Psts4PrPaoZ5J86ssiI7iEMOKxPDZuRyLKVbQQJBXHRPR0XotomAdma9ReuobzDlXJmW4w2Swjg4CXgMK26y7efM5YlcQv4MV9PYkrfq0pIEHQ/Fxm/QbqjNUBffpvLy0zPH9ysEQRLVzQDuzdFhJfVLGY03lS2ETtK5eOYbKNBP//tHXdN1hQllvrCUSMEgOFm4IB0m0GpGRkK+mWxzO0nQ6s8z7hYoVzABJ3s/BH1hDo77m X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUNTcVE1cWFVYTFkalk5TUdleWpDUWJEb0NrNVJ3dXFaU3NMWGFPc2F3T0Ja?= =?utf-8?B?WHE4S3FXV01uNENwc2J4ZVBwbWtjWHFGOWVsMXc4U0JieG1YYlZTQnNZKzZv?= =?utf-8?B?dW1xYURhK3ZPQUx4Nlg4K0EwVlNuR1VHVG44NlN3a0U2OXp0QisySWF3Mjlx?= =?utf-8?B?b2lCdkNqT2NZM1NZaEJPQlpYaXBNVmtxcTZ3Rll2MzBLbm9GVDRFM0h1QUMv?= =?utf-8?B?MkJocmNXZC8wbDM3UVorbzc1UjhRa2ZvOXpSZTRjNE11emZFSytYK1pBT0ht?= =?utf-8?B?Uk8wZExvdFMzQzJDRk00SlpzOHVrWVVqLzRMM3FiNDUzajZuZlAxTzBVelVH?= =?utf-8?B?bEFPc2lXTjIrY3F3YUYvSUNDMTlPWVN5dVZzVm9hQVZxN251SWNhdHJ4OHJX?= =?utf-8?B?WGNSRzFISTVrSWhTWWFzUVpyOC8zc3ZBR2Y5MGs1RTVDczExUWpta3pPQUsv?= =?utf-8?B?enFlK3VnZGM1MG1VdDhpdEIydzUrQmdwbTB6VUNNb0Joell4eVNWb3ZHenUr?= =?utf-8?B?bi94c3RaMyt3cmdiK1psTERwMFNwdFhGZmFHVG9Mc0J3V0VLNTJjN0MzYkUv?= =?utf-8?B?NHd2NDhGT0VaZTNvNmZxNkQwQjFCWEUzdG9KNVRPZ1hMU2VsSi9RYTBDOXc2?= =?utf-8?B?NHF0SUNRcUNsRWNkRTh6ZFhjSFNHb3NvbnZWZjZpVm9hRkE5R25MZVZzWmhV?= =?utf-8?B?aEZUa2xDbnVrZCt6eDR3ZGdCOUxwbVBWTDBSSzdEUUFqQnlzYUVJM0NIOFFm?= =?utf-8?B?ekdVcHJhRTU5eUE0WlZrNUVqODdsYVdLbzMrZWk1MDRjYVdZVFJreXExbmcv?= =?utf-8?B?aDE1OGw2ZFhDTEdoNmwzRHhtc1ZqMGNsY08zK2lYckx2ZXR2VE9DZ0VQeVBa?= =?utf-8?B?YWF4ZkIvQlVJRUI1Y05PTkRvanZrd3VNWTdnN0cwZEtPaWd2NFl6QUJIR2FT?= =?utf-8?B?azBHM3A1THNJdHZXdXhLTzg0TnpXYTkxVWtHVGNvK09LQ0huZ3FmSVhnOVo5?= =?utf-8?B?RGJVUkJURUtwK2xwK1ZJSEg4N1VXd0xLT0N1VGJQRy9BMHNPUzZJQ3RUYXFq?= =?utf-8?B?UE0wODVBUFRMWWNZZFBDY1FuR3RwTlhteFRNWmVnRk9kdHI0UkRPVzd0Uzgy?= =?utf-8?B?WVNoRjROSkRGN0IyWnI4emtzUlNqSHkyMFVzemZkRlVYQzZLZXUwbXhpT3VU?= =?utf-8?B?RG9vbERPMzBBNGRSWkFpS0hESGR3VW1KVi9jWUxBZVRnand5Y1J0a3l5eE5Q?= =?utf-8?B?emRCemx1QkExdyt1SCtqRWtGM2xWaEJpZk5yQ2JGNnJITDJwQzAvZUx3Rnd6?= =?utf-8?B?dldhUE1pUmNyY0VkMmg3YVVwMHQ4MmcvRExlVndLMDRvTS9Kb3hSTXlwdFY3?= =?utf-8?B?cC9NbHBFNUpHVERncjEwRGplWDdTdWRXaGRScXpZbEErL091R0UwUC9yUlAr?= =?utf-8?B?ZUdFLzVid3Q4ZE55M0FYdXM4WWFCMkJxS2Y2b1dFZElXcUJycG9tcGFHaDBh?= =?utf-8?B?Mm9SUHYxYzcyUmRvTUlCQVFnRUMvL2JHaXR4YzNBMjhVVkJNQ1ZBcEE3S0t4?= =?utf-8?B?MHpVY2hyZVBSSjJJWENBTDE0eTNDblk1UFh5bU9kclp5cGxFN3ltNmFUOTQ2?= =?utf-8?B?aFRsRzc5SFNiQ2NEUXdxTkYxUDRXY3ZHVXEzT2pCNGEyTjJyV3dnWndwd2wy?= =?utf-8?B?aUVmQ3Fxa1kzV2VtUTVReThuckRKQWFMTzY1TTlPVmFaSVpiSGZuTDBRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b333413-3656-4bd4-21cd-08dc59357b3f X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 08:09:01.7635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0518 Subject: Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-10 10:02:55) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-04-10 09:09:00) >>>> Anton Khirnov: >>>>> Quoting Andreas Rheinhardt (2024-04-08 22:13:40) >>>>>> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c >>>>>> index fd356bd190..6b2c4312e0 100644 >>>>>> --- a/libavcodec/pthread_frame.c >>>>>> +++ b/libavcodec/pthread_frame.c >>>>>> @@ -779,6 +779,7 @@ static av_cold int init_thread(PerThreadContext *p, int *threads_to_free, >>>>>> if (!copy->internal) >>>>>> return AVERROR(ENOMEM); >>>>>> copy->internal->thread_ctx = p; >>>>>> + copy->internal->progress_frame_pool = avctx->internal->progress_frame_pool; >>>>> >>>>> I'd still prefer every thread to have its own reference. >>>>> >>>>> Looks good otherwise. >>>>> >>>> >>>> The opaque of this pool is the main AVCodecContext; if the main >>>> AVCodecContext is destroyed, the pool is in a state where one can no >>>> longer get new entries from it. So giving every thread its own reference >>>> is pretending to make it an equal co-owner of the pool, but it is not as >>>> the pool must not outlive the main AVCodecContext. >>> >>> But the only use of that opaque is checking whether frame threading is >>> in use, which is a constant during decoder lifetime. Might be cleaner to >>> avoid using AVCodecContext as opaque. >>> In any case, this is not important, feel free to leave it as is. >>> >> >> But whether frame threading is in use is only determined after >> ff_decode_preinit(). > > I realize, which is why I'm not insisting you change this. > > But it could be handled, e.g. by allocating the pool later, or splitting > off the part of thread init that determines active_thread_type. > Which is IMO less elegant than simply doing what I did here. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".