From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C833049375 for ; Mon, 8 Apr 2024 20:15:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2947F68D396; Mon, 8 Apr 2024 23:15:07 +0300 (EEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2061.outbound.protection.outlook.com [40.92.66.61]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE10268D369 for ; Mon, 8 Apr 2024 23:15:03 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ci3+uAvGuJkmYqu5XbhYziAw+Lub1INCK9K8donEfJdRZvnjlNsIfwxCoV67jcJkUGVPLfRYcNZbHtA5zjCvGJqheMbxreTrvkwp67XNQLBXeavNH5fU87CFq8eatj3jeEmxWIqczphXxOi1HG8Lc3ZL0zTV9yP58MOEWscl9jrAW97OnWwS4Yw+FnuA9HNExGn+3I4lO9XNR4PbLUOd/vk3Tk+v+Lab8Tte18KHGenFKNGOS3Ik9VkzF3vZLdHLZIPQzAXeLWRb31ky4ev5RQchLcsKlqojJAeT0343GKAfeDzYzayoDIYuMUatk0IUiRXtXhoUYwSI8Hr3p2rvKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lTZij8djsi673dwUrJMVLvHKIgcfswSC0Ue8C0WjXD4=; b=C9aYYt6HvtfyV2dss4M0LDc0R2Hlp2T+EZiqMVj2ew/afIrZ1VM5WsvwhbMUpH974XF0eyIiU+xD22H7QR01eVZyZqXlgrL4zvV+4NLfm+Vjn1QWNxsRIAqW2uOf4CWQPnC2Xwl5SVNpxhJz3leE66gAehwwCkEIJcbHMLwpzal14j9Ut1Oa1FCCFU5nmKlp0bfypLG9r26BXdWIZsrhLeVwTrFp1SuX5wwcvJ7kulZIIC7Fg6pJJVA4IYsc3e7eDddXSOqFDBuC9PJfLQ3WMkKWiZQ6dCKYOJNDqEr8PzZiiuT6UUKTFIcW3w6kbFKcX9H32KtORcfEIq+IbIZGhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lTZij8djsi673dwUrJMVLvHKIgcfswSC0Ue8C0WjXD4=; b=bzwNZG3d3UNTm22rxsS9x6ScM7kkHVrJLBGWbGpqYy6YtntZsT4DkvsQ5JrvXUruaCrrs2LJk+CT5rBu3yo+d+TONA+ksTkEz6QPSyxPXMuk1Av1exK97/A416edgvhjhZWsIM3/xznEyPL/3c3UrFdooB0GqZ7aDHjSEwdLxIwbc1wTMogTDw9lEgFT9q7wNQsCLpueS6fJuMV6lAFclRx5mTZ/JNTIddUrteqgzQBf1o/e7OnBv3L3QEu6UuG2cNiC4z+LjOBqTd5ioGRDNm2edyxG2x7m1ILE0kgdejJR9fMDl+VrffrdehDlrdrW/yfjjcoXoeZCzNuFqxfH9g== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PAXP250MB0494.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 8 Apr 2024 20:15:02 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Mon, 8 Apr 2024 20:15:02 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 8 Apr 2024 22:13:47 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [Hg6QorluqkEhS8XWOKuOdewH3gw1GzzHrsNWAfnZjgw=] X-ClientProxiedBy: ZR0P278CA0124.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::21) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240408201405.2136840-8-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PAXP250MB0494:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c9d8773-3931-43a6-d8eb-08dc58089266 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l7QzbALm6e0z8ISX6/ZJkjI5UPvPxzOXMBgNTklkRtRPE8sazZJPqWa5zsO42O8iyyKFM40c6uP9ZM6Vudf1bMN2md7M5QuP25xh+BLGt6STdZidNXAdc5nzsOpN5cH0XqMDfo9hBOnb4+rGUMbIjmh+54KWHS5vjk80g8zVGwK2Xlm5klmi+qk+rKsnxEphtS/W0YMVoxtUOlGZWtKGojOodlB6wAb4wNd6h7wt0WJ6PloAlR566Sr4xm58re4DlOD+34jrEjE4X4o0f97WicEOnjlAbQWu6qo7jZvdODQKNYWOnYCUaKabTmpzqi7Ut369jYovq/ugYBGxDx//CUSnS4LEZyGlbimgMzq3oXIvG32wE7fpjQSZms9np6zSP+zaW765PPToazcVyu5J+P41cDgtKVoZnDdHk/H3THI2FR8KNilm17joEKKTwEG9SMWnaOn5Tk0MgSMahwW/FudacP04RLmM21gvoSenMxEafgj9kanJ15jCGRjATPzaqqKZt/PfDE1L6GPXVHu91lHBni4lZkUKYjpnwyzpm92HPToqMell/YMrqCG474H7xrsrKEOnZhglhFWuVKAbfeXKDbFESC9VbsrQtKg8/YyejCQ3BpNWkr0kc0fC6/EB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UTLy5i/ij7Yb1Vhyrt1s4QfixzlEOX8qyyH+ihWh/QQWLZMmmPrBGmYbGh4a?= =?us-ascii?Q?NVj+QJqgpbpcuTXjGWe5AMKeleFesDKC1a8z9qFWTVfK5NWgoFntfah14XBD?= =?us-ascii?Q?dIImz1rsTecCHA2F5uW7xv4LdZPJ3Huz/1Nj3x4HZzxkpjJ+Lp6APOW6WcLS?= =?us-ascii?Q?yQwoz9X+4CVW/jLUxfiHQ8Fq1LKZU0XIXL1LyKiezRPZaRwIaq3ACquxrjrv?= =?us-ascii?Q?IFodIrW2aX+kaoBFVRkNNj3ta9L+5xVMaenk04PVxduZfOCNTHJAgEe04A1U?= =?us-ascii?Q?8CAzyVyFNRWRlp2kZcjvyF6hTktTIbKYSgvcfC7dNlN14f6vSFbjNWsQBHnr?= =?us-ascii?Q?nYHEIg4jTFRWDeqVOZOoSt93mEdA5hrrayXnXmiQ1hF4twCBPgX+j5KASoeX?= =?us-ascii?Q?DUitpT0xAwQFmHLZmfLN9riPqemWCslXhmhL+FFByNi8FJU7/5+RmjT4EGBa?= =?us-ascii?Q?7MuhxPo2WAxLfvIJzdlri8YnAtVpTMiDzxK69D5w+JghEscOAnMZ5+WwjtFM?= =?us-ascii?Q?q5wsaWcmrayeg2nQHgyiZM3GwpGN5clsRQUrMi/O/uEOORf/0UuRSHAznbkX?= =?us-ascii?Q?HPDjuKLltkNbVSuvPzSAD1U/EQBq1x5YbqAfEa6qKIuroHE53xGqqPSa/WwN?= =?us-ascii?Q?RPYGfJ7v6nvu6nPL/H84UCn6cfRmRTa2S0fRJKAOQo4+QvKokO3dpYn+KyiD?= =?us-ascii?Q?3uL12s2BrTcNdIU/81qZThmKaeB3KRttnjdkxmvtxIOS345me1g9AnDbF7Uh?= =?us-ascii?Q?Le4n4bufYTRiMp4doV+GNymTZqcs2RMQzSX98n3ukGqAcZ0UVIA7Hgh6nRg/?= =?us-ascii?Q?waIzeBH8eQ99DG4q03tg3gvdC09bN5svmSwBWgj3Ygn9b8uSeQBhTWJw290X?= =?us-ascii?Q?oMTfC9Zy+Zpco17Awm9KrCFRvH4VL8WHymR2pRThafaMZU+5lSNZp/KpJ2e/?= =?us-ascii?Q?h1VzC4gvbPPiZGxGitE1lOlF7ok03zHcPHLlEjwHuCfnTMfMLAbODA7STYdS?= =?us-ascii?Q?gocUI5tH2MnmCLghguRjy3TtTJhlVAPvek5nMZfMyxjqubKNBuiLA9WFpzFg?= =?us-ascii?Q?gVgTWkubGbbwOhc9s+EhieM3YjuiWFvLdYoOqGN28MZe6g17xXhh6lgQEvbA?= =?us-ascii?Q?XAbrL5PwaIRy4BtiBCKD0nEcbWVPletaEEiXSmzcMT15TP2UqBehKWP3q3O9?= =?us-ascii?Q?qd2v1hxuUgrh7eolJi6jtEkWSqgwtymLBsuZjtGEzdNWbfeG2qIRgRGEHInZ?= =?us-ascii?Q?eJSDc0sVZU5JZv6jt5dZuPZDjACFaALSCAtFOFINuw=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c9d8773-3931-43a6-d8eb-08dc58089266 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 20:15:02.0691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0494 Subject: [FFmpeg-devel] [PATCH v2 09/27] avcodec/vp9: Replace atomic_store() by atomic_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This part of the code is not slice-threaded and they are semantically an initialization, so use atomic_init() instead of the potentially expensive atomic_store() (which uses sequentially consistent memory ordering). Also remove the initial initialization directly after allocating this array. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp9.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 443eb74c3c..3adfb98f2d 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -55,7 +55,6 @@ DEFINE_OFFSET_ARRAY(VP9Context, vp9_context, pthread_init_cnt, static int vp9_alloc_entries(AVCodecContext *avctx, int n) { VP9Context *s = avctx->priv_data; - int i; if (avctx->active_thread_type & FF_THREAD_SLICE) { if (s->entries) @@ -64,9 +63,6 @@ static int vp9_alloc_entries(AVCodecContext *avctx, int n) { s->entries = av_malloc_array(n, sizeof(atomic_int)); if (!s->entries) return AVERROR(ENOMEM); - - for (i = 0; i < n; i++) - atomic_init(&s->entries[i], 0); } return 0; } @@ -1661,7 +1657,7 @@ static int vp9_decode_frame(AVCodecContext *avctx, AVFrame *frame, #if HAVE_THREADS if (avctx->active_thread_type & FF_THREAD_SLICE) { for (i = 0; i < s->sb_rows; i++) - atomic_store(&s->entries[i], 0); + atomic_init(&s->entries[i], 0); } #endif -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".