From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A523244204 for ; Sun, 2 Oct 2022 17:17:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AC1AE68BBD0; Sun, 2 Oct 2022 20:17:33 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2081.outbound.protection.outlook.com [40.92.91.81]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A7EC68BB4C for ; Sun, 2 Oct 2022 20:17:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kMvL+gK8/OsKHPv4yGaSO2+htvlF00XNinlNHvgfGX3bx8rlUQRXzkP65QjHyFfxvlcywmoq//CdsQSckEWq+bLGkzW73PkpJRj4Z2wVU7uClp6GW9iWwEuh5LfzVpEakb7qR6ak32p5PlC0r8aw3AjbxOMknXNL4iDQVZljfqMbeyo8sPdk7OCwDlm5m7jmDHCUuCaUwr3bfqhqSxIfF6zGdCrt/zsKa9E7LB1dtSZwQVON8V7T3mADI6na8kE/VupgBRkJcUJlXzStfusoXCHWPIiiJL4poNDRYAPGze7RHz0SMDSfG7ZUWtlDhZvCYJK/QwkvGCyjLHEJLZuLBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gJZrQTl6EXq/VizgLT3PFx7/WcM7cejK0o1v9Db0xbs=; b=XIggK72u2RLOea9V1OgNCRjvQyfWlwrj+f8oJm3H+WwjdRq+I6h8tfCvCOf4RLpQS4ZDwRpDYtjkgNORlniljHzWUlS5/IL9zm/tKV8JyQy8MkYWuGfOmGSo2IBi6I/+RwBdmuPEAeTcUK2IaSakBP19gdoCmVCjBivXQAZEO9E0megA+m7sNY8aivVjx39UMxaIg2HjEXluGStzhLHP3utptsMxHehH/5zV3UPRWBtSUbbHWa0s0tUiLwtIAmXa7qfab+XNRAhb8X7gQuZ3masGsLBTNT6PQ7AEXM4ZStIVR4WGmO0MbH/Ki6bUnIz6Qv13cTkBDSLdjfA1PO4ipQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJZrQTl6EXq/VizgLT3PFx7/WcM7cejK0o1v9Db0xbs=; b=BtWTRG86OzxvNAjrmPXCm35Ml6JYbGKOlaBhAGSdgaAbV9w9Lkw3X+7Jol7uh3WBQ62xibHiV5Hchtvvy2sW5605Yza3jAAOA2M6WdUTPu7PWw5tGcT7wtVm41U0LJ5iAcYRHIZNPrGC9jnH1iT0g5M3awSw+xVjsXcI2d+jAEVBFupXGtNjWM24dHzvAhQfBgbOXF28+fRT19eXl7Z+qzkbe//SZsvSq+maf4hC4hZNtb90vfgzvcUwiF1hOajsrYPGMcc8Ye99fugdNcXej+bnpkRW6BiTVW34ViZoVeyZebGJ5Mca8jenZCEHmIkGN7QCyjlVK3Xp66LcCHKZfA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by GV1P250MB0788.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:9c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Sun, 2 Oct 2022 17:17:26 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8%9]) with mapi id 15.20.5676.023; Sun, 2 Oct 2022 17:17:26 +0000 Message-ID: Date: Sun, 2 Oct 2022 19:17:32 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [qkAv12nwIqQslurFxUM/FgUlCkAIP2iU] X-ClientProxiedBy: ZR2P278CA0033.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::9) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <0fa0088b-07ec-558f-4258-c962e821ab86@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|GV1P250MB0788:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c1aa553-3509-4fbd-8ca6-08daa499fa1f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gHG5N22IHx9p/iTdmbFiHj+ytIyg7fOc9oAovNW9XtSGnUOJPWk0/YoxlKd4nsFncndoSh0oHkId2NUqn+Ot5cloe++A095qkOLsRbLBUF8v9fAhh1TpoL4wvxhqibAaVh1Q/xxl4NKbu0U0jC6RMtcri3u2bod7qJajxxBezeRzl5lcO2OoGBCl+gfCuhBWo71Bs74XM0DLjSYP7bjGaBHl503JqW8E5tr8z4ZsKOK0XbA+75tRNrutFape/R4SaLJXd0tC5ArS6AoQVdsOwiCantSGxlmMj+dNbymz9J9S6inW/HiFtxwMKNgdA0qiSX+ybzGjCViNWdI4ajRzz1yBUIjR7w9Qw0u3Fgl3rWChNPW8qOKaH9EX/1YDxPcNYj7wkcXj0pJsLPszS1hQqC5djJUmu3+C3w41MEV3hz2B/iy/G43qJJ4bVoWAyvGC0V+Wk9lhqzh7zhqCPBhtIw0LQx90eBzGMKjjYRYAgNxqlbmHFuUISh/8DQtXX9IKExV7c4llqL6pU0CgeIpI8zpfaWrmrvfFM4QuyoHAFzUXYA/difEGX4DFiff+N0PP5sGrlccPunUtIAPSBMScEs7kgxhnVb2/ObDetxsujy6eeoQG1NT3Il52GRXSsttlxr143pVOpZwEUFugLJ7d68I8Bze7NCkgMQHfKy2HkRL/zzf1yF8ImDJxzSisILIU X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUQzVEYvVGJ5K3I1b3dyN29VZUU1eHh1NzR3dk5tVTBjbDNjSlV0UmNIb2RH?= =?utf-8?B?Wmd6OVYyUnBobGRjUWdQTElNRVRtM05yOG5OSEhiUGFGb3N4L3VzcFprQjE4?= =?utf-8?B?RWl6RUhDOENvVVJvQngyMDBrMENaUm05TGtFRDQ2NzRzemcrSmZhSkk2U0hH?= =?utf-8?B?TVZ4cStQazAxblNKbVlCVGZBQngzbWxsSFVYWFY5bEtCak1CcFpoSE5SMnE5?= =?utf-8?B?K2ZxcE82STFtb1ljTXRhejBmNTZuTEl1MGJEQVRWVHRPS2htWWI2ZW81NG9M?= =?utf-8?B?MmpNL2puT0FmWEZXbmlUc0l2c0FjR1l5aDJXaHBSNjQ4UytxNlFOcXhLQjJH?= =?utf-8?B?c2ZSdkQwM0pZYTNabmUraERwYXBDQWcvdG45Q2h2NlBBRmhCN0s5eG5WaTJP?= =?utf-8?B?M0JVbEpnRXNndWdySWUwdnRhc2Fic1hGdDF0QWloZVZrVVVMYjBoL2FNRHlF?= =?utf-8?B?R1UreU03c2JzTUVhSzl5RTJLdFlwNC9hY3NUNFk5VEFBZmpoR0x6cW5Pd29K?= =?utf-8?B?Z3YvY2JML1N2anlpZFl0SnFnbFVPVVY1MUdkSy9jWDdPVFBXVUZzcjRuOEJU?= =?utf-8?B?RFNTYzl0SFBCU2V1SHpFN0kzS0VIUXg3eTloUS9HTWhoTTBMYWtXR2M3dGF3?= =?utf-8?B?Y29TVVpreVJKRlVnMDdBZlU0MDZqN2NQK3Fhd2Eya1o5WWx3ZmlDeitrUlJO?= =?utf-8?B?M05QTTRuTU1USnljSzk5M2Uxd1ZEdkJqR0g5RlpjVCswRERzeTZkSStFSHRs?= =?utf-8?B?ZkkwYzdKb1hwc0FpQmpOOXFFbzN3NHVwU0dKQjR5ekVEUnU1UzhqSUgzK1d4?= =?utf-8?B?RXlucnhhMmlyaUlUSFR6bC9maWxoQ0Q3THNEV3lPaytDak1zUmVQVnRVSFJa?= =?utf-8?B?UWF0ZVpxQllOdnVTak5USTVac3NZZzVKSVM4UkZLNFFocm5CS2NXOHZpQ1Rw?= =?utf-8?B?MzlTVzFWMEFxeEtiT2xycE96YTFabTh3WGpwRmlmdkg2TnpuY01pSTliTjY0?= =?utf-8?B?cy9KdERIbzAwOFM2aTBhVUp2ZVVlNTFmZFZ4ck1qVVpwSGZkY3Vtampvd3J2?= =?utf-8?B?VnV3QVhWWG56S2hwNUhKZCtzVzBMRGlGbCsxdDNqNTdwRi9vR2NkWDlKUElG?= =?utf-8?B?RGU2dk94ck9WMmZhZmIzREV0c3d0SVVSa3haN2RUczZMYSs4REJUQWEyU0pK?= =?utf-8?B?YytVK0t2WVk1NmJtTno2eEFBN1NYdDJyb2d6YXo4NldWZjhRbHJjTWUxNUxY?= =?utf-8?B?cXU0MEhRbEVkTEVIbDlXY29yMlRqSzNoTSs5MFk4b3Q1VE14M1FRSkgwQ3cv?= =?utf-8?B?dmRiWm5mMzNzVDJKbHpJZll6VlRKWTcwaGlYMWF0TnRwN2h3UDdaRnNMSWw5?= =?utf-8?B?MC95WlZER1hrbVlZTWN6YVVNNHZFWTRGK3B2WG5tTXdaTDdxOFM0UTdlbEFn?= =?utf-8?B?QTR3WjhLSThBdS9WUFk2WUp0RktwakZoVHhBNTN2aTl3Z2lCOEo1QjRTL212?= =?utf-8?B?d1ExTG92Qzk3L0FpTlNhUEcybjJoMVRCc0JnckZBbXM4NE85VUk1RmU2eTd4?= =?utf-8?B?aStxZmtjc25uUkhwVXVpdHlYY2NPczVhOWNaOEo0ckRxdDNRems2VVFBNUxX?= =?utf-8?B?aXRYRWxGRFduMUR2M1NjZC9ONGtVWVpJaytkalMyRlM1bFYwM2tUQUYvZ2x1?= =?utf-8?B?WVE4QmtTZzdRWEtLV1lHdlM4VFFRYTVQSTJDOS8rNloybjg5Njg2dDNyM05i?= =?utf-8?Q?U2sj3PcPHXiXZlQp159WtHZrqM23kx7koCXoZBk?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c1aa553-3509-4fbd-8ca6-08daa499fa1f X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2022 17:17:26.1856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P250MB0788 Subject: Re: [FFmpeg-devel] [PATCH 1/6] avcodec/g723_1enc: Remove unnecessary av_clipl_int32() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > partial_corr is an int16_t and so the av_clipl_int32() > never clips and can be removed. This also avoids > undefined left-shifts of negative numbers. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/g723_1enc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/g723_1enc.c b/libavcodec/g723_1enc.c > index f3baf7b4ec..a22985ca44 100644 > --- a/libavcodec/g723_1enc.c > +++ b/libavcodec/g723_1enc.c > @@ -200,8 +200,7 @@ static void levinson_durbin(int16_t *lpc, int16_t *autocorr, int16_t error) > > partial_corr = temp / (error << 1); > > - lpc[i] = av_clipl_int32((int64_t) (partial_corr << 14) + > - (1 << 15)) >> 16; > + lpc[i] = (partial_corr + (1 << 1)) >> 2; > > /* Update the prediction error */ > temp = MULL2(temp, partial_corr); Will apply the remaining patches of this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".