From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 247C0449B5 for ; Mon, 31 Oct 2022 12:15:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9148A68BE14; Mon, 31 Oct 2022 14:15:13 +0200 (EET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069073.outbound.protection.outlook.com [40.92.69.73]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 74E6868BDA8 for ; Mon, 31 Oct 2022 14:15:07 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FlxLhlmMq6UmEzwrcpaQqCGyjDcIv15QvwQUqeXs5ebNdXgL/DlBCBzoUvsIg608B7YXk1S9vTfZLeweEuFtWoGIdaMohhpR48ZDt6zxanZnFByE3CJDfy6+ImQtKR7jvtkwzft5bp1kSwnfIx87mRvzWUKsCsWCspwtnySJNDmUay49eS3IxHUHIYDhLD/NUDhyR09wGSrnvsOOpKzGRbiMWZ7fv/x6SeOzjvlBzGnSloqOn5LwZbCHTgokiESfToooxqbHENd6x6kGssnridf05MjT1UsU1V+rXCgXejkBUiHQ0UdTpvsVgyZ2h9esGIvdL4PWX6hek1IzXKHvhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/VgletsgTg/tZwxTWy65JB+NvpTqswU3es62VtomWoU=; b=LzIVtvhF/4m7vFDJdkLfOCjJF6HPEyOHQaWj4mpgsdkEcCc1gyVwgEZWyk75Iqp1Gmg+kCw+BNOleOtrs078SjVu6TLZxgrkLwOZ0lbx4yIdgkdhfC5SG47NxLFxM55ib+ZHRRQAt1q6YGkYp7j5USNnU4mY/pebDhySeU0KCNuqKFgscZ4Mqt8PAB+oOk0s603BAK0QyHwpeSeJ3BYnh03vz3M55zC6X1LrgF/47D1DTSKmV6X2RrjOMemIC7BTyAQnaR5CER4RaChmsxEsUoDJQCtuqFu+zFY+r9gpVmNqYRGuhGgTcrGn/BbwdNp2qYdBJdavwc3pmwmJPX2Edg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/VgletsgTg/tZwxTWy65JB+NvpTqswU3es62VtomWoU=; b=j+IwDft1nQnTNDFTAVkaOKsfPPMH24Vve5wKuEUm3B+3zFxUgrKU/pOgxnSuHFDIsljFBcxVhTE8jnITneImYRAQTX79ZWYr3cZGJx+mYaJBF5af9Ox72SgPtQl5XIOd04GiXfhQTeT9IJ3tEj0IY8EEjVzJorrqmD9NdZxZOYDcUh6IFw7rFFzWVxIR8oGWc95Z/5rhsw6uVSKFd1nENF2LyKdpk+K8+WlR3Ufpbn4REplW3SwQ9EQXRVZFlq4QxHBWQGd5P2e0fW9K9bfllyanoLQVi7eJ1uI2YCTwtnuYDNA/rfPSLn+vP97pBthNPwxS3dIGmOc7Rvr+pL2sYA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0089.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:36c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct 2022 12:15:05 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::739a:8740:19c5:925c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::739a:8740:19c5:925c%5]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022 12:15:05 +0000 Message-ID: Date: Mon, 31 Oct 2022 13:15:15 +0100 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [YhAjiYJzMSbusvA04XemjEDtL5yvFICA4+vdgMxC9K4=] X-ClientProxiedBy: FR3P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <7f358f28-dd86-f1b9-7666-5732edf639a2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0089:EE_ X-MS-Office365-Filtering-Correlation-Id: 557557c6-ecab-40a7-3a1d-08dabb398b2a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BiTNItrn7pIyEJJKh/MenHjgGWkctnSdp2vSZyRAn2zjop4AbJe7ASFQe/No1ZfXSUZ1AaYyXrybMP8GS+wnT4uQJXA5iyt0Ci37qo93kd+wA4GQNtBHqDfeAFa4Yqgzve1eud8irOydLfbdt3fnxJlZcyF29Wk8zVAd0uyy0BszrOvSXDWCc+zTD6UY5PMtHnSLJdbwZv5ZIubN6GPpa/BJvfSu35CIFt8Du1cet6i4OkgpUO/pkYYxdKtwG+7d+8tK1E3AafxRv9hwjrB88Nvh+vfXLcyd9vuOYF5xSRowQYfDYe9XhGz/cyGG1I/j9XglLc7MUlUsG6pXk4PnMXz8rCLao2XtgYIXmbV56y4YxScN/bMk9zAJ9KdvWT8oQMiQu8EWOUXtsyxFRZKuqc8ISZX9cbs/i4Fy7YT3v+kOJMqpov1ey6Q7FhNdx+8GZZrjqN/3xJhWbxiM49U+kDjLs0W6dN+bUZalm4MskqyslNhFchexfv2rqqoX9gUR7nf8mQ5wZQPzEd5lWJuS5EyowGi6qFSxB9vsFQnNIm3VW71LRGTDVT7S1dLfsy56EOkRLnT5PiQe111XgenNzrcacLcOnuTxLa4UBLyHSPFamC1wPdPYTxydNpYPIL/XQHzWwDpwLtwImEtT+vAgBtaKLCcOOWtjlZt8HBG8XL5w7v0dXNdE/aZHwoO+SNaI X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFlQZHFoYXdnWldqVHhrdzRTTzNBd1lmMGxxUmg2Z3dHclIvbWExdDZpdlBa?= =?utf-8?B?ZlRiejNuV1VVMmtndmcxVFFENzRQYjZnTit0MTJvdUdrSFBJZDQ4OEVsTnR0?= =?utf-8?B?VklEclFFbXJsbEVOa1JvM0xLMXJ1dmcwQnllOWZCVHpmdlhIZElTYnhxK0Fn?= =?utf-8?B?d2NLcm9GOEJLeVM4M3F2TDJOREp4M0FLdkNnR3RHWTJJQkFqamJKUUNKMTJG?= =?utf-8?B?SEZMaTNIN2N0eWhQcDhvbDFKdGxXK2hkWHVmRUdaemFvYUhJblhGZTM3dFZq?= =?utf-8?B?YjhoMzBVRWYyYkl5M1c5OG9aRTYvOUNrSlBPRG5Fc0xXVjNNd3B4TjNBV2pl?= =?utf-8?B?ODhoWWE4Qk5FOFhERmNBZGNySlFidkx1Q0VoUVJvdTVYQ0M1c0N6dE1HYjBS?= =?utf-8?B?Q1NpakNuS3VxdG5qSGI0Rm1GakQzUHZZQ2lvcmJTSUZHVkRvRDFKZ1BuRElt?= =?utf-8?B?RDVoN0JoVndleklueUMxRGJESXNGTjVpaXNUUGNCdFlFUlZIM0psaHF4NXFx?= =?utf-8?B?UTFSSkdDS3h6L0lGdy9QR2NERkFnSitJUGUvNFZ6UU52dHVqRGJzSHlqOXlq?= =?utf-8?B?ZUY5OVBjMmllUmRCRjZ5SVRVQy81b0R1NTRQVFQzNCszbnBRc28xTUJseHdi?= =?utf-8?B?c0tkS0o3aXBrRkFwMDhNdlNBZnRqUHUxZVg1ZmExNU4zU29xb2ZDQy9ERVQx?= =?utf-8?B?OVdrOWhhOE1LaWpNNk9sZzgvaXlFY2doVjJSZk1wSlJodzRLOE1tbVR4OTE0?= =?utf-8?B?b0pSNDJqU0lmU2FKVTBvU0d5N1dVZUgyYmplQ2RKU1FKNmgwWlZvMElzQXZN?= =?utf-8?B?Y2lyTXZDRDN3c0NSWkJXcG9MUkdpSURrNWFrZ0pCKzlsRFdjVVRIVEZJSTF3?= =?utf-8?B?cTFVUVlPNmpBMWpYRVBUdDRXeTJyU2kyRDJER1FjLzl4ZFVGYlZtQ0FsV0gx?= =?utf-8?B?MGVMT0VnTmNsTEttbWVpejlWcUIxdWk2cnhHV0lxVzhrTVlwNXJObXVYRFFQ?= =?utf-8?B?OW1SejFlUTAzZk82cWJvMVhVYlpya29jQnZZNlR4RWd1VnBSZXBCOWdtOGda?= =?utf-8?B?a1I3WjdSeS81a1B5Yml4N1RQTml5MW12V0xyZW03VVhlYUw5bTNXSEJkakM3?= =?utf-8?B?ci9DUEE4SFB0R1FiNHZmNEpXZytQSm5IVDgrczNtQXJrajBieExLeEd6a1Ft?= =?utf-8?B?QXR4OGxJUEVNVm9wbW1taklpdzNoU1FCRlNHdjVabHJlU3J2VVNyNTBMYXBZ?= =?utf-8?B?dkVKWVdGTUUyS2Z6REZBR0Y5Y1l0NTJ4WUxjNExPWU9yaWp6NGVIR3FjQ21G?= =?utf-8?B?eDR1SmRteGdGRDM4RVUyRW55SHQzRmVVWG5YRzF3RG5mVlowTGtKek8xVzBH?= =?utf-8?B?WlNFdDNLWDhkOXVweE9Ba205VE1hWmxheHdPeFUyQjdMWFAyS1gyS0JLRUpW?= =?utf-8?B?ZElaQ2VkSTFKVXFXQkVrUFhPNzhrelNuZG50VnI4d3pvMTJVNk5IMndpMU9O?= =?utf-8?B?ZjZURXg1MjllYWFFNTJpQm9YaG5vQWFuenFaM3VnRmRLb0tycGNWZ3RIZGtM?= =?utf-8?B?Ly9GN2Nwenl5Z0piSFNPRGVRUHhFOU9FdUN5RkZCYzB2S01QQm5mSWl3a0p6?= =?utf-8?B?T0lFTFdRVVROelpuYkJHcVlBU25GUnBOT010YU4xSm9xTWZGc3VGeWtteVlp?= =?utf-8?B?dGlJYjB1VlVxWWVCZjdVTU1UZnNSRkd0ZmRtVUMyNXNkckRCMHVucExBVG41?= =?utf-8?Q?+vjIOzQFx1sxp0EGIYrb5EOqxP+rIAESO6axn7n?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 557557c6-ecab-40a7-3a1d-08dabb398b2a X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 12:15:05.1176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0089 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: support unknown channel layouts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Paul B Mahol: > - av_log(log_ctx, AV_LOG_ERROR, > + char *cl_name; > + > + av_log(log_ctx, AV_LOG_WARNING, > "Channel layout is not set in stream %d, and could not " > "be guessed from the number of channels (%d)\n", > st_index, dec_par->ch_layout.nb_channels); > - return AVERROR(EINVAL); > + cl_name = av_asprintf("%dC", dec_par->ch_layout.nb_channels); > + av_channel_layout_from_string(&chl, cl_name); > + free(cl_name); 1. Wrong deallocator. 2. The allocation is completely unnecessary: One can just use snprintf with a big enough (yet still small) buffer. 3. But even that is unnecessary: Just set chl = (AVChannelLayout){ .order = AV_CHANNEL_ORDER_UNSPEC, .nb_channels = dec_par->ch_layout.nb_channels }. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".