From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/src_movie: support unknown channel layouts
Date: Mon, 31 Oct 2022 13:15:15 +0100
Message-ID: <GV1P250MB0737C571C66B71F2A5F92C6B8F379@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAPYw7P5CV0zX-w6v0Y+ok9OgXRbfJ4iih_YNtP6jQAN2b4E4Rw@mail.gmail.com>
Paul B Mahol:
> - av_log(log_ctx, AV_LOG_ERROR,
> + char *cl_name;
> +
> + av_log(log_ctx, AV_LOG_WARNING,
> "Channel layout is not set in stream %d, and could not "
> "be guessed from the number of channels (%d)\n",
> st_index, dec_par->ch_layout.nb_channels);
> - return AVERROR(EINVAL);
> + cl_name = av_asprintf("%dC", dec_par->ch_layout.nb_channels);
> + av_channel_layout_from_string(&chl, cl_name);
> + free(cl_name);
1. Wrong deallocator.
2. The allocation is completely unnecessary: One can just use snprintf
with a big enough (yet still small) buffer.
3. But even that is unnecessary: Just set chl = (AVChannelLayout){
.order = AV_CHANNEL_ORDER_UNSPEC, .nb_channels =
dec_par->ch_layout.nb_channels }.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-31 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:53 Paul B Mahol
2022-10-31 12:15 ` Andreas Rheinhardt [this message]
2022-10-31 19:40 ` James Almer
2022-10-31 20:23 ` Paul B Mahol
2022-11-01 15:25 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB0737C571C66B71F2A5F92C6B8F379@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git