From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH
Date: Tue, 26 Sep 2023 16:51:57 +0200
Message-ID: <GV1P250MB0737C54C04DEB28C79B738078FC3A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <d23c7be2-7512-3a6e-c766-3950e724ebdb@martin.st>
Martin Storsjö:
> On Tue, 26 Sep 2023, Anton Khirnov wrote:
>
>> Quoting Andreas Rheinhardt (2023-09-26 01:54:30)
>>> It is of no value to the user, because every muxer can always
>>> be flushed with a NULL packet. As its documentation shows
>>> ("If not set, the muxer will not receive a NULL packet in
>>> the write_packet function") it is actually an internal flag
>>> that has been publically exposed because there was no internal
>>> flags field for output formats for a long time. But now there is
>>> and so use it by replacing the public flag with a private one.
>>
>> Is there any value for the callers in knowing whether flushing is a
>> no-op or actually does something?
>
> Hypthetically, in theory, I guess one could make a case for that. But
> most of the codepaths where one use this anyway, one is pretty closely
> tied to the specific muxer one is using (usually mov/mp4 or maybe mkv),
> so in practice I don't think that's needed.
>
> I don't remember there being a specific demand for that back when this
> was added, it was only a case of us not having internal flags at the time.
>
So if we had them back then, you would not have made the flag public?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-26 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 23:54 Andreas Rheinhardt
2023-09-25 23:55 ` [FFmpeg-devel] [PATCH 2/3] avcodec/codec_par: Move enum AVFieldOrder to defs.h Andreas Rheinhardt
2023-09-26 0:35 ` James Almer
2023-09-26 9:17 ` Andreas Rheinhardt
2023-09-28 10:17 ` Anton Khirnov
2023-09-25 23:55 ` [FFmpeg-devel] [PATCH 3/3] avcodec/avcodec: Avoid codec_desc.h, codec_par.h inclusions Andreas Rheinhardt
2023-09-26 10:49 ` [FFmpeg-devel] [PATCH v2 1/3] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH Anton Khirnov
2023-09-26 11:08 ` Martin Storsjö
2023-09-26 14:51 ` Andreas Rheinhardt [this message]
2023-09-27 8:51 ` Martin Storsjö
2023-09-28 10:38 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB0737C54C04DEB28C79B738078FC3A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git