From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3F9E040B1C for ; Mon, 3 Oct 2022 22:01:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE86D68BBB2; Tue, 4 Oct 2022 01:00:58 +0300 (EEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068036.outbound.protection.outlook.com [40.92.68.36]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0F7EB68B8EF for ; Tue, 4 Oct 2022 01:00:53 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=knzOJ7VJSzHzKJx1yyJJhfMQeJ8quAz47PG6TfEXpD1koNBdEd/OoQPj9YY9//ZcCDuc0/mmxzw8wUS3eSmNgO/TOy2uBe+CIogywJLB+5deRfuOrglWyKtlcBN0s+cb7Uqwy39MbL4cvK0cJRaJ79AaFImt3aErVY6/7YH/iFcCBvqcfzwRXPeVbm1FeH1grDHxEUMwynqw/4ekVHp1XYv0HjmXQfZoFPpwNuZDkF24ostFFWmG8p/jyvCbpyY6BOgUZEOe3kySOCVDjnr1zed1F8HlxKC6H4dkJADLxeWpTr8iUO6hCpFCNZEaS9C5OwVJAMQQLhoQpb8sj+wKqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0VU8M4aaEx96iaddPS8lzUKqFqRt+u4DQ4C7or/jADo=; b=kw/PRow3kgMbVrXaUAWt2KKAJAm0aerK9bFfMY2qrdsny171+x6r3iC+7AHC609rABIntFVwQbGeGM1+DBYCUBcqrFCuvLA10nLrNvFKGcoScc7sID1x6LqrPC8oafFYT5e1kbfKW6loYX8hK1wsh/0iMecsfBGhGk1/to5OrA2IPV0UkOhFCE8yIM9f73fV0H1+OLcTB1LN05PfGDqsgEzLPhb/einnlacRz+7XXaD1n13Iioc64naHo/GUpZyB6ILbaOkTvODiVkNdgRMu/7QnrsJ8IUelx2wrfK4uVVpSz6m7Q8qnAzVBukO4jyBe6SN2xUEtTkV+XfjWTFecrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0VU8M4aaEx96iaddPS8lzUKqFqRt+u4DQ4C7or/jADo=; b=Bp4y2VDXMLAj+tJCxlHp0kyxq+ThPD/RHEv+Y+tYqUGbbcjGcvF1HcrCToef1Ew6t3qhSGk+mHJSfO/5G4k9Z3FYGjI8OCF8VptTBCD0YE3uRSzdN1lx6mDds6N4pw/cDN9dvJe1En0IiGRkJp5Mh/oAwU5TkPLKNZYYIkumQ6UnaChrF7Nbgb0F9IM7mjZk9ts9CNje+66K6V+SHYTIjnAhdM5hfAaO+/7PPM+sqfjWXNViVfRSvIVtBqYBQU0LE1aVyKvcLVCHu2XnbXKgGub1a2wmHpwDKW60mK3ICPEbFvCRzR5iWRGDPOSj6S1gOop7W57UmAqYeTzfw6KroQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0126.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:239::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 3 Oct 2022 22:00:50 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8%9]) with mapi id 15.20.5676.023; Mon, 3 Oct 2022 22:00:50 +0000 Message-ID: Date: Tue, 4 Oct 2022 00:00:56 +0200 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [QnjaZQnt9PtO8JhlXtDH5IyovX9F1+iA/9Nuzqn6rLg=] X-ClientProxiedBy: ZR0P278CA0120.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::17) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <37372a7b-8962-7003-ee0e-e087ed9788d2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0126:EE_ X-MS-Office365-Filtering-Correlation-Id: e373d839-e2a8-4a0f-5813-08daa58abc05 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZSnAcJjzRJACXUcrfoL759yqSkPiZdWtXDwvQ300uDUpk5bh29JUbYBptj2bkuTPTgjkzgq8MKPPi1Lk/FqFRZFOIsd46nrS4aToe02cQh3MlFR9f2EOMJGI2AUfSumSHbEMq5rUv9c74CNcqTVIIaRuWcNgwKkmk56T0Zb5muH4/ReDPbocn8eskdcpExzSAjDew3Z9Ks9tZlUzz9r3Yqr2r1r4IfYlZVzY8MWu91sk5hyYLejAAZtb5vjOkhkIaGhke+HmIqKC4+F5zTmWvEY2OlD1bdmqB/EHmNj4ZYDJydLYgqJAjA8hJYpU0rOPBE/x9geiaz27KLPSQMEqDZ+/TQyZxEDQqIRYaY7m+90YWmkfUKd24PMjGdl8S7nGMUmEedSBjKIYkswBy8uVAkePgHbQdZPGMXqD39XRl0P2VcmMekhOn0uDSxnbP9VFHodC+3aGAn4S1sjXCHfF8f7ZBKjd+bYDSrBrkOzNIGHOGbvs0wJMHzPXr9p+7zDDe3HwlGmlj7rohZh0yIEUWMh41v3Onj24ejKC1nttlW8y+tYXqJfctgrFYXSJJ9ukcOnHtpVVMZE/4d5x/aFrlV3ik6MxC497Tjpxe9PTmetSsOFz+7ndQefMn/WJDi0L6NXzC8GjxAbC6KKsU23B3ELn3f+6S/7Z+u/6daIrexJS9qerD6buGXQUm60ydl/6 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZklvWXcyVnVvbVEvZDFTQnlHOE5Lb1RvK0xTV3dqUjF3VTEzMC9LcXcvS3J4?= =?utf-8?B?cVpFZ1hwZVRwblJiUFY3emp6M3FOQkU5MkZqUk9NcTVlT25hYWRBNlozUkFM?= =?utf-8?B?dC96cDhrcmdQaDY3ZG11RDRKL1d1RW1sdHRWTDZkLzBKQ3A5NTdjYmdhaGtl?= =?utf-8?B?SitNVkRjSHByR2JWdmZlbHJjdUN4OHpYQjZBeU5ZVVV0Z3lSUkMwTVkrYnJp?= =?utf-8?B?d3FMMXliZ2RZZGgxZllTVGZaMlNFVHFad3lUKzg2K2tENElwUXVRNVR4WEd4?= =?utf-8?B?d2hjejdCSDVqaDN3R0VaOVl5S2VOMGJ5UkJNZFlqMlFHYWN1VkdzWWVTa1RY?= =?utf-8?B?MGsxUDl0VGtZZVpaOGsyUkdET2lUSEF0aHZIR0NxNFRSaUYvWWtiWUhwc1lO?= =?utf-8?B?YlBKUi9TdGZDZUNoUVNRRDBjQ08xTTRmMkc5VHV0RCt3cXpGb29tRldRem9k?= =?utf-8?B?Tmw3anhlQUlwUXViR0FuaGQ5czhoVTRHZVNFdm8yajhST21OU0V4NWMrODNG?= =?utf-8?B?eEZ6dkY3Q2xUVzNuajdVWVp3WElrYk0wZkxSUUI1emxERnZ6NXBOL2pSUXZr?= =?utf-8?B?NFM3S1ZadkYwQ1pZUjY2K2k2N3NrRjNZQzFDYktlbnMyNTMxMmZMVnNWVzMy?= =?utf-8?B?cUhDV2c1VW1xWkd4TG9TZkNaN1Y1akpFNjNYazZvb3lqYkc0a0pkZ09tV3FO?= =?utf-8?B?WE50TytwQXROQ0JDaTBXYjE5dU02aUFJSkNhVEFEZWdqcld1Q1o0WHIxUmtK?= =?utf-8?B?NzJDZGhoYXphU1dsc0MwcUM3MFpKd0wweUZpT2xnUktjWUlvM1ExMldMaCtE?= =?utf-8?B?TkY1YkRkVlVkcnMzUnFlZytya2hERThhL1BnbmpiazgrZHdETndrTnBFbERp?= =?utf-8?B?d1ZGMmoyTjVDaUtVcmtWTy9uZXJiK1ZEMU1rZzNqWWtPdUJiVkRoZXl2aDBl?= =?utf-8?B?eFhvQUN6OU41QUM0VmRDbjhtVVVxOHNHckk4MHJnS00vaFBxUUxtUWlUVDVt?= =?utf-8?B?clM0SmxXRjZXU0gxaExiSVlZOGpHeDZKQnVYRlhaVWlhUDBUQWdNSk1ybHVP?= =?utf-8?B?QzhhU2tYTFBLWnkvNTBvMnlFWnJKNXpibzIvTjVvbmtZTUVoZlRDTUpHOWhQ?= =?utf-8?B?QlREenp6QWJIb0NCaWRmM2t4bFo4SWZldENsUGx4T1JyUkZSUFJsUnE0NnZB?= =?utf-8?B?MXBFNXE1dXBFVE9XYVpMeEE2VlRuQ2Jibzg4NnRiYzh5dTIrZmRRTXd6WXJH?= =?utf-8?B?N01UVXJ5a3ZyRlp3M2IrR0NSc2xFcEVOZlNqYmdjeHdPYis4azM3OEx1K1JH?= =?utf-8?B?UVFldFVDMFd3SCszNThtaTJHUmppYmhxSGtxei82d0w4bmZLQ0pzQzBubWtD?= =?utf-8?B?akNaL3FabmNEcXExNGZUeTNyRytBZDJKek5vWHNTNWdXc0MrRlVFRFFHTTFP?= =?utf-8?B?NnlvaEpCT3RoNWJITzlTdFcraFJmcWM5VG82aFNLaGNOV0pFdjlsa0QrYzhl?= =?utf-8?B?dDYvcWxBVzkxRmJFSThOeUg4NERoekJpQzZOZjMvc1RnRnNOWGVISGJjSHJZ?= =?utf-8?B?MGFiV1hJRkcyc1ZJdTRoczRrWVNobzdUSXlGdmxJVi9jNFIzM0sxay9EWjRG?= =?utf-8?B?emdBbEp4bUc5MzhjNFlFU0dMdFhycktZM3N6dW5tbVlOMFdJR0VFY1c2UThy?= =?utf-8?B?UC84WWxRaXpzOFk3Y3hrLytKNnF1Ykg2bFk4VmZLTDJPOTVyUnRESGxlVURI?= =?utf-8?Q?tnO1KtgkijVu8Ps1L83A2i96kaBEKEmqyZ9NceL?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e373d839-e2a8-4a0f-5813-08daa58abc05 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 22:00:50.7226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0126 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/sbcdec: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > We never guard against a user freeing/stealing the private context; > and returning AVERROR(EIO) is inappropriate. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sbcdec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/sbcdec.c b/libavcodec/sbcdec.c > index 3fac2f5016..fd7c2e5e80 100644 > --- a/libavcodec/sbcdec.c > +++ b/libavcodec/sbcdec.c > @@ -343,9 +343,6 @@ static int sbc_decode_frame(AVCodecContext *avctx, AVFrame *frame, > SBCDecContext *sbc = avctx->priv_data; > int ret, frame_length; > > - if (!sbc) > - return AVERROR(EIO); > - > frame_length = sbc_unpack_frame(avpkt->data, &sbc->frame, avpkt->size); > if (frame_length <= 0) > return frame_length; Will apply this patch tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".