From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 36E414A9D9 for ; Tue, 7 May 2024 08:49:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A210868D74A; Tue, 7 May 2024 11:49:27 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2045.outbound.protection.outlook.com [40.92.89.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A411568D52B for ; Tue, 7 May 2024 11:49:20 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TI9OIJ3Uwlf3DxXqvkjtfuV2bMKQKrE9CTErrDNFO6MEIbChWQxsXHabqD09O6g75hei4VeQ9UNaC0GVHIPV+hTXiSw4zKmcoGTE2m4EQr6tafWejex3HxLkLjzgx2Fjw6FdceUL+z+e3lsRyTZAOYc1+BsrVVTZvw/+VPDxshOm7Ryde5O7QVfcHdBM4U5uWjfuzLICXna16RZ+C0EQKceSDPvxTkXQp1BdiWGuuuwnc/1xW0/+iBI7HSW5d3qww4CDRuw2Zn3KmPTf7/n4Yx1Jak3EzZMpLXxy03qBDZ5bZ223Lnrj4Ba3CfrflRt7I3G9HBFa2fxJ7j+JBo+IJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xWDnfXGlpszCoU2Kcs39kIzFh4Ov++Av0pMvrr5a+uE=; b=R8hSAWuv19Dm7/UK1smKEW+hG52h0D1lBjbXEWQ51IhWXlEEEnyb2/1j0NqrSLh+8WQFZmxop++C+BbESE31G0MIT9OyDXULyHiWSHa9qqeXRdOqFzVT5D4EAg+HY8ghYHi6Cj/UcfC1f0fsno8eWyJlipISyAeTN26crTNFgQ+6c/T+PEt39mKeUqdgWeUCuoyBC26/9xIsA7vPQnpg7V2B7Z+7/fTwWwWqxUbtIopy3F/L2OG8s5/FvkgmFH4xBpPjPDWZ0ucAxrTAh/4z3edKpDKJQYckWWjMcTdRUCUt2r42qXx4Lz/DBF9Yeyu/RyP4ciNZfOg/zkfrrj4PQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xWDnfXGlpszCoU2Kcs39kIzFh4Ov++Av0pMvrr5a+uE=; b=Gyu1CfvgB3cgztDTfudP2bYPj5PYfjBZ13En1Td67h1QRZNs285iFFqflF0/muROnJg0RMmmDaTSLAMiCrDGNgGYTnS9oOjEgkr1RzxiqWUX8F+lLF4gyYGCo8S3kGSsI9X8SNjAPNg9rBcfPOpPg1TCNXg6FCWysVg+VJV0zp6phobpBfto697GfQCownC8UH2eACjyBii+nppRK4f/pNXsrOvaE3FaEe599rC1xGI9FqSJdaHx4MhDiKvd5/oxX5fkfnV8aQKwbpvQHLPuF0bcf80bWs63+m+l5JWlkjwMzJV5I7e4QVbvedW6vLiZ4lCuRKpcWVKXozTyGu5T5A== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0067.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:172::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 08:49:19 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 08:49:19 +0000 Message-ID: Date: Tue, 7 May 2024 10:49:15 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240507001016.GD6420@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240507001016.GD6420@pb2> X-TMN: [quQHHvQK/E8WYV6Lbebcpbzi5dalzGpaSVamPQ/LAKk=] X-ClientProxiedBy: ZR2P278CA0064.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <93a08afa-cf05-4fee-9029-7e1c7ab27142@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0067:EE_ X-MS-Office365-Filtering-Correlation-Id: 008ed464-10b1-4544-167e-08dc6e729511 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: DdIA07iryesFKZ7GVolWufxu7M7U2XM4f0t4wx/3rfndv4FDO4T6H3CY9VNmGTtgu0M8Fofjs5xBBh5krFa//E7dD3KyHQqTLRX1XdGYjg30kqdnV6G1eF5J91/jMUY+vKsWu/g/2fbL1rfWk/BGHIGWOifq8/G5e9WODyMEgxH989GP+21Bu2U/2B7bLVZ5d7CwmsDgFw2FvAr7Ya/9SiekOlDi49jcGeubLfqOK0aP/RHy8K4jFzNZrC6WnQclh9W9vETdOXxPlq30hRsaykqQXrPZ20dcrMlOp2XXIabngQsOctLg0nhU3HY9z3JEkPuF0MYLhaVDD/J65/X9C8c8DYzCiBlndEISiDuAYcRUT6lYyfROa4N1JFgYThYxWo+nm7ns24VmDpriaQOx1boCPgzTnVE0a1PZOdVYSIE/pb3LJjpna/mXrJNFT+8kSCjpbtiOcpKCc2yAwqN6nXenVY7ek/1UgX/okdA35IfeRSje5OhKR21Vxuz+hrC1Ooe1Xb3D3B86zv1TM0Sr1oD2/t3OC4a7oGaXar1y4j4KcX7mRlUgYCzn2U2Q6I8l X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UloycWJ5VWJjd2R1SHp4V2hHRkNVZ0djbzlFWnhnMDhCTlMxNU5OSjNDS0dO?= =?utf-8?B?cXBPNFpRU05pQ0wvVnQ5SjJJMlN1YXRyM1d6SXlnRVFSSG1JT01MVUlnZGxt?= =?utf-8?B?NDZmSE5GRFJ0NDUyMXJkbTlBL0R4UEo0NTUzaEhQclZxQ3FjV29PN2V0Y1JO?= =?utf-8?B?VzV3SVZYWGVMdk9HRGQrTzdTSHMzRzdIdWozOXFSbXQ2L001bVRqaEhnUnE4?= =?utf-8?B?MmlLU0g2SmVEanJ0TCtreG5yQXZhZmV4U0FYSTlzZ2VZaXlrUVhlT0ZCSW9m?= =?utf-8?B?cTBaY0ZwV1BxU1B0UHdncllNeVZrWGVJLzhaOHBIczlUWlNGM1pTSFZaZURH?= =?utf-8?B?WTRJSlI4dm4vUzg1eHFlV2JOVnhmUEFrZ3lSVE1qV1ROaDlDSnFBbWJoOHM4?= =?utf-8?B?bEdBNVFWVE1YQTFsb01lbXYzYndxSm0rY3RZWG50OHYxOVVzRjlBVXVFU0ps?= =?utf-8?B?d3dtaHBtVkNVNlI2MUtLcE9XR2QrS05TMWdBNnFVeTdKYnFzdVBhVXNjNDQ2?= =?utf-8?B?bEZWZGQyRzBWMUNIQTRFOUkrWTBLcnJKSDR0TURhNVY0NTFaYkNhV01aaDl0?= =?utf-8?B?MXRBVS90WUhaNmwwQTNvV0gxQU9wcmdaaktLdGZ4ZVhSRHZ5NVJpUmsrY3RO?= =?utf-8?B?L2JxamRxSTBZMW5LU2c1TUpJaGhXbHdkdmczYk5ZSXhrdk5Kbmg0cjh1U00r?= =?utf-8?B?NTRlRXlxb0ZuMlNnMnQ4U3VBYWFPZmdweEdLQmFLVEx6S3hLZ1BPVjIvTWVy?= =?utf-8?B?bVJKTFZlVFNlNXE1WnBPajIxdk55NGZ4YXZNYWNUbW9Qa1QyMXpCeTVlYkUv?= =?utf-8?B?WW1YYSttN2VZa1hjWnNMaGNlSHhEMVdPK0JnODh5aHB3b3lvT0ZCeGtaelN2?= =?utf-8?B?cnNDTUpZQmRpOUZYM2JVQjNhdzJUN0Q2Slh4Y1JFS3VWc1d1TSswblVOd05G?= =?utf-8?B?Vll3RFc3b2JhU0tVUGh2SFdhKzVlcWlQSmNDNUc0TlJUcDdwaStXQlVpTkgv?= =?utf-8?B?VUlEMEV3R1hUYzl1VXhCNitzRDN6L1N4T3IvZWJXV3lHQTF6ZVBaNjZjNGxR?= =?utf-8?B?blZrb29OVDJoazlrejNQRnhXNEtoWHIwTXd6eDB4K1dwc1hlb1lDQkZTSzFi?= =?utf-8?B?ZFN3T2E5dGIwSTF5UTV4V3liOVpUNlp3dWZuK3lZTFlrMjJDRDB3MGZyTzdF?= =?utf-8?B?UzdYWmxKR0llYVFTVUJSZnJMakFhNGQvRUUwRFI0emcySTJtL2drM0UwbUt1?= =?utf-8?B?SmhpeXpWV3RDSFM2WEZGR3BkYmN3MWxEaUJUQWd3OFZpZVpnL3JtY2VoVGVF?= =?utf-8?B?ZDdRR0FDSDYyc0Qyak8wTWNKWk43L2VwZ0xVR1pZMnBrNVdFQ0V1dkxQWGFL?= =?utf-8?B?aSs0Wi85eWNXSzhBQzBHeldCL09zRTRDb2xPanY1eEdMUzgrMVhhYkpTTmNY?= =?utf-8?B?ak8yeWU3VXZUMTQ5aEhKbnZkeG9PQ0VoMnlPTTU5SS9aLzVxZlJ3cTViSC9H?= =?utf-8?B?b012ZXpqd2NQTW1HVzgrVTZqQWpoMHNRc3M5bjNPNWhyNHRRd1RBenRPUVBx?= =?utf-8?B?RWV4U0tJTG11c0J2Wng3WFZGWGNEVWVoa0xRaDFESjlVT3hMeUNuOXF3a1V6?= =?utf-8?B?N2o5WXlsbUpyMm5QZURnVTdVVWI5dVlnbWJNUnFPUEMxQU56MkxQMS81MlJu?= =?utf-8?B?aERSRExPZU13eWJVTzl6YXcyNnFzQmtqVE0xaS9DQ2pEYXRnNG5qRTZBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 008ed464-10b1-4544-167e-08dc6e729511 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 08:49:19.0255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0067 Subject: Re: [FFmpeg-devel] [PATCH 25/28] avcodec/x86/mpegvideoencdsp_init: Remove bits_per_raw_sample check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Mon, May 06, 2024 at 11:52:24PM +0200, Andreas Rheinhardt wrote: >> This check has been added in 19a0729b4cfacfd90b8ee84ab0c093ff7e397e65; >> this commit added high bit-depth versions of draw_edges >> and added the check to indicate that the mmx version only >> supports eight bits. >> Yet there is no high bit depth draw_edges function any more >> since d4d186d185df98492d8935a87c5b5cf369db9748; since then, >> the mmx version and the C version always behave the same, >> yet said check has not been removed. This commit does so. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/x86/mpegvideoencdsp_init.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/libavcodec/x86/mpegvideoencdsp_init.c b/libavcodec/x86/mpegvideoencdsp_init.c >> index ec174b15aa..9fa7ee4824 100644 >> --- a/libavcodec/x86/mpegvideoencdsp_init.c >> +++ b/libavcodec/x86/mpegvideoencdsp_init.c >> @@ -233,9 +233,7 @@ av_cold void ff_mpegvideoencdsp_init_x86(MpegvideoEncDSPContext *c, >> } >> c->add_8x8basis = add_8x8basis_mmx; >> >> - if (avctx->bits_per_raw_sample <= 8) { >> - c->draw_edges = draw_edges_mmx; >> - } >> + c->draw_edges = draw_edges_mmx; > > does draw_edges_mmx support >8 bit ? > if not the code prior to the patch looks correct to me. > and the patch removes a part of >8bit support > it would be better to finish the >8bit support > Neither the C version nor the mmx version supports >8 bit (the former does not check for bits per raw sample at all). And none of the users want a high bit version. As has been said: It has been removed in d4d186d185df98492d8935a87c5b5cf369db9748. (If desired, a high bit depth version should IMO be a separate function pointer in the ctx.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".