From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4193D4E52D for ; Wed, 12 Mar 2025 05:27:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 912AA68E3FA; Wed, 12 Mar 2025 07:27:23 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2082.outbound.protection.outlook.com [40.92.89.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6FF168BA1E for ; Wed, 12 Mar 2025 07:27:16 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fa/+muF9f21BA+QGVCY0v0lduyXhir8wVw/hSA7zAw84BhCunXnfBAX/lWYswqbqw90BuStL4srAsIn4G+C1dlEVrXKzj+0y7bEHZxVwYQrwtyPJDXjbgFygtbYjMUJCenoWB7esHlv2y1+cL02FNVIzB2ShScmQ/9M3yysgoEz2tPNigTCXrTpiMAcEQ1lF2TVOzH0NJ2hiziQLENd3PWtzKsr2BmGjkWUz2v36QrPL9OR5Y38uE+gBEVP6tR9hSv9rd1/fqnj087t/Rgd3QCwNllDQYmLikJBLIqeBg3mXBCmEbCNvgaj7rZJOjZ2G45hdXEq4CLMl7mB09cf+3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7IsRIHvLmlgrOvtJIASlenEALvo1+TCpu0x4aR3ubZg=; b=Dyn312dlrxyMP7zilXnEDHgYHLGO18B3O5gM3VehwFgT2JrGtztcVuYE67dRXrQuMgIhuZ3PQog0GcEd7JXn+1xPquS/DuL4utjsKd+pAEFQANk0TQG7552g4jxWVuJ2XgdPAJCbkA8hdp4biNATZ2yvUcO8uEH49Lwaa6TSIxYC0xbi5OJg6xLg+hVCYDu60DNNr0KvzYL2gTxjboZuumiBvq+8yo4z/YaTA243skqZC/GpmHr3viClRSyq4jCEw6aw/JdoopFPGrCFwiU58Len0RKvw3Wk/0FBAAjJDKFksV4wDkz7OAPCEJlXXiAtN+n5gMSdaL0JA9qFmt5bqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7IsRIHvLmlgrOvtJIASlenEALvo1+TCpu0x4aR3ubZg=; b=Ox3dTzI/Gw3+RgX+cpoBgj5A34cdqBK6eo8xYJqpU1sAlCpcRlgm+iRXrzms76EfpATgK+QMwO3KnKYrJWxqwwNGB9DjUdzs3TfJNIyGONO7AHPpv+hCkTfXBoIt53MddBe1NLLwKpt4+Iu9JuwJ76XVo+Vo5EttFPOjEVcMJPo0q/unl7sjBeIjD2e87RWx0q/kpVgGajnxe8rYPsman3aNiiDYHPSWA2iyrgqd1HolXgFJq+FFaQ+mcIfkodwWCKGp7Wb+wkmDDB990dlq2OJIfZmjld/JKjde9e3X7bCjxFAWBP4zofIkDq8cfvs4eRIV+/aSaku1k7CWW6stxQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB1010.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5a9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.21; Wed, 12 Mar 2025 05:27:15 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%4]) with mapi id 15.20.8511.026; Wed, 12 Mar 2025 05:27:15 +0000 Message-ID: Date: Wed, 12 Mar 2025 06:27:13 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: ZR2P278CA0027.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <3b4d8787-8f37-4ef0-b1e6-c802aa8f1f17@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB1010:EE_ X-MS-Office365-Filtering-Correlation-Id: fe08aefa-49b9-493f-e2ab-08dd61268c71 X-Microsoft-Antispam: BCL:0; ARA:14566002|19110799003|8060799006|5072599009|461199028|6090799003|15080799006|7092599003|440099028|19061999003|3412199025|18061999006|12091999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?L3RqLzJmczJpL0I3WmgrcFJ2Mm5UMHFkaDhwWkczOUpZcUhacVJxb1M2OVJI?= =?utf-8?B?WXJya2Fwcnd1U0ZHdXhXa09Sc0djbHhrN2RpcTRoTDh3VjdEUE5XdUZSSWJn?= =?utf-8?B?WG5EdmZXWkRZN2RUT1AvUG9RMmpLMmpKV3ZuZFBXcWs2SzI2dDllSDExY3JO?= =?utf-8?B?ZVNxdnJqc0JQbGsvd01CcjdXUHBQQnBJVEV2ditpSkx1Q1puRTc2VFVhdVdt?= =?utf-8?B?ZHY1ejhQa0tWUnhDTVpaaDdKSSttVWs0bHpiLzNZdEN6cjE1T3lHNVhJV0pZ?= =?utf-8?B?LzBhSE1nZ1cyNVk3bUUyc1BIL1NxS2ZNWTR4bW44RVNhWFNVVnQ4NlpDblEv?= =?utf-8?B?OFNseWxFVDU0MXJmbVpzVTlqVndSdlZCL3BVeWMyZ3VzV3RZTkw2ciswVytZ?= =?utf-8?B?MGM4STVmUkIxOUxEYVZyTWFDU3RqL0hGSUpuSWpoNy92cWpVUWIraW9rcUNK?= =?utf-8?B?YmFHc0xsRDhBeFQvL284czNQeVNWT0ovc1JoaHkwUHo4by8vczZJeUJOR0N3?= =?utf-8?B?S0hPZUNLT0NNUlBSOGlaUkZPMHJNVkpWS2VsanpLSFlZSDVqc0cwRXNxZytN?= =?utf-8?B?UVFCeUFhYXhuUE5tS2ZWVnpINzJQRG5UaE1OMjd2bUZNS3d0U2w0eExHZkhG?= =?utf-8?B?NUV1b2puQ1plc3BwWFI0a1B0QTlETUxKSGlLRE50YmN2WFJ3NktDd2NpUVN1?= =?utf-8?B?Y01mMzd0TFNDNW40TXNCcW91VEl6QlZIN0xuOVdTZjZOWjBDMEtjbEx6aFph?= =?utf-8?B?SXNoem1kR2pvenR1RkluMEtaWU1GMjl2UEtaZnBJamNMaDd5Wit0QnMyYzh1?= =?utf-8?B?cmhBNk9mcHhEQmZ2K2tmbUozemVRRTMxZG5nUEE3dmJhNXF5YU56MHdFVFFB?= =?utf-8?B?MFVzdGsxQXVRUzl1dEE0QTBYbGw3dXZwTENwZkRaZS91dmNXZDhNL21TbUZa?= =?utf-8?B?UmN5S1lPc1BkMzE4NVdHSzN5ak41N1NNNDFUVDZlUTRQdlNlYlFiS1RsaHQ5?= =?utf-8?B?R3N3MGRsTStXaHVKUGZRK2hPODZMRkJjWVowZnN5bkt5WDErRXExVXNSb0gr?= =?utf-8?B?eHk2bWxoVzZ1YmtheDJWV2lmZEZFUWhPb0hEb3R2WXBLR0I2WkN0dDYwaUlB?= =?utf-8?B?b0VBYmttVnpHWmoyN3NNQUFkaVQxN0VSbU5xNE1BSFVuSG83QWk5bXg1bGlr?= =?utf-8?B?YmtacGxncXRxeDlhM0dOMUdoTTVnSXFoN0RGK055S0lJc0g1K0FpNUdaby9h?= =?utf-8?B?STQxVGhva0xnMGFmTDg2bXVBS2lIdmlaRkNab0MxYmJrOUdHaXVHVEtrNCs5?= =?utf-8?B?Wm1BMnA3RndLTzM3cEV4V2liQ3loYzZzdytIQ2FVdTBBOXNidGtpZFlhZHJG?= =?utf-8?B?MCtmUkVFTFNVeFY5VnF1aXBBMkpsbXp4bjMvQ1J2OW1kTnhrZGc2bzhBZ3FX?= =?utf-8?B?SWZVZnluYklzd2ZKKy8vdE5veXU0aXBLa2JHbmp4NGhuZWhFaStDanNvcWxU?= =?utf-8?B?WG5DT3Z1L3NHeGYyZU1uVHVyVGpBbGRIQTNwTi80OVNJQ0htNVZUZWE3a0Jj?= =?utf-8?B?NHBQRGpRc2xlT0dLN1hHZjNxR1JBUlp1RGp3eTFpS0R1SWFKVzBabHlSQUZv?= =?utf-8?B?SU5PYndLUElJc3BQc20vS1FBOFBVM2c9PQ==?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDg3ODVURGRub1N2VjByRjhTKzgrb2YyZkM5ZFVxQ3hYRTBFNlFOQ01DdXFu?= =?utf-8?B?NHZWWXhFbTlGcW1yeEo1MnFiVzQyN1BmWUMzODNWRHU1Yy80ZVd3UzZkQkxQ?= =?utf-8?B?MXNnWUxOdUd1L2NRUUFZOWNvTUQvTkptZ1hWTU1YQndQT29TdEh0R09wODZU?= =?utf-8?B?M1J2Rm1iOUR3Z0FETm91a0ZtMm53c0ljNTRiNW1pa3R3alZCa3JxWUtwVjIv?= =?utf-8?B?Z3paRWlOcFJsMTR1V2ZLVVhSMnFqTEIvS25Mak1Gdld0N3QrYVduYUl6K012?= =?utf-8?B?a20vbWJTdjU0VS9pdXZORkI5MzFIMmE3ZDdLOHFlOFhqS1pjNk43RXFWQ0NL?= =?utf-8?B?SjBYbzlNL05QWXhYU0ovSVpGMkI0ZHQzcENXSjAzdnlDQnV6ZE5KUFVKVVpm?= =?utf-8?B?ajFZK3kwMzFkRmFVZlVuZnBvWGtuSTVnNHM4ZUxiN2pXOE5JR0FHUVh6RXJt?= =?utf-8?B?L3RIOFNRWFJtVXhIdHpGNUZhQzREZ3h2Q3ltaVdxbTlLL0VwUG0rclpCMjFF?= =?utf-8?B?Zjg4eEZxU0JOdkY3MG9DYjZKVXZROFlwWmpBc01pNm5qWWliVHB5WTFUSTlO?= =?utf-8?B?MFZCRmNjcDFoRHNqbmVnTG95NUltTWVZWHJvTnMwS3VUQ0p5MUczVGFYNytv?= =?utf-8?B?bUVXdWNsTWNzKzVEbXBLaHZxbkQwOTBhVU9XLzlNSTBrbDdUdWljRjdDaGxt?= =?utf-8?B?U3VkODlXcVhmTVcrcnNlZmdHdS9hblh0U3RzQVJBSHZwcGM5TEpxV29pVWJ0?= =?utf-8?B?dlphQ3NqaUpuWFgrSkNQeDVKVUdVTTY2WUt0T2ZJclVkak8rMml4UCtDSzdU?= =?utf-8?B?YWRickV4Um5sMm9GVHlZT2dMMkhaTXFmTHIrM3VXQUpRME9kSVppUUg1ZjNx?= =?utf-8?B?SjFKUVpHSzZkK01NVDR2eXU1Z3ZDc01STEdGZjNZZEtXTmFsbGtSc0VpR1d6?= =?utf-8?B?UnVKS2YyRG5XUWd5eWxJUGlRMXFad043MVQrL3JIWU1VM1lkYnREeEsxZUFM?= =?utf-8?B?ckx1QjBOL3B5N3AySlVIWkdMNTdJL2F3eStIZWZ2V2RxMkNDMVZuTkpWenpt?= =?utf-8?B?UEx4bzVaa1NiWU1YZDcxcUxWMjBMVTM0MGZKT09YTEVsSjdNWXZINWpCRXVK?= =?utf-8?B?clppdlJQQTNPSXR0a0d2SnVhdUZVNk9EeElvLzJLL0NQSWNWSjdpRWJEMzBp?= =?utf-8?B?TElTSGVCMEFGWWVacU1UT0o3Y0dqcW41bm5ER0VmL2dndURMV0kxamg0bWtv?= =?utf-8?B?Y2NQNmM0RE5QSEwzWXZ6MXNBb1RpdHpJWElWWU1xZVg1ZzFiS2RoSldoQk10?= =?utf-8?B?Znd5N1FpOHRZUTlCeUlnOFpkYVBzRnRjaVdtZjgxNE9lbDVCRmo0anI0WnZH?= =?utf-8?B?bk02RUFJMytFVVoyK3U4SzVGblVYcDgrdWNuUlNlYmN4Y3pJL3QyUmNGd2Ir?= =?utf-8?B?UjhXY2RhbU9zaDZvTmUrZEFBTHBwMjJpSCtkSzd4bzJ0aHU4MFllQmFhTTAr?= =?utf-8?B?TmcwaUwzL1pTcDBNOW8wRkVwaTZKem5vMlFpZmJ4anMybmJ2dDRTL3dxWS9F?= =?utf-8?B?RWU5cFJpTlcveFAyTjlTVXgrNWZkai9seHgvdHEvR2F4UWdIalNyVm5TUnFm?= =?utf-8?B?WFB2bzJpRlIyejJFOVhEd2hWZllEREhxbWk0eW1Gc2U3VVdjSWZSUTB5Ykc3?= =?utf-8?B?b3ZFVXhlNlJmZUh5ZHVUbWZTOHlCcm9iT283MXpPelhsaEJ4Ykh0Q3Z3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe08aefa-49b9-493f-e2ab-08dd61268c71 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2025 05:27:15.2027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB1010 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc: Use LUT to assemble interleaved golomb, code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > On 12/03/2025 04:10, Andreas Rheinhardt wrote: >> Patches attached. >> >> - Andreas > > First patch is wild, its surprising no one considered inverting the way > decoder parses codes for an encoder yet. I didn't even look at the decoder. (It is actually surprising that it took until 512e597932dfe05cf5665192efbe2c93c2e36af2 for the original code to be improved.) > Rather than ORing and using put_bits63, I think it would make more sense > to write out each chunk using put_bits sequentially. It might be > possible to reverse the lookups such that you get the MSBs first so you > wouldn't need to reverse them out of place in a small array. > But either way, LGTM. Feel free to explore this in a follow-up. I don't think that writing them sequentially will improve anything: In order to be able to use a LUT, I would have to shift the bits starting with the MSBs into position; and then there would be the internal shifts and checks inside put_bits(). Apart from that: put_bits63() is the same as put_bits() when BUF_BITS is 64 (see ede2b391cc516f4f93621f6a214b3410b231f582). > > Second patch seems a bit pointless. It's just one single call you're > uninlining? Chasing to save a few extra bytes of binary surely don't > deserve having a wrapper function for uninlining. > I am uninlining all calls besides the hot one. 31 callsites. For GCC, this reduced codesize 2c36 to 25b1 (15% saved), for clang from 4b08 to 3338 (32% saved). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".