[FFmpeg-devel] [PATCH] avcodec/vc2enc: Improve error codes

* [FFmpeg-devel] [PATCH] avcodec/vc2enc: Improve error codes
@ 2025-04-18  9:11 Andreas Rheinhardt
  2025-04-20 16:29 ` Andreas Rheinhardt
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Rheinhardt @ 2025-04-18  9:11 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

[-- Attachment #1: Type: text/plain, Size: 27 bytes --]

Patch attached.

- Andreas

[-- Attachment #2: 0001-avcodec-vc2enc-Improve-error-codes.patch --]
[-- Type: text/x-patch, Size: 1585 bytes --]

From 7ef2a150ad06043c1e97d565360d7366f5fb81fe Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Fri, 18 Apr 2025 11:09:21 +0200
Subject: [PATCH] avcodec/vc2enc: Improve error codes

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/vc2enc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index d05df64911..99ca95c40a 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -1080,13 +1080,13 @@ static av_cold int vc2_encode_init(AVCodecContext *avctx)
     if ((s->slice_width  & (s->slice_width  - 1)) ||
         (s->slice_height & (s->slice_height - 1))) {
         av_log(avctx, AV_LOG_ERROR, "Slice size is not a power of two!\n");
-        return AVERROR_UNKNOWN;
+        return AVERROR(EINVAL);
     }
 
     if ((s->slice_width > avctx->width) ||
         (s->slice_height > avctx->height)) {
         av_log(avctx, AV_LOG_ERROR, "Slice size is bigger than the image!\n");
-        return AVERROR_UNKNOWN;
+        return AVERROR(EINVAL);
     }
 
     if (s->base_vf <= 0) {
@@ -1096,7 +1096,7 @@ static av_cold int vc2_encode_init(AVCodecContext *avctx)
         } else {
             av_log(avctx, AV_LOG_WARNING, "Given format does not strictly comply with "
                    "the specifications, decrease strictness to use it.\n");
-            return AVERROR_UNKNOWN;
+            return AVERROR(EINVAL);
         }
     } else {
         av_log(avctx, AV_LOG_INFO, "Selected base video format = %i (%s)\n",
-- 
2.45.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread