From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E1A944217 for ; Sun, 2 Oct 2022 17:18:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E01F868BBD6; Sun, 2 Oct 2022 20:18:24 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2037.outbound.protection.outlook.com [40.92.91.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92D2068B930 for ; Sun, 2 Oct 2022 20:18:18 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5hhceWgN0CFi4eCxUouW0AiJ2X2Fmlny6ADTFOFqnjoHRMBoTH6cUBgfl7nSznjCbTgLiUQTNlyURselkVlQkZdYV/iHa7z+/xdl5Bs/WaC2zqJXLkqiuJDGaDgBsFJTKEpE2z0Tdfm+0gIGbmSFde0WbZOJngHuy7EjE42r/L6v52BtBZSrhfUDBbSU2Uynw6cSMGa5+FxjfAQPKcL0o421kGL7b3NktVR2vkBbH5klp0wLHP48DuZwnOFaMqtZS55UGVTtkUAWK/0ZkKJXSc4DnNObaX0blYmekTugDpAI/BDDzyQ3e6zRebAz/A1mGTmxDAh+DLz5OIcAYO4bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jlG5Z3kf8tvr7wsHAH10FOZsqOrvieM9t9E2blpF4cY=; b=VBCivI/YmCwG3YKIWjbQx0OtHmC8M6d/IjjrazjfFkWsA3ptaGM8dpbadOEDLtAR9mEUO3Fkvdkr6kMc2SGUL+fC1xluAv26rTy8bfko5jv92qJldfCVa7nTyaxd6qWS3LYer4WAUVpyXl+FlNQBGxqnuqqma6P+OB2Y/luZ7LbTOv67+lkYvlsGueANkxNxcnlTz//HvxkuV1R6fRGmfOQn9zwydkbAcq2WT7zD07U93wJ7owrOlt5uP49t6i44Un7V/uxGe+H0uckEHSXB/wfmwmMKJmwkYTiuj97gdTms+Dcj2+W2pkot4cnq464uDgmjrBu4atad2+4u5WVLbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jlG5Z3kf8tvr7wsHAH10FOZsqOrvieM9t9E2blpF4cY=; b=oP1DBN328rfSlOI4Ih6K4A/xd3KImomAxkMhdRLYtw8bcB3pwNGvHreJ7Qb+RRfGR2/9EG5LUNnmBEDgAoFqSAK+dLK5w+9OY2wD6olijnnYyH9oSnr1MrEdRwlrqNUeP0KCxJM1JxUVO/vBCghquKjrCSOcs1tTwxDwKWf9yz15ubJRChNQbLF3zI/gkzOV1s2wTrkYOfFRwhx+iegIltPH5BGfybUi7J8Zn9gmYJeEFC80P0+jqh3L8DsxgwqrQ0XGevyHUJHCtZkvumvdtuIU7AWZ2HF9Hn9ZZpp//3g7MqzuPDQd46lJSHege1wb+g55wK6huWt9mranQCL+Xg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by GV1P250MB0788.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:9c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Sun, 2 Oct 2022 17:18:17 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8%9]) with mapi id 15.20.5676.023; Sun, 2 Oct 2022 17:18:17 +0000 Message-ID: Date: Sun, 2 Oct 2022 19:18:23 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [rxkE54AMGgC/hK/SCv5rCPjVuU3KjA9R6YIQgSX9cnk=] X-ClientProxiedBy: ZR2P278CA0020.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|GV1P250MB0788:EE_ X-MS-Office365-Filtering-Correlation-Id: a21dbc53-c9c4-4b07-504c-08daa49a1894 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dvh7nsz4vAw2w21JCL9y8nXVETDwXw8wftK6wqGuOINP/8LqQs9YvVfKW+5NYU9ugLFVu299nDSLbQ4LMimrp5LYcIgXNu9DCxIvNR3D6hFpoa4+3dRGVFdAa+3aET41M4SRieGIQZoVW+dNE1qy3EbnhUarciG8y9YkWpGgfhF4SZwr5E4alJru/k9aUONa4AOy5OxcqITGh6ll6YfyLUTyk0Isl8D9GOnHkjfjIFUGcIdQ3MkjjOliS6cOwWy0upAQzQK1zdYSONg9KC3oPHPymEIQTBoWdWCQbliP5yZ2tJmMPxg0XSgrGBIcDThODsOMvXpfKS8QGzXQhUXZBnCEh2FLFw6fFB/nFecfVESJ7Cy/lvq2yfkTjEgLQQwxH2uehcgL65CktUVvJhCCS0D82WYoA71jayY1eK1/Ar4/p2HLlFA1lkwpuEVuE6oCBOAOdgYep6esBcFNbE/1vrSF5WU5khZxwXkOK2FS9Luc2ksNi1ZZdlI2BtIvUuePK8908E37dzWjo2cz4PoelOBsoRrK1KMoILhAjVlyMOMi52VxiSCWBLvgrvhl0Cajz7qoe6ppt4KyxrK04utsc6c5/LrmucOGKtW5XrE3OTKOzHMUJ3BQOE6GHRajCT4k/onOt7sfgKPvtuA98cOR6rJ1XpvnBGNtlWR/6EcKFUPdbTtWjjoG0RIsb1k0C1hr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDd2RFhwYnVaMlp2Nm94d1VGUTBidWorRmtlQ0FjOFB5Rm8vQzVPV1BvZk9I?= =?utf-8?B?ZEt2ekM2Wk1Hd0x3QWduSnhFTWF0OU1VRlV0TlZMcTY2QUh3ejFGL3BNRmY3?= =?utf-8?B?NDM5TjlpVk5wdUVQM2lETU5yd0RxSWNpSHpQdDNxRW1ickRIOTBQaGx3RTJz?= =?utf-8?B?QUhNYks2MEhSSmpZY0JJM2lvNnd2ZmRaWkZjR1JKMGJ2bXFQaVNIM3NpVjJo?= =?utf-8?B?Z1NURzlSZ0crNVY4Rk1Lb2FVTzF3L0h0NWkxR2VtazZLUno5ZHkvYXpDelBH?= =?utf-8?B?MjRsdFpJYTZOYzlLSURGcXlqb2dRcTlYWVYvcVg2TDc0SHFtZmF2eVdWWlV0?= =?utf-8?B?SVpCamp4THhZeXo4RU1FSGdTLzhBSTlwVFloWnBETU9ZbXh5RW1rVllWMGVr?= =?utf-8?B?clBJQklEWWNGWW9GMldqajRZQjYwaVpMTGEzQUJQSXR3dzZoTUhnWFgxK0x5?= =?utf-8?B?MlltT1piQ2NEaGtBalpTU3dBb2VuK2lBTENObW1nZFRBVE9oKzV2cGlQcVE0?= =?utf-8?B?dzlWeTRkU2RDTWZRMzRUWXllNy9ETUU1MHNwOHRteGZHYTBCR3FzMHhVMEZj?= =?utf-8?B?ZUdlc0tQRER2SC9jNlRFbmFIeGRBTmFqL3dFRGVabGRmZDJpR0xlSk0yMzF0?= =?utf-8?B?bHBSQ2N6allKRW9VSlUyd1lNSm53RUZDS3JrcjJTS0M1dDkvWm1sNURyYmgw?= =?utf-8?B?cVZ3ZlU0eEZISXdtaXJBRndBaStSQk5aTEdzZXJZa2ptOHdwYVZxdGJiL2Fo?= =?utf-8?B?c0ZqSGdpMkUxYmwxY2RVclJ5UHdYWmxwbEF1aUJ2akQ3QThlVnNDa3NRN0xi?= =?utf-8?B?Uy9Uam0rU0pyOHNOZmY2RVJtL1RKMU0zQmJvQi8yR2svUS9vZkNKbDhxUGho?= =?utf-8?B?QThMQ3BMRDlnS1h6YjN4UUxpbEROQmhFTXJ5QTVCblZ3ZFo5OHdaOGcyTmoy?= =?utf-8?B?K2V3Z2VaaTJVSnRZMVdYUm5UTnlmZitiaWwydE9qQW5XUVFMV3k5T0lGdFFD?= =?utf-8?B?SkcvOWNHblYxaW9CWEhwTDAweW9QdU1aSTZJQVdSWnJyTXVFWng1cWVHUEJO?= =?utf-8?B?YkllU05jTTE5K1JFMlJvblphN3RqRWRyRFd5V3U0SnRuQUlrYkx2bmE5RUwr?= =?utf-8?B?MEJPdnhHK3lnajVEYk82TGtneTV3ZlNNVWtoSWZLZG9UdjVBQnhYVzZtUmdZ?= =?utf-8?B?bWt6UCtJa3RXYTJwUHQ0WEZ6eUxScExIQ0p5eGFHVFhNK1k5V3NPMHRxVkcr?= =?utf-8?B?NUVNTVovazUxb2FvbnREZ1pBSXR3N1J3OUhVTEtMRVFXV1NuRVg5YkRJOFVZ?= =?utf-8?B?eW4rQnRLWHl5MmdNZEFTdTN5YzVKcm9PUW54MTQ3aXBkVFNzQlJUZm9taml2?= =?utf-8?B?VnRCVkNJNmRCS1RjZWwvNmc1TU5FVE1QQjNtQU5YeVdjQ0lZclJvREZORGdZ?= =?utf-8?B?eDVueW91bE9reEVBUExEa3dhLy9oR0F1ZTJ1TXY5MGtmSy9EaHVpMUZmQ2k3?= =?utf-8?B?WEI2cUJHVjYwMTNyZUZKZVhRbHpMYWt4T3VucUV2aUdrbFMvaXk5UkNJL3Rh?= =?utf-8?B?cTZsVFQ2QXRCSXpaYTZtVlVOWDNCdGhZQ00yTVpkcFdKSEFyZTZoM0tYRGE0?= =?utf-8?B?TU00NDRoQ1gxTmZSdHowWEcyQVJLZUdpbGJqOUphMzJpTjdkcTVSZFpQWnhW?= =?utf-8?B?TEhpeVpNUy9tZ3R5eVdFK3dINXpXMHp2WDhzRzlrbUlKUHZBV0lxSzNQUUdS?= =?utf-8?Q?lIJe99k9rTPeVsM6MXS3x91BS0x6csoXeMSXqto?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a21dbc53-c9c4-4b07-504c-08daa49a1894 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2022 17:18:17.2356 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P250MB0788 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dsp: Use unsigned to avoid overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Affected the jpeg2000dsp checkasm test. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpeg2000dsp.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/jpeg2000dsp.c b/libavcodec/jpeg2000dsp.c > index b61be3b72f..b1bff6d5b1 100644 > --- a/libavcodec/jpeg2000dsp.c > +++ b/libavcodec/jpeg2000dsp.c > @@ -76,14 +76,13 @@ static void ict_int(void *_src0, void *_src1, void *_src2, int csize) > > static void rct_int(void *_src0, void *_src1, void *_src2, int csize) > { > - int32_t *src0 = _src0, *src1 = _src1, *src2 = _src2; > - int32_t i0, i1, i2; > + uint32_t *src0 = _src0, *src1 = _src1, *src2 = _src2; > int i; > > for (i = 0; i < csize; i++) { > - i1 = *src0 - (*src2 + *src1 >> 2); > - i0 = i1 + *src2; > - i2 = i1 + *src1; > + uint32_t i1 = *src0 - ((int32_t)(*src2 + *src1) >> 2); > + int32_t i0 = i1 + *src2; > + int32_t i2 = i1 + *src1; > *src0++ = i0; > *src1++ = i1; > *src2++ = i2; Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".