From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B4FAB40714 for ; Sun, 13 Jul 2025 17:37:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 56B7C68E198; Sun, 13 Jul 2025 20:37:16 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2079.outbound.protection.outlook.com [40.92.89.79]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DE10D68D6CA for ; Sun, 13 Jul 2025 20:37:09 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vgtch7I5tgaMZRz14AczR1rSc8EHfUaXzNKsOksMRDXiWWxRG6v6BY7Ics/CnbA0WmYqn2Mrg5gDQjrpDZbfn4Yhnwx1q7bSYnWlsBWflqsbJQiRNfiq8CYcz9ufMAKQDsFwyJU0CPKFq/4hyHlqGkxb7jxgfVpnYK2P8WaRtXu6L5u5krWNU4A9Iy/KkHO7DT0LiO0MGXUyOO8I0yabK9oLmtAO6P4n96Wle4SQ03q4GaO1Ew+XhetCDYyWchg68iIqH2p2kqWdrrVcuQgBxGBzkh1smPlmcOCSx6jsbgpV1FT/cpLUcER+q9q5sNHnf+b50aMmWd9l6z2WRgnUqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mdk9mdVKU41kV4RrMt1WFQ5JtUB2GB17y4qQoQcOwpA=; b=fj5t689q00GTU8K/REVAlVHJogV0F1PyBloBu9/FLLRaMQMpkzz8bzDnPqqcifcuIN0wSIp2LGkgY6f6J1rY/d4Pt4Xxyh2aM6WVeHn1pc/pUUMsJ4CBxQOPQejhbhq1izICTkQixDhbjwrWjsdPAcPU/vutO3DfuMN6ZTenKjvDOYL6OeQvVUt67uwPZX/dJrfQtIljB0p+qCOZjY+Qsk7HdvPw7KLiB73+llfU5HSU1O1spavBL0kEkEnwmpEZuV6CxweW+qYekn78V18JHuMZ6UfWnVLLk6z9W6SCOed3xlhSwEReM0avZjt7TL2kQwvFWCEW5H+m+6dWjzftLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mdk9mdVKU41kV4RrMt1WFQ5JtUB2GB17y4qQoQcOwpA=; b=Oe0PCJApsijMrUyDDa3+bIN8ob5k/T+vzxx2MWLLP5z3YbmFwyaS/VfkAQJYuLU0rDrgO3Dlo1TfnlrWdTawZpwFXXHjIAwYAZO8JMqKa/Wxp+uhCVa98XXjY/4k+kotRKZgfLPkKEsSpOFfLann9AKU65Cz0ah+w4wa46Q+I1eZzSgvkZa0mWSZKhjqxY9hITOov3o2xgaqPkPAtI1cwpxKCTFZ1J0iYv1PniTNdZGdVEflTjZyG0vtGt4LTV88iLxvf8gKbsd9LjIWx1cepMSIi4PqQSJYJo8/ye4T4Wsf0oFLrm99M0NnCimja23UxNPYSTKj/a4T4o4bMQGOsQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0011.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.25; Sun, 13 Jul 2025 17:37:08 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4bfc:40d7:f620:ee41]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4bfc:40d7:f620:ee41%4]) with mapi id 15.20.8901.033; Sun, 13 Jul 2025 17:37:08 +0000 Message-ID: Date: Sun, 13 Jul 2025 19:37:06 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250713011030.1156550-1-michael@niedermayer.cc> <20250713011030.1156550-5-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250713011030.1156550-5-michael@niedermayer.cc> X-ClientProxiedBy: FR4P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b9::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <05a670bc-fef3-44e5-80e6-f60bb78a440f@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0011:EE_ X-MS-Office365-Filtering-Correlation-Id: ab4c00bf-3387-4011-159c-08ddc233e3da X-MS-Exchange-SLBlob-MailProps: a+H6FLLcF3rI6xxNHx/8sTW/IVA+nBvYmgm7Y8NTrkKmqEfQOgSPCDZ4bWVKzWFzx9ACNd66oFhtm3c5H5mJshFVxbvd8qIDfqOnUlMLy4Ky/lL0btU7Sa45zHSEqC69GBa1Yy8OZfKOY17UU7BAiYnB51dxgtjNPLcI6WbkcZEvueitxSdDmhdyA5wNjqpS3NQC3QT2Mq/1SnxtobB8ZFHKCayx/hhrgZ2wD0yM14Vfg8O/V25ybX84noruAnQsmwQTSDpdF4a8t/nbYwoF7jxXDGDDbcnpkCOfPbYAMRVxFAeQk/Qwai9JuycqlyUgtEil4DKJJ2NuM1bkahlCoVTwJb6iCwKH5T3kdyTzCGmNOvCY1rhaus31qEtcoJ6J+35DNGSHEZXLPMRUgzRzYHlPsbWPbvvTHESiWe9vBUF7I6C5+nZogk4FoT8ImjGTW4Tc23mwyP3vU1rBhiQ88soJdVr4i8LSgyWwkRp6x6uVQRoxwJxB4oghGLl4bFOz29SGaJ3L+pf4MAj/HxKi6QNPpgtLZrr2+N9BnDuuNEnWrpcgY1Pg8YAN1QbKKgHqNyy3TpXow6K4ukz+QQ/kHT3C1ID58tSSfqgCN7s3BCn/7cOeqkVwZ4In4z84LJA3/FVMjmDcGEFeg6iyDZEDS1DbQXJJ+YXjtyPu0/gxy8NCOK6AruVWmJ1WGa6XR4jdZ91bseQQiha2B1KtP5zupSEeWLrgwKvkCD+fzYPFFztGJG7nYOzWpv2G5I0XLH9s78nB/PULq6Yg0SQwblTgDG8xNCcvm03fOvShemuEWvMjra/NQ6ArRdUtKUjfItiI X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|5072599009|6090799003|15080799012|40105399003|3412199025|440099028|10035399007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OWxwWFBzVmNKZlk4OVhDWUJ5b1pJNnJtU0E3SEVpRCtQelhrU1JkbG1Xa29v?= =?utf-8?B?TnVmR1RESjJmZGJlcEU2eFhwL3pGUG9heUhVemtoOU1RN294Nk5CT1Q0cnNS?= =?utf-8?B?NHdzRTdNUysyd0pIR0I2eHZ4Z1VwWlhKbEUva09mL3BncmtRNllpZ0VpcU1F?= =?utf-8?B?YkI0empBMitoTFRzSkFNc0NvMnpEcHQwallZRWVUVXRidEdWa2NIYjBadHJQ?= =?utf-8?B?SkgyZ1MwVjZjN0c3alVNZ0JkOWt2Y2dPTnVwVWZsNDBUZVd1WkFabGtIMW91?= =?utf-8?B?Z3NwQW5PeVBLS3krMCt3N09SWTA4RVRYWWd2RkZwL21mMUdWWWk5MHVneVVn?= =?utf-8?B?UC9KRW52cnlGb3FUSjhuWHRpQ3l4enl2cWY4QWQrRDFlZmNEUHdsT1dWb2lO?= =?utf-8?B?U2hhS3dWMkJKNjRqMTg0emh5a21SMjROTUxWTVlKczVWNzFGTEt3ZVlZQXlo?= =?utf-8?B?VTRJdEZWNVRwYmJ5bU1jVDlJVkU2eG9lRkhsNmpJeWJCOW5vL0RyeithM2Fk?= =?utf-8?B?MElaZjRjalB4TnhRNU52dUZIRFdxcUlmbVRvKzJSV2ZPbEJTL0Q4cytyV2Uv?= =?utf-8?B?Y0hzcUhyS2JWV21DUW9FNi83dTZvZkVNbGtPTmNPWWI2RFI4VkNRc1pMRFZx?= =?utf-8?B?T2cwNnpZT29TOFV6cTA5TTFmdzN0QTU5eVBxbTFVU1FhWjY3OFNKMXNvZVpU?= =?utf-8?B?ZUhCTmtQS1FLQVFEaGExT2FaaUNIdkVhM2tjTXBrUyt6M1hPVXZUM1ViUjM4?= =?utf-8?B?V2JlL1RTYitSYVc3VERQbk54SmZiZUJtT0RCU1RNazg3RC9xK3NkSlMrejVC?= =?utf-8?B?SDA2VWxUNnAvcWxFSFgrYXgrNXNpK0pmaFdsMjZlMDVKSHh4aHAxeTlDTGxY?= =?utf-8?B?RW8wdjUxd3pqdis5RUQ2OW93U2pGRjhVYVdjdHBtZVFyV0ZuekFpS0tsVm9S?= =?utf-8?B?S3hwR1lwSmNwa1BKZUhqZ3U1aWE0V3VFcUErcmh3VENmdzQ4TUdSQlVRZzZI?= =?utf-8?B?SlRkREp1Y3VoQ21Ud29PWXloWlVxR3FQS2IyVWVXZGhUN1g3SEVaWmlnTVZ4?= =?utf-8?B?MmZncW5iVzlwc1NMNkIzOFNCY0Q4QUVRK3FwZ2M0SDE1RHB1QWsyTVBCMTdQ?= =?utf-8?B?eHFROUFVcCtSRzh5elBDVFFSQmNSL2UwdTJBdmNkMDUxYWdnWEliQmltSDQ2?= =?utf-8?B?RjBHeVJaNzl5dUNTTTdVL1B5Z1NPU3JmT2s2dVZ6ZStpR3hnQXdFb3JWcjdY?= =?utf-8?B?ZFlOcUhCLzQrMDh3ejhVMFAwMFZuVE9QZXdwNkxYd2FXaFB2b2lSa3kvRkli?= =?utf-8?B?T0tudW1HUVZWbEhNdWJzU3pibjJvcEswcTBaZ25CdDhXOWJhbVkyaHJWQzU1?= =?utf-8?B?TzA1SktrcGZZNGZLQzlRNDNrRk04S1NQTERQR3JTY1lxeVZiZGN2UGNvR1RC?= =?utf-8?B?WFpETmcweE9Ja2E5UDlTcGczb2tzNzBRWDZFaVNSZjN5ekYydjgrS0dCUDlJ?= =?utf-8?Q?Tpr1yk=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODhNZDN0OHFkV05WMTBzSmVxRjlXMEY2aGZEQWdBT25SNnQzZkZKWDVNQklD?= =?utf-8?B?Z0VQNjJ2MlpPdVZlQTJaeHBoMnhPOEREMUxVTHpYMmRVVXM3eS9RUUkzcHE5?= =?utf-8?B?M1RhWVJWd1pTTkFyVmxUSU9LWk5ZL2EvYTVKUGVSOTNnL3lxbFREc3B3MnBx?= =?utf-8?B?Mms5aEEzZUVveEZTTjhMNG9SdjhOTVhGMHVDLzE0QWtSZ0c1TDBlWlptZ0RE?= =?utf-8?B?b01mT1EzQmxXTVRqTkxmYU91dGlVOFhJVWxpMlZXVHlNTGhZVlkxVG1hSVAy?= =?utf-8?B?U1JmR25DNUZRbVlUSlNGRko2Qkh6b2dnbWc3aDFXQ1lNMEZ6VHdiUHhzVDJ0?= =?utf-8?B?UDhNTThNektEN1dxc25KSWF0anpoYTZqaHpSSjdZWkNQSnBuY1pyQTVIekZC?= =?utf-8?B?dk14VndoY0FJZHpHZlFLRHYxTXFmVWpWSkVOQlBxem1TRVJqRGIxMVJVSDVt?= =?utf-8?B?dVRNUkNTZ2JpQ215U3VzRXNpOEk3OHhtU2kzMG53UG81MWhPdHFrQ0VXcnJi?= =?utf-8?B?b2g5cEhLeWZGTXdudzZ6TGhhUlZuN2pyaFk5emVWeDQxbEY2NnV1blBBTVBZ?= =?utf-8?B?cCtTZnFRWE01KzRrQmZaYk4xQSt0V0I4UExZd0M3VTFaSkw1S2pKTFo2ZkIw?= =?utf-8?B?YW1aYkk3NGhKUkhDK1Axb25OZ2taWGlINEVteExtVzNHRFN2eHcxNmk5dHdX?= =?utf-8?B?SDlvUjBaVitxRFBpYnBvRUdtSWp1UEo0ZGpINno2VCsrcy9DMWx6ak9sUHZR?= =?utf-8?B?aVBaNGM0dTdBVHJMSFFCM1JsVGsxYmx2NmY2Z3YwN2kzVmlubGhsM09rclo4?= =?utf-8?B?cmdvSksyUnc0OTdiS3lYUEVhOFVpVmpvL3NlYStpUk5DczBUK1RJdXBMUXFY?= =?utf-8?B?NkFzVGJsanpueW5udXo2L2V3bGtQQ2JkdzI1UVFOeWFUV3dYM0prOW1uaWZG?= =?utf-8?B?SVZJRW9xUDBKby9jYWJZWG5zelpDMWxnN1dabDRadUF5d01vcVZ3WmdvbmI2?= =?utf-8?B?aWo4ZThvRnJ3Z1hac1BCRU4xdmFXd2pPRm1yZ3hTYVFSeFdUQXVGVDRlQnJ0?= =?utf-8?B?MkE5Y3AyMDJiVUdCQXk3dHc1QkpMYW4yVHpHeDc3cGRqY1VWMEFkeDJ5UHhy?= =?utf-8?B?SEN4aUJTNVY5VVVhc1VKcmhFS1RXODRJZkJTRXAvSGdVenVwMDEwclBYWFM3?= =?utf-8?B?YUFsbkdyNk93ei90dE5mKy9SV1dIaTVOVDVWWGcrem1pMDNvQXdtV0tzVFRm?= =?utf-8?B?YTByWC96VEhEZkhDTlRrSlFDM2dzL3JsLzhTSWRRWUNiUnJ1K0JPcHdNMEZ2?= =?utf-8?B?YUtzdmVkbFJVMjU4OVRHSVd6ZHFTTUEvbENJcHl0ZVZNQklqNDYxbnltQVoz?= =?utf-8?B?OEFYMVpuUlVKVkpSWjVqSDVlWE9GOS94aFF0ellhUkpzWC93L2piVTF6anlE?= =?utf-8?B?OUpOQklxbXUxT2g2QjVlQUdJZzN0NzRjRHRZMEhERDY5dG1GdW95VUJkd2w1?= =?utf-8?B?K25vWVNkRlpsaS9nNkJvWHdTaVVkM0V6VGVoUW0wQk5EdzlaSjVvVnBjS0Yx?= =?utf-8?B?RCt6NVNEa0tOQmZZUmEyODdvQ1NzTHd4NkwrckVQeG5hajVPZGtoRFc5MHZH?= =?utf-8?B?ZmpuWWxRWWZ5eU1UTUxjM1E4TXUxQXMyM09tdVovZ3o1blB0T2M4N1VpN3U5?= =?utf-8?B?WWl1eGR4dGtFNEpTTGsvcFoxczJFVU91cXc1b0Q3UEVUOFFGT1kzdFliRm9o?= =?utf-8?B?MG5nRDJWVkYvWFl2WHArcW5mWUYzd1hLMG1icDdOOHhiM0FWZzV1S3B6b25y?= =?utf-8?B?OGI1eU55Vjh1UXZGcjdWdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab4c00bf-3387-4011-159c-08ddc233e3da X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2025 17:37:08.1161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0011 Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/osq: Fix 32bit sample overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: signed integer overflow: 2147483565 + 128 cannot be represented in type 'int' > Fixes: 428055715/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6358069900804096 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/osq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/osq.c b/libavcodec/osq.c > index 76090aa8d07..1d99ab32451 100644 > --- a/libavcodec/osq.c > +++ b/libavcodec/osq.c > @@ -390,7 +390,7 @@ static int osq_decode_block(AVCodecContext *avctx, AVFrame *frame) > int32_t *src = s->decode_buffer[ch] + OFFSET; > > for (int n = 0; n < nb_samples; n++) > - dst[n] = av_clip_uint8(src[n] + 0x80); > + dst[n] = av_clip_uint8(src[n] + 0x80ll); > } > break; > case AV_SAMPLE_FMT_S16P: Why do you use a 64bit intermediate instead of simply using unsigned like we do everywhere else? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".