From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C09C44DBA for ; Mon, 26 Dec 2022 14:48:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5A57368BA07; Mon, 26 Dec 2022 16:48:24 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2010.outbound.protection.outlook.com [40.92.73.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 99655680677 for ; Mon, 26 Dec 2022 16:48:17 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T4QQXZFQSR32CJVqw1wIzleWHcfGcF/3IS3Iqh5OD7ruZgd6y7D3MHt1+vzlNuCyDfJH1mZfeOUGeXkdUM0MqzcCMQHa+ADv0bdyR+A4h6zFqrabICd8aL87EQs9P2x0LfexcP0ZeG/ywWIlN23WbQuaGM6r0t2B8Ozt/WKJXa0VMEq7qwZ7Lze64BJ1M6GgQUVlbkcpqqP9Ory/1UEim5rKHzrPImw3BqinDMS4kZI2d+e5sWcjX+NAmtAbssGH187WOne3WdH8nnrH5ydcR+ugh9bC1h/ZyseSSbJKGix8zeE8OYe/k+CY2HShbNZCqbtpdNN4h6d9UYtyvF9ZaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NmesJQxn0gku5pAlF5UXPqOSUH1GtPJTq7uMniywy6s=; b=IsVwGv42I81OOzIWBmW2QW/kRNx3l5/vVqYcgQ5NP2yuMbhtU+2qpcKb1kXDzkjtoAQtWTqayv9uf/AvGYc7WB+kkDs+XNDElbllUkW6mqVVMEm2Bfsq7Nkft7Xgy5r8YM2PMM/WOWuBVJ1vnRrmz+wsRsoaHMo9yeHD7gbadaOHWGTyterPeVr0mVEuyeqHYpukRH1Reg/2zqoHg4wfSCW/djL6iczH3ZfyFjT1HY/Yqgfui7sNb2JcC8h2+EtZ/IYw9+FC2SbtwsUyK/zjINWV0z0MPq3yagDQQyYOKdi8pxR00bkwAsmnzPMYnDyCAlDiBemJGYiTERCSr7pxmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NmesJQxn0gku5pAlF5UXPqOSUH1GtPJTq7uMniywy6s=; b=HGRvMDZKXGi4HqkgyqxddayIjcHWBNxkC0PAqGFzXAugLqJRxRdnS2m5elW9hJqFyWdhvvQl7XGQJfPLiW3ldMFiJaz+IO+bcWW4CoJppfaGjTLP0BuiCD47dr9VYm0+y3gfeN2VNxKX5NoCijRJlkoc9sdqFdt4n62fvbt44gFQaEBB8RO8LASVZUF1idJ8+51cny4rxTlCenGbOFR2GqX8kJfaKzwLZO0e+9UC+IO9T/Mq7pfENIR3CjuTAVXmK75/1SiX/YLNOZOUwJJTAePX+Jv4PUYZJVOM4SQCYaOWOMaTXNPtTgOIF2MGyCsRQQXNV2aG+X3ypDgkqtuSSQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0909.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:54b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.12; Mon, 26 Dec 2022 14:48:15 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::da14:61e3:630a:70b5]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::da14:61e3:630a:70b5%9]) with mapi id 15.20.5944.013; Mon, 26 Dec 2022 14:48:15 +0000 Message-ID: Date: Mon, 26 Dec 2022 15:48:41 +0100 To: ffmpeg-devel@ffmpeg.org References: <20221225182812.18238-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20221225182812.18238-1-michael@niedermayer.cc> X-TMN: [yDa3jQ1D8CdJUwOI89W/taPo1F2SEJPH] X-ClientProxiedBy: ZR0P278CA0052.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::21) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0909:EE_ X-MS-Office365-Filtering-Correlation-Id: b477ecbf-91f1-4b7a-2096-08dae750384d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 24MBNuCwUIrE4PyxeJRhE/1Lya78iMw0VFF+zCBNyLYpsKiKf3HU1gIfIDyr6Kt9Y3jAlaKLI80pAJdqiRBkas0e4Tqvpd7S3zPMrnPnNObJODyq5W54Ik0Ti6tNePRr02g7DWEdEOXtoQevwf9YpnEg6HRGzJQo+1wAYmPTScKdO0vYmoxJnLJ7gfzE1MAijaZaj/9jDW5/0a3a3/LXnxD5htB1MYIBmyvTp24JmGHWsm9y9NiqTfNGry7QG556lKMN30LpdzZ4lS/TDuQUeQk9ug/1o60OlGf7CAcqq8LSocgAagbsAjcGDiz9zFsKGGj+7zzJvdd8TRmmCJAQh71PP/f6pTVBCusPygxfXM9G/YL2CXSwMzd1G2Yx3y9yn4szXcmioklCNFf/+7YuhpSbPfBVjAaaiJy+xzjMkdJ5qm5XmMZFYCSrC/LFWtQ9TjM08x9usAu9sLwDGpe31YZJA5hbO69RTlMrkBZBDLz3bt7mGurRaAgiA1fbWTUkzVaATOpO7QFIEjEO6/kIK5Cl/zXnv/9ImbBpiP1DY5wnOylOMN6LRPb6K/JlcUrO07a27AqHpt8DpTdcjl5OtaEaWzq954LI9ctAZ5JkYP71U5X5QjiBvokXphvYQz8Sz2QP9rWvBaLVS+M8oJxpqw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2Q1eDJaV2FOV3lycmJxQlhsMmF5YWd5d2NobHpsL1BISXZJODY4Myt5THBj?= =?utf-8?B?STdYcm9HY2xEa0srb0dGRkVtM2FFUDJXTVovTytZQVRtNVJIbTJmUkRkNUUy?= =?utf-8?B?WGVxemxVT3ZJbmVPU1hScFZURWdrSHY2d0ZUS1Z4NnJNaTVyd3NtVDJNQllG?= =?utf-8?B?SUFqSjhvU3NBcUxYUExSNmNsYlpQcVlxZTV1R0RINmNzZnBBQUFvZXp6YW43?= =?utf-8?B?MnEwbFI5MHFLenZkUmVUMnViL3UwaGFRalQ3akd0YWJlS3ZtWUVLbUl3REho?= =?utf-8?B?RDN4a0NDa3E1RXBZWjBIMFFrVDg2Qm9JUzZjUGdmQWFVeGM2ejdQN0gwSjA5?= =?utf-8?B?RGVicFBPNUl1NFlVS2ZqNzR5dXRQeFhkWHl4ZmM3UHR5QlhtbE5lekZDOUhG?= =?utf-8?B?RnhWMDdIU3hFMGp4Nis0a3J3dkd0TThrL1N4N2t5dXZKNFB4TVJMalJGOHdC?= =?utf-8?B?amRRd0c3cWVMdGNWSkNtUG1PYWVaL1BOdHRmWHhrSnBpaUNBeG42WW5hTW1x?= =?utf-8?B?dTZqZkMrV1hwQmY4c0pWcFJCTkRvcWxOQUlHUzJlU2VRKytvQW9zS3FaN0RE?= =?utf-8?B?T3EwRVdvVVJtM3YzSEwyUkh1cnp6cUpMM3pXVkVmcWczalpDMjI3KzFvY01y?= =?utf-8?B?TFRpeXFBbTZCMUNZenMyOHlDeUtMc1hFUmZxZStTL3BSbEZTQ3lPUE9WbURy?= =?utf-8?B?MmIxWmFsOG8xTXpFb3JteG5iRFdrNS9MOHp4MHhFa2hUWDArM2NzQ3JLV1Iz?= =?utf-8?B?dUozM2t0TkN6TnJVaEowTjJKNS83U1JhOGE5cWJUOGhIZjVuT2YrMjhWNDFZ?= =?utf-8?B?b2V5Z1ZRcHBRb0o1V09PSnpQQ1ZPeGdIRXRDdksyc0k4VWlhMkt4bkhUZFB0?= =?utf-8?B?MlYzOVJoSUR2ZElBTENDZUs5d1FiVVBhNmZQVzNicWVzQ0hNclpwZ29teXJP?= =?utf-8?B?Zy9FZmZJUHVDVm8waDdIK2RtNHpLVzhKOEcwRmx2TlluQTZ5UnZKNmFOOEFN?= =?utf-8?B?MThZZ2QzTnE1ZllBZWxOZmlkUngwRFBzaUd5emFpbFNCekxSWWloMU5Xamcr?= =?utf-8?B?clp3V1NJVmhVRGtWVlo4a1QxTGFwd2tQTi9xeVJZNVdab0FnS2UzNnpscHZz?= =?utf-8?B?T21WVWZLdWFGaUV1VVg1Q0N6Szh2K0xWeWduT3FNVU1STk1NTEN4N3NER2ZN?= =?utf-8?B?eU5ldnh5cjBMSldmN01XZ011dVRXNjdJeTNCQTFncXgyNE9EYXVvTVZCRDFJ?= =?utf-8?B?VGwxSmhlR0F6NXkxQ094WGZhTU55SWdlZjJwT09JeldZSTBVckR3K1h6ZHI5?= =?utf-8?B?VU9jWFlnUi9aL0JMMVlJV0xUR2RDSzZ4cnVXZ05HcGE5Z3V6R2VuNkdFTXV2?= =?utf-8?B?N0s5WUFTaStPQm5VOC9RZmVYN1F5WnQ4cVdDM3BPYmIzTmtqVVUvN2ZoUDJh?= =?utf-8?B?V2IxYkUrSEFVQjRsL2Jvd09QR0o1cGc1bjU0VkJ3cVZMOHFBc1RIckZwZWxO?= =?utf-8?B?NW84dE1JRWp6SVdkZFVVZk11bGtOL1dBN0JQN3o4SkxDWm5kQ21OV3NRRy8z?= =?utf-8?B?ZEZNNENra3R2MjBXYjErQmJhU2hnTDhFei9rckI3czZJY2tXeklZbkFxSEs5?= =?utf-8?B?RHRmeEcyeTVKS3JJYzVpempMZ3RqZjdqM1dVOHBtaFM2WFhPeFc1SVJTN0xw?= =?utf-8?B?WitBQzdDUG1HMlFSSGpTSUM3cjVYc3EvNEZsLzduNURYZHRyMjg1Mmhoakdz?= =?utf-8?Q?Kx0IVCLsOA3923z9Z0=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b477ecbf-91f1-4b7a-2096-08dae750384d X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2022 14:48:15.6980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0909 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dts2pts_bsf: Avoid poc overflows in cmp_find() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: signed integer overflow: -2147483648 - 5 cannot be represented in type 'int' > Fixes: 54242/clusterfuzz-testcase-minimized-ffmpeg_BSF_DTS2PTS_fuzzer-472928339243827 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/dts2pts_bsf.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dts2pts_bsf.c b/libavcodec/dts2pts_bsf.c > index 48612e59db..60bec91f99 100644 > --- a/libavcodec/dts2pts_bsf.c > +++ b/libavcodec/dts2pts_bsf.c > @@ -90,9 +90,11 @@ static int cmp_insert(const void *key, const void *node) > > static int cmp_find(const void *key, const void *node) > { > - int ret = ((const DTS2PTSFrame *)key)->poc - ((const DTS2PTSNode *) node)->poc; > + const DTS2PTSFrame * key1 = key; > + const DTS2PTSNode *node1 = node; > + int ret = (key1->poc > node1->poc) - (key1->poc < node1->poc) ; Don't we have FFDIFFSIGN (or so) for this? > if (!ret) > - ret = ((const DTS2PTSFrame *)key)->gop - ((const DTS2PTSNode *) node)->gop; > + ret = key1->gop - node1->gop; > return ret; > } > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".