From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 34D9D4E220 for ; Sat, 7 Jun 2025 20:04:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 83A7268B5B9; Sat, 7 Jun 2025 23:04:42 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2081.outbound.protection.outlook.com [40.92.48.81]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9752D68B508 for ; Sat, 7 Jun 2025 23:04:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S+ol2tyJfnwxDbN+XIMJ47F4YdRKhATStZFmONMe9B/0efdaTDKUx7WyKGK1+mloY3bKT9baPdIDk6B+2VWfwScTXg33WXxSNz0Y/Re55VlrqsLLpQryJt9sfWzOtVjYW7tcdlolRr8xpkONZlvsBkHA3nuI/AHLK3nBr5Of5GlbN3m2AODTXaBfTWO13woqlcbumgLAu+nD2WqBZjOWYhE8TxBLFWr/shExT4wF/Cj8qHBf6hoGhEG+n2RZBkN1NzgYxmlayYDNv6ToIo7ew970s3OAGGfORwPdwyCFgMOaWI8hO02zKPWZ7YL8zfxet57kTu+dVYLOY3535sy7Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ka+sFa5rr83pYfg+/+Hm/+7hse2j40Rr1m4aLlcvc4=; b=YLuNq1eo3hK879Hnz4R9+7vrogHquTJbec3zGDr0ZTPWIZF9/1vHEeXRdpJxJPJrNIEnbrLyuQ/GBlfDMziNZ9VVnVGmBjlSk87+/taobdbJx2wx8dFV2udHthGzE8nTwdmIqnSlLboFBAJX2BocumRZbTLGuCS4SHi7T7jxWeOR1yxm06kHlYwPgdyaCNNVRQahFtCYB0Qc26lJqar4y1NYqWvVMaX0OJI/aegLzloXkQpl6sl1QXUHXfetKOEYp8FbI7QS9NUUhjZhBtR1O3KZdFEAcXhmYje+W7TFlDpyZM/YR6UD41K4YXnZVZCCKFIU+wMD1SgVk34MQiks7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ka+sFa5rr83pYfg+/+Hm/+7hse2j40Rr1m4aLlcvc4=; b=CRu7Qj9zblKxBe9uYehJij/A7hUNbPDLURdpgTBkkshmovFlaQfBrj6OWOnP5S+zXHKd1NT0cxBPAhkBJFM8rk0Z0d2milbLA8uRa83jBBQJjX2HfCJ6vQavZPdEMue/tYBg/3nhJ9oF8f5zii4Cdeem4k8rBfsLd/YMv7WG+VeOc8cRaYS+M0SVZnwVutF5eCNWphAWhdKgs3hrtysCME2HNjS/nvJ/OkiJfXjkbfdsOizfHlourDV8vAQshsJSSlif3K5K2Oc355sWT/23s15cIb5GZO/xfzk7HFJ+JazbdO4YWT3hUJ3I+OmxjeGgeFuRdjSrNMaWOw0Rjy1sZw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0365.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.34; Sat, 7 Jun 2025 20:04:35 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8792.034; Sat, 7 Jun 2025 20:04:35 +0000 Message-ID: Date: Sat, 7 Jun 2025 22:04:33 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: ZR0P278CA0151.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::12) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <1b73bdca-bd63-4d65-905f-db6a01553516@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0365:EE_ X-MS-Office365-Filtering-Correlation-Id: f22862b8-528b-43d9-2ca4-08dda5fe863b X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmpKEBsvou3idazKhbklnsCkBK1Y3J3nTJMBOBABwigwSJXUG0y1rLUI71q+Nta7+8ZS+qfi9fabqpZ+HTwub1OlQtGrngLf4renjxLY4AJ5dpO+e66WUtWaS8vUtl5/6EQ7XBZwiskGoQ1IvPKnRJRpc4b1LfWJL8EvDu2wNO5aB31ASKnMbBznlUK9X123Ro114KEoTYB9lOxRUl96P88VFBYZt1vnFkDW4iKXeJMz5Ku0rBdAcY1PnKlwmIAvPNXJhMEKSkEjY7edpKi9SbB4at56qOD7Au+TAJ7J7tZRA+pkTSJNw5erS9GjffZdtjPBuN142m7c091IrmC29OExyYjy3fYbIUJJjDzPgcmAnqD2VsFrBoL2tctiBssA2zdSe5C1pRzna64WW+TF7aH2TweO7z1T9NCGd6Uv1EilnKuBPx5R0X+PJ2CiRHd9WnuA1Ow8c/I7uY1UMiFPwig5bbTdUYPLCA3jwaJLr2xT2yhvM0OIosPhSXOYggmedktHgYoiHzlxXjIt+mIXnsdmp+u3WCBc80qTD0lHDu1RMYbeYdbHI/8orhUvcbbBhku3hB6he8roPF1T0Gg8T0tb5Ps+eO8xpetCNUkfXxEu4YgeYMZuB/mAHtLajGsCCRqbbjTmCAJx8Nwr7VfRCVSgepyoKHpE7wtSQ3nqMF40jQjtbOFFSVhv50gHZJ55qCvstLG06bZN6el4IyU7U0Z/h1869rfoccWkWwEOm5yn4yEt+mWX2Zx5noY7013OksE= X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|5072599009|6090799003|19110799006|7092599006|41001999006|15080799009|8060799009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V2xYZDJkV05XU3BWdWpxTHc0RDFzOE9jbTRpenFLb3BJcFYwYVMvbzFHR0xQ?= =?utf-8?B?RzArN0hnTzFYZlFTaWRMYWJrc2F4TG92a0w0M0RoSkNTeXRiTGMzbEQ4bjdx?= =?utf-8?B?a2ticGRuWW5xeWtuVmIwRXpEQ3hJbkVCQXcwbXd1UGRFR25QYzUyMDNHSWRW?= =?utf-8?B?a2g4YWYwSExBMGo2QXNVZWdGdTdJZW1SNFZMZ2xEblgxZkZNSVJJa2hoVHNm?= =?utf-8?B?cmlLMjZWTDdNbEJ0TFhEZTJiOWJUZEhJS0xUR1FDM3cvS1dIYUMrWXhnMmdw?= =?utf-8?B?dHVkZytlR3B4U3cxcDhRc3dIdlh5cEx1RWVzdHVvTVpHSkU5VUxEWE9TV1ZJ?= =?utf-8?B?bWZ6UE1LeHh2RkZXenRaRDFrdEpKSHpsalhIdVlRc1g5NVhvOGp1MnFXY2dh?= =?utf-8?B?aTdvTyt6R0tLN3QwOGV1MzFtTk13dnc0bDZ6MDNNTTlGdEFEWEx1VUdWb3Aw?= =?utf-8?B?YzUwZmtqTW9IVjJtYnpyWEk0UVhNOHFLa29nNmFPRWxvUk1zYkZiSE5BdHlH?= =?utf-8?B?OHNxVDFKcm00ZXhMUldPVFZ3cnhISjVoZFkxci82OEY3U1JzbTB1RGRicGV0?= =?utf-8?B?Q1dhQk5oUWdQU1pnd2dERm5vM3JsQnEzbFFEeVcyY0pPc0djY3ZZRklqK1or?= =?utf-8?B?aVBYbG4zdE9vZHN3RkJ1d05DcUdqaHNESWVJZERSOFJFVGRuNWVQSCtibnBR?= =?utf-8?B?NE9XWkF0UEI4bWFQbWR6MkhGSTJ0ams0QzFza0U1bVlSL0kxWnRFOURpUDN1?= =?utf-8?B?UDJEN3E0RjRmM1Y2OU0rV1ZPTStTWHAremE0UThERzJSSUNQZDZ4ZERCdEUr?= =?utf-8?B?NnhpZUF5NXpwb01vMUs5QXIrRzZQK1JXMkJ0VGh4R1QrTEFPRjBiVTNsUThu?= =?utf-8?B?MDBma2JsZHRGZFUzbWpVWnQ2T2k2aDl6M01TN2tVN0RuNFV6cGlEd2h1eWdP?= =?utf-8?B?dTA4QmduRHQyN3JXZ0h6UTNzZTJZTlJ6SVBhYW9sVVl6T1Z2YmhTT3dtTVgr?= =?utf-8?B?b2xLVGN3cm8rTDZxK0FsTUVOY0lKL2ZmTkhWc2VIb3l4dnMzQWlSVGkvTDNZ?= =?utf-8?B?clJPcFZ4YXFoZnBLQ1p3TlYxcWx3RGJJOCs2eVBtOTk1WjBCemxnZm1oL3Nv?= =?utf-8?B?eEpaMHpMMFpZeXo0N2xoUExzRUFkNDE1N3ZNeUhTc2Vtb1dNQ09CSm1QTkNU?= =?utf-8?B?QkVraUEyL3NFSVg1K1ZxR3ZZWTArRTNOMCtjZ2RsdUd6UVdDTHhqdG5TT1BR?= =?utf-8?B?dDdiSXh5cmNaQ0ZlbnpQUUxWVU5qY0plRXk1S01zWEtHUnhZTmdFSk5ocllM?= =?utf-8?B?TzhWdCtYY0FQcjB3S2tUSlZxSXoxUjVTWWRDWXdueUJSUFM4VEhlQXJZd0VJ?= =?utf-8?B?RU1oLzFJbzllMWlCZTFiWGJibTNmK0doSWgvZnNTM1pySU9wVENnTGZqQUtS?= =?utf-8?B?TWNZTTBWKzJORktqWThBVWVSVVNyTThNTkp2UmRNRDVxQW1qQXZyM1pFWm9a?= =?utf-8?B?SHNxYXVPUU8rVGpkOEh6T01hdUVZa0FFeElVTmIyMi9XYllZS2J5bFUxRnpX?= =?utf-8?Q?tlpHHoOpZ6rs0q7xjnDoCIu2w=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGVoM0YwTnF5VHVkYzJRMW1rNVJma1RGTlhVZ0N5d2JSdEpIaXFoUlYrc0Va?= =?utf-8?B?SjhHR3dtSGhzMDBLcEdQQ2JBVUlxa2dla3BhcXJ6am1tbjJjcDB6cVJNM0x4?= =?utf-8?B?ODVPMlpaZGtiTHg4TDhGd2V6SW1kWFNZOVkyM1RWbHJFQkZHbzNQd0ZDWjh6?= =?utf-8?B?ak5MRnk3Z0xiMHBLWmtZbE53YmNQTTZRUHRtZm4zZmJtQzAzdHdLc0ZkZHpJ?= =?utf-8?B?SW1GY1A1K3NXcm51dnZsamtvOWd1L25MckpDNHBzV1VPMHJRVWFSNjRLQ3hw?= =?utf-8?B?L2ZvY0IzUTVtYnh2amp3aVMzRzBYZ1hjYmtLa2JPeWNwbE14VHRVTnhHNXQ3?= =?utf-8?B?VGJBQm1uaVo4dUpsbmw5UUk2emRGYzVoLzZ2ZFEva3dvQ3FNdEhCdEFzWm9q?= =?utf-8?B?S3ZjclhVanEyZ3VUQ2E2cWphcVhWT3oyR1phTU0wSmRsZWN3NW9qOEs4cjY0?= =?utf-8?B?NFY2ZC83RXJQd243SGhsWnVIRzkxQkhOZk9heTROR3YrK1VHdnp6cXZydzMy?= =?utf-8?B?d1FPZitvVWRSTXlOWTAwTllCanM1WG5OK1hGanZFZG5wcjJ5N0hZMlBtWEdx?= =?utf-8?B?VkZsamo2Q05OU3dEYzlDWVVjS3JaQi9kbzA0NHZSemdSTkNZWlhULytzb3NX?= =?utf-8?B?aHZJT3cvWTUxNTNXRWtqSDdFY2RMS2xpQzlJQ2lDSEF2VFhvWlVKMHZGU2xs?= =?utf-8?B?N3BPR1hDT2ZhTTJiSXdudmRnN3kxakpMQXFIdmJMWlo5R0FIK1lXd0xvVW1D?= =?utf-8?B?SEdHTWw1U1Jic0QwN1MwV1pUaHExNjFVUms1SHBoVVpqc0NHci94V1RMOGk3?= =?utf-8?B?bE4vT0puYnczcC82L0p3bmJXc0dFMllJQ21ma0RjK2J2NkdWYnV6OTJ1S0wv?= =?utf-8?B?dURVcE1yWXZWd2QzaTMxWVRFNE84MUhPNkwvZmw2ZWdtQ0thb3dyMTdTUExE?= =?utf-8?B?QzJQSExoZXhya1RjdVpsTTg2Zlg5OGRJUWR2dk9BZmFCM0x1NXZ4YTR2c0dM?= =?utf-8?B?VnNITHR3R0Fnb1kyTUcrMGFIWENaYmtLS3hCUDdqUzV3K0FDS1dvMUxjRENP?= =?utf-8?B?VURxbEFPSE1rRmYwSTA2bUx4RnFSVFhTeG5mMHdhZGpkeTZMeCtTSTJkS09a?= =?utf-8?B?c3NjWkF6dGRWY1JQY3hBek4xV2JBbFdqT0Zoa3ZxdUVjZDlLd2Y5YUNLVkRT?= =?utf-8?B?MFRoZlJKcHNoZnRuSWYrQ3NhTnBlMmRhWEpXZWdNZ3lSVUhDbzJlNEVNZGdO?= =?utf-8?B?cmRlY0JlVVBZcVFHMDVqYVp5SjU4L2lnc3dyUFliNzhUQVM4TDE3UStQQjlB?= =?utf-8?B?R0ZtRkk4aERUdXlQRFkwdys5eEdZbVdKeWNzc0ZUSlJydjE1K2EwYUlpWUZK?= =?utf-8?B?Z3g4UDJCWmtPV1NUbmtpRVhiRXNFV2x2ZGF2aGlvcDRlQlk4OW1HRkV0NDlO?= =?utf-8?B?aTJUOE55QVhLZzFuV3UwTUx3QkMzUnJhUWVFbFFXK1JKTW1XVk42dG1ucFpT?= =?utf-8?B?cy8rWHBCckNEWnNaTXlDa1dRWm5wVmR4b2ljRVJWVDQvNW91dFVyWVNoMHdX?= =?utf-8?B?bFgxL2Y1c1ZQK3B2d0g1V21NTVVWMGZCWlV2VENWUytHOEIwTkN1aWF1WWR6?= =?utf-8?B?NDJQbFVPdU1BaW1KbFM3WXBRamt1MDFzQjdaZzU1bWdyRjA3QTY3anIvQTVN?= =?utf-8?B?cnNZUlV4ekJZeVhjM1VNVkpiZVhwRjlqM2tMM0FWcnZoNDQ2aFRKZ0thREhk?= =?utf-8?B?eXhKdk0xUndqMzNNc2IzY29OeEthNmlZdWZ2OUhMd0cwQi9zbG5YbjduNncz?= =?utf-8?B?bUFUbWJmbGhtOU5TemhRdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f22862b8-528b-43d9-2ca4-08dda5fe863b X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2025 20:04:35.1758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0365 Subject: Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jack Lau via ffmpeg-devel: > In higher versions (like openssl 1.1.1 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a const string doesn't cause an warnings. > However, in lower versions of OpenSSL, > the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), > which leads to warnings. > > OpenSSL guarantees that it will not modify the string, > so it's safe to cast the pem_str to (void *) to avoid this warning. > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index 86e8935fee..5387e21df1 100644 > --- a/libavformat/tls_openssl.c > +++ b/libavformat/tls_openssl.c > @@ -415,7 +415,7 @@ error: > */ > static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) > { > - BIO *mem = BIO_new_mem_buf(pem_str, -1); > + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); > if (!mem) { > av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); > return NULL; > @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv) > */ > static X509 *cert_from_pem_string(const char *pem_str) > { > - BIO *mem = BIO_new_mem_buf(pem_str, -1); > + BIO *mem = BIO_new_mem_buf((void *)pem_str, -1); > if (!mem) { > av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n"); > return NULL; Shouldn't this use #if checks to only cast const away when building for old versions so that we do not forget to remove these casts when we drop support for these old versions (and to avoid warnings when using -Wcast-qual)? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".