From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 66F96445CC for ; Sun, 18 Sep 2022 20:58:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 35A6668BBEE; Sun, 18 Sep 2022 23:58:11 +0300 (EEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066038.outbound.protection.outlook.com [40.92.66.38]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ABCA468BA35 for ; Sun, 18 Sep 2022 23:58:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7wnoaomqyy+lk1jREWYKRyXLT28Sydn2yEEi9vzE9JsbxlVHBGsvPADZ9zQAZQlI7x98Rk6TSFPZLEvRK6ox29zVutkmkY5lnxNe8urCm3CIpPm9hqbaRhAAAF90WdC+ej6x+ufG+uG76POERJjvFu9IgWqjGAhE48HYxPbpuJ4cTXYrb7W8u3YlIyB24lvvZXCOlN+DI3+n6ptZDNLQnSzE5Nr4tSiMjNLoqvrbZ4zORXcQRuBF/Kr3cN8LFr0z9Da9qarj9iia5GQmvN4jCQsTWD0qGbOz65cZWvYaRAm3s/YyMM/ff8PkMAy6a5Pj/Gs2cM+48hYU+PF8Ho9bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BaveWFE7yuQmjds9BzNFjtQz/PTCSlUOL5++Vs6Awg0=; b=mpuCVnPucDslGYBKebgt8ECn2j3pgv49qZyZ4kJGCcDbZMiitfLQZHqy2NFpj05Gfk2d4mQR/f83bfQyv5FzmzWxySMDAjSLlgLPCCNpi3yw1BkSRh14MGOFm2oxB2g1PF/Wp1+36UU8ziTh4FfjUcJZ4uSoH7bYDyQkk24wciFywKv4Igsy/satydiDC0juEfKdvvl+Z0hKRxVnBxtDvsV6+06+jnUgpKqN+q8yWdlnu/YYzuX8Tc507aLhq0ZaU6/EOuQ6JpqvDX0iHPc4P4Wnp0iqI00F/PtVA7UDZEWwI5gubQkRmln61mot3bG3gEIc1IHiBZe4Xarr9Qhe3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BaveWFE7yuQmjds9BzNFjtQz/PTCSlUOL5++Vs6Awg0=; b=MNAAt5kiu2axyRHBNmGXTRX5PFTosyFD2w2wyzM8jlQ/Lc27Vws46BN7+1HgOzyXwbXHnULxQGAdb3hodH3dUoI9hz8SAxzigaAgxgTqa8KzVhJ84D5EU+LVkAcrQpMUrXSp8SVE7taPVrCRnFKyGTC0kFzVvANlkacyvyd7KQFJL7kNaqhnJgFO9rSkLjJBU6jlzcdLZuww5Ovk1kzL53qRATRDWivCuNwKiL+HUK1ZW2Gy+mAuGM4CKhDqQd7oFcmBR2JFvSFOSkOMxlZPEuy8WiZuqvqCJVZBHzVE8phh+3crRCr1UN+En+04rpCwSHXbIUXH9BHPlXxpU5RuqQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0156.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:372::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Sun, 18 Sep 2022 20:58:02 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::f3f2:4362:56:4785]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::f3f2:4362:56:4785%7]) with mapi id 15.20.5632.019; Sun, 18 Sep 2022 20:58:02 +0000 Message-ID: Date: Sun, 18 Sep 2022 22:58:02 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <166331162401.3205.5905647206678559059@lain.khirnov.net> <20220916105754.GT2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220916105754.GT2088045@pb2> X-TMN: [k5nbDOz9s63/Ntwt2IwApGKpx115ufjAi8/bCeBFNQo=] X-ClientProxiedBy: ZR2P278CA0026.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::9) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <2edb4de0-7247-892a-876f-b3250ab4c41c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0156:EE_ X-MS-Office365-Filtering-Correlation-Id: 3996ffdb-a086-450d-03ed-08da99b8798c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BDDkT59QRuGx7mQYyTe1NSuazXst3btr0jHEqVa5h2naLwYOXTNYAxVDLIPHR7yC3H855LJHof2ntMEe/pOulW5NH3bHtvsg4W8KajpcmCvFPyqA7ncRYhgT1mjd8YXbWGt+SzEl2AYqWgcs7mAyUy8Wwnb5paL2bcfpCTGfxxf3hLKjSXwvA0O922ZmiN4esffQm7sfYPk2H/6xvHIK2VAI0NzLlze3xUCbjnuJXYWblETjKhgold+J3C24mp6p/Al+GBeEy0E/Aj9kI46qYSBrzHgL4GwlNf29mtw45BdyeSx7gWdsUCniX0vfYTXRSNyl+vslg6ZVam5J5MxwTquMxSSFs5bgwJ7jnrIo5+czX8V1+OvFzLOUwflmozuMXxLZZiganbdeB7qA+XCVtGa7ocLpLEvU4J1ev4+/iSY8U4FDRiUZeSX/1I4lbbMcx1MewB/3qQ9EYYRwwjNcouwqunVpV8ALZ4UXvauYBhi6lM3WwbKlQLBVRKJmIXf43Jh83id1IkRqHvjuy5DJOMU5eE/iQwSPQJKSUkwrbdSra0dLpRnLY2LjwEQ+BjTtPqWlJdQp5HKOagy+e7UEXKUNDNGPf3ECuEDWJtYfEjqZHui4S7GfYuL2fr2sjRSHtlzQGlJj1kyJ/cIHTD174araRr9otPU3yLQy32zI7Ll1SBngUUp8sIFpcTt44nCu X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWh6eXZqOWROZHRLMm1wZ3VLSnRQaWVLTlVxSU9PQUpnU2R4c2RIVFI2YVNH?= =?utf-8?B?b09pcmsrWE1LQjBJV1NmUnYrSEVVM3hWS1JxQzJSa2VmcC9JelJFWHlMZ2pO?= =?utf-8?B?K3JtRXZ0SzRiVXJpNjNDYTBLK25rNEFkWXBtMHlJMHUzeUQvTHM2ZVJRekRp?= =?utf-8?B?T1NpdFdhTk9tbitHdGVLRkpiSVJQOG1hVURyRXVuUWxkdkN2emRtQ2Irai8x?= =?utf-8?B?U29CNzNFeGZ4WDBhL2ROZnpPOUVsYzM2TFBCRzBHK3IvdkN4LzZ4L3I2Vy9T?= =?utf-8?B?dFE2dUh5VkVBM2IyWDI3ZUJiZFpzTFJHdEp0ZW00UHliSGN0Um52cHU5RnZx?= =?utf-8?B?WGFSLzI1YVdiOTZqa2lLYTM0VjZLaW5GR3RudmJzVHhQYW9PTVk1MEd6TTE2?= =?utf-8?B?Vk9JYjhyMHVzRnJuN1pxQmxNaXllYXZzc3R5bTJISEZ6TmdJSGI5Q05rSkg2?= =?utf-8?B?ZHdNSlFMdTZrU2RUajJpV2tGanR2Z0VBR3BRWHVxdWcySzhITEVQNllmNzJV?= =?utf-8?B?WSsvZS83QnEvZFUxVEhBYmZzQjRFT0VQaW5abFg0WFo0bFhtbHVqNjU4eUpk?= =?utf-8?B?YU9XMjBmcmJFUEdNbm5FY3RsZFJ1bWNJK0NPN2Nud1JrV0NEZXVEbzVqY1ZP?= =?utf-8?B?Vnc2cGtkWUZ1N29GeG54STJRTmNmN0NKbW1wL1J5dE04UHFaUEt1TjRHck15?= =?utf-8?B?clQ3VjV1a3Z2cTYzdXJZRjc4OG1wbE5YdlRnN1MxUUtJT000TEFGWFhRV3Ew?= =?utf-8?B?ekQ5aVdheFZEb1hUVzVDUmVwYmV1NnBWVlEvTXBleHpoTWtkeERsc0VIN3ll?= =?utf-8?B?TzZxMHNBSHQ3bEp0L2hvTGdpVWZmbUI1R09ZTXF0QXNySm1XcWlLVlM3OER3?= =?utf-8?B?TndTM2FlVkxnMjFuNjNNU3RDVDZCUGlrYmFoTTdSMm1mNUYyQW4zUzljcGU2?= =?utf-8?B?bEdjU1hoeHhOaHBwM1Y5eHVzUHVqbm1JZGloa1RhZzNwcGJlMjBkMmVvVXFO?= =?utf-8?B?djN3eTltRTNCNEJncHhYcWdTUFgxRklUejBIVUYxeVZPdmFjMFdValJNOURB?= =?utf-8?B?WktTdHJGSUJMVVRnaWl6RkgrMGJOQnpxeDQvc3pyRWUyZ3BkNTlmVDZQRUhW?= =?utf-8?B?cnpQNUkyYTdTa2QxdGlUOGtvUWxIY2o5ZSthQ2xRSDB0RmI4eWVLeHVzRXZh?= =?utf-8?B?RzkveDlVOXhJUTk4M2lxZFduM1UzN0I1SHhxaWdFV3hGZ0J5WVpxWVFaWURQ?= =?utf-8?B?NjNGb1FlWFJUejZObzBNeUVtYjF5bHdBYmlZL1RnbndRZjVZR1laVkhCUWlv?= =?utf-8?B?NTFsc3IyN2M2VitheWx0bFl6MjUxakxVTXpMemFodU0zTFMvSk1GSlhKdmRi?= =?utf-8?B?NmJIWUY1V3FXZ3JHYVB4L0dYamY2M0R4VW51RHpTbUtpWmN5MUVuZ1pjK1JJ?= =?utf-8?B?NjQ0MURjYzduYzJNcDEvcXBhWGtLVGdQNDZOakJXMndXSktDRnZFeEpXd3Nl?= =?utf-8?B?UHZrUGdETlh0MmMzazV6ZlErV3Fmdkw3YldrTC9lWUdMTit2aEk0dWNXZUk5?= =?utf-8?B?dnV2RUp3VjJ5SFl4RUN2RGlZZXJlV2J3emlvdXhRdlBLNGp1WE1PL081YTRs?= =?utf-8?B?VlI1VUtOc1RCdnJZOFBxckduYkd5bGhZeWpVOHB5N3d6RllDKzRBQ1FlVHVL?= =?utf-8?B?S3JpMmxCbENXTWp5anFabi9MNDVoeThlNVZ3aW94Z2J3bm5RZEsrcnEyZnNs?= =?utf-8?Q?RycPc4GaYmwmaarEIVG2yQ+2opq1r1MYtHjSQVf?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3996ffdb-a086-450d-03ed-08da99b8798c X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2022 20:58:02.0472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0156 Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Fri, Sep 16, 2022 at 09:00:24AM +0200, Anton Khirnov wrote: >> Quoting Andreas Rheinhardt (2022-09-09 20:15:22) >>> Michael Niedermayer: >>>> On Thu, Sep 08, 2022 at 11:44:51PM +0200, Andreas Rheinhardt wrote: >>>>> Michael Niedermayer: >>>>>> On Thu, Sep 08, 2022 at 09:38:51PM +0200, Andreas Rheinhardt wrote: >>>>>>> Michael Niedermayer: >>>> [...] >>>>>> To me if i look at the evolution >>>>>> of isBE() / code checking BE-ness it become more messy over time >>>>>> >>>>>> I think it would be interresting to think about if we can make >>>>>> av_pix_fmt_desc_get(compile time constant) work at compile time. >>>>>> or if we maybe can return to a simpler implementation >>>>>> >>>>> >>>>> We could put the av_pix_fmt_descriptors array into an internal header >>>>> and use something like >>>>> >>>>> static av_always_inline const AVPixFmtDescriptor >>>>> *ff_pix_fmt_descriptor_get(enum AVPixelFormat fmt) >>>>> { >>>>> if (av_builtin_constant_p(fmt)) >>>>> return &av_pix_fmt_descriptors[fmt]; >>>>> return av_pix_fmt_desc_get(fmt); >>>>> } >>>> >>>> yes thats what i was thinking of too. >>>> >>> >>> Seems like Anton is away for a week or so. I am sure he has an opinion >>> on the above approach. I think we will wait for him or shall I apply the >>> patches as they are given that they do not block any later alternative >>> solution? >>> (There is one thing I already don't like about the alternative solution: >>> It relies on av_builtin_constant_p, which not every compiler supports.) >> >> For what my opinion is worth, the patch as is with some extra >> explanatory comments for the new IS_BE* macros seems like the best >> solution to me. They are indeed slightly confusing at first glance, but >> quite obvious if you look at the code for two minutes (less for people >> smarter than me). And I think few people will need to understand how >> precisely they work anyway. > > i agree, maybe we can solve this by changing the IS_BE* names instead > of adding comments. > IS_BE, ENDIAN_IDENTIFER, > (0,1) , (LE, BE) > > or something like that, may reduce the need for comments > > I sent a version 2 here: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-September/301535.html Can you take a look at it, please? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".