From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CDA614995D for ; Fri, 24 May 2024 06:21:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D05C868D51F; Fri, 24 May 2024 09:21:15 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2064.outbound.protection.outlook.com [40.92.91.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F4C768D17B for ; Fri, 24 May 2024 09:21:09 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hcvltNfchhOSKuDBV7EJQjO0cIDBj108DPr0hHA2rgTEjLQxEr77PeIUSzlplcxXbzwWcwj5It7I40j5iXeoP34exvHYWXfrKnqkECV8Yof8Qy86GA5HvA7sBRIxoWFhxqsNrG9ur53Qb5HHh2Npusvirpnhwy5qiP4+n2sWWpFi7/xARk24VqAypncjeBjRH+5ttXgYmVnQCosBVJIWBdhx/F7gq4jFc6UmeZOM126d5YKSRjGSt1dWUewsbxzRKBUKff53+8U+Om3SsDbyxnlIstWvZBSj9NayHyUEH8oRICtdyTDK5d7/q4UKkAfxxxvX3i5ClHYvxmlx4033MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W7xCgkVPFTAoi2dHk6Fns8d0tq8KiY3bPPKJcq3aftM=; b=dB0ofk2HOyKYReHvi4EoQ/iyI/lmcAFV7ZvGlsR+zGTIpXfLRGcb/f/KrLkzALXszgOyfsRpcb/o2Uj7SrsIsY4QtYPAoj1dCY4m1ZVgk9+Vo/FDveuVMYsJJ0fZ9rrmhiXY+ygM77iCdiXB0rDjeyACR8CMAy4sxvGxgSq53o6TKE7OtA9xGngwSfQ64R+5RqewxNPG9vvnaVVT04Lusks07PHm2dvmJBeYb68pXPQQE967bHNmCVaSFDFZikAD8jKxVihtCosGvQ4XCB98eGGFNxfWNptjAtEDr9x/2As4QTIlw856B/+Z4pmvCMasTXiwT+WSdShcHD9C2nyGnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7xCgkVPFTAoi2dHk6Fns8d0tq8KiY3bPPKJcq3aftM=; b=V9/axmOrAMlDZtrGHpJDCGjHMd68FyG0PLYqALRCiuTq1Y1E7puGnqfL5pbtSZ+o3DpoSuRhzbXRMw1jQ8TRUNj/nt2Qn605udP7r9Sb5dgmMiewrgjI44bTyL1C3e3vWwJY4qGFhsD0wLzQ0HDMnHi8P9lM3herF6L5SvTOyMGsaR2LOwgF40CKvw8/VYDjRrXDy6ZJbzhnE/YVxknTgawOrQiIJqjE6HcZxpcCSDQaeozqQMZ6a49TNoHT/gecMf/pVaV1mmtXDw4feZHoH/nnAZWqc1LaCgL7QXlWWdM/tiUSkl0RGPB6D47PLpi79OJ0eGe/7l7Si3QuQXNLWA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0285.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 06:21:07 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Fri, 24 May 2024 06:21:07 +0000 Message-ID: Date: Fri, 24 May 2024 08:21:05 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240524002523.2984524-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240524002523.2984524-1-michael@niedermayer.cc> X-TMN: [hzc49vDDvDLD1mQIxhsMHwqPWxaU0DjD/fyw9jGp3V0=] X-ClientProxiedBy: FR0P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::13) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0285:EE_ X-MS-Office365-Filtering-Correlation-Id: cec57644-4dc2-4cb6-b876-08dc7bb9b220 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: 0FbkqAiIV3pvuiv8RgeKLtGsELEeMK1L4RJj4XqTehpPrmedcI6JMobromtuimPQ6PpN4vPDVtO+HDkT5s8ICUnDhoNLoF7aAavFXaxFQFDIXiOmlfUu8N5f5xuYhqpPuNHPCEh5OURSOppYIjdtT7vInMxXEThvnD8QH0VWRDcxeNKCh/Cz1PE2zJrvvEiMVOxdT2qe4C4Ed9KXuZ2Aq9YAk6D2Unvsa8udEYEbLsG+t07fedLRztYpA1nfz1R11Dlfzxakfx2o0mCkLdbrB265X+xQ5pyYY5bH4khHeiHEfbw1V4JSu3/dv4bw0VQPrkgdZgUBheizIvx81QQZhjfTCk3cX6x4fwACSwWplFqLCN69XX9O0OBfTuYRA8BJxjN85bZplzMdAoqTFU7SOKigXm4as1lPm+7Whc/Z7uXDgt1jUUdUWW1a/qQSUsM3v+yckinjW8Ny250irtFvX68GIsRV0HqHSSPQlGsSB7xIXjFCzAHy+OHqis+HNLSV8Vf+up2M0+0oY85WEkZOw+I8A0Mr6DySo7jmIHoyPn3wg/hTeGlgQXjskN76r2a2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWlhK1Y5N3BHOCtoZXhGNzBlQVFWdzZ6cElOYnJWTDFvVE9IOUw3TUd4MnZL?= =?utf-8?B?aTJZVExRMmlsV2x1SzJCSzdsWGdTcGxEQ1NmQXgzTjdkU0xndzhNR05OQ3V4?= =?utf-8?B?MlJIYm1zM2Iva09jZFZrbnFkcE8rVll2TmdMZzc3aWNaVVZuNTVOVnZFRzNY?= =?utf-8?B?c0R3WDJnMEhhTEpmWmNQWmw5S1F5ZjBZZmVOT1VMZ3h0T1A3ay9vT1JoTWxm?= =?utf-8?B?WURhZkNsL3h1OVZXYm14N2JER3ZTcjlhd1o3c1E3WXJMUkw1aEpnYnNVYzdp?= =?utf-8?B?dXpmaHlMemdUeXVlYVNOSVUycWcxaU11VEltZXFUN1ZlSjkzT3FwaDBZRDFl?= =?utf-8?B?UVdHSGtDRXlrakJDQWdEYktIb05yOVBUL1lJMUZ6c05SdnNuQW1JbGFaWWlV?= =?utf-8?B?Z0VPcHBwWHE2dG54QnNMT3I3bWtXenZoR3dia0FCNTBaSGpLc1NHUTlFekxt?= =?utf-8?B?VVJRME9PL2g0VFNZWG84WEdBd3Z0dnIyc3hlS29EcXdBUDBHT1BIbkdadHI0?= =?utf-8?B?Y0c3ZUxFdTBQYjRKeHg2bjk2c3F1ZHpiTHh1Y2NrUXlSNW11eEhpU2xmTThJ?= =?utf-8?B?enJDNjF3MHgxbWN0V2lQQUplbUl4c3NCbW1iVjlqeUpPbmFvd3lmUlNvN3B3?= =?utf-8?B?cXh3a0RGQVpmUnJTc084Zy9VNm5hODdsUjVRelM4L3RjVmJEVUFHQWlJMGFh?= =?utf-8?B?NHZ4TVpmbXltQ3pKY08rN1c3L1drcTZiaURSR3lDTnFhMkovditBOWNRaThN?= =?utf-8?B?SG1ObFBkMTBmVVQyV2RSWTI0dUVxdWhLaEdXNHYwbXZTM1VjZnZnL0RBN0Vl?= =?utf-8?B?aHFqanUvVW5lNThsT1QrWVByNjJsSXFia3hadURlRE83Z3NURFBNZExhdlRN?= =?utf-8?B?dGxkT0o0R2NhNVVhd2Vocko3SUFyWVRtMnZWRzdDS3p4RXRJMHhKUG5ZZGpX?= =?utf-8?B?dk1GV0NPMVRyNnoyTWVLbC9jN3M0Z3lPV2VlSHdjeFVacWwxMXVvOTljclhy?= =?utf-8?B?UzkrcFAvZ2ZCM01VUXd5bDVZQktTSjBpcEx1MDgvWjI0Y0xPYTRoREFiaWlk?= =?utf-8?B?VTNNSDFYNlpzZGdhVlFCZUdQblE2N083VHhzT2I3WFNXRlFaUmxPSGVjZzlr?= =?utf-8?B?Wi9PaktzN043MHhjcG1pNEMwL01kRzRlNFF2bHZlczVRbGI4aDZQZnhITmRU?= =?utf-8?B?dlNZUkpUQzRiejUraStQSlczL3U3cktyVXFndGxlUGpEMTJaV05ibHQ3UkM0?= =?utf-8?B?bFF5c3QzMlpiTWpnNmFXeUtybUthUEVuVy9sM0c2UVpGclRDQUlkR0U4czY2?= =?utf-8?B?ZHVaVlhKRU5MckVldnI0RGVYenhVVlM0VXhEZmJKWVlDRzRNZUMyOHloWDZT?= =?utf-8?B?ZUxjWHhqNG5qWGFrYmNaU3NrV1IzNnlHcDdIeGdySG1UVFR4ZFFaYUc1R2Y5?= =?utf-8?B?MEhjSjRyMHdCVGMva0RPL0c3QitzSWxaWjVtOWFhRjFrb1BoamFXY3Y1c1Vw?= =?utf-8?B?QjJBU3B3b0xIVHRXTE9VOXhFUTJJdDhtV3N4UndNSDdya2g3UFNSTDVmM0hP?= =?utf-8?B?V2l0TjJsVVkrMzU4THRLSUgzVGJMdHZxT1F3cWZVL3J3RkRqcG1LSlo4NmIz?= =?utf-8?B?cDU2T0hMQUhib2VDNElkN29Ia0s3YXkwdk1kam9DbTJyMmU4WWYwVmxjSjFq?= =?utf-8?B?aklhR2d6dk03cGozWXFCYW1HNllEbnlTV3RiYUhpMHRZaFZva1ZkYll3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cec57644-4dc2-4cb6-b876-08dc7bb9b220 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 06:21:06.9894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0285 Subject: Re: [FFmpeg-devel] [PATCH] avformat/demux: Remove dead stores X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: CID1473512 Unused value > Fixes: CID1529228 Unused value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/demux.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/libavformat/demux.c b/libavformat/demux.c > index ecefe7e0a74..d0a5a39d052 100644 > --- a/libavformat/demux.c > +++ b/libavformat/demux.c > @@ -2998,9 +2998,6 @@ int avformat_find_stream_info(AVFormatContext *ic, AVDictionary **options) > > av_opt_set_int(ic, "skip_clear", 0, AV_OPT_SEARCH_CHILDREN); > > - if (ret >= 0 && ic->nb_streams) > - /* We could not have all the codec parameters before EOF. */ > - ret = -1; > for (unsigned i = 0; i < ic->nb_streams; i++) { > AVStream *const st = ic->streams[i]; > FFStream *const sti = ffstream(st); > @@ -3022,8 +3019,6 @@ int avformat_find_stream_info(AVFormatContext *ic, AVDictionary **options) > "Could not find codec parameters for stream %d (%s): %s\n" > "Consider increasing the value for the 'analyzeduration' (%"PRId64") and 'probesize' (%"PRId64") options\n", > i, buf, errmsg, ic->max_analyze_duration, ic->probesize); > - } else { > - ret = 0; > } > } > IIRC these stores are only dead since ac5a568e6dff8162a2e982f3571b925f1b207e2c; and it doesn't seem as if this was intended. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".