From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9DC88499F1 for ; Wed, 27 Mar 2024 01:32:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D27968D6AD; Wed, 27 Mar 2024 03:32:14 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2028.outbound.protection.outlook.com [40.92.91.28]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 789A068D652 for ; Wed, 27 Mar 2024 03:32:07 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+4SzT8HmPzcHCV3va7OPe9MPIjo0Ghtjhlx2yLS5HinVgalI+BS4BWUL3b9g45Flkmj58nukpVQWlpouo2h9cpU75yhC7EZsTkWKzFOVaXxDCtV+bPBvULDqaVIReSLEsJvDOf9I3Ik8/6YCGMcPtBa2g/Lgqfdg1oBLsiFHos1QqEnL+5ekr8zmZbRY50eGfNYBE97bcsrL15I4Fry3pwBAi89JzAUybZy6qioYh9Kn7zoIz4xAQB5QuSJyNONbTxluxyDEFjNQvNorQU8foE2ljH2TJVEBSWIeL8bxhRul31f6rM3Bd0oXx0QVx4xP7agGEDSZ9rTzOdp/FvEbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8ghj7vI8kFvn2bF900X8n8G5jlnUI86OheHygPdgnQ=; b=fRSX+7e6Fbxe9kGpe+iooBhL+7e54r5JFi4STvrKz33PzjCTYTDYzDVxCGvGNlSIp+P1QgQO9KJ+u/eUGKlz6BItXd3tJgTsV4t8g6LhynDN+nfpKeVMOZxv5QlXZQemE+tP49Oonrf/KPV+iothfWEBnqp+Y67v6ZOqaG8caLewhSaA6/499cvL1JmZ+bvvSfOY4XoQ/LfOKAoN2i/u4ZUSyPNPfAkbZaxvi5vjudeRCsZ4DQySs/Ap5pXaua8tyxir6Hc0fZD0QJBjqLxbr068osHwB/pzEhvHcoI1F0Jo/r2QyXv7I4iwfZkPDD8SI7Klk9ZbR5eqOZCbDrvVNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8ghj7vI8kFvn2bF900X8n8G5jlnUI86OheHygPdgnQ=; b=qqVozraBiYIkoivVvCM+EGH1tgkYk4/oFwzUngSixn5j2JV0B5pTsbpA1Uf/0A90hK76p6LzBl5o27kuFZIpB6HYN54qha5/BkWt8U8Wk2m3OZK2fiHGu8KXFiWXdnO8WXbnV92BqYT3pmHvnzZkTirHbwHyTJjZZgrYSLiJ/csOPKs3+n1ajhyZYrtcIWXh1bxq5FIWkpCsqhr75lQK2Hl2SKquAy60O3DVuJrzQw0mef2VxzLHUkQgAJMXuLb9NebTJw3lNLRxxt0ro2AG+SXH09eaZGzxxlYLwrDWLjRv2w3yVH1a+gkEMVKj4G031AplVtvD13lKckFj88GDTA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0063.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:238::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 01:32:05 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.028; Wed, 27 Mar 2024 01:32:05 +0000 Message-ID: Date: Wed, 27 Mar 2024 02:32:03 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [cidAGUlOCT/ZlHDRyDQvgicjS3Amw59F4RqLLaGd2XU=] X-ClientProxiedBy: ZR2P278CA0004.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <040fe609-922a-4338-bc39-9a40c31277a2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0063:EE_ X-MS-Office365-Filtering-Correlation-Id: ca1364d7-f6fa-4bad-07d8-08dc4dfdb5ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Beu+8U3kF7E96XPmItWM5quhIX+wQUt6WbpQUtvXS73OHVrYc4/rHu24P+oKx0O9DlNtat0kVct4XLc6pYpGOzKB0WRsPtS+XBnZpJ/MvlwuzVMwqVmX/sbELbrvlVJlU9KgRE//7GvzRUdaIUaxZgBazB58Xl5tyGc/af0+SgDNaOu1A8Nrug7rGmj5ZcU+759X/rx+7GIdEVUsdqQoR7wdUcb+Z0X0gW0UR/VRKigFArVKQ/KPQkO71pAfW9GRDWLP9m1PAFq9oQbWwGMA9HJlFZbjZ1rRHdeAsk5JbnBaidR15gSfqBifIpMQnvEqzwJl9weeQVEwbTWo1RECjUtx5rtHLJMrCKjJkzK7BikmXi3JwlGpyf1AFX/c+uCnO6mRSREtE+VwBCB16nXe2zEObRUSwDerqCoweWRGwqTT+E0MFxkfQO76by/6O5NrA2KSt9Dl2p8Zk3YMHro8rtI+hEPVsjDPkdEsLFkl2o+wjQKdquE+KGcnqMH4SK68IfISpdpY2LVxDIxHlmRq5526PjS5BjdKwcw7X8FpfZQvC0bIVmxJdMl8A1q8w1UTRvRI2AupW43K+m/Y+lqT6Kr99z6+5WHt0uBPfRp6Wf/L8HNFESHlk2+2ypZxE6eYnvcj8FNP/IhNJ1xTQGUtFmOu/7y2YPCnEM4aAzyiRw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDNWYUpvNXRyQzZTeHFGa0E1QXk4YTFxQVNzWlVpeW1XVmtlTEpEMU8weFFm?= =?utf-8?B?ZkZyU2kyOHMyWmNPUnMwQlhOM0UydHpkUzk3VHd0cGtsUzE0aUtEQUx5TEps?= =?utf-8?B?M2RvN2xnNHU4cmVLeHlmNWdVemEzTFV4WDVDMmorcVJxdTFFM1Vldit6R2xr?= =?utf-8?B?VmhYQmZSckpSNTlMOG5MUVB1a0RMRnRvaHpMVTBGVXNWM2RxQ1R3MDZqMDR0?= =?utf-8?B?Yis3TlZTSlIzS0lyR2paZXlxYmdPOWR0bFVFS1QyZWgxWS9OWEpybk84U1NL?= =?utf-8?B?L09NWjV5SkV2UWFHUCtpa3pJa2VrejJ5ZG5jb1V3MGxvUDI1ODFKNnF0UzNF?= =?utf-8?B?b1lLYi9QTCtuTEI4SWhiam9OcXhha3pVek50ZlZUek91WklrR1lZVjZ0c2Fy?= =?utf-8?B?T3ZacWloOFhtOHhNMjYxaDBGN29jQnhPOGhaWmRlRm91YXlrMGZSajdqNVlD?= =?utf-8?B?d0FYTVk3c3hueGNnU0VPWlRqNGQ4UXlLSGg3MTdWOWQrb25KRWh4UG1XejFm?= =?utf-8?B?VHAzZDdnRmFQY0ZwUyt5YVJQdERyVWIwcFhacU12YXlDc284WStnTVVCM21G?= =?utf-8?B?ZnBEeVhldVRMbU5CZ3hVM1haYWtoQ1RQdHRkVHlPM3habjM2Wk85L3JCYTlK?= =?utf-8?B?eThtY3JLbTBnOFc2ZjZVbks1RHVjSys2UnRJUkg1eHpQTm93ZExGbFAzLzBW?= =?utf-8?B?Rlg2MDl0Zm5KWEdLVFllSWR2enI4eTdJQVlCVmd2SWRibWVGRmNuT0lQWGNC?= =?utf-8?B?Vy9NbllOcnRUT0tMS2tuMFFzOTgveUE4TVFMc3ZIbmlEZUtBZGxHajhia1M4?= =?utf-8?B?c2QxRUF6Y1l0OTAvd09HcGwxY1ZkVkUwUGtaMGh5N3BpbVRlbjR5ekR6Smda?= =?utf-8?B?dWsyK1RmL1lzOW5yK3ZGSkErNTMwSEFjTGNMbFVUZXAvSW1mZ214MFlneHp3?= =?utf-8?B?N1hobGcwSCtrdWNyclhqcWZDMm5kWFBPVHBobmsxZWlOYXVMOUdPUGdaNEx6?= =?utf-8?B?U3BGTXJJMUx3WWJnTGRLYUZTd3RMME1hUXhzdTR0TmpqRlFybXp2TElHdnhW?= =?utf-8?B?UUNpZ2pRNW1vOTdDK0pLc3RlS3lhdUdORnQ2U3U2SXJDZnRHS2I0R3MxUjNy?= =?utf-8?B?dUErRkRocDI1QnZtV05EVUhRSHlJV1RyZXhBMmt4RmtKU0dvSmZzL0I4akJ4?= =?utf-8?B?dHhlYkVGdE1IdnlDSmJlV1l6SEcwZjBpTDVRTTJJTkE0dUNpTE5HbDhpT0tL?= =?utf-8?B?SkNSSWdjdUw5MWxjVURza1gxVGROZ0ovRlJIU2VkRjFWaW1LcGF6VUY2YUJ2?= =?utf-8?B?WnR0cU5Od2c2SXNhOGN4enBtdmM3aHRHdW9abVBtWUM1a3FZbFk5R091WHAr?= =?utf-8?B?ZkVJS1duaktBZHFLdWtES0toTUZ5cmIvUUp2ZDBCOTQ1VnZkNVB5Z294TTBu?= =?utf-8?B?Y1dKdVVPcXFxaG9maTYrcGZOSHdVRTRFZ0dCbFNxQ2IzV2lRUmZzU1g2a1JW?= =?utf-8?B?eU9nZkIvRlR2b3k3OGFZTlFCNm5VZlNoTzQwTldlbmVsVVpQWFBXNkxpcGtY?= =?utf-8?B?SVBsZ1d3L3N5MDdET21OZFkxaFdmUnlCT3pFVFdZS2VnTGJqMCt5MXZUSFMr?= =?utf-8?B?Qnp2ZWpuaXZmRDU5R3lDaklGUWlHUCtUZDJUcmNQMnh3WlpkendyT1BYWTRF?= =?utf-8?B?cGVzNlU4VkJ6cFhPT1RYdHYvL2E3SE9ueExQK3A5TktoRklXWXlOVTRBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca1364d7-f6fa-4bad-07d8-08dc4dfdb5ec X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 01:32:05.5887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0063 Subject: Re: [FFmpeg-devel] [PATCH] all: Don't use ATOMIC_VAR_INIT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > C11 required to use ATOMIC_VAR_INIT to statically initialize > atomic objects with static storage duration. Yet this macro > was unsuitable for initializing structures [1] and was actually > unneeded for all known implementations (this includes our > compatibility fallback implementations which simply wrap the value > in parentheses: #define ATOMIC_VAR_INIT(value) (value)). > Therefore C17 deprecated the macro and C23 actually removed it [2]. > > Since commit 5ff0eb34d2b1089d3dd9f27fdb51520001709138 we default > to C17 if the compiler supports it; Clang warns about ATOMIC_VAR_INIT > in this mode. Given that no implementation ever needed this macro, > this commit stops using it to avoid this warning. > > [1]: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2396.htm#dr_485 > [2]: https://en.cppreference.com/w/c/atomic/ATOMIC_VAR_INIT > > Signed-off-by: Andreas Rheinhardt > --- > configure | 4 ++-- > fftools/ffmpeg.c | 2 +- > libavformat/allformats.c | 4 ++-- > libavutil/cpu.c | 6 +++--- > libavutil/mem.c | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/configure b/configure > index b9fa8652c4..e577dcc677 100755 > --- a/configure > +++ b/configure > @@ -6610,8 +6610,8 @@ check_headers asm/types.h > # some configurations also require linking to libatomic, so try > # both with -latomic and without > for LATOMIC in "-latomic" ""; do > - check_builtin stdatomic stdatomic.h \ > - "atomic_int foo, bar = ATOMIC_VAR_INIT(-1); atomic_store(&foo, 0); foo += bar" \ > + check_builtin stdatomic stdatomic.h \ > + "atomic_int foo, bar = -1; atomic_store(&foo, 0); foo += bar" \ > $LATOMIC && eval stdatomic_extralibs="\$LATOMIC" && break > done > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index d4e5f978f1..5e00d5b645 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -157,7 +157,7 @@ void term_exit(void) > > static volatile int received_sigterm = 0; > static volatile int received_nb_signals = 0; > -static atomic_int transcode_init_done = ATOMIC_VAR_INIT(0); > +static atomic_int transcode_init_done = 0; > static volatile int ffmpeg_exited = 0; > static int64_t copy_ts_first_pts = AV_NOPTS_VALUE; > > diff --git a/libavformat/allformats.c b/libavformat/allformats.c > index e15d0fa6d7..9df42bb87a 100644 > --- a/libavformat/allformats.c > +++ b/libavformat/allformats.c > @@ -576,8 +576,8 @@ extern const FFInputFormat ff_vapoursynth_demuxer; > #include "libavformat/muxer_list.c" > #include "libavformat/demuxer_list.c" > > -static atomic_uintptr_t indev_list_intptr = ATOMIC_VAR_INIT(0); > -static atomic_uintptr_t outdev_list_intptr = ATOMIC_VAR_INIT(0); > +static atomic_uintptr_t indev_list_intptr = 0; > +static atomic_uintptr_t outdev_list_intptr = 0; > > const AVOutputFormat *av_muxer_iterate(void **opaque) > { > diff --git a/libavutil/cpu.c b/libavutil/cpu.c > index 48d195168c..d4f947360a 100644 > --- a/libavutil/cpu.c > +++ b/libavutil/cpu.c > @@ -49,8 +49,8 @@ > #include > #endif > > -static atomic_int cpu_flags = ATOMIC_VAR_INIT(-1); > -static atomic_int cpu_count = ATOMIC_VAR_INIT(-1); > +static atomic_int cpu_flags = -1; > +static atomic_int cpu_count = -1; > > static int get_cpu_flags(void) > { > @@ -208,7 +208,7 @@ int av_parse_cpu_caps(unsigned *flags, const char *s) > > int av_cpu_count(void) > { > - static atomic_int printed = ATOMIC_VAR_INIT(0); > + static atomic_int printed = 0; > > int nb_cpus = 1; > int count = 0; > diff --git a/libavutil/mem.c b/libavutil/mem.c > index 62163b4cb3..02d4cb791f 100644 > --- a/libavutil/mem.c > +++ b/libavutil/mem.c > @@ -69,7 +69,7 @@ void free(void *ptr); > * dynamic libraries and remove -Wl,-Bsymbolic from the linker flags. > * Note that this will cost performance. */ > > -static atomic_size_t max_alloc_size = ATOMIC_VAR_INIT(INT_MAX); > +static atomic_size_t max_alloc_size = INT_MAX; > > void av_max_alloc(size_t max){ > atomic_store_explicit(&max_alloc_size, max, memory_order_relaxed); Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".