From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1A9954B78E for ; Thu, 13 Jun 2024 04:40:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D26FD68D936; Thu, 13 Jun 2024 07:40:39 +0300 (EEST) Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03olkn2077.outbound.protection.outlook.com [40.92.57.77]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AFEBA68D549 for ; Thu, 13 Jun 2024 07:40:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgWkbesGuiq8SD3uDmp17C2Maku1dJAoHgKJuPkR0SXBKwNElGgDMVGAEZB7uOJ0+RirgcvGwSKpt4AZVw6tAi4wKrP3hzUjNy3jeDGSJPtKT8UWqkyYwZVDjH78+nOh+0rOITLvHeMnggh/+2O5V3v455h1G/QXfPxVTJu+YmtHr2fR5KzlpKuDxGbUGj3+5K080kOPeYagsP8VxhnUrSPGpX1eF3fUv+DJFx0dQI1nmWjJFsGCBrCm8XJeVSFQXuXP5uVz/TWabjlTrK4nq5K9wPZ5Zqmr2ndURGyUPiQ9s/lK2+YJGD6rubvY+fbq38Ck67Pew4A/xd8myEnzGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZRWJkw9j65l2X5xx53vXL45tr2sgw3mMQ7aLj+FuBlg=; b=Y5ZFU+lhaC/1kdS5a3csgaiwgACey8iBvgApVXpStQHRbXnZ3xv9ADmdOfklTY0c57GHUAZjgD+BwFmzD2I+VO/c56FZ9cWaxCHK5WJFO3miViNh0XkvNc93NO0bckdB0xYndL7JtA+tZqUnxTtpUQwq7FkpN7hrc8l2y6x1XOQUpFdxY0mFQVFDcrw2Etzv7yxLdZOfUKvPbYivzcxWD34AxI4XCwmyjl4E1kfSCvDM1G0X27LRT90ptE2ANd+iyAN2RKMc2c0YbVAWMbf93EcuakS0v7V/BZe5V6UCZ9o96VzAxOZqroastc7ds2FoymURmFCy9qB9bvnF0PaGmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRWJkw9j65l2X5xx53vXL45tr2sgw3mMQ7aLj+FuBlg=; b=dJ6eGoBkNFQwh5XF2mMhM5ZDdj/cF9VaDEtk7ppKqM9+hFDqBja1dK5BqFwGxxEJ4XokaHs3tLkFDvFJQy0gKsX0sWpsoRxnVbqM9jD1YWVgTuqq3z0YWTRSe+XfAJWxohfyDfPVVvuQzBTo2wEFCpAVIX473YFLUcAyZ2cXwP7RnbmthYUuPEkd6tDfWV41KUgssz42kjpLn4pkSPUOVO01e8Rb2hP67gaqgV4xLN/OMqjo2Zh+St2dLQML8crkTcrDHrTH1ElJRVvTqKajbadCdAMTL55jWpfU1OgnHc1nLUKfMhTBmItCh299VETtZA8nL432o5SIfBpTYxh6Ow== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PRAP250MB0443.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:29f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.24; Thu, 13 Jun 2024 04:40:31 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7633.036; Thu, 13 Jun 2024 04:40:31 +0000 Message-ID: Date: Thu, 13 Jun 2024 06:40:29 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [8NJEryK17NxaxUOKYDCgjjl0nwZ1MtW2zxB2D0/8NNc=] X-ClientProxiedBy: ZR0P278CA0207.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::10) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <5fd07e1c-7474-4cd0-a66b-7b25aa3e3690@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PRAP250MB0443:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ba32150-5972-4b36-7ff5-08dc8b62f500 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199022|440099022|4302099007|1602099006|3412199019; X-Microsoft-Antispam-Message-Info: M+bMqS4Hc2iOVhMQ4uv5kXEqe0HUIEwa8fD4dKJkUwptIVF1/FubNzlop+NEuk3f4inGZut459bZVjlp0SyL4CVP7brN5vnfEuMKBXAmah5u+/FtvfNmngGE4Nhp5sl33ZoWb3hGXTOThLJ3mPXv5Et5tAI7svK0zjs+X/sICnADurjzcsr9JTCJfvcacc9rMZ7tNi3bPS2/KhvAqu7U8xBqEhIoYZ9heymhdvIC9gaEBOZ+7HUjaUEStVIiDFSZYZKAYLi3S4ouZsGXI7R86gnTkJnIi6um0mLLM9LLqzAb7gbBqH3h/M9WRjtxmbbv34wS1QwDeWPGSLbIg5ONftcBJwRp1je6sV5UV69LnOOnFgHJdkjkjeujxcbWBdXCSdM7KhUkUuckYX1TRhA5rLpbkm/MgHZODzKvlez2FaiBgWVm/sz1bctq1CSYjVIycjhdi9hbCh02ANYGdTR5cCMr1NdlWlGMJIqIaCVWDux1IC+eAgBF9lCKCI7FlysTDfsgtZWlLs3eJ2Joxq1h7FzZcvrDQgjsgCtqQcE489ji9NGoXVM47RYcE1Sk0GQYF/vp/CcEJ+THOcDQ4c89ILq5z+RYA7kbFrD2rDO4PG4Rvf+B1rnSqVFOA+MVB1f6YwCSdc2Lk9fPC6z5Yr5cF7HPOk2sNnUCLFvkY85k4HYYd1jUWq+9Qm/b6DI3PuT0 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0NveWpReXVIY0lId0NPWlpHZU1zMVpoR2s4anB6YW43c09PMVhpRFZPYzFp?= =?utf-8?B?R1JnZUw0S3A2MXpmcER6d3g5QTlZbjZpYUtjNUhUbGxuQjgrTU9Rd05wN0dR?= =?utf-8?B?eFcrL1dBY1krVTVQcE1xcWJPc1hTTEo2bk9WcmwxSDNhejVzL1RZRG8xZVZj?= =?utf-8?B?bStDUExSTU9rUHhmMlBGZEVtam85V1U3WERHelFzeXF5Ry80RG10QWFSZmdu?= =?utf-8?B?ME9TdmJFaithSVQ2NTJCdm1ob25lcUlqSVlOVm1aak5oT1V1cW1NeThySFQw?= =?utf-8?B?Y002NUtpYmJKUjRHN0NjSVhBaUJzaHJiL1dpOWs5bjl6c29FVmVscEM5VTdU?= =?utf-8?B?dGx2eUQvRER4R0JMVWZJR2tCRDN5Z3pwYjFCSmJGait3eGpKWUNaY1RpY25v?= =?utf-8?B?SGxUQkhVMHRKM1JyZnZKdGwvS0hnNFgyd1R1eGZ3YjAxazIxNmZUaCtiRDh2?= =?utf-8?B?a0lYbE1YTkUrTWQ4U2U5YUNIZEpITmNKamhKRUFOVnBzRFAzUVFua1B4VEN3?= =?utf-8?B?Rk1EUzNsbGt4RTR4eEhoZ2xZRTVXTkVrcVA5eFMreUtxOE1IUVd3NHQ2TW82?= =?utf-8?B?dUZWMGlhKzlYZEFwQVN2eW9qclRoU1BEVW5Od0VGaE9tRXdERVdWQlhIUklS?= =?utf-8?B?d2puMmJHNEZMd3llQm1TM0xBRmh2MllSaWtGRW5hVkdqaUZXTmFnSWFOVW9v?= =?utf-8?B?T0Zpc2dqU2c5QnNxeGpleUN5RTlER2NsSXFQTUIwc2p0U2cxeUZDNHBSVFZo?= =?utf-8?B?MnE2NmFMenZoTUt4dGxCbnlsQmZsUnBGcEpwR3NYcC9vcWo1aVRiS25kNWp2?= =?utf-8?B?SjU0RU1UamN1RHFUendwT3h0Z0F3YVhsOGplalhuc29pN1F0UWpxWXIvb3Bz?= =?utf-8?B?MHVoY2NZaFVhVHl3SFIxMXduYXpVU2V0bWR1aGp5YmRZMXlJTVNLbG0zdjQw?= =?utf-8?B?RzA5RllBQW5YdlBmdFJEcDZ2bVQydmp6REZQdVAxcHNydmliUlhleHpSdFRu?= =?utf-8?B?MEFBM2tSMHVZRUFmcFRHVENtWXJ5TkhGWWVFMURqZVovbWg0VStnRmdSRU4r?= =?utf-8?B?MVZDZ041T3l2bktLZmhHeWF5RWVDSVRQTklPRWsySi9ZNk5rQWZqKytlYWRq?= =?utf-8?B?MXlIZW5oVisxTmZkNG9SWlI2RWNYbFdJK3VGNmtxOXJUYmVkTTg3b0daeEd5?= =?utf-8?B?MnYyTWNmSThvb3lQQ0Vtb2lLVGkyK1dkd0E1aEY2Qktudkk3NU9Uemw1U1c5?= =?utf-8?B?dG90RlNyUEhPNFBDdGF4MVVLN3l1emZQVGNNczBiVElsTzdBWHVyRTdVTzAx?= =?utf-8?B?a01zTFI0V2h2bmxhWDVVYkZrenViK3U5eDJhUUpYdFRxOERsUVU3dmR3eUZ0?= =?utf-8?B?bCtYUHE0aWdiOVZuM2hBYld5b09KeFZCMWNrWUM3d1FZaEJRUXJzYnRCbnBx?= =?utf-8?B?V2kwMmpLalhaam83VkdKejFUS0ZncW0reXBuYzlLYWlaZXQzR2orVzBnbWNE?= =?utf-8?B?K3JucUE4aE80OFpURU9MZUhRcnNFNVJoN3lDQkM5N1NWOWFtbWdyZFZjbmpk?= =?utf-8?B?dzhzQm9XZ0dYQ1JGMVMwdm4zMEdza0l5Wld2VVVpSmwxNFVrblVUNVdoeWxm?= =?utf-8?B?SjhUbVVMYnJ2T21ZVzBwZlcvcW11VTd5cVk5UGdYNGFGTU4zeUd0eTlUdkVQ?= =?utf-8?B?YjlETFU4M1BPd3d6dHI0SmN0M3RUS2l0eml0dmQ2N1lCcWllaTJIODRnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ba32150-5972-4b36-7ff5-08dc8b62f500 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 04:40:31.5667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0443 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Don't copy A53 closed captions by default X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The SEI handling of libx265 is buggy and can easily lead > to memory corruption: It reuses certain buffers, but when > reusing them it presumes that it is enough for these buffers > to exist and does not check whether they are actually large > enough to hold what is intended to be stored in them.* > > Our users are exposed to this because forwarding A53 CC data > is enabled by default. Change this to make it disabled > by default. > > "Fixes" tickets #9666, #10411, #11052 and (presumably) #10906. > > *: See https://trac.ffmpeg.org/ticket/9666#comment:1 > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libx265.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index ac1dbc4f97..0dc7ab6eeb 100644 > --- a/libavcodec/libx265.c > +++ b/libavcodec/libx265.c > @@ -948,7 +948,7 @@ static const AVOption options[] = { > { "tune", "set the x265 tune parameter", OFFSET(tune), AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE }, > { "profile", "set the x265 profile", OFFSET(profile), AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE }, > { "udu_sei", "Use user data unregistered SEI if available", OFFSET(udu_sei), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, > - { "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE }, > + { "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, > { "x265-params", "set the x265 configuration using a :-separated list of key=value parameters", OFFSET(x265_opts), AV_OPT_TYPE_DICT, { 0 }, 0, 0, VE }, > #if X265_BUILD >= 167 > { "dolbyvision", "Enable Dolby Vision RPU coding", OFFSET(dovi.enable), AV_OPT_TYPE_BOOL, {.i64 = FF_DOVI_AUTOMATIC }, -1, 1, VE, .unit = "dovi" }, Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".