From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 08/17] avcodec/pcm: Remove always-false check Date: Sun, 18 Sep 2022 22:27:48 +0200 Message-ID: <GV1P250MB0737A18572C4E5E36C32F05C8F4A9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw) In-Reply-To: <GV1P250MB07378D20BA2B5BB1370634B18F4A9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> None of the decoders here have the AV_CODEC_CAP_CHANNEL_CONF set, so that it is already checked generically that the number of channels is positive. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/pcm.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index fcb8ae1c2c..ee36a364c8 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -254,11 +254,6 @@ static av_cold int pcm_decode_init(AVCodecContext *avctx) AVFloatDSPContext *fdsp; int i; - if (avctx->ch_layout.nb_channels <= 0) { - av_log(avctx, AV_LOG_ERROR, "PCM channels out of bounds\n"); - return AVERROR(EINVAL); - } - switch (avctx->codec_id) { case AV_CODEC_ID_PCM_ALAW: for (i = 0; i < 256; i++) -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-18 20:28 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-18 20:15 [FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: Uninitialize AVChannelLayout before overwriting it Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 02/17] avcodec/encode: Remove dead deprecated check Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 03/17] avcodec/avcodec: Check for more invalid channel layouts Andreas Rheinhardt 2022-09-20 22:47 ` James Almer 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 04/17] avcodec/avcodec: Always use old channel count/layout if set Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 05/17] avcodec/encode: Remove deprecated always-false checks Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 06/17] avcodec/dfpwmdec: Remove always-false check Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 07/17] avcodec/pcm-blurayenc: Don't presume every channel layout to be native Andreas Rheinhardt 2022-09-18 20:27 ` Andreas Rheinhardt [this message] 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 09/17] avcodec/libcodec2: Remove dead channel count check Andreas Rheinhardt 2022-09-21 13:31 ` Tomas Härdin 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 10/17] avcodec/libshine: " Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 11/17] avcodec/libspeexenc: " Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 12/17] avcodec/mpegaudioenc_template: " Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 13/17] avcodec/mlpenc: Fix channel layouts Andreas Rheinhardt 2022-09-21 7:13 ` Paul B Mahol 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 14/17] avcodec/mlpenc: Simplify channel layout comparisons Andreas Rheinhardt 2022-09-21 7:15 ` Paul B Mahol 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 15/17] avcodec/mlpenc: Remove dead channel layout checks Andreas Rheinhardt 2022-09-21 7:14 ` Paul B Mahol 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 16/17] avcodec/dcaenc: Remove dead checks for unspec channel layouts Andreas Rheinhardt 2022-09-18 20:27 ` [FFmpeg-devel] [PATCH 17/17] avcodec/dcaenc: Simplify channel layout check Andreas Rheinhardt 2022-09-20 22:15 ` [FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: Uninitialize AVChannelLayout before overwriting it Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=GV1P250MB0737A18572C4E5E36C32F05C8F4A9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git