From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: Print size of attachments
Date: Sun, 20 Apr 2025 19:40:17 +0200
Message-ID: <GV1P250MB0737A07667E22A62318DB6228FB92@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <pull.71.ffstaging.FFmpeg.1745114229731.ffmpegagent@gmail.com>
softworkz:
> From: softworkz <softworkz@hotmail.com>
>
> libavformat/asfdec: Fix regression bug when reading image attachments
> ---
> fftools/ffprobe: Print size of attachments
>
> libavformat/asfdec: Fix regression bug when reading image attachments
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-71%2Fsoftworkz%2Fsubmit_attachment_size-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-71/softworkz/submit_attachment_size-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/71
>
> doc/ffprobe.xsd | 3 +++
> fftools/ffprobe.c | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> index b53b799227..8c2326e499 100644
> --- a/doc/ffprobe.xsd
> +++ b/doc/ffprobe.xsd
> @@ -319,6 +319,9 @@
> <xsd:attribute name="nb_frames" type="xsd:int"/>
> <xsd:attribute name="nb_read_frames" type="xsd:int"/>
> <xsd:attribute name="nb_read_packets" type="xsd:int"/>
> +
> + <!-- attachment attributes -->
> + <xsd:attribute name="attachment_size" type="xsd:int"/>
> </xsd:complexType>
>
> <xsd:complexType name="programType">
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index f5c83925b9..0da44b8c49 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -1847,6 +1847,10 @@ static int show_stream(AVTextFormatContext *tfc, AVFormatContext *fmt_ctx, int s
> else
> print_str_opt("height", "N/A");
> break;
> +
> + case AVMEDIA_TYPE_ATTACHMENT:
> + if (par->extradata_size)
> + print_int("attachment_size", par->extradata_size);
> }
>
> if (show_private_data) {
>
> base-commit: 7cd1edeaa410d977a9f1ff8436f480cb45b80178
The commit message here is completely wrong.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-20 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 1:57 softworkz
2025-04-20 17:40 ` Andreas Rheinhardt [this message]
2025-04-20 20:10 ` [FFmpeg-devel] [PATCH v2] " softworkz
2025-04-20 20:15 ` [FFmpeg-devel] [PATCH v3] " softworkz
2025-04-21 16:14 ` Stefano Sabatini
2025-04-21 16:56 ` softworkz .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB0737A07667E22A62318DB6228FB92@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git