From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A9144928F for ; Tue, 7 May 2024 15:10:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84E8768D735; Tue, 7 May 2024 18:10:43 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2082.outbound.protection.outlook.com [40.92.91.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 95C1D688384 for ; Tue, 7 May 2024 18:10:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQQAWdpUg+xzTOti7D6ByLxiJv0V4nOxeT6L+qDqqjRhzDALQ4GvOBOT7EAylZpwJqHkyG3ZtS9LM292n7lP99+UxQBas7SWRyujEpKpmXuaf5MAM3+mjR+siLuYpG5pLi3KEA3PTd1ENjenCSbnuIxI09EtVy1Wohdn0P+GM3CJIxUyrG2JXzvpreG/o5M75qG03eiu8SlbTA6xdkT+vYFW//LKjvyDfyLhcoZStjUZu7kGRYpUqE5m7HKI3InL+egWwg53W1yvRMKO9re9ZQoDL0Gmr0voTJxxKKZpDXGi0Hk/jDp7I9nREX57N3qSQ7BlD2wZB/MxLN4Dou6hYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W52hNToHqotpyK4xxKeEW7ETVrTfcRSllRNqtBrmpdI=; b=ajXr5wC/66ai1T3hmOyTtwMymF9DVPeGpogxiftbaer06iS0wgI96GUt0mw+u0a0SUEZ2RwHKMUCY6bfBwX8SfCyh4td/Dz1NSi7kD13F7t49kRTszeyZV0nulpOLcX5woN1kNfBKPTPgWxi0THATIx5o90sTvY2YC28s8Xz/J2xWnFoSgAeJlrD8P/Qblmb/eo6120vvXG8mCVYfNGdJigxgAEyPHrnfgnBuB5eHnxxjRPlYZt5u5R8s6vK+SU20MWS9MmtX7/aTgHWGss3yFLeDjXQfexZzbZFWf503ijYwhrTouN7Ws+dQpL3MIkZVf1wAYf/RC66DPSjuRA0eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W52hNToHqotpyK4xxKeEW7ETVrTfcRSllRNqtBrmpdI=; b=nuHo+KLjgqdYOzDffr+otFYAP8n/d5q83Uh/Ykpspgr5C2Qgtojjy7R+WZDz8oAzEi4SOnmB9irhwQFKQ9a7vzb1WeUd5dhKDu0h8w8LM1b0U3Yx0dOCYqkuWkujKPbM4LHe0EZ4ozFm8pe94w4kt0NJsLqGtnoOHXs2u95T3LHX2/rWYBq34M+Wk1pHtds+mkOwwkx6kUXVXLrncp+cN0yzlwzWxy+nVaH9RxGU3k07hv9Z2oPsb/RyeiNmKSWaBWOq7rYVrmEZo64orllJsL+lwkIXT3EU3AoR7SAkmodXsIDHX4HjSa7SUFEmjU8cxYbt9c08L9EJNc08rY+2rg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0119.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:372::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 15:10:34 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 15:10:34 +0000 Message-ID: Date: Tue, 7 May 2024 17:10:33 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240507002723.1603-1-jamrial@gmail.com> <20240507150205.2039-1-jamrial@gmail.com> <20240507150205.2039-2-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240507150205.2039-2-jamrial@gmail.com> X-TMN: [8PvcCXCgC6RZ2k5T0iYuIvflrN/nN1kpmmaEVmwiRdM=] X-ClientProxiedBy: FR4P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c7::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <9249ff66-e21a-4d8b-9b84-c1f50b8566c1@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0119:EE_ X-MS-Office365-Filtering-Correlation-Id: dc2dd7d3-4735-474a-41c9-08dc6ea7d814 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: O8IQd6F5x2HbmvgUO6anewBgU2V/iYjlt+QBK4tcGuIih3ZI/R3YBFrZAHP/f5OLGuaKWWQC6ZgXtTHtR2+MCttE64D5u23alHkpQO2kGpYCH6y3pVXqp5CMnLcCHcPgcGEqtQncT2c//8ioNnKkfoNErc0Y603x5RgbGl4aLKXV5hkn6xGW6qHETB8wPpf04o+RUGGTifIEwhAlPYwNjXDqlcokr/ryWccl9Zj9/e8GELJR1Cfw357VptOwmZD8XFuHVCnOpdFG/4j2siESwmG95Euv8RNAYrFbzAXOZqiYbLq77Zxv+QHegwcVJrjo5cBMig0ua9x0ANmD4+IXS4oj6N7WmmZm9mwgXeIuCopJqHFNHK47hl7TJBVQMIEkYX277OiOJQb0CxApZbrGQtOqDDjoNNh+CsHnt723hai7Pn8/gQnRhDgr9u4YyGD2XAu1KeqYFmFUYnrsNPE2+LQAkJG+dHxvWUXPDFuj9S0CajKX/skZamEzyeNHlBX01QV4ZdygG9LReXePn3I3HN5RO1HEfainGoiRgSKnNCU8hhKc0d7ZmKsAGtns5hO8 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEdDNFY2eFo3ZlRKL3lHUmNVWFZId1pzV3RXSVM2bzNwc2RuWHdRbWkyZ0h3?= =?utf-8?B?N2Zuc0hyZnVnSlNia01vN0tKQzhaeG8xbzNGaHRuVmdZWkFVckVOTWZHSFBO?= =?utf-8?B?emlIRTBGWFpmdUtMOE00ZmcrR0RxVThnVTdEVnhRTWpUYTFERVhMdFIyUkti?= =?utf-8?B?UTlMWHZWWGo5Z2hiNVI4MjZnSkgxZVQ4R3dQcUl6dTh1N3BNdHd1RDFUUkdS?= =?utf-8?B?Q2ptcG9ZVStQTnBkcW0rcDNNTEpIL0V0L2ZuYjhmSkxiNmFrOVRLNXY0bDZV?= =?utf-8?B?c1BhLzNKeXRNNERieE5aS0FLZlZIS1ZQSXFnVzQzc215WFFUcGhMU2x4T2tZ?= =?utf-8?B?RzRQbmNTT2dUTEdvMFh4T2JlM2FpcUtpaWFvWFBXZ255UWZiSVZNcno0NVQv?= =?utf-8?B?UE5XdE5rdHdtT1h5dmJNU053TFpVbDJEbWRZb3ljVkNzMzNQQkVHVXRnOC9z?= =?utf-8?B?WTRNOERYVFA5cDNpOXNocG5LeWhhV0h0cXZvZmxFN25scFdyQVZBaXkzNG0y?= =?utf-8?B?T01kUGZHNmZiMDM4RFBicDdSNEJSM2FFMk1EbWZZQ0RkS3RXVTVVdHVvZUJo?= =?utf-8?B?RmpJWkd6VndBUFg3L3k0WUgwdFVKS0c4SnA0ODBLbjZKNzBqclIzcDlQQ09s?= =?utf-8?B?KzBkQmxrL0VIY3ZTUi9YMXFxaEpmU05hSXFpMVp5dHRnQXVMNUQ1MUV0U1dr?= =?utf-8?B?SEFnWEliR0RPQy9lY3VVTlRwdFdXQjkyMkR3eVNqYllKa1hGWGxKYjZKS2NF?= =?utf-8?B?VzQrNlE0enlrQ2xJK1Fqb3lwYkw2dVU2Y2lDbytucDl5MG02Sk4vNkZiR0FI?= =?utf-8?B?bFppdVNOV3dyOThxS1JNYnlWZWtDakVuTHp2bXFXSjU3OUNWc1BiVTBTaW94?= =?utf-8?B?L3ZKYWdwWVhIQ0FzTEU0RzNXSncxZFRiNC9BbzgzZXgwRlZaeS93aWRaRE5D?= =?utf-8?B?d0dDQS9ZNzk2ciszMElIbE1hTjZ0NlBpZjd1MkdBWkJSeno2M01peUNoc0FS?= =?utf-8?B?RXdxK1Q5eXpRakN1Y3ZFK212SDFTRXNJbXJhZFQ4MHhZRG5OdUp0QzBUdCtI?= =?utf-8?B?NXllOTloV3JwOVpLT3djblBUczU1ekpwZzBFdk1SVkR4dVdhL3lmYkJHaFRM?= =?utf-8?B?QmhWa0ZyZkVlcDBHRUlSV2F4ek01aW5QOStiOEdoMFhtME1kZnRsWi9NSFU1?= =?utf-8?B?TXFPRnYxdE9iVE9YTEdxSU1FWVRVMlhKZy9mS2tXeXNHREFYblRnWExxZjdo?= =?utf-8?B?dzlpS0ZXVUxMaXY5TG8weDBVdE9RY2tDbDF5N1MwVlRwNW52ak8vVFdjWTE0?= =?utf-8?B?eFB4MTZBTFhxZ01qNzc1UjlXaDVaK1Z3cWtCLzRhbDZrbXFndS9YWlIvV1Fv?= =?utf-8?B?b1VMU3RzUVJJQXN1RHRLMzFwSnNuNjhabUdFSVNzWVRwZHdNZW9MVU1ML1dT?= =?utf-8?B?aVQyMlFHZTc0WS9CRGY2R2FqVkN4Ukx3YjByTUtmVDM0em5RSDRQMi9NRGtV?= =?utf-8?B?VzB3VmMra1lVSVMwUE0rNjVna3NIYWhQS1JScEVnWDFEMDBUSUs1Q1k1b1Ar?= =?utf-8?B?dHlKUXFJNVA0eTJ4anUweThmZjU2WW1uT0ZXdUk0M3dsUGM2MDR3bmhoYTJw?= =?utf-8?B?OE9wSzRmL2NwSlFxdnUvclg3ZTh5SDBPcHo2Y1hOdkhpMUdja05pUE4vNXpG?= =?utf-8?B?N0w0TWVFbDVZV3RrRWNDOFVRQzZUQ2RiNy9oMjFFdENOV29SbnhDRmJ3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc2dd7d3-4735-474a-41c9-08dc6ea7d814 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:10:34.6610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0119 Subject: Re: [FFmpeg-devel] [PATCH 3/3] x86/blockdsp: add sse2 and avx2 versions of fill_block_tab X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > Signed-off-by: James Almer > --- > libavcodec/x86/blockdsp.asm | 33 +++++++++++++++++++++++++++++++++ > libavcodec/x86/blockdsp_init.c | 13 +++++++++++++ > 2 files changed, 46 insertions(+) > > diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm > index e380308d4a..cccc9a801a 100644 > --- a/libavcodec/x86/blockdsp.asm > +++ b/libavcodec/x86/blockdsp.asm > @@ -80,3 +80,36 @@ INIT_XMM sse > CLEAR_BLOCKS 1 > INIT_YMM avx > CLEAR_BLOCKS 1 > + > +;----------------------------------------- > +; void ff_fill_block_tab_%1(uint8_t *block, uint8_t value, > +; ptrdiff_t line_size, int h); > +;----------------------------------------- > +%macro FILL_BLOCK_TAB 2 > +cglobal fill_block_tab_%1, 4, 5, 1, block, value, stride, h, stride3 > + lea stride3q, [strideq + strideq * 2] > +%if cpuflag(avx2) > + movd m0, valued > + vpbroadcastb m0, m0 > +%else > + SPLATB_REG m0, value, x > +%endif > +.loop: > + mov%2 [blockq], m0 > + mov%2 [blockq + strideq], m0 > + mov%2 [blockq + strideq * 2], m0 > + mov%2 [blockq + stride3q], m0 > + lea blockq, [blockq + strideq * 4] > + sub hd, 4 > + jg .loop > + RET > +%endmacro > + > +INIT_XMM sse2 > +FILL_BLOCK_TAB 8, q > +FILL_BLOCK_TAB 16, a > +%if HAVE_AVX2_EXTERNAL > +INIT_XMM avx2 > +FILL_BLOCK_TAB 8, q > +FILL_BLOCK_TAB 16, a > +%endif > diff --git a/libavcodec/x86/blockdsp_init.c b/libavcodec/x86/blockdsp_init.c > index 996124114f..37f3bb6a84 100644 > --- a/libavcodec/x86/blockdsp_init.c > +++ b/libavcodec/x86/blockdsp_init.c > @@ -29,6 +29,11 @@ void ff_clear_block_avx(int16_t *block); > void ff_clear_blocks_sse(int16_t *blocks); > void ff_clear_blocks_avx(int16_t *blocks); > > +void ff_fill_block_tab_16_sse2(uint8_t *block, uint8_t value, ptrdiff_t line_size, int h); > +void ff_fill_block_tab_8_sse2(uint8_t *block, uint8_t value, ptrdiff_t line_size, int h); > +void ff_fill_block_tab_16_avx2(uint8_t *block, uint8_t value, ptrdiff_t line_size, int h); > +void ff_fill_block_tab_8_avx2(uint8_t *block, uint8_t value, ptrdiff_t line_size, int h); > + > av_cold void ff_blockdsp_init_x86(BlockDSPContext *c) > { > #if HAVE_X86ASM > @@ -38,9 +43,17 @@ av_cold void ff_blockdsp_init_x86(BlockDSPContext *c) > c->clear_block = ff_clear_block_sse; > c->clear_blocks = ff_clear_blocks_sse; > } > + if (EXTERNAL_SSE2(cpu_flags)) { > + c->fill_block_tab[0] = ff_fill_block_tab_16_sse2; > + c->fill_block_tab[1] = ff_fill_block_tab_8_sse2; > + } > if (EXTERNAL_AVX_FAST(cpu_flags)) { > c->clear_block = ff_clear_block_avx; > c->clear_blocks = ff_clear_blocks_avx; > } > + if (EXTERNAL_AVX2(cpu_flags)) { > + c->fill_block_tab[0] = ff_fill_block_tab_16_avx2; > + c->fill_block_tab[1] = ff_fill_block_tab_8_avx2; > + } > #endif /* HAVE_X86ASM */ > } Benchmarks? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".