From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 00/47] avcodec/mpeg4videodec: Don't zero blocks twice
Date: Fri, 20 Jun 2025 17:11:27 +0200
Message-ID: <GV1P250MB07379951A8B396DCBD3C7B228F7CA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <pull.98.ffstaging.FFmpeg.1750006478.ffmpegagent@gmail.com>
ffmpegagent:
> This patchset is a mix of mpegvideo-related patches. The second half
> (beginning with avcodec/ituh263dec: Simplify AIC handling) mostly has a
> theme, namely improving dc_val and ac_val handling in mpegvideo. The first
> is just other stuff which I found while investigating the latter.
>
> Andreas Rheinhardt (47):
> avcodec/mpeg4videodec: Don't zero blocks twice
> avcodec/rv10: Perform RV20 initialization during init
> avcodec/rv10: Perform RV20 check only for RV20
> avcodec/ituh263dec: Don't process unnecessarily many coefficients
> avcodec/ituh263dec: Remove redundant store
> avcodec/ituh263enc: Don't use array unnecessarily
> avcodec/ituh263enc: Fix indentation
> avcodec/mpeg12dec: Don't store block_last_index unnecessarily
> avcodec/rv10: Avoid indirection when reading VLC codes
> avcodec/mpeg_er: Mark ff_mpeg_er_init() as av_cold
> avcodec/mpegvideo_enc: Remove always-true branch
> avcodec/motion_est: Fix indentation
> avcodec/svq1enc: Don't free scratchbuf upon error
> avcodec/svq1enc: Allocate motion_val{8,16} during init
> avcodec/svq1enc: Stop calling ff_mpv_common_init()
> avcodec/svq1enc: Remove write-only c_block_{width,height}
> avcodec/svq1enc: Set MpegEncContext.avctx only once
> avcodec/svq1enc: Don't initialize unneeded block_index
> configure: Factor mpegvideoencdsp out of mpegvideoenc
> configure: Relax svq1enc->mpegvideoenc dependency
> configure: Relax diracdec->mpegvideoenc dependency
> configure: Relax snowenc->mpegvideoenc dependency
> avcodec/mpegvideo: Don't reset thread_context ptrs unnecessarily
> avcodec/mpegvideo: Don't zero unnecessarily
> avcodec/mpegvideo: Defer init of enc slice ctxs in
> ff_mpv_common_init()
> avcodec/mpegvideo_enc: Simplify allocating non-slice buffers
> avcodec/ituh263dec: Simplify AIC handling
> avcodec/ituh263enc: Simplify AIC handling
> avcodec/flvenc: Combine writing bits
> avcodec/flvenc: Move ff_flv2_encode_ac_esc() to ituh263enc.c
> avcodec/mpegvideo: Redo resetting intra table entry
> avcodec/mpegvideo: Avoid {a,d}c_val[{1,2}]
> avcodec/mpegvideo: Provide alignment hint to compiler
> avcodec/mpegvideo: Don't reset AC values of upper-left luma block
> avcodec/mpegvideo: Combine stores
> avcodec/mpeg4video: Don't use ac_val[1], ac_val[2] when cleaning
> buffers
> avcodec/mpegvideo: Only use a single ac_val pointer
> avcodec/mpegvideo: Allocate ac_val jointly
> avcodec/mpegvideo: Zero-init mbintra_table
> avcodec/mpegvideo: Only keep MpegEncContext.dc_val[0]
> avcodec/vc1: Only keep mb_type[0]
> avcodec/mpegvideo: Allocate dc_val for each encoder slice
> avcodec/{ituh263,mpeg4video}enc: Simplify out-of-slice DC prediction
> avcodec/mpeg4video: Move ff_mpeg4_pred_dc() to decoder
> avcodec/ituh263enc: Simplify encoding umotion vectors
> avcodec/mpegvideo: Reduce stack usage when copying MpegEncContext
> avcodec/mpeg4videoenc: Fix data race when using AC prediction
>
> configure | 9 +-
> libavcodec/Makefile | 9 +-
> libavcodec/aarch64/Makefile | 4 +-
> libavcodec/arm/Makefile | 4 +-
> libavcodec/flvenc.c | 19 ----
> libavcodec/flvenc.h | 4 -
> libavcodec/h263.c | 5 +-
> libavcodec/h263.h | 8 ++
> libavcodec/h263dec.c | 3 +-
> libavcodec/h263enc.h | 1 +
> libavcodec/ituh263dec.c | 47 ++++-----
> libavcodec/ituh263enc.c | 181 ++++++++++++++++++-----------------
> libavcodec/mathops.h | 1 +
> libavcodec/mathtables.c | 39 ++++++++
> libavcodec/me_cmp.c | 36 -------
> libavcodec/me_cmp.h | 5 -
> libavcodec/mips/Makefile | 6 +-
> libavcodec/motion_est.c | 180 +++++++++++++++++-----------------
> libavcodec/mpeg12.c | 4 +-
> libavcodec/mpeg12dec.c | 3 -
> libavcodec/mpeg4video.c | 13 ++-
> libavcodec/mpeg4video.h | 45 ---------
> libavcodec/mpeg4videodec.c | 65 ++++++++++---
> libavcodec/mpeg4videoenc.c | 40 +++++++-
> libavcodec/mpeg_er.c | 10 +-
> libavcodec/mpegvideo.c | 155 +++++++++++++++---------------
> libavcodec/mpegvideo.h | 4 +-
> libavcodec/mpegvideo_enc.c | 179 +++++++++++++++++++---------------
> libavcodec/mpegvideoencdsp.c | 2 +-
> libavcodec/msmpeg4.c | 3 +-
> libavcodec/ppc/Makefile | 2 +-
> libavcodec/riscv/Makefile | 4 +-
> libavcodec/rv10.c | 53 +++++-----
> libavcodec/svq1enc.c | 65 ++++---------
> libavcodec/vc1.h | 2 +-
> libavcodec/vc1_block.c | 138 +++++++++++++-------------
> libavcodec/vc1_loopfilter.c | 10 +-
> libavcodec/vc1_mc.c | 8 +-
> libavcodec/vc1_pred.c | 14 +--
> libavcodec/vc1dec.c | 4 +-
> libavcodec/x86/Makefile | 6 +-
> tests/checkasm/Makefile | 2 +-
> tests/checkasm/checkasm.c | 2 +-
> 43 files changed, 697 insertions(+), 697 deletions(-)
>
Will apply this patchset tomorrow unless there are objections.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-06-20 15:11 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 16:53 ffmpegagent
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 01/47] " Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 02/47] avcodec/rv10: Perform RV20 initialization during init Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 03/47] avcodec/rv10: Perform RV20 check only for RV20 Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 04/47] avcodec/ituh263dec: Don't process unnecessarily many coefficients Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 05/47] avcodec/ituh263dec: Remove redundant store Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 06/47] avcodec/ituh263enc: Don't use array unnecessarily Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 07/47] avcodec/ituh263enc: Fix indentation Andreas Rheinhardt
2025-06-15 16:53 ` [FFmpeg-devel] [PATCH 08/47] avcodec/mpeg12dec: Don't store block_last_index unnecessarily Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 09/47] avcodec/rv10: Avoid indirection when reading VLC codes Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 10/47] avcodec/mpeg_er: Mark ff_mpeg_er_init() as av_cold Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 11/47] avcodec/mpegvideo_enc: Remove always-true branch Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 12/47] avcodec/motion_est: Fix indentation Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 13/47] avcodec/svq1enc: Don't free scratchbuf upon error Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 14/47] avcodec/svq1enc: Allocate motion_val{8, 16} during init Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 15/47] avcodec/svq1enc: Stop calling ff_mpv_common_init() Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 16/47] avcodec/svq1enc: Remove write-only c_block_{width, height} Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 17/47] avcodec/svq1enc: Set MpegEncContext.avctx only once Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 18/47] avcodec/svq1enc: Don't initialize unneeded block_index Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 19/47] configure: Factor mpegvideoencdsp out of mpegvideoenc Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 20/47] configure: Relax svq1enc->mpegvideoenc dependency Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 21/47] configure: Relax diracdec->mpegvideoenc dependency Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 22/47] configure: Relax snowenc->mpegvideoenc dependency Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 23/47] avcodec/mpegvideo: Don't reset thread_context ptrs unnecessarily Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 24/47] avcodec/mpegvideo: Don't zero unnecessarily Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 25/47] avcodec/mpegvideo: Defer init of enc slice ctxs in ff_mpv_common_init() Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 26/47] avcodec/mpegvideo_enc: Simplify allocating non-slice buffers Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 27/47] avcodec/ituh263dec: Simplify AIC handling Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 28/47] avcodec/ituh263enc: " Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 29/47] avcodec/flvenc: Combine writing bits Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 30/47] avcodec/flvenc: Move ff_flv2_encode_ac_esc() to ituh263enc.c Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 31/47] avcodec/mpegvideo: Redo resetting intra table entry Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 32/47] avcodec/mpegvideo: Avoid {a, d}c_val[{1, 2}] Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 33/47] avcodec/mpegvideo: Provide alignment hint to compiler Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 34/47] avcodec/mpegvideo: Don't reset AC values of upper-left luma block Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 35/47] avcodec/mpegvideo: Combine stores Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 36/47] avcodec/mpeg4video: Don't use ac_val[1], ac_val[2] when cleaning buffers Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 37/47] avcodec/mpegvideo: Only use a single ac_val pointer Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 38/47] avcodec/mpegvideo: Allocate ac_val jointly Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 39/47] avcodec/mpegvideo: Zero-init mbintra_table Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 40/47] avcodec/mpegvideo: Only keep MpegEncContext.dc_val[0] Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 41/47] avcodec/vc1: Only keep mb_type[0] Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 42/47] avcodec/mpegvideo: Allocate dc_val for each encoder slice Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 43/47] avcodec/{ituh263, mpeg4video}enc: Simplify out-of-slice DC prediction Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 44/47] avcodec/mpeg4video: Move ff_mpeg4_pred_dc() to decoder Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 45/47] avcodec/ituh263enc: Simplify encoding umotion vectors Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 46/47] avcodec/mpegvideo: Reduce stack usage when copying MpegEncContext Andreas Rheinhardt
2025-06-15 16:54 ` [FFmpeg-devel] [PATCH 47/47] avcodec/mpeg4videoenc: Fix data race when using AC prediction Andreas Rheinhardt
2025-06-20 15:11 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07379951A8B396DCBD3C7B228F7CA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git