From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2E6034AE71 for ; Wed, 22 May 2024 09:12:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BECB68D40C; Wed, 22 May 2024 12:12:22 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2109.outbound.protection.outlook.com [40.92.75.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A4ABA68D3DF for ; Wed, 22 May 2024 12:12:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TA6IKUJctBm2CqM1sh8/0Fdy4OxlaTmgv3OPR3nbai2Q84fw3j/J5/eVwF0MOWTjR1caSBxLzzLQ3/xE39ACni48iTq4X+gOKKTsNdcf6l/XcVVgpkyGykzU2P984VDTLi0GlwFXvZG4QV4kxj2xEQ/YjtGX7ieJE4LImSWCPlbnoj5/5jX7GSS6zsq3altAXHkfjXo6jQbHno2HXYEunNjCJBITrAL9cvngBtWAPFJdO/6pQwBRlkAgLGGbK9bXC3uEr9FifvNZ1J1iqlhg5K4gh0mf+9x2mRCpltTQzwPYTsv4HLPwSieAvR38YLlHA4J+1rhQI/VYvWahfPnINw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8SN2rZuyxoELsGa9XxTEWlMDBW5Uyfl3Wdu6pgl5t8Q=; b=TgNWGfavsFRJ0dUCtXqS4yaVUKxKZ833pJAFMVYwcmAYVc5xNm0cY7Zr5GUmGoO9++sEts9RL1GixcaRReovrqJH1v2XBv4RGK7gEk1LkdV6yB87l5VRJB7I3gu9ve04jnGEOG4pPNpMzbZOJXKyROa0pxct2DyZVHFQm+xX2khX6NKpI6JUnMATwduWV7lkWMgEreure2+brW88GwRh2YD5op5k6n7suRRNuXZ8ypgmEAMDx++QD5kkrfnRkBX6upsedHHxJwcILVM4robfWzxdUhaoeN6nQzc4m2i39m65EXbkH9j62Kecbijzujlr+QiwNy2j4Ce135JB5fqW8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8SN2rZuyxoELsGa9XxTEWlMDBW5Uyfl3Wdu6pgl5t8Q=; b=NfJqU83fzJ8F6H3oyr9uWqV2+YTHtqsx1wFnpc1BO6S34aIbUzOpyC9vatdJ25cFCmSy+wkIGukJdl27SlceHJlHLbv4b+j8Ti0/UsL2OW4ONPvl2wQu6Pt9mPyHuym8l9fTCAm1Ume+9DULUNLyvAMnpjXKy7xZPxni9EoA+0MRsjbAZAYn/xjPeP+XtWpr0Jap00/JB0mAgrJbJeg9qFcnQWJ7QwGltIXD6Zn+bvGnuv1OrQQtO1kCLs0WO/QUqsIwwrqWU4ZKH23I5QI9bNxZL0DMlCsGpJC7M1FySlLsVSyEEWxDumcRu1LOdXEyQSuqV1NUmvAWSIsWIe2TSg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0020.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3db::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.19; Wed, 22 May 2024 09:12:15 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Wed, 22 May 2024 09:12:15 +0000 Message-ID: Date: Wed, 22 May 2024 11:12:12 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240522090513.55806-1-post@frankplowman.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240522090513.55806-1-post@frankplowman.com> X-TMN: [PDgrjJhir7AmbgUYXB7M7feHuObLGj4vhXtxEue17v8=] X-ClientProxiedBy: ZR2P278CA0028.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0020:EE_ X-MS-Office365-Filtering-Correlation-Id: 03931874-184b-4fe8-7f65-08dc7a3f458e X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|56899024|3412199016|440099019; X-Microsoft-Antispam-Message-Info: 8hzTnhWyoy7v5dmO8veHdo0Zj81ru+PXOBoG4N7UWgr7Rwtbhi1LJ0hm56tE/LgsX1yeSanSYsXLblpYe+bKx25kKDMQCMWGv4CwhexQHsa4U1iR32sUGaCab8diznrQN4eoam5bZVvFNen+IK1La370OPWJKiAobuBcRJuRvIBPIM//P4Khn3F7zR3/33Y8DxJebSgqBg3eYHpfr5S/q0lzfmoqhv9KMsGJd19eUP54K7I4n3fb+w/fB2R8SDkCwEfAOM5C/CpMLnoztUlGuxUCepBNx8zfuldaWIVkpa+kFo9d0SZrSC7wj1Us522bU0lDEThuJnCGG8kqNY0tXa0g1EjlHFXA3W5qIgSS/d7E482Npp08zLyEzun3AIg4P5I8JC0DIt4KsTAIf7AAtd4Qb2g6tlZvlVd6jsqDSIEZxynNS/EtLMumJmUqsADz2lz1PSP1q6le6LsJmZuSY8ghkxBVHGT0W5ueySLHx1eAnLg10TTb6nXNb42zF0BKmZPG9csLXULL8gXe1mAsj2I0aaLNa5EQsrf0Cex3mF8jFSb1h/gmG+7g8H60Hakd X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjgyNHpOU1lxTWlDbUx2QjhhNVZwdm5lallMZ3pKQTZpQ0hiakQ4U3dFdlZC?= =?utf-8?B?WllWZVczTHlodC9sN01wN1dIYXlZT3JDZ1Q4YkFDK2hTQUM4S3AvS0s1V0h1?= =?utf-8?B?V2xmNUVCYkhqMU9GaUxXZk1TTDRKVy9wVm9xc05PR1dDK1Zpa0R0T3VRcnNz?= =?utf-8?B?RVlyY05LVDIzK3A1Z0hWUHJwcytvYlViaUJIL3I4ZjFuejN6dUtYaFR3dnRr?= =?utf-8?B?YVVxazBoZVlvNlhMYTJXWTQ2ZWJ1RjNqVnY3US91SkttMlEvNFFVNkcxcTZu?= =?utf-8?B?SFFGRWQ3K2QzaGNFWFUxSXc0NnkwY0o2YUVhZlIyTG1WMXI1aTlxNE9DY01s?= =?utf-8?B?K09TSFB4a01yc2l1blM2Snk5ZTl6VFpKdEV3OUVtTVg1b2g4WGl1Z1BiVUt1?= =?utf-8?B?dkExN2psYWkreUphVFNJSS9KSHRReDVacXZJRDJTaGpBODFZUzEzdlFBWVFR?= =?utf-8?B?bkZnaE96N3lPL3poTSsxSmZMUHNCakdBMTlEOWJPRVN1b1RJQU0zNnhCN0Zo?= =?utf-8?B?QWlzWmlPWnQwVXBpWi9nM2x2L1BZWmlpU2JsV1I5aHQvbWlHa1JyQzRmeEdo?= =?utf-8?B?L0xDNll0WXY4VkQvVVNTdytoeWpsNkFmd1dkQjVuajhDNURaamg0RTUwZ2JB?= =?utf-8?B?NWFJQjVLTVVBT25IMlhJTFowbXlNRmxmN1ZHbHVpT1FCL2k3eEZ6MXBQU09t?= =?utf-8?B?MHIweEZVV2VEb0MzRUJlT1gyUGs2TnRJYk9YblhaMDNYZ3kwM0UrSlMzZXM0?= =?utf-8?B?U1RTTlJoNUhZcFFEUktpejh4Um1MdWhxK2RIenU0bThnQ2hYQnZJZytmSGNq?= =?utf-8?B?RjFLbmdpMmdGcWVkZkUxM3Z4S2ZMZDNWbWhMVlRoUXNiK0prc2lMWmQ4MERm?= =?utf-8?B?aUwxTnJyaHNRWXQ0eHpHTjN4SzVmYTN2WkowcmEzMVdrdFZmSkZkTFRVUjMy?= =?utf-8?B?TEV3Vk53MFhhRG9PUFc4QlVmeUlGQkVuU1p5MnRxY2ozUXZEdEl0SmdVMkcr?= =?utf-8?B?b00vamNkc0pUa1JlWnFabkZQU1FqY2UxaWpRMUNpeFZpRzB0MDJ5SGRBdWwx?= =?utf-8?B?cm0vWEx0OXpHYnB1Y1lVL0swK0tINlkwc3piWkd4ek9qQzBVbVpiNnZ4Z2R6?= =?utf-8?B?MEZCckhoNnJRZ21YZkZTeU10UEw0cC9Sa0JFYnArZmVpUXFRb25TMFBPT2dQ?= =?utf-8?B?Nm15aGp4elBTY1I3ZE1CaDMrQ3BaZCsvMXgwY0w5Ykh2ci9qYnJQNFkya3Fr?= =?utf-8?B?UWwrMGgrbUVpeGhiYUE0TkhiL3BwdzlVVncrc0dxSEgwZU1MYWxmT0w4T1N4?= =?utf-8?B?MTlSUW1tWDJwTThSck9XUTdFYjI0V1dibkVSWHVFeVVOWkJ1SmtHZFQ0RHhF?= =?utf-8?B?ZzZ2dllSV2hTaXpsNW1xL0I1T0xhN2pKSWptanlHRlQva0ZsNGNmeTlHZU9a?= =?utf-8?B?TDBjcVpTL2E2QmZxdEs3YTlzeDhId0VIREZQSE0zNXNqbEZ4YVNJVzdkOSt5?= =?utf-8?B?Z0JaWHR5SEd6Y2YvT3JGM3pxZUp1bXB3Qm9WU1VMU283enJkOS9SM2d5SUVl?= =?utf-8?B?Zk1lZW4xb3hTTStsZzIrRWhGZTVnWHVWSlVNR0RJOE5kUkM0TlJVSTVOT0c0?= =?utf-8?B?ZUNzamlzcjRWYjZwV3orQW9SdW9MMVlGNGdZSThmVEgya0hTaVhHUGhGNzlK?= =?utf-8?B?V1g5T05TWjZqekxTM1ZnMW0rK0tGME5KV0p1SDZWYUgvMDhiY2JhOUhRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03931874-184b-4fe8-7f65-08dc7a3f458e X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 09:12:15.0887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0020 Subject: Re: [FFmpeg-devel] [PATCH v2] lavf/dash: Forward strict flag to component demuxers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Frank Plowman: > Before the patch, opening a DASH file containing streams which require > experimental decoders was problematic. No matter where the -strict -2 > was put on the command line, the option was not passed to the demuxer > for that component. This resulted in an error, prompting the user to > add the -strict -2 flag, which is already present. Decoding appeared to > continue correctly however. > > Patch removes the error message by creating an options object for the > demuxer created for the component, which inherits from the parent > demuxer. > > Signed-off-by: Frank Plowman > --- > Changes since v1: Use nb_streams stream_info_opts, not just one. > > libavformat/dashdec.c | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 555e21bf69..9c5ef5801a 100644 > --- a/libavformat/dashdec.c > +++ b/libavformat/dashdec.c > @@ -1911,13 +1911,28 @@ static int reopen_demux_for_component(AVFormatContext *s, struct representation > if (ret < 0) > goto fail; > if (pls->n_fragments) { > + AVDictionary **stream_info_opts; > + > + stream_info_opts = av_calloc(pls->ctx->nb_streams, sizeof(*stream_info_opts)); > + if (!stream_info_opts) > + goto fail; Presumably you should set ret here. > + > #if FF_API_R_FRAME_RATE > if (pls->framerate.den) { > - for (i = 0; i < pls->ctx->nb_streams; i++) > + for (i = 0; i < pls->ctx->nb_streams; i++) { > pls->ctx->streams[i]->r_frame_rate = pls->framerate; > + av_dict_set_int(&stream_info_opts[i], "strict", s->strict_std_compliance, 0); You are setting this in a loop intended to be removed; and one that is furthermore only executed under certain conditions. This is surely not what you intended. > + } > + > } > #endif > - ret = avformat_find_stream_info(pls->ctx, NULL); > + > + ret = avformat_find_stream_info(pls->ctx, stream_info_opts); > + > + for (i = 0; i < pls->ctx->nb_streams; i++) We prefer loop-based iterators nowadays. > + av_dict_free(&stream_info_opts[i]); > + av_dict_free(stream_info_opts); This is the wrong deallocator; stream_info_opts will leak. > + > if (ret < 0) > goto fail; > } Apart from that my comment about using AVFormatContext.stridt_std_compliance still applies. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".