From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 888284E0F6 for ; Sun, 27 Apr 2025 20:48:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EEEE468B407; Sun, 27 Apr 2025 23:48:52 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2031.outbound.protection.outlook.com [40.92.91.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B390268812C for ; Sun, 27 Apr 2025 23:48:46 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gduWDnCSu7YdPPqHInHlsSxM+A7ynKk8JZpFpTRFKNxPi4JoMgG98H0zk6FARzrL9bMzcyYM0vACLmn7qZaV/3HYjy1lMumHnB4u269WEizHs84T7V9JbPQFdtw7Y7KB3gTr0NI0/sBUYTy94t6lDTjdRMgs8PDNyWrpRFR+CPziQyQnPFA0jzxpkg3/FfP+NVsxCL9djVZgXA99LZc2yR6btZLmR5e9q+R7YQZAmjjdKvO3vujrKoSVFWRkkN0J1slZX7ku9AsiURT45xj8A4ufs2HzyIIFmLjkhFvAs/wEU8nM6TYP1hAuNFb9rxAWyDiwEypwYCwrO47hN9k7bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hwK1g5RN9A0f8rU+gUyVcYSYWeugNgJZesTx5CSAURI=; b=ZpgIl/+r1S37SAivXyrH+vID72lHqV8BsZqvwzaekJQbzamCosUr4xWKD0iFzvkcBP0cC6kkw06/zRHvUrVsoMxhwfmYXDv3vMEc3TsD542VZ7e1r9G1AMMzuw4AEh306L+YMmu6v0BzDqKNMf8rd32IsTZc6rSeVHnmbL6a+LN0Z0w/XMPSPVhx731nGJz1NsjG/UZOYHXKMo2cVxZ9iUIH9i7xd59MszppcTFCAFu7SHe0qVQp5ExKBpBUeYbu0vDIJpJv9YkK8rmm5P2/4guk+fwUYdQbCcTz8Q4PgxDqtwh011r792+14OBHwxye076kvZZOV65ybjLOQw7hPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hwK1g5RN9A0f8rU+gUyVcYSYWeugNgJZesTx5CSAURI=; b=hh84l1gZTnJREcnQmt36iXrGA6yZFwJLAA7+VlOEOaMYscXXPAVDu2oVEb8qd9jMl/b6q8AyAMghimkPBj9OJCRRw+DS0wputVYQDCcd/BxA+SIGDfnZ4Efo24CjWXl7582iS6Wpsgl9LFXL46HrUyta8juUbxeEFz9yX3b9EVtBkZYqLYWVg4W/kajYf457qW0frVvoNJAtfKY/uHKyFkWtRaIzuyXEQ0pbb3BD+Vf/cUdyRMZydsblcgNTq/fVf7zDYIRqHItjkmnJKUY96nD00ws67DHbckdZQREdGgPmzokI86nE2tP/h7QppBvRemRLxqzCy6JIbbjjGTkWLQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS1P250MB0431.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4a8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.31; Sun, 27 Apr 2025 20:48:45 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8678.028; Sun, 27 Apr 2025 20:48:44 +0000 Message-ID: Date: Sun, 27 Apr 2025 22:48:43 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: FR4P281CA0392.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cf::17) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <475409ad-7ce3-4f44-9e07-71087eb3a7dc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS1P250MB0431:EE_ X-MS-Office365-Filtering-Correlation-Id: 2788dec9-3d47-40ae-68d1-08dd85cce69f X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799006|461199028|19110799003|7092599003|5072599009|8060799006|6090799003|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YVhFMU92VExYMW8vL3FQeFlkUG5kTkU5akgrOW85U0hBYUtMTVllQlNWaFRo?= =?utf-8?B?djV4QmtHb2xmUlBYbzQrN0ZXRGJXV0lLRUJ4YXZuUTh0Ni9SWFM1dU5KNXo5?= =?utf-8?B?a2FuUVpoOXpabXArUkEwbjNzOFRiQ1hQSUp0Tmx4VWpZOWdpZmg1WWFGMW1I?= =?utf-8?B?Ym1ZdXVock5VSGp6V1lqNC9PMFNNekYrMGozUWZZZE5hMThBdkdyekZrc01a?= =?utf-8?B?MTdGNks4QTNFU1R4Y3hOUi91SWpYKzhZY2xUcFBwMk5WbnArYjl2aVNvNHhj?= =?utf-8?B?WVhvc2ZZTDNadWZma0tBVkQwR1h0WmY2MUlZYnRnV3VCc1RqRmx2K0pBRHVE?= =?utf-8?B?dnUrekNXYk5EQWZueWhHYlZnYnZ6Wnkva3dOVW1CLzdlV0NJK2xQaHJnYzFl?= =?utf-8?B?NEErcVVhVnZod1U4TWh5RmJINHV5d3BwTnF3V0t1REQ3VUtDNm51QjJwNEd4?= =?utf-8?B?c3dGNy8vaG16SWE0VzVwdk9XUnh1Q0FKZXVMR1R2UnVzcERvM3ZDT1dCNjV6?= =?utf-8?B?ZXpRWVFuR3VyQWxGM0dvcGsrdlU0eGxZUkQwU0haeVBEelg2THZGZ2grQnMz?= =?utf-8?B?SFdUR1haak1pWHZNV29pdWtEdXgzNlc3dVlxU2hkbkVNRmgwUXhab3VmVXFu?= =?utf-8?B?QVBOdDJXWGs1NHp4Tzh4V3JDbFR5dUNkbnJscHZrTXZLTDB6WkN6ZE0xN0Vz?= =?utf-8?B?em9BQnpDcnZoZU1NdE9mb28vMjFMbWtraURBbW9OdmQ2MTV2eEk1R3RTN1RN?= =?utf-8?B?NHhkRTNSbXd1STkwUS85TmwxTHpwV2pUOXZzMTFIVUVmZEViTXhwRmpiVWRo?= =?utf-8?B?c25EMElGZkJXVUFIVGJ0ZCtrWUl0N1UxMTQ3Q0VBTnBmcUtDY1J4bDNjaHR4?= =?utf-8?B?cWZYMXNGUFRTUlRLTGZZR3dZSDc0ZzR5Y25vdzdwRENZbThaRTlMSDdTT0VV?= =?utf-8?B?NW1JK1Q4cVNpSUZCalRoalN4MXIyNTBWTkNQL1ZMcnZTcjFCZHhuUWdHWWR0?= =?utf-8?B?ZjFUWWhXajN5R08yOGNUQk9uTlZFVjhWekljQzFQRmpralNxemVTRmoySFhQ?= =?utf-8?B?b2hNc09MOEcyWFB2aUZCQkFaaVNVQURZazNUNVYzTzBrZkk5WHN3ZXhDMk1P?= =?utf-8?B?eGdUKzFhSysxQ3VTcDl0aVk3RW1HVjVPTUdIaDdRMkd1TktnRG4yZ01kN2dB?= =?utf-8?B?RThzdi82a00vYno2OEVRSzNERkcwUDV1UFRqUzROQkxmeUlGWXZwRmdsYjE2?= =?utf-8?B?Z29LYXdtV3dYOFBwaDhGNkJ5ZEN5Zk40Sm1OUHBXRmFPSEx3YnBZaEhzSzVy?= =?utf-8?B?aGNWRUdOalBmQmhiOWsyb1lHVElkTGRoeVBjL0w0QzNkbmRITDl5bEdmTDhs?= =?utf-8?B?Z2p3ZDJ4dGcyc3lVbGhLUlZTUjQvaGQvZ1BucFgvYW5yVGE2ckxKclQ2R0Y0?= =?utf-8?B?anpDUTlmdThqNjc0VFhBVTFKbWI5ZndWd0s3WXErL2d6Wk50Y25aLzFwa0xZ?= =?utf-8?B?cXBDUXRNRi96ODZNWnV5aEIya3hRbzloQkYzUEt5VmFoeUJQUG5CMnlibENX?= =?utf-8?B?SU5tUT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFkvaTNyLzZ6d2xsdFZKWWVxU0swNWtzUnc1MWdaZWp2dGJrN1BVK08zMWhu?= =?utf-8?B?ZW9wZHcvM2R1dnpYR0hZd0JPaWt2THVIczZiM0ZvTkZGWlloM3Fua3hnbnlY?= =?utf-8?B?M2dvQlF0TVdPdnMwazhXV2hHbmxnTjUxa1lLU211Y2ZsTUhqaHpTaEVNc3Nh?= =?utf-8?B?RzVncjZhQzBXd09qZjQvRm5maVR2TUFRYjZ0Q2U5ZjJqdjdKOEtwTC9ZK2xj?= =?utf-8?B?cWtvQ2FtMXdrazFaVmhKRnQ4S3UrcTJURHJ1Q21GZExQUkUzMWRxVnJqWjcr?= =?utf-8?B?bmI2cTZRL08ra21GZWJJSTIwMXd0MzEwTEZqVXlWVWFQYjlnVEtOdjJXdFNN?= =?utf-8?B?bG0xazlYTFZiN2h4dGxrbkFTSEJKM3JwOEZheU5RMDJ3VzBtQVEvV2FwOVZa?= =?utf-8?B?VVpLSHpWRWQ4RWFZSW15a2VzWFdndVAzaXRWY1FwMk1zVlZtU0phTG9hcWN0?= =?utf-8?B?dEVETkIzT0R5UDhHc3AwUnBSZi9jUGRzVzRmd3E4alRROUwzbEFkcmxBekxy?= =?utf-8?B?YmxOMUt2eDkyWkpXSVFQVDJHS1hib0hnQXNrakEvM2wzN0VCeDdBUVd3bTVH?= =?utf-8?B?eGtiZXhuekFvdUFvNkhvVW1Geis0TWNpcXFHTXhOOXpEZnArZ0U5ZUNDSXQ2?= =?utf-8?B?bDd3b2RXMitxd0xraUJVTHcvcmk5cXlWTVRQZWlNOXQyYS8rSWNZYitPZ0xM?= =?utf-8?B?NTNUbFZ6SFBUSm04LzRkWmRjUXFUWlJHSEwyOVBNNVdDTFlzTUZ3a0NWcW9Y?= =?utf-8?B?cU50eG5PcTFnNVZMT21nVjNSNkNKanFwYU1Va1I2WlV4ZG5pVWkxSjFjNklP?= =?utf-8?B?UTlKd1V1eisvMWZ3cU80NWlWVjRqUE5WaXBqS2tSMElybEMxWDdsTzhndGdh?= =?utf-8?B?MmdPZEliVDMybDUxcitYaWdmOTNUTFdhY0xmT05iRnQ4N0ZqSk5DRXJ5aHMz?= =?utf-8?B?RDRFM0tPM2NvY2V2QmFtRGQ0ZDNrb3kxZnRJVGRJQzFleXlvbk5jMEZxdVBa?= =?utf-8?B?akR2RllOaFU5eXYwZTk5OHgyN0pDSURuV2tVVFB3cm9ZVHpyRUw3Nnd5S2lq?= =?utf-8?B?SEV4d2xzNU5rSS8yWUN1ZFczbkpZQzdqK1VzODBtMXVlcDV3UnFzYTNVRWZx?= =?utf-8?B?ZlBkd3MxQTZIdnMwTEptSUhhcUdDbWJRSGlxbDJJSnhEMi9ZMTBHN2dWS0wx?= =?utf-8?B?M1lJZjZVclR6M05CMG1LMDMxcEFsaVo1V2o2cHdkMVpXako0Z0w2d3NCekhT?= =?utf-8?B?UjRKKzgzZCt3eEpXWnpZTjlQTzZkUmZ6UEFaSHRQV28wWWszZVZMNnNhTkdV?= =?utf-8?B?cTY2c2M5YWpsRTI4K1hWeTBnMER2MlU3VVRuS0RRL1cvVUl2b1NKb2dDUk5O?= =?utf-8?B?by9Ha29NM2psZDFMZFdIRm1DN2cxc1ZJWWN3ZnRIL01BZHJtY3RBVUZNZWMv?= =?utf-8?B?a0JhSlBNYUFFTVZIOS91R0F4cTVXNXA3Z1JDbkVzbmlRWHBSZlZOZnhYVkNC?= =?utf-8?B?aVowTkdFZFl4ZnlDYnBrMWx1NFJ3NHc2dTRVczdOTDFGNTF0ZXVSdkVqWWN6?= =?utf-8?B?UWVWRmQxdWZhUHhIdndqL2MvZ09LeHNaeWhyVnlXbjlXVURKZzRLVHE0STBQ?= =?utf-8?B?eUhzN2RsYmQrRjNIR1NFNjZUMXdoSy9yc3JwTGFlQ2s1aGtIMTd0L25KS0Fk?= =?utf-8?B?bFpmbVhGZVcycWtNQXJIaVBLKzVJRTFIeUluZ0N0UUNKaUgzd05pc1VsbGI3?= =?utf-8?B?RU9nN2E5UEFjVUJnTldwZGU1bzQ0TC9acmhiYWNCbGNWeFliYTNnUnNUUnhF?= =?utf-8?B?Q1Z2VjFuMjBVVit3a3RqZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2788dec9-3d47-40ae-68d1-08dd85cce69f X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2025 20:48:44.8235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0431 Subject: Re: [FFmpeg-devel] [PATCH 1/7] avformat/apvenc: Only allow APV X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Mark Thompson: > On 27/04/2025 19:42, Andreas Rheinhardt wrote: >> Patches attached. >> >> - Andreas > >> [PATCH 1/7] avformat/apvenc: Only allow APV > > Oops, sure. > >> [PATCH 2/7] avformat/apvenc: Remove unused header > > Sure. > >> [PATCH 3/7] avformat/apvdec: Use ffio_read_size() > > Is there a cleaner way to discard very short files without reading them? The minimum size of a valid is significantly larger than this, and an early failure would be nice rather than it get packetised and something later has to realise it's bad. There is avio_size(). But I know of no demuxer that uses it to discard small files. (What is the minimum size of a valid file?) > >> [PATCH 4/7] avformat/apvdec: Remove inappropriate flags > > What does the GENERIC_INDEX flag affect here? > With the flag set, the demux code adds index entries for keyframes based on AVPacket.pos. For this demuxer, AVPacket.pos points to the position of the signature, not of the access unit size field which is where the read_packet() code expects to be when called. So with the current code, seeking to an already encountered place will lead to an APV_SIGNATURE being mistaken for an access unit size. You can see this for yourself with ffmpeg -stream_loop 50 -i $(FATE_SUITE)/apv/profile_422-10.apv -c copy -f null - An alternative would be to decrement AVPacket.pos by four. > Currently mpv does successfully seek in a raw file (to already-seen places), but this may or may not be related. IIRC mpv caches a certain amount of data (in the form of AVPackets IIRC) in order to enable short seeks backwards and forwards from the current position. I don't think it calls the avformat seek functions for your seeks. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".