From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7F9F44A19D for ; Sat, 23 Mar 2024 13:21:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3AC8368D554; Sat, 23 Mar 2024 15:21:49 +0200 (EET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2044.outbound.protection.outlook.com [40.92.49.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0385468D4F8 for ; Sat, 23 Mar 2024 15:21:42 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kvdw3TRPazFi9y3nc2vnoZ602/9hpzgIUU4JqLJ9kvL4CvaYvWehewrndXQTBS3q+A1uiQbjoHvFzofXQgpVesmR3X2vxjr/2KjFxyEOpNmykBn+w0FHk1coicIAGrfEj3oMhLOWUBmI7QiSoIb1J9+doP5LWbaDb0OtABzyibU82s5NcMkD5lMHz1puQ0t/itwqn4rF+jNPgZ1hrlS8nZhHl+kiI70Y0jeA9CgKhxR3UjTDFcBmQjBX+nnlttex1jZUkM4k5dz2vvTn5NZRrgO657F8pweboDyBOngp8t9chcRI1qvY8fU0FjJXi0BnupoBlIMuqnEWyEqM+bOgKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O7eTwGinBXS47MqUZRYvZ/Qd3ALpIKwATN8zqMbxxBs=; b=acUlietQNag6scHGKv7p7JRQHegZPHI4nASFnzEiNOwa4C/856dKhyC1cDravYTEMZQ5eLP8PgWPxUXUk1lyXKMcFmPEJP+qTjulNeRted1mV7zYGjzwSFCUs464wZIKjkFZtUpClGVTW/P6CAKMWHqL+UZW1cioiY4TnS8sy2bYuz8L9OteNmerMY3WRRUgatp3WC2EQNm9rTgDcMa1GcubQJ9AWC5guFIexJ/r1YdIDiUvavTXHBmg9QXHppDcIdcaL+VXPlnrdUN4dK43fqLzViHsAHHk/rT//DAXGzTgJuA84Z2aTHNvjoUsBWphFCdqwK9eXePpIEsE3kXqpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O7eTwGinBXS47MqUZRYvZ/Qd3ALpIKwATN8zqMbxxBs=; b=LiZAs+ETom02AlN4zIT8DzmemTN3hp8KXR+Td/IFClc5kp05D34DZVqq6Q2ijSNeb4aMTEpAuuLOppWA6Jokgof2hiNaOenb39/G8Y0fwbDNe9mmahfGXj7TbwYKv4+29VIju4AjUmKUIUE3hWago7dhv9bwgbuMpD8HwuTpnFkd3U+VP311GZFvmp9Bq/AzEvEo2eYZEYsEuwpxIVqSrHgBhmTSlo14RUjgEAm6kaRgz88RH3UqD4ZyBFMIa8Mvng0pyx5LtZf/I2y5f3Q6PXZHnI1ig9Xq5KltcBMLb9ss7XWViIgwJ/AdLahpdiu0WAcVgR4Mxao8PbDC6Qxj4g== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB9P250MB0548.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:336::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Sat, 23 Mar 2024 13:21:40 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7386.025; Sat, 23 Mar 2024 13:21:39 +0000 Message-ID: Date: Sat, 23 Mar 2024 14:21:37 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240323130409.20925-1-anton@khirnov.net> <20240323130409.20925-2-anton@khirnov.net> <171119995067.1646.11310285146493611311@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <171119995067.1646.11310285146493611311@lain.khirnov.net> X-TMN: [+rH62Z4v8MrqEQJhawpFApP/S7chJtakzEuNn3v4324=] X-ClientProxiedBy: ZR0P278CA0034.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::21) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB9P250MB0548:EE_ X-MS-Office365-Filtering-Correlation-Id: 397bddd5-577f-4185-0c8f-08dc4b3c2c4b X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqkjmXb1vlddM5aSa/Epk3A5x6rj+83+QTC9KFg3Jw2NkXNQYxP2S4wmWZH8WCATOIjuUz+8/8UQAWf7m4vbh4HTrdz2O5aV1CBYZM/TtrOfJ/Nw9lErqujF0749UN262YCKMtM3xieY1HSmwGla+NaKhwA/ma3Y0rl4kZ03l9ThDGYT4agRCYEcbFlpuscnKhbJHkvKIyl/x6lK1msPUnULxv0F8t3KlKJTgKHs5LxyPKW4GQ0f1wQG2wI4T5pijwrF1XixAMa8YFWmO+f+Q57i69yleL9uHmAgaGshyNOQSQRPw5rGTAOM8M+mxUhSaX5YUtUUYXjMe4JAgr2OjPTRrMuUd1hhZka3pjGsh9JBDPAHtqhJc6oZL3sgDkq7J4Ie4pv5YRF8hgTbEW2Vddl0u/R0y2vjiyaNZ/rm5IyNoiLu4Xx3BDDYx+4xW8GLDxpV1HofxVjwr68j2cHv3WJjYTzdkzkVsy46APr3XqAfKoiBperEv5Sma96VF//e0PWZRPdLafXZvy+Ei837yEasHt8hWPJSQ9r37rgj2QQ9fk7ogjKMX63ABUJoGqIPVXI5rIECCenSZ0QGeabLjqYSWomw00YGdHLIRgava1MlfSZOW7aumYG9CyH/eUBUNy4sSUSmmaaSUshfHmnfplRI4jPPxWAXSg1/ZHD7MgLxpfYsLNPSWyXU4XK0rDKfzjYN1eqTu3yp+RVUuWPmZl+3x56WM8NO9F5zaKPvYmpeSh9tI/BkBqC2d4VrZgsFyk= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XBAzpt/yMyl7839/k4zqZgYs8XlACtV4eNV67bPhQzeHxej4Hc1xGMU6sPhvRtjri9TiDB/w4ETRf5B033sJzekTLpWXArppPZ1AA191ujrr2OC1ok7MmTlMU+Y12DQQVBDVdW4LRjMnoEcwpaWQo97tYTagAGf7yiDDKMZQ9RTjtutnj+MXDdQIQRsHZPNkcb7gL2eVNL5RZA4mNlnTPs/7SQdj4IJLn88Yix6/s5jdhFOctgsRzaBfjWcBK+uEPHM5aF1T1wvgTa/LBO1NY6naKEDuzDeasSMGNpWIJYx2GW7I3IaxxTOW5Av5uA+9dPyTnRZVuRFrEWr4W5w0dwDg7O0miikSfAmtDMczUb1Vm4tzuO0kzklFSYIGeIc9ZzWsAt/LqFjGAEFE1HjA/xeA4yVK3VHEu7+Ewiw49ig3hHQljT58OWRi1cvdR2awX6ct+Bi5FPv3kVQNCK7TLiZmYQ7MMc139DLXfBfz0g/973soL0u5AmH9Z4u1JiSde+acQ3JY9NViJtX9J5/14UOIhr2WGfFQ/ERMfB4RvicBjh0AxfMSsjXNVMKwxiTJ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1FVK1EzbTA4STlpUlVRR2h0VllTSFo0aFptVkxaUE5pcHUwbDhkOWpWcWNJ?= =?utf-8?B?MVlOUng5ajFDT0JuVW1vRUpRTmo4cjV2RGxmT1pqV3VtTTlaV3UwRnFxOUFs?= =?utf-8?B?cStBdkh4L3VIcU5kN3RUQTVRQmtDMUQycHdtQkNXZUtyS3Awc2llUWhEZVlq?= =?utf-8?B?SmtsYTAwUG5NaW56eVZkYlowdWRLamJwbHhRL3IvVEFBekJqemlqVlJwUjYx?= =?utf-8?B?K21sd0dDREkvWmJDRzdocUx4Zi85czFjV2pWQjVnZGZJMElNeUU3eU5QdXFo?= =?utf-8?B?S1ZUSWh0VzM3dEI1QTVjWHhtbXhMaEVuUVk2WFQ0a3laaVFxb0cxZlpFN25V?= =?utf-8?B?dmllVldoSzFZYi82TVV2L05SSDZGeVBWbmN1ZlRldklrNDV3UkxJWTM1bndk?= =?utf-8?B?dHJHREwvQTBKT1F6Yi8wc0UyNGk2UzhnWHY4MlpBYUNMS3M0MEVsZXJZL0hh?= =?utf-8?B?SG83SFhEcGY1NXQyNFlUVGFsS2lJakgyNjR6QU05b0JFYnU4cTZIRVRTbnV3?= =?utf-8?B?TGFjK0w0ZUhJY0UxRlJ0aHlWWnRTRjViOG8zWkVOdnBuYUpJbkxyMzExbjhh?= =?utf-8?B?YnNDcXVkN1k2Q3NEaFRkaUFBR1VkS0RiTVI3aUthNForZTFPZkVaaHpGYk5u?= =?utf-8?B?dWZNZXR5dndjYzd0UzN2N2taNHVYV0Q2Snd5UEpzQlhYTkgxOVkydnJsNSto?= =?utf-8?B?cHFJVDJnbHFJeFZLNy83MUMzdUFEbU1DSkFEWitGd1R0eEhqdXRvU0RwN3Z4?= =?utf-8?B?aTB6ckI4OGlIdnV2THVoeGpucnhRNUgwZXhBWlpQYTdDdTJsNk1MWkZraUVN?= =?utf-8?B?OUJ5RFZMdHhkczAyaW90TTdtY1U4S3ZYZXE4VUtHWHRBdlpWbldld0U2NTgx?= =?utf-8?B?ay91U1BMQm1hTGlpOGh1UG9FMHlRaUZxZlZ6UlhXSmVIbWRLZHljYnVSbENS?= =?utf-8?B?MHVMemo2bXE5Vk1aQ2g4aGtZOEQ5VTRrSERCdWZSTnYxTU5BLzhWWGh5KzJQ?= =?utf-8?B?bWI0elJ6S0I0KzhaSFlsZVFlUWxyQWk0a1h5ZUF2VlJ1WGkwU2h4bUtsVEJB?= =?utf-8?B?U2pVcytucU0wZnNXR2xxZThpTTU0S1VXQ0pXMmNuc1ZCZStkM0lxdEFNbFoy?= =?utf-8?B?MENxcExTT0t0UVVnWENySjJtMkRKaU5hb3FDRE9tKzlCV29zRllnMk5xZEpZ?= =?utf-8?B?NTRCNkdDOWFIVWdNMG9scnNOOEhwWlJ0bGI1VjVvcXA3ZTdnbTk5dElneFln?= =?utf-8?B?eGd5R1B5VWdZb0VDQ2hNUWo2ZWpNRDdPTTJKWWNtLzNmZ1VpM2dra0VKcWp3?= =?utf-8?B?endOSEVpa3VGRlJuclBCTXdhZ0d5YVBPUGQ3eTlRYlQ3cC9jTy83a1BGWEdi?= =?utf-8?B?bm45YUNOWWJHQkVIRWxxNXNMSUFOTFJRNlFmNzZnY21jaDJhSVFad0dBZnd3?= =?utf-8?B?TUt6NEc2USs1OUUzUGlqYXY3SkZGM1oreWt3V1Vmc1VUTnBDa0Ivc2JjWWln?= =?utf-8?B?em5MZi9WU3RsL0VmQW41Q0ZHTGdoVXkyb3FzSGUzQVcxVkVjWEl6UXhpTmpp?= =?utf-8?B?ZG1wN0lEMzhiYkwwSUZxY1I0anRtYXlWT2VCOWlPcWpWWFRMOElPUGovV3FI?= =?utf-8?B?RkRINVQwSjV3OGZaUi92WVY1UXZ2SmFmeEl3ZXpaNWJqb0M0TklRRGJUUTZP?= =?utf-8?B?R1NwMlRaYUs5dUUvbjFIVkVlRW9sYXlwNnZlSExMN0N1UjY5d2ZCWmp3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 397bddd5-577f-4185-0c8f-08dc4b3c2c4b X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 13:21:39.4801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0548 Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg_enc: only promote first frame side data to global when meaningful X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-23 14:15:06) >> Anton Khirnov: >>> Skip those side data types that do not make sense as global side data. >>> --- >>> fftools/ffmpeg_enc.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c >>> index f01be1c22f..6a91fd0398 100644 >>> --- a/fftools/ffmpeg_enc.c >>> +++ b/fftools/ffmpeg_enc.c >>> @@ -247,6 +247,11 @@ int enc_open(void *opaque, const AVFrame *frame) >>> enc_ctx->chroma_sample_location = frame->chroma_location; >>> >>> for (int i = 0; i < frame->nb_side_data; i++) { >>> + const AVSideDataDescriptor *desc = av_frame_side_data_desc(frame->side_data[i]->type); >>> + >>> + if (!desc || !(desc->props & AV_SIDE_DATA_PROP_GLOBAL)) >>> + continue; >> >> Why the first check? Is it intended that a defined side data type >> doesn't have a descriptor? Because IIRC all side data types that can >> occur here are defined and have not been created by letting the user >> pass a number via options. > > It shouldn't happen, but it's not inconceivable that e.g. a filter could > attach side data with an unknown type to a frame. I can remove the check > if you prefer it. > Yes. I'd consider such a filter buggy and that bug should not be covered up. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".