Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 5/5] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths.
Date: Fri, 18 Apr 2025 11:32:54 +0200
Message-ID: <GV1P250MB0737969C52577FF08254F7F58FBF2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20250417235543.227108-5-47210458+raphaelthegreat@users.noreply.github.com>

IndecisiveTurtle:
> From: IndecisiveTurtle <geoster3d@gmail.com>
> 
> Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes about 30 seconds on my NVIDIA GTX 1650
> 
> Haar shader has a subgroup optimized variant that applies when configured wavelet depth allows it
> ---



> +
> +void put_vc2_ue_uint(inout PutBitContext pb, uint val)
> +{
> +    int pbits = 0, topbit = 1, maxval = 1, bits = 0;
> +    if (val == 0)
> +    {
> +        put_bits(pb, 1, 1);
> +        return;
> +    }
> +    val++;
> +
> +    while (val > maxval)
> +    {
> +        topbit <<= 1;
> +        bits++;
> +        maxval <<= 1;
> +        maxval |=  1;
> +    }
> +
> +    for (int i = 0; i < bits; i++)
> +    {
> +        topbit >>= 1;
> +        pbits <<= 2;
> +        if ((val & topbit) != 0)
> +            pbits |= 1;
> +    }
> +
> +    put_bits(pb, bits * 2 + 1, (pbits << 1) | 1);
> +}
> +

You are still using the old and inefficient way to write VC-2
exponential coded integers. Improving this gave a nice speed boost to
the software encoder.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2025-04-18  9:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 23:55 [FFmpeg-devel] [PATCH v3 1/5] libavcodec/vc2enc: Split out common functions between software and hardware encoders IndecisiveTurtle
2025-04-17 23:55 ` [FFmpeg-devel] [PATCH v3 2/5] libavcodec/vc2enc: Switch quant to int IndecisiveTurtle
2025-04-17 23:55 ` [FFmpeg-devel] [PATCH v3 3/5] libavcodec/vc2enc: Pass quant array as argument to init function IndecisiveTurtle
2025-04-17 23:55 ` [FFmpeg-devel] [PATCH v3 4/5] libavcodec/vulkan: Add modifications to common shader for VC2 vulkan encoder IndecisiveTurtle
2025-04-17 23:55 ` [FFmpeg-devel] [PATCH v3 5/5] lavc: implement a Vulkan-based VC-2 encoder Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths IndecisiveTurtle
2025-04-18  1:11   ` Lynne
2025-04-18  1:19     ` James Almer
2025-04-18  1:18   ` James Almer
2025-04-18  9:17   ` Andreas Rheinhardt
2025-04-18  9:32   ` Andreas Rheinhardt [this message]
2025-04-18  8:39 ` [FFmpeg-devel] [PATCH v3 1/5] libavcodec/vc2enc: Split out common functions between software and hardware encoders Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB0737969C52577FF08254F7F58FBF2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git