From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A41244AE9A for ; Wed, 22 May 2024 15:24:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63B3A68D373; Wed, 22 May 2024 18:24:46 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2026.outbound.protection.outlook.com [40.92.75.26]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6F4C68D155 for ; Wed, 22 May 2024 18:24:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDv5F0WitcClSF3eM/0gfCfNF5eEnZejcPU3ORG7iq6auezj6yugud/c1JVZgkv+TkJsXp0R+ctA8UdKavYKG2fIaWn7skuSNlnQ87Iau7wAW5h3ylSpMKXng4D413CDjzJEr2uE7/kdGQxhAke0AuyyncemyVL2zk4OZ6P/Ip263O87Cb+DTMK5ZkY8Mh+Gf+zqW+xHW4gU4znLMKB5UMs7ivrPDrJ0L/mfAM4W/v9Rz1mDdSQSzQNlTE+WPpwuvvprfrkgL6dMmYHdppbdP35VqFLSMlVj9gSk0HWLtM/gIz2dGEFXPnECQQ60NC0me3o9yBZ7V0c4r01aMgHvBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qvc44xefuJCZRMRS0LBFpe3N2YG02ADuwrJ2lOB6Zf8=; b=ceMqcTaT8a6C48nVwgyPYTf0GxI/ldNszbb08AUxa0Jqn/QyI/rWnnKP5FGzJYJPHadeLRjw0rp4OqDL9u3rXauC6NWnIGeg6Mlz6LCyIwJe7/Yd4RCne9Z74NkhxibEqgIi5u8Noz7/06AAv/kef65k/QKvwEmg8kw1bvJT9b4+wMFmQLjF6QDb77gJKOxAvMOFKIXW5tfciDuJwgH3FzCPAZOPKEK8/VlbmWwYqNjP0xPbvBiOaRolWEqcIfDK+qNRgSsoli2DcjpFqoAuifuO/AYyBRhB6U8BXsUPXtqqx0fmESMcy6ESYDc69IiBcOsesK0k9VwmWphPyymviA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qvc44xefuJCZRMRS0LBFpe3N2YG02ADuwrJ2lOB6Zf8=; b=rNbFWshWf+udLJ16q4BRDkQZb9sQZ7DcoPolfvejXejpaYa6+wdmYxNEXEIi1hBSxnkCBultNUmVsiecJdZ5zmTSM5aRm61MYOR9gXYHM+cHbKqn8EeLqleEQ6z+9qDEU/yb9SARqKLxrSY1rVDyYUwTFkDGMKDLrjFmOTp2idAls6La13e0SOV+Tr+ZxrZWbBArEq2zxRiZHafizgafOMYMWiWe9mGNb969HpeKyNGMTJJbVztXM5qNyRVKp1laW+odq7nhPQ7OnDd4tQbp8DAh73R3tblQEcPilj5JYGjKwbCzdYqpl2/Sif9aQ2Nun8BYyrCCW8/Nl4fggVHkJQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0301.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.34; Wed, 22 May 2024 15:24:37 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Wed, 22 May 2024 15:24:37 +0000 Message-ID: Date: Wed, 22 May 2024 17:24:36 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240418150614.3952107-1-ffmpeg-devel@pileofstuff.org> <20240515155446.3589239-1-ffmpeg-devel@pileofstuff.org> <20240515155446.3589239-5-ffmpeg-devel@pileofstuff.org> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240515155446.3589239-5-ffmpeg-devel@pileofstuff.org> X-TMN: [Oa5rXW0XThZ7gkyTnbl9HaAhi7MGc8+X1K0JcAIcLYc=] X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <3dd1ffa9-1f4a-4f5b-9b8b-509c823283ca@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0301:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f327d6f-874c-494b-34ce-08dc7a734adc X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: yzNT9HdlbuZ17eUSydsr3wlO2Y0p0g+LImOQaStc2NFJeKR++EsoZKsLPqy6euuE2lfRb4BfJIpori0PAKVfGvmbf+4PMFawODq77gawWcLNsUzmYIFpaAXgHT8GbCNQIgec3NBneBCKvsg/f8T2yYJkfuun3vUO1IL76jhnFJTynmKvi62G0hRIetZOxy1ExQ0EdSTKelP1jIUEtwrq9r3pnwTaYxA/Hc0UDQ3Vd+nX3s6tR9NF3G/WrHu+5eoWyQZxz7Kn42Ptjp/DPmkdpvQJK8TVrtmdWWAcSH1pSEAWJ1GHTBFbfnMrIqHDDqNCPRBz0sCk9g5dnlBr33LKcCYeBtsqDWr+jnK0Albe+/qMRAwrMN+QURhUeDgLTYiRds9F9BdyAv3+O9+ZNLjDibIYTJTxL14ouJdM+CeJeqAjN/Ae8WOfeqSoqMbgBtD1/JjDB5I97OIZgmRuW0/Q2my5LVHpndOeZGryIU+40BGOOoJY6emjXfA7vei6attixAVHP8wBqJ+Cvbu+ZRlKsS8R4QLCsNRt8OPgqvP6VDCCBeYFgED0ccVaTMt0gL8O X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?am5meFFnQTdLNGJIR0tqUXpDMzM5QTkxYnRxcHpGU1hPYlE5M2V0bk9DbTV6?= =?utf-8?B?MVF5NVN2RG5HekpIaTZid3hLSFlMT1E3R3lTQjJscUJvaW43VURiNDB0N29R?= =?utf-8?B?Q1J3cEtCeUgxZTVVRGxpTGJqazNIREpVMy9LZ3dpYXNZMG9FdGdpZ3F4Q0J0?= =?utf-8?B?Mmhndy9TdjZrdlJtZnppZW02b3AvSkx3Q0ZTSExNN3JzK2VqNjVBUCs5N3A4?= =?utf-8?B?NGFTZ3VPMThlZ3IyN1BCa3hUNWtoQkpyS2pyMUMzUjA3MkJNL202d3didmNU?= =?utf-8?B?QW1uR3lpbVF1ZU5SS2JuSFMzSVVGZWJkQmdQa0Z5NjNvM0ZZRmxRMkdpQ1ZE?= =?utf-8?B?R0FnVllKYkdTeGJkT0x6VHI3bkdxdzBUZkVCSXdLUjhUUXYwZUVGazJWNW5I?= =?utf-8?B?em9HenRwUDB0bmpFNFdEZGFMM3FxSFpPM3kwVHl0SnFkNXVvZDVuQzhOa01p?= =?utf-8?B?S3FaL1BqZFNmZjkzVmw4UUdHTjVTdDIxRlF2dms5eDFsSXg1OXk0dWM1MEZo?= =?utf-8?B?OXVlYWwzMGIvcGZsYTdDV3piaUtWK2kwcS8yUHdCQ3h3YXg3Y1h4YkdCNWIy?= =?utf-8?B?WEkxelIwSUJuS25rQ3RramJNcHZrcUVZMWdMK0N1aG5XY1ZrdFhLRFlESGNZ?= =?utf-8?B?WHptRzlqbnI2dWRJV04yYWVQREIzOVVhL21EYVlJWWtyTlBycnRZR3hyZXVN?= =?utf-8?B?UFQvbHpLd0FiYWNETDdEOUdWcnNHdGhON0NnTUJnZTNGOHlNbTFESUNXNkVH?= =?utf-8?B?SzdxRTl3OFNwQytVYXNQZU9SSDF5UXlhdEhvamlJek1yd0NQTGtDYWd0V2Iz?= =?utf-8?B?NFRLRjBxSkFwYU5rOVNFSGcvVHoyalM1TTBoVTFaNVgwRGY4L0xCQ1Jia2tp?= =?utf-8?B?L2NPRWQ3ZXRzc2t1dktmQXVza2l3RXIvOURiWVNFNkV2Sm9GSEk4MDdlbGEw?= =?utf-8?B?anZrajVoUDhhVU1CQ1Y2K1MvaE5ZN2phYWtkcHVhN2toSTVLMDAyeHZlOENl?= =?utf-8?B?UVVkcFFlVDgwdGliSlF2anhaeEhBaXMwUFFoTUNyeWJOMU83NVh1L3g5TDRt?= =?utf-8?B?SnQxMndvdDVDYWd5aENlTkdGejlxN0txN3ZTY1MyZ3NkelMvbFY5akJUeHht?= =?utf-8?B?R0hwZ0JzajdtZ3ZneFNWUVY1MDA0Y3lSRXJXYklJREw0Rm44NjVoK1FvZU92?= =?utf-8?B?VmgzU08wYlhqTjNiU0pSTGVHV0h1b05wU0hUSmpLR3hRUW5MRUNZczlBaGs3?= =?utf-8?B?NTU1N0ZZRStHR2RIOWNpcHNlRFZ2dkllaXBSb3NTR3FzaTZoUHZER1pvQ0FN?= =?utf-8?B?T21SdXZiVzdaOHZHRnNDeFlMOWlwQ2ZOSVN4VFNrQnNxN1l4c0pDL3YvOGpL?= =?utf-8?B?U0hFSHZidTlROHBSZTNBTUJhczlqQTNpVTMxbGdkWmxGK2ZweFZ6cGZTbU5M?= =?utf-8?B?cVVzbkw4U24vajFuN1VQL2xOZzlFOTBBQ0NEWnZkTFVrZnlxSURRaUI5cGFp?= =?utf-8?B?R1hJRGtFTUlMY1h6ekhkTmV6T2dwN3NROFBObTVKdEE2TTBZRzA1VU9IYXFP?= =?utf-8?B?cnY2YnEwUzlVQ2NFeHpJNnJMZ0g5LzZPZ1hHbTZzSTV3cnlvSjRtSFd2eDc0?= =?utf-8?B?WFhYUGlFdXRKckdFMWhIU1pkb3doWncxdjY0dGcxWGNZa0c4Qms5dWNzR3NC?= =?utf-8?B?cTdzQ2tSRjJ2bmxLV0FjdDhIQ3AyeU1uZEk4U3lqemtjdEErc3FmR2t3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f327d6f-874c-494b-34ce-08dc7a734adc X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 15:24:37.7872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0301 Subject: Re: [FFmpeg-devel] [PATCH v4 4/4] lavf: Add documentation for private "Context" classes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andrew Sayers: > Doxygen thinks any text like "Context for foo" is a link to a struct called "Context". > Add a description and a better link, to avoid confusing readers. > --- > libavformat/async.c | 3 +++ > libavformat/cache.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/libavformat/async.c b/libavformat/async.c > index e096b0bc6f..3c28d418ae 100644 > --- a/libavformat/async.c > +++ b/libavformat/async.c > @@ -53,6 +53,9 @@ typedef struct RingBuffer > int read_pos; > } RingBuffer; > > +/** > + * @brief @ref md_doc_2context "Context" for testing async > + */ > typedef struct Context { > AVClass *class; > URLContext *inner; > diff --git a/libavformat/cache.c b/libavformat/cache.c > index 5f78adba9d..3cc0edec82 100644 > --- a/libavformat/cache.c > +++ b/libavformat/cache.c > @@ -52,6 +52,9 @@ typedef struct CacheEntry { > int size; > } CacheEntry; > > +/** > + * @brief @ref md_doc_2context "Context" for a cache > + */ > typedef struct Context { > AVClass *class; > int fd; These structures should be renamed instead of adding these comments (which are pointless for internal developers). I just sent a patch for that. Thanks for pointing out the issue. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".