From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 040254AA6E for ; Wed, 8 May 2024 10:16:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2761C68D62C; Wed, 8 May 2024 13:16:55 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01olkn2065.outbound.protection.outlook.com [40.92.64.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0C4B96800C1 for ; Wed, 8 May 2024 13:16:49 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TCKWbSYANLblq6izzGJPKt369CWnJKWSYPmvYNzWiRICHiiGY7rbgA5gWyHDko4Kn7LFOxN7vdnobX9rmbfaQtifAU6Rk1iTnFe36lNV7q0vF12lwkrRV2gKIoD5deYT3hBQgArAhu3CuWuD8QX5Or2VT2wskxoK8AU7jyI+jwn2se0+AWOtqGaXd/VVMBSXZ9ivJbxBqsLcjmx4SK5IAn8uJJ3QTl4MD5sDE/KA10wkUD8u4aO1osNSZ3sPqFZdYDcNsgn1CKHngg0Gi3e4ZKG+rEb0JModEO1Rz5YJUhC6zj9S1yWHeVod4XW+6/L7eQfQQ53ETmvhJhbECHvuSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yJ56rxRX3kfLpFqV2r8uzuFaU2IqIiLCeAi4g3pLkXQ=; b=bm4TStwQWXTWUjcXMGyk6QGEDlX5uqtq+b3CzOL78eSI1ZaSZYbWshPCG+WDqvcrIQem+RkW/fkeDf63UA0dCqNX0a3WQjxkfbeP2L13emu4lHDAPPBKyJAQNnyun4yZsiSYtP+rjXM4o0u0xaC3NJnxKld7I0AK8kg+h8UQmKvSJQH6iaqX5vBFRCQ7lP4BCaKVa0SKAu50xVfg3PfF+Wi+LcGEB4EFIi+W2zIqY4ZTX7kV1QVe9iOO5LHAUx6I9GN9qk1EoELVmMYr7rLwgYdNMYVdQDshOLD9+2t3ogNpq+/USbUFb5JyZaHYqIlQ9ZIbUiLUU9o2Lz7hUChLwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yJ56rxRX3kfLpFqV2r8uzuFaU2IqIiLCeAi4g3pLkXQ=; b=qVeir8rXAS3yjpmvJdlk68QJU2A26PkZHojJb3aro86X6B2IJxW4W5szxyB09m4A8WM5z5GwyMZUbnmtjx3h1wiSC77BBua8vamokPoRqROdKlOGJPQYzs4odES9d6Pl3YbGzK47vGwBdkazkrRMYGfFI7zo+5H3W7kUGT0qUaQPywlJSz391dqYkKo9a1w31cPnfRKZ/BrD4EFdA3xDWGgrXbXQqB8QY4JKh1TXfosFXBmU2X5ZDxoSDTDOrsHiGbmU/VqTplr7h96UjFWMJKurJ89YEHGm7bqysWMHYyKdQ6kSOKawztyrpQ2RAGP/+D5h7OHi0Ti38X1SN6LxCA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PAXP250MB0445.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:287::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Wed, 8 May 2024 10:16:47 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.041; Wed, 8 May 2024 10:16:46 +0000 Message-ID: Date: Wed, 8 May 2024 12:16:44 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240508023923.28209-1-michael@niedermayer.cc> <20240508023923.28209-3-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240508023923.28209-3-michael@niedermayer.cc> X-TMN: [yIBbzUg0AD0RUaysYKsvkjbLrXt8OiCj] X-ClientProxiedBy: FR3P281CA0203.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::11) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <142a8fa4-9019-45a6-abf2-8f3d37403afa@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PAXP250MB0445:EE_ X-MS-Office365-Filtering-Correlation-Id: b06a8fa0-aaf4-4808-b8ea-08dc6f47f76c X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1602099003; X-Microsoft-Antispam-Message-Info: QfIBzQmuhY8Dz3PUfUy/jPtBdTGKClIEfIAJF4onTtReeqiFSERM56CYv6iAvE/nYBCi4C9X4rxSSXcVEE2z8ONg7uiJjmiSQe259QbnvaBsnNV35XsptSvRPJGumFAGkAzML7s9D2yOiv5s/C+PftbA4UCjHxEPMh5ow2G08HfEHPNz3KKzLx4OUtoB1THWJfGUT3a1tWllYJb4wKwOBPbrg60xVMrxi/PZGDpMXNJnLahxIrxW3Jg7GhpOINOMcbrggUDsaQYBXB6U2L1JnrhZmleayj0wKHM9WhkefqblqSuiawwHKSosovXXUjUaxQVBeIqaA4KjHauxPfhc7IxrPsnyQvYa4Q+o/a9FQa2PsN+xTjVpN7cghWNp9jRA9ctaeRZ/QOX6+Lu50SFYftNIKENENerhvC50drQBAQDk85lArE96i3R6cIKK0E4HqpQBLj0Kiq/XKElPmQJ9eOgytRtnn3JHcjEQgxKsRUeSb/aOHWcq0VuJaIY2czvfMIiVsEqKt1k3rpTIEs74CZs/CoGo3OKIV+DbqWStjvBDSxJUTGV3FGZaZmOXi0qMfFHBWR2pOtgUXQ/DJMwFZgsGaYj4OIeWCbUaD10XILnx0y4IuhGgftljpuDivy9tB/mxOAg8D2fhbjZr6bXCsmIRkL2hskZz/4H0e54NVRaPI0U8v1jc043Adlzj0Mx9m0sB0jcF+iZ1ZAEM0uxwAQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVE3VnVYYUZsWnNoSDdVaVQ0NHJIVXpXajYrOFdSYW94ZUc5YUtFZzZkd2h3?= =?utf-8?B?QldSMVdkQkowOWtETERvdGxzcWdCWUtSUE5pdDIwSG1tMDVHMjlKVUZrd1lR?= =?utf-8?B?U1pyUmxqZloxc0MrWEdWRHNmMTRPV05OOUNwTUgyTTRUb3hJb3hsSXErSXpz?= =?utf-8?B?NFVHL1gyZHl0ZkJYUDRzSW9BWWFMUHVuNFRaRHcrOGplbWJndkk1SUhnbisr?= =?utf-8?B?b3VtS1YvTFJmUTZLa1JINGZ3Q3JkSlJhTlZXdVRSMWVoRzdHN1ZpYTFBUU1X?= =?utf-8?B?M1pYVUIreXBpcW9wdHV2ekdkdENUN1hpNEp1ZFR5bEIzQzBacjFZcDJHVm5V?= =?utf-8?B?T0xpWHdJWGYxUGtKdXYwSzNDODBoNWpEditPQzRSc01ZckIycUE5OEVSMEtm?= =?utf-8?B?dWp5dXF6ZU9UVDFPekRPN1JkKzF1THQvUElLelNFOGMvL0FUSE9DQ01wZE10?= =?utf-8?B?ZFlYaGdMSGxuZUdVMnBZL1pOcTM3ZGxGMDVEVzdLVTc0V2R3Mk9mc1NFT2Qy?= =?utf-8?B?K2U5b3V6SkVNdVVrY2xzdk5TYkwrYy9oY21zRGVzUzRNOEFGM2lKRnZIdENF?= =?utf-8?B?eHcrZDRsTyswTzYwbG8zU21YWUd6K3h1bGh3VWQxRCtVME8vYjQ3Q2tTVUpM?= =?utf-8?B?RzkvSm00TmMvR2ZjNUtBL3VJSHZFOFo2L2N0cWtjY08vTERlemRmQ280cHFm?= =?utf-8?B?U2JGY2dJWFVWQTRLY0l1bVBDcWN3elJEL2trTWlEQUM1Y3Q2U0ZpQ0RRZk00?= =?utf-8?B?ZnpUM1R1dHhYSW5RV1BzUUc3MnFUT0c4SUc2NTMrQVFDbllOY1B5SzJlTDZo?= =?utf-8?B?NjR1bjRIT3FpRTNqbjdxNXNaQWl4cERacUNpTzZuUi9SaEsyNU16bFdQVmE3?= =?utf-8?B?SWFZM0FWTTExaGlORTJOYUwwT1hZZzUvYUo3OExJemlFa05TUElRaUNrOHVT?= =?utf-8?B?QzlTbTVMRmprdHpwWWpvMWJCSGVMbnJGc3JFeHYvK3FIZ3o3QWtxclZyWjFi?= =?utf-8?B?b3FZaHU3NFFIR1I2eFY1bmFxRTc4d0dVM2lPMlpPTWJmSW1iejhuK1hHNG11?= =?utf-8?B?aUFZejdxMC9lZTRSaUZyaWFMaVBWZ0pCUlZUZmJ0MXdaQlpOTldVZ1VBR1Fr?= =?utf-8?B?eHE4RkVmQzA3TmJUc0praHBNK0M3Q01kcE5oTmNPZkZ5NW5LSkhiQjRLUy82?= =?utf-8?B?VW1NbUEwOTNhV0UxN0wydlgyRGw0V3I5Y2E0dFcvNDZUOXNDT3NVSk5Yb0ZD?= =?utf-8?B?enhFVlBYQlFoYjBaN2d3QVU0YVUxcTRRQ2RPeStGZ3ZLOVBNRWRhMFpBSURQ?= =?utf-8?B?cGRJdWd0L3JWdVMyWW1yMythbk5DZ0hNWTVCOVo0NHIzOEoxRTRIRW10R3BW?= =?utf-8?B?b1BnNXNCTFhkZTFpOC80elFSdnd1V1RnZEF3M3FBQTJ3NS9jOFdSbjEzQVRv?= =?utf-8?B?WERPT0tyNnc2d0FxT0U4VHV4M2RINDN4RVBMZklObjFoajZja25pa1AxOXpW?= =?utf-8?B?dHBhN0YyK0V1cjIvR3RXQkFwTlVrVTFOQ0ZiWUNQaGxtdE1MUEtUZTBYOGda?= =?utf-8?B?SVBvbjZFRVpVYUFJQ0VjM3ZtNVlzd3FVWXduTkpJdjlKaU9mYWMzZ3lpWmhN?= =?utf-8?B?djZ1em5Mc1ViTU5mNFlkTTBrdmhKaFc4MGRNVUlWM1l1WDZHYTRoRTg0WE4r?= =?utf-8?B?bzE3TW5vZjlOZlU1TEF4N1c1RWpXNVFBYnRUTTJ6bWhrSmxtdXBNODhBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b06a8fa0-aaf4-4808-b8ea-08dc6f47f76c X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 10:16:46.6466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0445 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/img2dec: assert no pipe on ts_from_file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Help coverity with CID500302 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/img2dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index a40675d4341..6220003fb4d 100644 > --- a/libavformat/img2dec.c > +++ b/libavformat/img2dec.c > @@ -25,6 +25,7 @@ > #define _DEFAULT_SOURCE > #define _BSD_SOURCE > #include > +#include "libavutil/avassert.h" > #include "libavutil/avstring.h" > #include "libavutil/log.h" > #include "libavutil/mem.h" > @@ -504,6 +505,7 @@ int ff_img_read_packet(AVFormatContext *s1, AVPacket *pkt) > pkt->flags |= AV_PKT_FLAG_KEY; > if (s->ts_from_file) { > struct stat img_stat; > + av_assert0(!s->is_pipe); > if (stat(filename, &img_stat)) { > res = AVERROR(EIO); > goto fail; 1. You seem to refer to 1500302 which I can't even select any more because it has been dismissed. 2. Why are you using av_assert0 to help coverity? 3. In cases like these it would be important to actually note why this assert can't be triggered. With a comment like "The ts_from_file option is not supported by piped input demuxers". 4. I just sent an alternative for this: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/327035.html. I don't know which one should be preferred or whether the code should be left as-is. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".