From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id F35714DE78
for <ffmpegdev@gitmailbox.com>; Fri, 25 Apr 2025 22:11:26 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE1A2687DF1;
Sat, 26 Apr 2025 01:11:22 +0300 (EEST)
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
(mail-dbaeur03olkn2056.outbound.protection.outlook.com [40.92.58.56])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 54B7B687C60
for <ffmpeg-devel@ffmpeg.org>; Sat, 26 Apr 2025 01:11:16 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=J/m6R7g283Bkj5jf1YHus9ES9ARSJP4tZ+nHj+k3cZtXlyGxxK2I4yPFjP1JP7qRIjfpH7hAyPCJFBcF5XLGE6OLfnJVk1ZdrC3/G6r2gSjQGVob6NUTBbsz6fezCLElaNqwugHTISNHv9gN/Eq+YBVA1LdzYarnA9dVlwF6ybEfPSEfeFrTHDtuxYEAMIJyRqFld+NZgmB87Ak/ZpE1apujQ7UA+anW8eAhPEARDlFQPJG2vy4I7K/DpQ+7D5vh0YAhKlRHnsTqN/QuCOhiRMr/dIV9kkO4+Fs4CANYyYej2ZVlbfL1sLIkbXBK7qM2AD7yhMHgZvuF3gUuwM87+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=W3s+zQuaTXXFKpN1H5+wHisyMsnmduMWigpmJDSE45M=;
b=cOWlDv6b0/lSzN1HtvWHquOQIir0PsPfCEHnm1VNQR8WxvAhBZ65BejvC6tAWAGr58Vjx6HSirK/+j2xJAzEKo/cjyNvfYIfJaKkcY3KFWR0+weToTRm6vD00l5vNoadZIA/FUecBA2DKYf5L2S+maVqT+UqvEuBLpNDcHQSPkxyIHQjQcFnVjgy4SCuUePMYW/aLUarNpJWwlIPY9HBGCkfChwZ5G0lcHSqVlgb+pRVZaGYBoLtEIaC+cZJIuYGtIB/rNpoEp4kFKe5c3WQl6dgj9nKVM2sgljQYPAtmjgKUvfh7MvC2LH26C0VanfwwUfkRZzu1e/yvrBgiYZJgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=W3s+zQuaTXXFKpN1H5+wHisyMsnmduMWigpmJDSE45M=;
b=KYXF+IKtp1Ujg7WDK0tnT7CcS2423cw3QBBOGGCjs5ONW4WCko+YxupxMAFuOeqKXx8IZOZgbiWQYW34AazoNF6qA7+5dXTzpyeeNHg79WHZaO8D+p8plHmrKETJpMUosQAr5RT3+ZloZgPDdp3t2pMMlj41m5aLxl8Rh8d9uXHDdByg56XlRqY600LojJTyi10zCTpqFQByWsxfqmIpxv926+5sVwZY7YfKfFRSiqDvkrtKcEUNaslJ0/zv0Rh+H6499K5yRHr+JnB5Hvo51DQ5gshdUhO/CsSIwRx1eQqDeo6COb+qFDqqGW6pkHGscKZx/GH5CgIGStmkOzK8zg==
Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17)
by PAXP250MB0517.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28d::14) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.28; Fri, 25 Apr
2025 22:11:14 +0000
Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8678.024; Fri, 25 Apr 2025
22:11:14 +0000
Message-ID: <GV1P250MB07378BADD120594AA91E8A8D8F842@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Date: Sat, 26 Apr 2025 00:11:11 +0200
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20250401171616.1378-1-toqsxw@outlook.com>
<20250401171616.1378-3-toqsxw@outlook.com>
Content-Language: en-US
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
In-Reply-To: <20250401171616.1378-3-toqsxw@outlook.com>
X-ClientProxiedBy: ZR0P278CA0137.CHEP278.PROD.OUTLOOK.COM
(2603:10a6:910:40::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
(2603:10a6:150:8e::17)
X-Microsoft-Original-Message-ID: <bb6ea0c3-5983-45f9-ae35-a9be270a55df@outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PAXP250MB0517:EE_
X-MS-Office365-Filtering-Correlation-Id: a11344d2-a831-4aa5-6ae3-08dd844617d4
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|5072599009|6090799003|19110799003|8060799006|7092599003|15080799006|12121999004|440099028|3412199025|41001999003;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?alBxYjR3UzhWcW92TG9GRTcwN1pER1VUZWtUcTl4UnM1TjdhUXdISW82eXg0?=
=?utf-8?B?Wjd2aWN5cXZ6cHVmOWY5dE5yVGxmOXZhTWdmU1ErTUc5RnJCNjhvN2M2SVY1?=
=?utf-8?B?ejhHZENWdlNrUlFUZ2E2MC9nL2s3R3h1Y005VGh2RGRHVGpQVXRXbzRxb2NF?=
=?utf-8?B?cVlVOHI3U2ZtRHlQMDhsaXprMG9GR1lYZXVPTFl0ekFjMFR5eVYzODdHclBl?=
=?utf-8?B?YjFydHZudDd4bXNTRzVNelduQ1FGZWtUWkdiUnI0VUVIR3huOEtrUkZYemJO?=
=?utf-8?B?ejdaN0grNGx5UE9zU1FvU3JIWnVIMGxtekwySm9GQlVUdXdXczlFbzJVcjFv?=
=?utf-8?B?c1o4MDU5SWVwcjY5Q2drVzBDYVE3L3NJd0xqTWg1cmNGM0k3NE1uTHV4UE14?=
=?utf-8?B?eThZY2Q3d29OcHl5cnhOTVVpY1ZQYTRreFVHVExsSkdqRHdyUlBPbS9ML1Va?=
=?utf-8?B?S1NmSG15N3BwQkUyeU5PSUNsbU84RU5PbmF1Zk05bmhTMkgvRi9hK2wxVW9s?=
=?utf-8?B?U0V1Wi9DeTNnR3pkQUFBZFhIRk9SZUZLQmowalAyOXFqdnBIeTB1c2NPUFpQ?=
=?utf-8?B?Z3JtbVdQdklRQ000ZGpRQ09ycTAxbHlwOURKeXdhWll2eE95N1hmb1JaMUdt?=
=?utf-8?B?eVJrKy9QTzVYSVpBOERvVDJRNEFlOUMvRE1WdlRHSTlwanRxQXRXQ2w4ZXl4?=
=?utf-8?B?SEUrb0pUejV6YWN6NitKTm94S2s3YWJwZEpRT3hvY1d0ckR3SWk3aWZVUm94?=
=?utf-8?B?U0VpVEgxbitndyt3OWw0b29pS2pnRkpBV2lSR2dNN0M2WDdUbHlyME5ZclQv?=
=?utf-8?B?dHFJeTlGS1VsV2VTNUJMd3RWbEMzTnhWWFB5UkhiY1FXVkhmUHhVRXVncy9F?=
=?utf-8?B?Z1Viek9hSGE2bUlhdEpSRVM0Tk90ckVObzVNbno3L2pNaEUrekZ0c2NyZC9w?=
=?utf-8?B?djNVeWVkWFA1Tiszbld5RGJGRk5DQ2hpNlZHVndrRjlBZjhsZ0krMUV2czdU?=
=?utf-8?B?YTRZeHIyUHFmSUZNbUsybEFvbnVUWDBIZjJMeTZZTWpad1dPVTZMNGRlRDl2?=
=?utf-8?B?MWhINGJWb2tFeTlibHhkTzQrSlEwY3JlenVkVlZFVDUzTis4RGNIanJ1SnU4?=
=?utf-8?B?TG5wcVprb0ZIVEl5N3Z4TytoalZ0eFA4OVN1TjdHWU1CQVdTM1YyNUFoUCtI?=
=?utf-8?B?MGtjV0syNFhYV1JMR3I4MFp1aXZSdFpvc2tKMkw2RGExUlFrLzYzamtYN2Uw?=
=?utf-8?B?MGtJQmRCT2l1WlVTM0Q1bW5TMkNkd2lnVGowMG5aVUZ4NjdwVTI3dzBVcFVl?=
=?utf-8?B?QW9UbVVJYWhPQm04S1dZUC91WFc5Sll3d2IzS05xZ3I4Zzd2QUk5VGZpaXVW?=
=?utf-8?B?Uk1SQ1JPUWt5SEg3QzZSREhmZ2NScmRINVNZcHB5MTdGa2V0OCs1K1hOKzhL?=
=?utf-8?B?aUVobXY0SXZTMitxcGViT1NSSFhIY2pvODVURzhtT0pIOE9FbFNIb2F0czJ3?=
=?utf-8?B?c3JkSkQ3a1FVSFR6N2ZVbmEzYjhraVNtdWxSeC9vR1dEaVdHZlFMdVE3MWl6?=
=?utf-8?B?aERHMUFCNGZrMWR6a05ISFY3T1BzenkvYmRTZEFMSnNSVjJob0dyYllwMDVp?=
=?utf-8?B?Z0Q3VWZhWjd5dFBVV3FSVUVhR0tCQXc9PQ==?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1hLdG5TeUtKb29pTzZ0cFFWY1BUbVJST1Z5bDZjaVNPMkdtbXplU2ttRUJh?=
=?utf-8?B?THpmUytldCsxVlZvUXI2ZFViVnpHTzEwcWtBZ2dzSlB4aE5zdTJSanV0YUNS?=
=?utf-8?B?R1pHbWVwc2VEU3ZZakNwTGFVUkExZWUwK0xpWllKSVd2S0dpSkdUZjJIbXBq?=
=?utf-8?B?ZWdqYnV5K0NyMUJjVFJuT1pvdVBxdjlUMUg4SEhyZkxtYUg2dm4rOEZnOEdj?=
=?utf-8?B?SzlqbCt5M3VCVEdEWUxMVVZaOHNxbURkOWF0MTlWUy9mc3RFQ0ZieEFyeFR3?=
=?utf-8?B?ZXgvT25FTHppQm9HVEU2TkhxcDNiQTVRWSsvaUFCS2JESitRTnFUV2ZYd1Nm?=
=?utf-8?B?UzF4UGJpQ3VlNHdydno5bUE5b3lJSVBxWWx5MEtOeTBiYXk5NnllMDMweDJB?=
=?utf-8?B?TmRlOXhkSGtPc1VPQ3Q1SlErWUphYUsvSXYreTlsT1ZaWTVQM05IbUlQTlNl?=
=?utf-8?B?L2RQbURPRTgwZWxvbmpyYnoyK3ZtTmhaWmhPcGVnNGMyM1I5Q3pIZHhPWm9I?=
=?utf-8?B?TU44K3FRUGF5dDJjSWU1TTdLYXhuU2JOZ2I2RkVLMjYzNnlrdzFFNmtHd1ZB?=
=?utf-8?B?YXdQLzU2WFltT2RRbEpxQ2F4azFjMXNYVjJ4Q0pRcVNiRVB5bW5razhRNFlS?=
=?utf-8?B?RUpnN2d0TzhXRGRNV282Rmx4eTg1RVBDOTJzdFpFaHhqd0xDUThDdG5DQVov?=
=?utf-8?B?NlpqUjhJNGI2MTJCMHBwUTJMaEpMSDVLTFdzODljeTRiTG5MZzBiczF1T1F6?=
=?utf-8?B?V3FvVjhTK0N1cWNkeWl5QUlkVmt2MUpOVTZNSFRMSmhhczE1OUJPbUdRcUlX?=
=?utf-8?B?ZjV0UCtNYXVkZ3Q0Y0cwQ3JxOTNKQzdUQUVla2NmVXRrRThaSVFqK2JyS1Nv?=
=?utf-8?B?UENaYVhnL21YY0VjNWlrTkw2L2k4M292MTE1alhVajRXV1BxdjhrNlMrOWg3?=
=?utf-8?B?VDFMbXFjcTVxYkZnTXVPYUpKSkVsZkJLNG5wZk5Mcyt3Q3J5TmNoNUpMS1dZ?=
=?utf-8?B?K1N0eGVTQ0twa3Zpd0NFR1A5bStYdGx4eVA5MmRRNjRWenIvK1dSSmdEM3JG?=
=?utf-8?B?dHVJQTdWYXR4V3RrRnRpdjA1VHZwWUxnMEJJQlorYnVIRzJQYWdhYUFlcG9w?=
=?utf-8?B?R2tJMGZwdWNWem5vM2J5WVJVb1JSSXNFdEFKSmkwNWhVeUxkM1pGckZVUmZ6?=
=?utf-8?B?TjB2V2N2MVZRM2N5NXJSdFB5KzhJT3QwTHU2Slc2aTVlVGJzVmdiWVp4WWhl?=
=?utf-8?B?UTN4THZRY2N2R245YzdlV1l3MTd6dWdyTWtwUnc5WEhwR0xlMlBsVEpNNTM5?=
=?utf-8?B?Vytuc0dpNWx2V0xZSmhuR3FsTGFLdVEzQ3hpNHAvZ2ZidGNTeU5yeGQwZUJD?=
=?utf-8?B?Um11NDc1NUJPdFgrQ2JyaWljL1FCRHpZZ3psaWRkUEQ2b2NZM1l0WEQ0aURS?=
=?utf-8?B?ZkFLbEpCVUQ5VTVyUm1oTDlLOU81dTN0dVZaOWN0ZlZ0dWZVcjU5bzJIRUJj?=
=?utf-8?B?M256azlJMEpYRW9yRXBTN3MyL0psZU9uZlFLaGNacVB2aUlxTGpDNHFQdHJn?=
=?utf-8?B?Q0ZLQzJnSWNKb1hVV1BZUnFIRC82Zk4yNE9sOTFzak4xb2JqMVBkdjU1bHh6?=
=?utf-8?B?Q0VxS1RZYmJIaHhKUWxyVFBXckVlWndrN2c2dThodXl1WlJnR1h3bVMxdERn?=
=?utf-8?B?N29qQXdSR1JLdmRWSktzc0ZEa0syTlBRMEpySkdFVUNoWmVBaHdnNXRXbDZG?=
=?utf-8?B?Z1gyZXltL3h1N1dyZW5IaXp3QzBVdjJqck5aMWdJREo0eFVCYWRGeEQzM041?=
=?utf-8?B?Nk1TQWtiTTJ4YmVMRWhHQT09?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a11344d2-a831-4aa5-6ae3-08dd844617d4
X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2025 22:11:14.2528 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0517
Subject: Re: [FFmpeg-devel] [PATCH v1 03/19] avcodec/vvc/sei: add
decode_film_grain_characteristics
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/GV1P250MB07378BADD120594AA91E8A8D8F842@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
toqsxw@gmail.com:
> From: Wu Jianhua <toqsxw@outlook.com>
>
> Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
> ---
> libavcodec/vvc/sei.c | 66 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
>
> diff --git a/libavcodec/vvc/sei.c b/libavcodec/vvc/sei.c
> index 2842862a36..365f815950 100644
> --- a/libavcodec/vvc/sei.c
> +++ b/libavcodec/vvc/sei.c
> @@ -24,15 +24,81 @@
> #include "dec.h"
> #include "libavutil/refstruct.h"
>
> +static int decode_film_grain_characteristics(H2645SEIFilmGrainCharacteristics *h, const SEIRawFilmGrainCharacteristics *s, const VVCFrameContext *fc)
> +{
> + const VVCSPS *sps = fc->ps.sps;
> +
> + h->present = !s->fg_characteristics_cancel_flag;
> + if (h->present) {
> + h->model_id = s->fg_model_id;
> + h->separate_colour_description_present_flag = s->fg_separate_colour_description_present_flag;
> + if (h->separate_colour_description_present_flag) {
> + h->bit_depth_luma = s->fg_bit_depth_luma_minus8 + 8;
> + h->bit_depth_chroma = s->fg_bit_depth_chroma_minus8 + 8;
> + h->full_range = s->fg_full_range_flag;
> + h->color_primaries = s->fg_colour_primaries;
> + h->transfer_characteristics = s->fg_transfer_characteristics;
> + h->matrix_coeffs = s->fg_matrix_coeffs;
> + } else {
> + if (!sps) {
> + av_log(fc->log_ctx, AV_LOG_ERROR,
> + "No active SPS for film_grain_characteristics.\n");
> + return AVERROR_INVALIDDATA;
> + }
> + h->bit_depth_luma = sps->bit_depth;
> + h->bit_depth_chroma = sps->bit_depth;
> + h->full_range = sps->r->vui.vui_full_range_flag;
> + h->color_primaries = sps->r->vui.vui_colour_primaries;
> + h->transfer_characteristics = sps->r->vui.vui_transfer_characteristics;
> + h->matrix_coeffs = sps->r->vui.vui_matrix_coeffs ;
> + }
> +
> + h->blending_mode_id = s->fg_blending_mode_id;
> + h->log2_scale_factor = s->fg_log2_scale_factor;
> +
> + for (int c = 0; c < 3; c++) {
> + h->comp_model_present_flag[c] = s->fg_comp_model_present_flag[c];
> + if (h->comp_model_present_flag[c]) {
> + h->num_intensity_intervals[c] = s->fg_num_intensity_intervals_minus1[c] + 1;
> + h->num_model_values[c] = s->fg_num_model_values_minus1[c] + 1;
> +
> + if (h->num_model_values[c] > 6)
> + return AVERROR_INVALIDDATA;
> +
> + for (int i = 0; i < h->num_intensity_intervals[c]; i++) {
> + h->intensity_interval_lower_bound[c][i] = s->fg_intensity_interval_lower_bound[c][i];
> + h->intensity_interval_upper_bound[c][i] = s->fg_intensity_interval_upper_bound[c][i];
> + for (int j = 0; j < h->num_model_values[c]; j++)
> + h->comp_model_value[c][i][j] = s->fg_comp_model_value[c][i][j];
> + }
> + }
> + }
> +
> + h->persistence_flag = s->fg_characteristics_persistence_flag;
> + }
> +
> + return 0;
> +}
> +
This is a gigantic translation from CBS to h2645_sei. Several of the
latter patches do likewise. Is it really beneficial to use h2645_sei,
given that you do not use it for parsing?
> int ff_vvc_sei_decode(VVCSEI *s, const H266RawSEI *sei, const struct VVCFrameContext *fc)
> {
> + H2645SEI *c = &s->common;
> +
> if (!sei)
> return AVERROR_INVALIDDATA;
>
> for (int i = 0; i < sei->message_list.nb_messages; i++) {
> SEIRawMessage *message = &sei->message_list.messages[i];
> + void *payload = message->payload;
>
> switch (message->payload_type) {
> + case SEI_TYPE_FILM_GRAIN_CHARACTERISTICS:
> + av_refstruct_unref(&c->film_grain_characteristics);
> + c->film_grain_characteristics = av_refstruct_allocz(sizeof(*c->film_grain_characteristics));
> + if (!c->film_grain_characteristics)
> + return AVERROR(ENOMEM);
> + return decode_film_grain_characteristics(c->film_grain_characteristics, payload, fc);
> +
> default:
> av_log(fc->log_ctx, AV_LOG_DEBUG, "Skipped %s SEI %d\n",
> sei->nal_unit_header.nal_unit_type == VVC_PREFIX_SEI_NUT ?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".