From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 453574C6AC for ; Thu, 15 May 2025 00:05:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 70E7968C15E; Thu, 15 May 2025 03:05:24 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2053.outbound.protection.outlook.com [40.92.90.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B373F68BC73 for ; Thu, 15 May 2025 03:05:18 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vgw8r3o9HTP0PqmZUzfjKUAxE4ObGtRRSmwNeaM7akx4rY0C+3QRHECjW40ay8X97dVn42aX8l1/OIzVhz7+3EXwD7Sp8lJCRgkXAX1gNHlOsNEeUPCJ1HR8tubdZSDnXuH4SDq1thbWRMV5DzshmpbPhJ5HaSIGpHUBsOKsBVTvIN0aCjsWcWHpxjvqppxWm28fmArbXTmBB9Gba6qCjiDBW7tABMYr6RXMwFdlHEkBWYVqT3R/GaSJQA1cqm4PliDdfTVh0YFERIljhTdZy5C5vMHM13V3dHDyBa0KxYaaITuC6m7+7tCB3RzCDETTD0WC/B7bOVGLiLnn4PYZ7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fANFMjpzwcnzCWKzKOWfZSbyhTna11aJ0SDd5aNcga8=; b=hME86sWX1LmoeDbaJOGiCSxxgvDr15BGz7RVCC7bVFZwKdxUoZGgw7MpB77PSin1kHnlyqhQsSVhcmKB1tvRosWhoE5Wn32oEWgg0F5CK6I24rqm+qGXyF4GDaMKBHrZM2mLa28WLdILR7aKGtfvzUOAo8xFO8tH6gKpR1wCLd9hfHp2f1s6oNb9MS1Bgo/9ckBGIekAW+I8KizumAnEzmS0qPDplU09zATGpLxo4kgdiB2kbvPNCrG0OxTbcHoXzWrlADgdJAH8B+SgHTojYqngtujT+/n0DUyGqB2k6sJ1vaOq1HoQsVtEXk4Fzvv14gvmHqhfyFtr01L6U+v7vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fANFMjpzwcnzCWKzKOWfZSbyhTna11aJ0SDd5aNcga8=; b=XKD4mfG4H944985VtsBTprKzYEcVel17ZoR394rvtGeGFT6UGvbK5asiMyendndHE3uJCw7P8toH53dCM2kJOVDqZZtRl7rNx98/bEjLxRjX6uwAx79bzXbcrIIOEh7erw8mJWXlaFe8Gz6ej6WMr7Hll9vGey1ARCp4tnvL8cPYAYzhUOH66FX8BRxEH5H98n/y8RQne+lsXarQSnhSLVkj44R5UlvAi6tZ5aayg9VyfhPOkWyQfLZxRDyJcSQEQEAGywWuisgQFoL2V6lAez6jYoDgcJolnGrJ4u0/ImyO/RTUrprlI4HS8hRle2wZ7EcNhRpBwjDXHznCVRZ1vg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by VI2P250MB1096.EURP250.PROD.OUTLOOK.COM (2603:10a6:800:22d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.30; Thu, 15 May 2025 00:05:17 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8699.021; Thu, 15 May 2025 00:05:17 +0000 Message-ID: Date: Thu, 15 May 2025 02:05:15 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250511003245.413345-1-michael@niedermayer.cc> <20250511003245.413345-7-michael@niedermayer.cc> <20250514232458.GQ29660@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250514232458.GQ29660@pb2> X-ClientProxiedBy: FR4P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c7::20) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|VI2P250MB1096:EE_ X-MS-Office365-Filtering-Correlation-Id: d2c6a5f8-9664-4738-dd73-08dd93442c62 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmoaApi1aWVt9ILKZbGoHsd6yqsJbF4U9aAg12rXuqzxchnez+JTCRfz4Ct9iMBkR9Ec0zoW8mvw6C3Tun93vMz9cgb1ZMYfpDAeEkFBW4pyzP9HIFDHAJTK+Z1DL8TGPwihelSNPXc0x5+e+W+lR5stSvvu/WRkvFNH7FdI8uht8r6NA6mUiuWhJ6uYcS9L6BZIuz6m0TJFb/RUeczrGxjOLTH/KJ0418aFryw0bDCX1m6Ejnvpj+EyPvmUjMIvJI5zbJJiWXhgWj5QEzNbfhtLWbpw5MzSwVkSsTh5R/jKiXjZfllF+L2sCfQpyjm6UHr2PETSKwMy05HwVFqv1jjqwX0t2mFSTP4GcrSm2HiZ22n9oDyz+pu1Vyktg+pZXBENEl/micwzI5alxowcweAiq4DjtW1gz29nmfBnUJcesU7ipLiYbKy0Zg4oDKHqQtU0I14N1BCd23rlz4gaB7/5o/eR4EyaDr8G44xKdpCowgyxA/9Z82K6qt3+DLNwo+OjRYBI4v7TxSDIyYM+Vec261VjEWpMSBiZlraVsxGXcmFJ94FRSeWC9Rx5R8BwoALIQY8c5RIs+JZufVM3WpBX+VtbTRdhovtVtmpfgpqPTIgMrmCBQDrPH1J6qR1c3nda7cH6p6E+O89UUMSKN+vD02E/7PipNtgOdBuEmIB6JPKmwHrBM0Tpomfoq7OwCW3p1+ny3ECmF/SZslUjhRTnMEqkcgTktHmxTmcgaOf9K4eBVdC3VgEFiL7oCeHrGNo= X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|7092599006|41001999006|15080799009|19110799006|8060799009|6090799003|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFNJVDJrZHkxUXBvekdveTBXYkVHeHBDY1BxTkU0NTk3T3Q4MjVXTUh0ZmtM?= =?utf-8?B?VEtJTGFMdVhCWVVzUElTRG0yYmNVQmV0bGZYWDF5ZGhYamZXOUkva21uQWFv?= =?utf-8?B?YkdLcmFyYVAzUllxeGdTeUphN3o5QUNvZkp0UWZnbTd4MjR5NlJ6Q0NaQlJk?= =?utf-8?B?d3diR3cxZncrUTV4ZzVpZ0RIaHRlc3pVTXVHMndIV2dueEw1ZGc5SVZmZEZE?= =?utf-8?B?R2dackd0QXlabUVham00RGRnRDBReWFXQURibHFBUzVDZ0tsQThuNTlSMFVi?= =?utf-8?B?M09tbVh0bnNWQUpxU3lWTy9NQWlncUlDNFFOVU5aL3JONnFGL0o1SStCTzFI?= =?utf-8?B?dDBCNmJ0RUUvdVhKWmdXRTYvR0FEV1JSN29vYitUd3V0RGpFN2c4OG5Fa1pk?= =?utf-8?B?MXAyejMrcFRpV3ZNdTg3N2J3UVIzR1cvRXdBM2JZT1BHRkZXMVZXbnNFYmcz?= =?utf-8?B?MXJrVnRtOFdNbGg2MkpjeDc5K0Y5ZSt3UnFZWjBtR0FOM3RWUjdQMDEvZ0JR?= =?utf-8?B?ZURwZE5yRnI4bmNCcXdtcm50QnhSdjN0M1luZFhubUNUTGhWRXNUNFc2ZFpD?= =?utf-8?B?QlkvNnJqOUM5YlhLVW91OGVFZmZ6WWJob2UyMWdaSVFtUVIrc3FHQWZKWEd0?= =?utf-8?B?ZzNFdGdZaVdEQVNvOHlmcDBWOFZxYXhkVUlPSHVJbnlBbDVieHFzOG4zZlgz?= =?utf-8?B?RkRjM3F4SGhMck1CR2tUUE1SWkM4amdZQndmTHkwckFwWkpnT05adUEyL1U5?= =?utf-8?B?ZUJxT0t0WEdXRWlabkZjdDhOMUJ2K2d5TFRkUytSM20rbmJ2aVpEdUhHYXB1?= =?utf-8?B?cWxlaTI1WVoyVmxhYkhYVGpPbEo2TyszVlRZSnRnbHI2L25WNlNNMkdsdkg2?= =?utf-8?B?VVZLVzZKa0tQOStHSEtQYzBaOWVTU1hjNUl1RktVZkxDdXlQZFIyakFhVkhJ?= =?utf-8?B?RjJ3Wng0Ri9HMkM0VStRNjgrQWp5TUY0QzNGa1ZyajBIeFU3OW83Nmcrc2hn?= =?utf-8?B?UStHMXlrM1h0N0JUUUwyYmdGVFIxc0NueFNmUGdMbUxmYmFRb0ZaSGJCeFli?= =?utf-8?B?ck5rTHRkcGhBWFdremY2VjliN0g5S0RId1VhOHlKMG9VS3BSeFFVdUZmSkhh?= =?utf-8?B?czR2RkhVaHpOK1YvcVdxT0hzYjJOMGlWNU5nZ2pKWWFNVVdXVW1oVTJmVzRm?= =?utf-8?B?cXFGdXlLbC9TWi9DeU9HdDNiRWtOei9LZ1NaMWh4VEwvYmRGMDdjNzltOXVu?= =?utf-8?B?bzRLTVZ6TlFZL29wbVlvM0ordU9QVGhJNDFtYXJETjlCV2NLak8zOStsUlV6?= =?utf-8?B?QklyMFJRNFA1ZElGbm5wZTNLdjhwQzdnb0ZvaVNlUUhkanJWbEVIZjlOclhu?= =?utf-8?B?VzhaQ3ZUc3pxYXNIY3MranB2THkyQ1A3MjV6YnFNL2tsNitFeXpwWEhOUDZr?= =?utf-8?B?WDNzcEJqR2JyT2JOa3JDVG9oR1ZZcjZVNWFCbTdBOThpNjFsRWxhRHEvNUJx?= =?utf-8?B?bURzUzd0QXhaekZSQ0lNbU9Rc09XUkY0NXkvWFRsMGRhK0lTRlpqbDUyVk91?= =?utf-8?Q?StuCTePSWF7jyg8rmZWLPsHX8=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWVLOXgxTm9HZWNsR2ltQUpMdFNiNWtDTGFUZXlIMlVXczd1citVbzRvdVEw?= =?utf-8?B?YjdXNUoxeHZEamZCSlQ2dk9vSlIvdjRzRm5mbUEweFNMVkd5ZEVRUHVWalBU?= =?utf-8?B?bXlqOU5iUTRnOFJyODBLSjRJQ09yN3NiVEFScGdqTWRXc3BmbS9YRTFjYlNV?= =?utf-8?B?WGlVbHQvRlVKWS92KzNUTitUNmx0cjRjQllLdHZDS3ZmNnBFQktpd2FmUStB?= =?utf-8?B?dmx4ZVRmamxnU082QW5pSGRhaDkvcE5WWDJrS3dXTEhYT2pDMURaOHAxdHZ5?= =?utf-8?B?TkdDamdqKzBMQmFMVFhLczJ3c1BzUks2WEVZN2JvSjE2bElma0pBNTBVMXMr?= =?utf-8?B?cDBEWUxjUCs1NVRiemJ6cUUxeDM1UWhUbEkrT09SMDVnRUVWcE5aZWM0Ui8w?= =?utf-8?B?c2dHc2R0OHJZTTFPYkc4SkZQajh1SUVXWSswNXVMVHVEWlJvMktSU1AyUGZq?= =?utf-8?B?Y0w1c21WK1ZPQWtudU85VzgrNmZlNlc1Y3R1MzJodnAwTnlKdlR2TS90MWxt?= =?utf-8?B?VEt1VDBXYm8ydWxlOGtnOWhEZ05KTFpleDZMajFtYTFGY1BFR2JJd1I0V0JX?= =?utf-8?B?S09uYXFuUExSeEFKRzFqZVJMK2xUY3NqYzQvVHlYY0ZrR0tTa0s2Y01VMzV0?= =?utf-8?B?ckR5aE1oQW5PeUtLRUNTbXZNVlVXZkdiVHQ3cTcxTXNXOTd3NThrSm03b1VM?= =?utf-8?B?MFBpazdkdWpxV0FrNE1UQUdVYTNDMDNxTW9vMG9RdVFXV2FiSitGRjZ3ZU05?= =?utf-8?B?ZTIvVktzNWhDMjh0NFQwNVVBc1NkeFZLRXhFeU95cE0yU254dVVJenhUWkVP?= =?utf-8?B?a2ZPSDlFYWN2TlpJcFJobm03cWtwR0wxc3VDODV6UTBHcWV0N2k5Ym5oeHg3?= =?utf-8?B?RWx4SDhXaTBpU2tjUGNXZVE0NHRmcFFBdGtBUVRSRDdTV2ZBMmJ0Ly9KZGg3?= =?utf-8?B?V01sQks2R2NSQnlQcUJNc2loNUVaTUs0Zm1uclRtVkRrN3J6M0VVL3g0Ry9N?= =?utf-8?B?Z0QvTGpYRnNMM0tzSllpYnBBZjBZaGR5dkJ1Qi9Ra1JJQjhHYlFjZTJFYnA3?= =?utf-8?B?ZlhtWEs4VmVpMEhiZHdiaDV2dk12N0pzRjNMaVYxS2lBSUs2OE4xcWJBZVRm?= =?utf-8?B?bnA0OVg4aFVueHhpOTFpL0x1M0tIZE4xeFE0Rk12eWduMi9RV0RDejJSZlZ3?= =?utf-8?B?Vm9PSnd6QkVwQUx0RmZOL3dLRVBwYmhmM242NzdNY1J0bk5FdXlMRmpnRFFa?= =?utf-8?B?TGlCYmJhK1h3dW5wQTJESFgrM01xSFYrRVpZUE1UdGNha0Vzc0VDNzZzK2ZX?= =?utf-8?B?cUhpd0Q0TmFtQlZ5RjNNa1lGUldPanB1NUZkQjUxeTFUWnNmZzBwenFmVmVx?= =?utf-8?B?T1pSaC9TZ0d6Q0M1cGZ6K0hreTRpc3lpdC8xd1ZYS0krdzhsZzAzNlgrWmJH?= =?utf-8?B?YzhlZFpKWmJNOXhoV280S28rUTRQRDZlVUZUQXFUREhwQTNNWkthWU10dXVQ?= =?utf-8?B?aXR3Vmhwb2VDQThDTVhRbGVVWmdqTUhFdkxKcGpONzBrSTZhektmOHpiQUNX?= =?utf-8?B?eDRRV3NIQ3dETVoxclhlNEJ5N3NtdXJmeWpsa3k1MFdkb3hQY1VVUGdyM2M0?= =?utf-8?B?RjUwcXFkbHNwc1dLS3VEd0FFOEY0MXI1d21iMGtDTENGRFo0R2xSVS9xQ2xy?= =?utf-8?B?QVVpZXVCUG03R1VMS0dOdDdVYjFTamNBdWdsTHhLZURwdU9hb2g5bmhZL1ZQ?= =?utf-8?B?aDF3N1JSMXZQZ1ZHWGowbWp5eUIzWDQzU1JCVm91KzZNSzYvcnBGckl3UzBM?= =?utf-8?B?SEtzRXBHaWxwMjE0a1JEQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2c6a5f8-9664-4738-dd73-08dd93442c62 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2025 00:05:17.2561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2P250MB1096 Subject: Re: [FFmpeg-devel] [PATCH 7/8] avcodec/svq3: Check that for 8 byte space before subtracting X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, May 14, 2025 at 06:34:25PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> No testcase >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/svq3.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c >>> index f730358e2f9..30bc9334af7 100644 >>> --- a/libavcodec/svq3.c >>> +++ b/libavcodec/svq3.c >>> @@ -1173,7 +1173,7 @@ static av_cold int svq3_decode_init(AVCodecContext *avctx) >>> int w,h; >>> >>> size = AV_RB32(&extradata[4]); >>> - if (size > extradata_end - extradata - 8) >>> + if (extradata_end - extradata < 8 || size > extradata_end - extradata - 8) >>> return AVERROR_INVALIDDATA; >>> init_get_bits(&gb, extradata + 8, size * 8); >>> >> >> Can't be triggered: This code is only executed iff marker_found is 1; >> and given the "m + 8 < avctx->extradata_size" check in the loop it is >> guaranteed that there are at least eight bytes of extradata available. > > True > > Did we ever had someone miss such distributed checks and > produce buggy code through a change ? > If not then i think you are correct here and lets skip adding an > explicit check, its ugly to have such redundant checks > We could avoid the whole marker_found branch (and the variable) by moving the whole if (marker_found) block into a function of its own that is called where currently marker_found is set to one. I'll send a patch for this. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".