Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame()

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Michael Niedermayer:
> Fixes: CID1591924 Uninitialized scalar variable
> Fixes: CID1591938 Uninitialized scalar variable
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/dxva2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c
> index 1a33c8bbac7..22ecd5acafe 100644
> --- a/libavcodec/dxva2.c
> +++ b/libavcodec/dxva2.c
> @@ -906,7 +906,7 @@ int ff_dxva2_common_end_frame(AVCodecContext *avctx, AVFrame *frame,
>  #endif
>      DECODER_BUFFER_DESC             *buffer = NULL, *buffer_slice = NULL;
>      int result, runs = 0;
> -    HRESULT hr;
> +    HRESULT hr = -1;
>      unsigned type;
>      FFDXVASharedContext *sctx = DXVA_SHARED_CONTEXT(avctx);
>  

It seems to me that this (and other patches in this set) is not a real
fix of a bug. These functions are called either with a D3D11 pix fmt or
with AV_PIX_FMT_DXVA2_VLD, so these variables are initialized before
their use.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".