From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 10CFC43ADA for ; Sun, 11 Sep 2022 04:38:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 610E568BAB9; Sun, 11 Sep 2022 07:38:46 +0300 (EEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072047.outbound.protection.outlook.com [40.92.72.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4542F68BA89 for ; Sun, 11 Sep 2022 07:38:40 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=miyml8FCd4lUYSzLm7ptA0DZcljLDFEtiZDAC3dyB1YMWLB4EQ2j3Fs6x0+8eKoBAgb0kVKchBhTDMGYS4+Ow3A03OgN43BJAvwgxMsFB7fiiYIL7ih0WOzkkBGBoNZ/WQZ9LnLZbQGYlV3lTfpto0IjgdFwq2j4KklECg1JNiQi+Jn4cIPdBrixesKIZkvN3Zsf6zHtCaZec+F4l+0cCKLvmMsHGj2bMfwTgkNhYBoUfGWuE1L8PvKvi7SjP0dcQbpoegUhr6Ju7KxXJSViC881/ClswHFG6O5jTgJ6ACRE0n78YaHCbN+Kt/rnOym5tmnKlPjT/zvxNBX03YE4KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ufMXnBDobGsHQ0yU2z2m1t2K5JcsoKiLwoZcUn4keQ=; b=d6zXQHI5w7B0TbkcIuvK30ppnf6D8bPSGPKUcWGFCd+a4bD+wyR50yD/7dwKVLIdlZdei2SP/NF90QaF/agHkNYnTeR+CxbATZanuv5m09Dv3+HpWABwRLJh7HobpQtcNPhxK6x6VExH5k3XcERwgUh3Bk8f4dgqM64VFqt7n/V+lZEOLFIeeZUj7JAFax73VuCAkmaWt2rXSE8ZiqKdW49MTkmDvseADCWWZNJI/nzzBqWEtdRZv9WYelDq90v34X3FNPOyXovVHNM56wfWHUn1IjcGxBnjvw/cF79T3K2Fdi1jVKThUiXxqJckayaRmUOSrYaezAckVMvvjjgn/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ufMXnBDobGsHQ0yU2z2m1t2K5JcsoKiLwoZcUn4keQ=; b=iu0C2jeIhh2l6TsCBsNdAPKeYBMZq+nE6d8uxgNMq9Ip2pJ/OhLAdH1Y8szaTW0W82t0dJMKcnNUDMZFHKE2W0PstlI56+cmEdBRN8fNe5FdvJSW+nkf1Z9omKtcyiIe92r0r5+a9JCxu27ZHpw3GIl4o52Dt+qoXjW4xUZXKut/G73wZ3gWWcyL2kL60MixAAxVpAmMlkjVHmSQcKi3nxWMhsKthgTMtT4DAKwVCODzbMnDLDj/hLfO8doBsK3H0O9Yqa7aw2r/M7ZY4hlhrPtAsLCTvR3H/QdvbMp1iMMOSzQ7RrMKfzCKMA/cp+tMOdXMy4lTtPgXneAma6xPBg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB4P250MB0757.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:37a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Sun, 11 Sep 2022 04:38:37 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::36a0:c1e3:9fee:2125]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::36a0:c1e3:9fee:2125%2]) with mapi id 15.20.5612.022; Sun, 11 Sep 2022 04:38:37 +0000 Message-ID: Date: Sun, 11 Sep 2022 06:38:39 +0200 Content-Language: en-US To: FFmpeg development discussions and patches References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [KtFNPvIHjajqQy0j07w+lIUVpWxIB8h87H/+XzY9oMo=] X-ClientProxiedBy: FR0P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::13) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <49bad95c-9cb6-6444-cbe3-c3952c2b5e59@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB4P250MB0757:EE_ X-MS-Office365-Filtering-Correlation-Id: 08224b92-04de-4eba-2957-08da93af7e30 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RfUfW+E72nFKmhiq284am3T0SNk/Z3cHXVzRCh+kq3H3h6sLttBb7lWUkt49C6zt/uBNK7yxv4hpFDP4i2fLvQVnBApabP6+h6l2g7XvIBR6cKiGJldz3rzZIkvnNfdHPB8xb73MaJSarOQkYMAhsD6m+R6HwglO/47DCQIHERdy49fpDBfv9QtU2naSK2PM0kBmPaSswyOwT5FjiXz7pF8ATGH/U2rOMM6RSGzvK1zdkVjK6o0VX8wekJS7sQA2h/0tHumJYD//XbejZyv0kE/ikygGeF0w3y6yWuEjwnshJJ8P5ZVNrqGHIF1FR5n1Sp81dgkgEwMW3wCIBtsdb9b5oLRuypJSfeH5/t2CyO5/HiRfXjwL/mlzS1VUV2S9tNZUCfRsfEdEbxiuLNP/aMMugrvE6AYyjVEv23gllqNbsMcAcpe4Z2h+lNV5Di+qWqKAOUJTnIQZART7lHeYP1RbUro2fAp6KVnxSUnRD1GmDYzJJ5I7F2i+2nNznwtXloCVsfd+dPm+49oTVNdsQWygVRZHUUPi//eN648787k1kGIippP1TByLltlsanyCCzOnQTXgQJq3WG4Px6ySQNcyRUpSB1DOzOmnNUyk6e8QSpzwjGeZ4jEtWZoWFmlOZagLb56nSkJgLtf4lsrQuEPOeiaRmIpWcQoFBQ1i+WLki2jaOkH+XwPCThIKPL74 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVNVWnpKbG9WS2QwTkY1VVJ5RmxHNC9ab2hFMnY3UnVHZEg1NHNvYmwvSWV5?= =?utf-8?B?aDlKcExZTTBhQ1JqZFUwVlVmMkh1VkRGeVJpY0p2M3hRbk9kL2RaN0g5a2t3?= =?utf-8?B?U1lJaFh4WW5WM2s1K1g2eFpyYmx3TzY5eXU2Y0VqWFNwUlVuVlIrc0JxL2RW?= =?utf-8?B?cG4vcW1kcGJPNG5TdUZqeXlkTjVUb2FoQ21sNEY0ak9FRWY5ZEt6bDdMMHBa?= =?utf-8?B?dUxnN2hOcTVPVzkrcEJ5NUZwTHdDK1R1QWUzYVVEM1MxV1hQSnNXT0E3QXhB?= =?utf-8?B?NEtqS2dkeStsU0tZaEhGOWhlemVsdTl3V0xwOGpDUEdWZDBjMEQ3OHZjQXZC?= =?utf-8?B?YnFWNTg4WVZuVnRZUmJPcXB3YS95TWp1amRuSDkvaTdla0h5Q2RCb2NKRHZW?= =?utf-8?B?NUVNam55VExlSFV2RHUwV0x5dHZIQ0o4dGhjSVdsM2VkSGpadDk3SjZCSVl0?= =?utf-8?B?ay85OHNmRFJ3b0NEWjN6WDI1OHE0Rzdha2k5OFpKME9XMExpUUUzVUJWei9J?= =?utf-8?B?QUFNMUZ0S252ZVdEb0dKNjJ4VXFqek53K3VZOUozbWRKa2dOQzlpOE56Ymhp?= =?utf-8?B?L0dDR0gyVlE2Y012VXN6ZG1MSy9NQ0xWQ3pNLzJ1TEk2SkY5OWZGdHMyVldQ?= =?utf-8?B?R2Z5K0ZWTVMwYmp1ZDdBU25rMXlGd09uRG1rS3JtMWpmQTliY0FkT2REUlo0?= =?utf-8?B?YXlUMjdtY2FUWlM3ck9KaDNxeUZDOTBIeDFubVVKVlNYdlI0djVqV1Q2bHBl?= =?utf-8?B?UnlDMGpoR3hIMVl1dlpuZDVXbUN2TU5IUnk3K1JnaHFIdnFUclI3eXRJdFBN?= =?utf-8?B?YU1zeFlBVWk5UFhRM2RxZHVvWGlFcEVNeVgxa3VqVmlzbk85WlVvOFJpRHRB?= =?utf-8?B?dnVUVUdTakJMMmJ1bWk1N3VzYk4yTytVdHFZdHFhcHcwaHlGdFZpdFdrMExS?= =?utf-8?B?c1ppVWNrdS9wNWp3TVkvOUltNCsrNzR5WEZJSEI0ejE2Vlc3WVR0VU8ydmxU?= =?utf-8?B?SXN4MUVObWdNc1NpeEFWbHhGc200N0JYek9MaFFoYlp6S2M3VHBrMnk3bzBo?= =?utf-8?B?SzBqemthYy9XdkZKN0ZQcmg2Yzl4ZkxVQlNOL2x4VHFtOFlrV3c1NmplSzBJ?= =?utf-8?B?ZTN0cXZlcm9iODlKZXRRUnFBVGRNYkxPZ1hVamROV1FUbkpUaWNFdk04blQ1?= =?utf-8?B?UjVyK1cvSFYzQTJicC9oTVd0NTBjaWh0bnFOcTVmbHZ2U0FIU1I0SjcvZzNT?= =?utf-8?B?QndtSmRvMVFMa2hmdXpSYnRXOHJTdThKOGp4N0tqTWpFTDAvb3h5RHhDNDZJ?= =?utf-8?B?Y1d0QTJxU1BHSVlpaUNua2s5RFMwTHhhMnhML3hWajhFdG9tcS9wdENOMDd0?= =?utf-8?B?OTFybjFxWFBWbHBqK2ZRcHYyNWJ1ZkgzL2wwcUI0V0JBeHlPSkZMa1prQXRM?= =?utf-8?B?YWZUR0dHVmZsak9sN1Z4eGdyMlBrLzdaM3psRGNWWFNOSmY4T2c5WFRDVVZS?= =?utf-8?B?WXcvdU9lWUdLTEpJS2g5MGZrakp2dy90TmVHZWpPeHFuOFFuUyt5ODNtMENw?= =?utf-8?B?Z0RqY3RTN1IzMGtQMkpjL1A0Um43Q0x4aFVoTFNING1yYnpSYlJvYUpEc09i?= =?utf-8?B?M3pHNjdBb2RqOUVLRFVhMGI3QVMrWUpvQkZMMUdtdW40aHZMdlpCR1pnTTV3?= =?utf-8?B?U0pRNlVEV2RMQkZ3RVY5NDVQRmNJcFR5eWVGV0g1SWNYejFHenBjRmJXVTdo?= =?utf-8?Q?ENnS2O7xd9XO3fR4ugwz/JLV3B0vdS4XxW2Plpz?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08224b92-04de-4eba-2957-08da93af7e30 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2022 04:38:37.3866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4P250MB0757 Subject: Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Peter Ross: > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: >> It is a VP8-only feature. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/vp8.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c >> index c00c5c975e..04a2113cc8 100644 >> --- a/libavcodec/vp8.c >> +++ b/libavcodec/vp8.c >> @@ -637,7 +637,6 @@ static int vp7_decode_frame_header(VP8Context *s, const uint8_t *buf, int buf_si >> for (i = 0; i < 2; i++) >> memcpy(s->prob->mvc[i], vp7_mv_default_prob[i], >> sizeof(vp7_mv_default_prob[i])); >> - memset(&s->lf_delta, 0, sizeof(s->lf_delta)); >> memcpy(s->prob[0].scan, ff_zigzag_scan, sizeof(s->prob[0].scan)); >> } >> >> @@ -2171,7 +2170,7 @@ void filter_level_for_mb(VP8Context *s, VP8Macroblock *mb, >> } else >> filter_level = s->filter.level; >> >> - if (s->lf_delta.enabled) { >> + if (!is_vp7 && s->lf_delta.enabled) { >> filter_level += s->lf_delta.ref[mb->ref_frame]; >> filter_level += s->lf_delta.mode[mb->mode]; >> } > > what's the motivation for patches 01 and 02? > are you not just adding another condition (is_vp7) to evaluate at decode time? > if its improved readability, then suggest renaming 'lf_delta' to 'lf_delta_vp8' > > pathces 3-18 look fine to me. > is_vp7 is evaluated at compile-time, because all the functions that use is_vp7 in this decoder are marked as av_always_inline. If it were otherwise, several of the patches 3-18 would make no sense and would just add another runtime check. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".