From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B56164AB2D for ; Wed, 12 Jun 2024 13:54:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2486068DA22; Wed, 12 Jun 2024 16:54:37 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2102.outbound.protection.outlook.com [40.92.74.102]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC83868D99C for ; Wed, 12 Jun 2024 16:54:35 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNy+rG2i7eZPwP6yZCzpzk1li7YfMRtucIyLrrFM5o0o7CUmZxVJRVU22RSgc8wF5VLJI/nKS3zaqQJiFfE+vQ3vOECy+eZb30TlzQeZ6ptHK4U6R9Zv1dieNhIT+HJIHUD33tJljztn0LfL5UDi8CNZCueqIyTlFmtg10OMFKjKKhoKKxzCJdHRv92q2NkSAABYHST2C3SbiNhDIhVmPM2n/REwhl87qgmnsL2Lhdm4G9CTlU57zeZqIvSZOEjwVR9Zqd6nkuCfHkwsS4A/v2zDVbHoVXJjYWBcxQOt1OS3ffD/twrLK3sNOmYS9rCeduranzaxYP8cTL5dwxqK/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8e2dZGw7ExuQ89WCh1jdOmX63nOXhbQgvyxwYLiHJWo=; b=ZjzO/aQ/PCT1wJ5OEe/8mkeSHiKL9c1u2NRvrI4ZKz7cQfOh1wxOIu7qknXbfHhp8ioyE4SlIEwb2mZq/br11UksQgVxHwXe7iNb3BjhBOGzYirdGdTSeRp5B/lBvD7GNhn/ofxHTrbQ2WYW6+27a4ZNuIrMUwpRnxwvSVLmtqm4K0rbq3KmqMO6FYrC1Zh28MKwxHL3gmERPhSlB5+gnf3FglZLTyOoDGWV2epJDEJBrQ15WVo9WRCtGbiAe8m1TeX5YI52ZF1Pe/KWOH4vISGtzIMsZt4EglbXtW4RF8oq+oN73ix5OWQo7PqI94OgULySL9a0Y6dGmXiv0G+fzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8e2dZGw7ExuQ89WCh1jdOmX63nOXhbQgvyxwYLiHJWo=; b=mNKWxiWmLF9MxEQYA1eNLgOSoX4uoRC7nZYArEWAGTaWpSF861m2MAhswzg47P8Dr0olqeZzz4a7FF8EBdhqJ4b2VfysqU3+X9wt/7+pFIhPzyOBvJUUbKdHDBOVfbNE1owrEVsv97hTg0HHU+bLUVyUPOk39akpHWhksxvzSPqDQg6nwrLxmEix9ShlNs+i7dxKaUY67YsXazTuRQ1ZM1706ckDJ0s4YFk2xYwOEgWmXcTIGTzcDZbmRVxzc5FOEB45OY6qBReUaw6X2j5IqePl4QHljqBVOUXQnvYjjyFvl66QauyJsYkzdjokuCyJwjyoVSFLVSCw7AikmCyKvA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0204.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.37; Wed, 12 Jun 2024 13:54:34 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7633.036; Wed, 12 Jun 2024 13:54:34 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 12 Jun 2024 15:48:31 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [57MCH9IwwHAFqlTCP+IFkHNCh53Jpw1peL4wYNGoCB4=] X-ClientProxiedBy: ZR0P278CA0189.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240612134853.2102377-34-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0204:EE_ X-MS-Office365-Filtering-Correlation-Id: cde602fe-85ce-4cc4-fa2f-08dc8ae730a4 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199020|440099020|3412199017|1710799020; X-Microsoft-Antispam-Message-Info: EqYaMZkH2fhRzknhXsXcBS5qgEWmihNsp5v2EWacd74cI7SrpQnXXQRzCLoSDALG3CiMGQJ9kH1qOaM3MjHezFkNLxlN8HYd5buq/XtHRXKiFYP2iYrB9ecJn1Or1FtEirnTOd2/wri36KdmHBW01TPnaWMyEDuOzyh06oEgL+oYrVXGkLq+9XnKM0qfzhjSu20vH8QtoWryuvGTlbJ8XlBiGZsUVajPqmiTeSGpAphPokxSgxcFrtohCfWOLwiHz5pu36PCTh4u1So/qs7544nTqVTqKDcGY634MSdHSOW7uwMm+H2FCj3F1cpGLJ0WCrZ7Su0vXocyKRk8+c8gf82Oe9uwY/Elj13ctXwyR4D3Vcc7PRx7urIAYtLXVdeUUdoq1OIt4qf39hFlCljfreXf+SraAeRdO5lmO8LTlDYmCBCJAiXGVpv54yRDthHR3GvMxRUha0hD933edSLRMxctZcXi890GxPsEkONTVqsRUxT2WFr+6SQAmRgHWdS26PZOcUaRlwlRqGmLWEV+hj1e5uj28vuLV8/hsbaeSJoYYk1ISO91F+ndp8+msG6SoUJ1cvVIF6n+AQdTd/PXJkdypDooycRbzohr2WHmy0bW/huF1S0Ye1aHNZKEq0K1 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CyHxNLvqxCRO0bOVv9/Ni7XEXYxEwjrzOhmlA67pPJguzJ4/YZkX8quFOIqG?= =?us-ascii?Q?hKmk/aPk03MB9oa40K9WURTNaKkUq3BBYGTxGj/NeiwI3vv1HSmcE4ACiuZ0?= =?us-ascii?Q?bkL+Ku7MA98ngjzYIVnCL2ZVqCRQhhsSRT646CHRVlAkqnEvxJfOcga3f5Ff?= =?us-ascii?Q?Pxp/f1nMQGGmuCNwDI7tGb3CXu5vHRoPkWyxzrZ/zD4t3oLDAxy/ED4ebw2v?= =?us-ascii?Q?vJT0GYPPysD6edRqohfgC27Aruh0LkVimzKynL5XjDzLrErA3s3vi53WO3CU?= =?us-ascii?Q?2lbs8EhB3dMa2hGaNtLSzqguK2gIG7WlS+otAmz9+dZggn7KVFda1BxeNv6P?= =?us-ascii?Q?Wk+O1VKkACEbscubKaquPWhZiSrzBMNDqy1YwiZIpb2YDf8aL51FKIaA9ZmY?= =?us-ascii?Q?qQZXKvr7TVXOolMBGV2ax9BxXmlybm6ASZYhFqsjDrnP5oL5p0Zg6mGDsz9k?= =?us-ascii?Q?aAXqajiOu5jvO4SWe6yGYFpoK/5dhytxTMXBFPeOrfcTq/HC63A5yna/CGJ1?= =?us-ascii?Q?USL/mL9zytsmnuRtrlCCMuZiONJJuECIX6O7mqkEreLc4T7aqZ9tihDWCbF7?= =?us-ascii?Q?wWn8x7CuUDv3p3VRWZSa450wQsK0Em6RKk/tORwg/I+oe05dpUOs5CUmJ4X4?= =?us-ascii?Q?OamLQwMIO4sDtEd7ImvttdwA9K5LPH7B6SEtTAkCJHUTJW+vQHMa8imVA0ik?= =?us-ascii?Q?BPyBzmUAHn41Xe+praNmteOYyxLiccDp3ev6DW6S/dyBRnzr4nSqoIVRUagc?= =?us-ascii?Q?G0axJOjUikm73aG56rogFmrGcwYi9aW0I4WmoIe9yF3/V9hyL6FmWxzaevmu?= =?us-ascii?Q?5eQ0W9/PVVgj9es6RQV8P5LliC79kAiWRsE+P2ExF5TjODRc3tICtIoBsCIw?= =?us-ascii?Q?izgWyY7ZessjMdSruMiQ6RTbo2f3sYV3a5GsIXVFM6M/6oJIObx5iDgOXHUG?= =?us-ascii?Q?lu4zshiYEgvC0pBAtzPXfMnvziY171jyMzBNjS8igNBHVmsm93s1ZWU6bW3q?= =?us-ascii?Q?STHQjuDI9yRbtQ5JBnTpczydujoh3hfo7SrZpVJ1QZ2mBU5gYCVB9ftBo9xc?= =?us-ascii?Q?XoCUKejztlWnAL3Fjp2zO9f6JTcmuLwejTuKoJg/W6XlY/SUqJ5COT6N14Kl?= =?us-ascii?Q?mPy+E2/B+kH7x32W9qJQhHb2yQqwIx7NpnodFNi/myc14N16tqs0HCZ3EJVL?= =?us-ascii?Q?xSeHcKzXa6ciDOnRjjNHLDZPXEDnFrwaHnTft52HBl5S+F0+2Uwg4k8lU5Hq?= =?us-ascii?Q?crKxy8Ayjq3hk36KoQts8v56omXa2yJ/Qh+HrhVfnQ=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cde602fe-85ce-4cc4-fa2f-08dc8ae730a4 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 13:54:33.9829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0204 Subject: [FFmpeg-devel] [PATCH 35/57] avcodec/mpegvideo_dec: Don't alloc framesize-bufs in update_thread_ctx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: It is always allocated in ff_mpv_frame_start(), so the only reason to put it into ff_mpeg_update_thread_context() would be for the case that a frame-threaded decoder that supports coded fields implements frame-threading. The only mpegvideo-decoders supporting coded fields are MPEG-1/2 and VC-1. The latter's bitstream requires both coded fields to be part of the same access unit/packet, so that every frame thread will always call ff_mpv_frame_start() itself. The former only "need" the framesize buffers when using lowres. If MPEG-1/2 gains frame-threading, one could either perform framesize allocation in its update_thread_context or when starting a field. (Given that the next packet may trigger a reinitialization due to a frame size change, it was possible for the buffers that were allocated here to be thrown away unused.) Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index ad35505819..b3753b6ad2 100644 --- a/libavcodec/mpegvideo_dec.c +++ b/libavcodec/mpegvideo_dec.c @@ -160,14 +160,6 @@ int ff_mpeg_update_thread_context(AVCodecContext *dst, s1->bitstream_buffer_size); } - // linesize-dependent scratch buffer allocation - ret = ff_mpv_framesize_alloc(s->avctx, &s->sc, s1->linesize); - if (ret < 0) { - av_log(s->avctx, AV_LOG_ERROR, "Failed to allocate context " - "scratch buffers.\n"); - return ret; - } - // MPEG-2/interlacing info memcpy(&s->progressive_sequence, &s1->progressive_sequence, (char *) &s1->rtp_mode - (char *) &s1->progressive_sequence); -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".