From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 3/9] avcodec/opus: Move OpusStreamContext to its only user
Date: Tue, 4 Oct 2022 00:44:59 +0200
Message-ID: <GV1P250MB07378422E82E2658B3B8CD808F5B9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737B923F3D6B89664C7F2E68F5B9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Namely opusdec.c.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/opus.h | 52 +-------------------------------------------
libavcodec/opusdec.c | 47 +++++++++++++++++++++++++++++++++++++++
2 files changed, 48 insertions(+), 51 deletions(-)
diff --git a/libavcodec/opus.h b/libavcodec/opus.h
index b73949a811..264128f09e 100644
--- a/libavcodec/opus.h
+++ b/libavcodec/opus.h
@@ -25,12 +25,7 @@
#include <stdint.h>
-#include "libavutil/audio_fifo.h"
#include "libavutil/float_dsp.h"
-#include "libavutil/frame.h"
-#include "libavutil/mem_internal.h"
-
-#include "libswresample/swresample.h"
#include "avcodec.h"
#include "opus_rc.h"
@@ -98,51 +93,6 @@ typedef struct OpusPacket {
enum OpusBandwidth bandwidth; /**< bandwidth */
} OpusPacket;
-typedef struct OpusStreamContext {
- AVCodecContext *avctx;
- int output_channels;
-
- /* number of decoded samples for this stream */
- int decoded_samples;
- /* current output buffers for this stream */
- float *out[2];
- int out_size;
- /* Buffer with samples from this stream for synchronizing
- * the streams when they have different resampling delays */
- AVAudioFifo *sync_buffer;
-
- OpusRangeCoder rc;
- OpusRangeCoder redundancy_rc;
- SilkContext *silk;
- CeltFrame *celt;
- AVFloatDSPContext *fdsp;
-
- float silk_buf[2][960];
- float *silk_output[2];
- DECLARE_ALIGNED(32, float, celt_buf)[2][960];
- float *celt_output[2];
-
- DECLARE_ALIGNED(32, float, redundancy_buf)[2][960];
- float *redundancy_output[2];
-
- /* buffers for the next samples to be decoded */
- float *cur_out[2];
- int remaining_out_size;
-
- float *out_dummy;
- int out_dummy_allocated_size;
-
- SwrContext *swr;
- AVAudioFifo *celt_delay;
- int silk_samplerate;
- /* number of samples we still want to get from the resampler */
- int delayed_samples;
-
- OpusPacket packet;
-
- int redundancy_idx;
-} OpusStreamContext;
-
// a mapping between an opus stream and an output channel
typedef struct ChannelMap {
int stream_idx;
@@ -161,7 +111,7 @@ typedef struct ChannelMap {
typedef struct OpusContext {
AVClass *av_class;
- OpusStreamContext *streams;
+ struct OpusStreamContext *streams;
int apply_phase_inv;
int nb_streams;
diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c
index d255486d06..87a86b6b47 100644
--- a/libavcodec/opusdec.c
+++ b/libavcodec/opusdec.c
@@ -38,6 +38,8 @@
#include "libavutil/attributes.h"
#include "libavutil/audio_fifo.h"
#include "libavutil/channel_layout.h"
+#include "libavutil/frame.h"
+#include "libavutil/mem_internal.h"
#include "libavutil/opt.h"
#include "libswresample/swresample.h"
@@ -63,6 +65,51 @@ static const int silk_resample_delay[] = {
4, 8, 11, 11, 11
};
+typedef struct OpusStreamContext {
+ AVCodecContext *avctx;
+ int output_channels;
+
+ /* number of decoded samples for this stream */
+ int decoded_samples;
+ /* current output buffers for this stream */
+ float *out[2];
+ int out_size;
+ /* Buffer with samples from this stream for synchronizing
+ * the streams when they have different resampling delays */
+ AVAudioFifo *sync_buffer;
+
+ OpusRangeCoder rc;
+ OpusRangeCoder redundancy_rc;
+ SilkContext *silk;
+ CeltFrame *celt;
+ AVFloatDSPContext *fdsp;
+
+ float silk_buf[2][960];
+ float *silk_output[2];
+ DECLARE_ALIGNED(32, float, celt_buf)[2][960];
+ float *celt_output[2];
+
+ DECLARE_ALIGNED(32, float, redundancy_buf)[2][960];
+ float *redundancy_output[2];
+
+ /* buffers for the next samples to be decoded */
+ float *cur_out[2];
+ int remaining_out_size;
+
+ float *out_dummy;
+ int out_dummy_allocated_size;
+
+ SwrContext *swr;
+ AVAudioFifo *celt_delay;
+ int silk_samplerate;
+ /* number of samples we still want to get from the resampler */
+ int delayed_samples;
+
+ OpusPacket packet;
+
+ int redundancy_idx;
+} OpusStreamContext;
+
static int get_silk_samplerate(int config)
{
if (config < 4)
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-03 22:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 22:32 [FFmpeg-devel] [PATCH 1/9] avutil/attributes_internal: Add visibility pragma Andreas Rheinhardt
2022-10-03 22:44 ` [FFmpeg-devel] [PATCH 2/9] avcodec/opustab: Avoid indirection to access ff_celt_window Andreas Rheinhardt
2022-10-04 12:14 ` Michael Niedermayer
2022-10-04 12:18 ` Andreas Rheinhardt
2022-10-03 22:44 ` Andreas Rheinhardt [this message]
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 4/9] avcodec/opus: Move stuff shared by decoder and parser to a new file Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 5/9] avcodec/opus_celt: Break cyclic inlusion of opus_celt.h<->opus_pvq.h Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 6/9] avcodec/opus_celt, opus_pvq: Move CeltPVQ typedef to opus_pvq.h Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 7/9] avcodec/opus: Move remaining celt declarations to opus_celt.h Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 8/9] avcodec/opus: Move defines to better places Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 9/9] avcodec/opus: Move Silk declarations to a new header, opus_silk.h Andreas Rheinhardt
2022-10-04 11:09 ` [FFmpeg-devel] [PATCH 10/10] avcodec/opus, opus_celt: Fix header descriptions Andreas Rheinhardt
2022-10-04 21:40 ` Lynne
2022-10-04 22:39 ` Andreas Rheinhardt
2022-10-04 18:30 ` [FFmpeg-devel] [PATCH v2] avutil/attributes_internal: Add visibility pragma Andreas Rheinhardt
2022-10-09 16:03 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07378422E82E2658B3B8CD808F5B9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git