From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5C30A42337 for ; Sun, 9 Jul 2023 01:03:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5CED068C556; Sun, 9 Jul 2023 04:03:19 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2051.outbound.protection.outlook.com [40.92.65.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EEFAF68C45C for ; Sun, 9 Jul 2023 04:03:12 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bULqLyFe2ufE5z+penXITuyxPMuAAPhqIvYPc1uzGE/HJqE6Np0AOKTX5YtemWEzvSnB3oHTZO5x7alZBHKu5PS/ZE/gilDVqG4YaaRHnJRCjvgKHmZfhaO+CK3SGVb4jINRUfUh8g6LCnHfRpTmjjaZVNrnjXz+IKpImuB03SBBswLKL899Ow3MCIluF2OctBrOd5ru7WXFYElm8FBVmdS1rrb3/lHBSWLl5dgnly5zVdGgjC/5UZ5dZ/kuUIJtk1uGQKGG9TouhcnM+vaJ5i51B4y/oVL7iIARQYqUyQLQtqlRdmBet7Pw9NL2PVzv5WkHi3JCLaZ7Q60Q3kxlMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zF+Jwjf7f22jzUVJeCCEtG7GDBolbgHxGayMjCHsjhw=; b=BIc3pUVZKfsN5tKMM3IU+jMVNgvGCulGVihZDaCS2eD7XzKoNdmSjxUqm4Nya4jfBwaUsVzF2imw1tEuE/4FGYV4zFuJ+Zb2MsfDXtRpVQchVi0UV0SLS3JmeDCjSsfT8pN9Ocwo7t8ENdn0hEuxbK1a8jHwjSATBRfUC1zaxt0JwLfI4zf6EhwUxj6CUB+3IDCyTRBRM4FnoKq3orAwGoCGMT5THqUxGkIqOiza2jZVWbST9sJ9TuKyQncQrq6eu5uq/Asx6voFy7DfOlTyYg5SETFx3YEQbAOKNSvLlNvv7gIRrPheGL+pf/iP8GtxAGX3vemtG05OcXM1PRU+Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zF+Jwjf7f22jzUVJeCCEtG7GDBolbgHxGayMjCHsjhw=; b=fb0OR9E1sW1SDwrMGAPa+YC7EewSdW2jZ0PCzwK8h3ukJVs0kE7Pxi/2wRpG0ZxjM4+td3V5bB7QJozr9eySyG1Ln96opREjZjcTGUZr5XQs/2EqS/2wY/Di8hctzboV77Eabaa2pYftSsmrECLEeETC0eM8thuAsEmnSipE08fFf1cCbfNW7E81J43bzX8eI1RifmDzOntjL3bgu7jior6bbzy5hjdnbe9FJTLVksvmB0KO7Jfep+EwyMwqlAfd43QMZi3Z1vxfe8Skewr8uv2CbSrTkNUkte4/CFoXyCT5lESm3X2emGp8YSaW1ymw+mt0KYUeCC3Ru87JrBhcUg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0387.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.29; Sun, 9 Jul 2023 01:03:10 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::8f13:2ef8:4559:907]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::8f13:2ef8:4559:907%6]) with mapi id 15.20.6565.026; Sun, 9 Jul 2023 01:03:10 +0000 Message-ID: Date: Sun, 9 Jul 2023 03:04:19 +0200 To: ffmpeg-devel@ffmpeg.org References: <20230707140540.10279-1-nuomi2021@gmail.com> <20230708214135.GA1093384@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20230708214135.GA1093384@pb2> X-TMN: [Jd1+jUOdVWPVZclrf4alCMCSVZx9+882] X-ClientProxiedBy: ZR0P278CA0126.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::23) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0387:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fc7b5d3-fa4c-4fa5-c25c-08db8018436d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XAuWUdsyPQG5mKsrwGGg8mXBNviSVVpUFg73HZBNYDoNABUGKb06vR1GJqN9gWgJMSj34KKeiwLEPkdTkeUxZP55DJARD7CRBbRrm4HkD98L3ERLEIJIu671rCgYA6mzfWIyz172Cev+gdBAPaDhIdZKc4UJY7L/zkX7bf40pPlnlWUCq9BXx2yaM35JLhzYyrLiKTDpp0MpJxropec4+VR9dlBUHJH68VnTtzsst9+wUSeSMxaHSZRGSXzFs3JDx3okKz8RfvD4P5NNDUlX2KbevUg3CY2A7pZ87xhagS5XancrZt+SOx/d61NKB5aa75m8ydRUhrvm46medHqeMCaHiRR/0v0m4fgjqMJSTh4wYFMJUYix7BrfRgDCktlbVTehL85rl93atSPjciSwJjx7EL7cD0LqYNPtOyBJaoWTmMxd0idlm7SwEadDMUk7omlH3Daq1Scxph1BCEKSYIi6aw2ZrJCWP5p9F17/Oc5f1YWAZ1WCX2YIxSCiUyqXZuZgzLlg2R2GinG7WmpbWYKUYmyGbLddrPCciPn+RxGz6T0DS4gM6Q9Can66mZaw X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVArek9GUjhUZzRNVHVuQ21MVmtLMXR1eVN6c1JSSTlqNEFRTnFtWXpFaWZ2?= =?utf-8?B?aWNUZHBhVURGejZXTGdoZ0pJK2pHNnNQbVVwRml2bHhPUjU1V1VvZ3VNNlU5?= =?utf-8?B?cXVOU3NuZmFzc1BSRG1tOFJLMmtISC81aGtWblhhQ28rdjZZejRjd2hQY05j?= =?utf-8?B?ZTkzNy9uME5FemNxUk8zZUg4TE1OalJSNm93MjhBQUxQd1NpRHEzYVFKOFpG?= =?utf-8?B?YUcrOUh0Qm1JazJaUlJjcE0yWG1KWUNyTjJ1MFdmUTRWWDY4c29uNlBLVnYx?= =?utf-8?B?M0w4OXFmMlBvWTh4bFJPQ21yNENLejVhSHJBS3FCWHdoVGZGRzVTSTB2Mm4z?= =?utf-8?B?SzFMTUE5cjUvVENZMXQ2ZVFGajNVME5HS1JOVld4c2dueHh1eUprS0hBbFVt?= =?utf-8?B?QnVHNjlhSkg1S0VJckovUFB5R3p4cFMzajBJQ1p3V1RnU0NiQXgwcmxNUGI4?= =?utf-8?B?RXliaVk2Z1lTRFJGWWh2dm9NNWg1QUxrMUd6UGJwV3BnNVdZMUUxbkFvV2U0?= =?utf-8?B?U2MwRGphcnFmWWppM2h4V1ZLd2FPS25FODNOVTVpbytia3I5VU9FSHZUdkFB?= =?utf-8?B?NXY2WHhCZTA3d0xpcmZVTTQ0dWF2S25TRXNOSWE0VGZJQTF2UW9MditmZ3VD?= =?utf-8?B?Y25DU3hDQXNiYWZ0ZWJiL1pCblU0QTJ0SHhieTlLdFRMSFVIWksrYWt2cHM4?= =?utf-8?B?OWdOd1RxZk4wTU1QZ2lldW1oTXlvQTNZOVhEbmhEYkV1amI0cjlIZ3kramVR?= =?utf-8?B?QWU2ZUo3dk1FckR4SHlQSVJ3blJYRG9yVjVtbFBhUlNCYXpuYUtiTW15KzFs?= =?utf-8?B?UTJxV2lqaDhvKzNLTnd1VXhoaGR0bUEzVnV2NWVzTEtZdW96Q0x1VFpMdVdH?= =?utf-8?B?cExNTkRjaDYzZkJlQkNmaTNVMHpINVNBYzEySjFHMG9xSjFvNEh0aTAxYW84?= =?utf-8?B?VHhXVlh1aXJ4cjVQbXVJYWg2YUxTNENxV2RLd1hQcldvNTNacjUzRzVVSlNF?= =?utf-8?B?SkdIOFREenF3OXBtZGwrY0FhWDZ4c0JORUhua0lFWWFOZ2xIcVhXcW9iR3Rs?= =?utf-8?B?aUNUZmo2eENjV2ZJV2FrSzNSYkJ1cFVMTVVOWXNGdnJ5K1BFQ2QwTFNTQlkv?= =?utf-8?B?cVdVV3J5WmNtc00ySGs3cUhjeGdqcnR3cGhOdFpyZVdTREpEWmFqOE5rQlBU?= =?utf-8?B?USt1TkNXZFUzNkNla3I0am4vbEhrUnZwVmRJS1lmK1hvUEM4L2lRdk1PbHVU?= =?utf-8?B?cVBBUmRHTW9oVkpDdWt3RGZIMkg5bW1DY0kzK1RWR0ljS0c5S3laSXBVVVRX?= =?utf-8?B?MXBHMkNTSkZEL21BQjNScWVoZFJGMWh1aTdwRkczNFVpMnhCSEozSFdZRjRi?= =?utf-8?B?YzR6NDA3QllxUmJOQTNRL3dXaCtQQ2R3c3M1MTFoNWNEc3V1QWI0YUx2TXlF?= =?utf-8?B?d0J5SXlidkJHRmhqc1JWckNTREZmY2lOdTJja0NVSXh6T2V4TStoZHFvRGhn?= =?utf-8?B?c3lIWndjeEhHd0F4V3c0LzdZeFNYM3d1eE4rK3FQckdxc3h2ejdUVjZuSWRz?= =?utf-8?B?SUl1SGhVQ3NWT2dDYjVWRmZ6bys5cnAzZ2tpeHJNSElTc1FjUXJXZ2pWVVVE?= =?utf-8?B?Nk9aNHp3OWRTeU5TQlIyd1U1R1ZXcHcvUHAzTVdpMkM4anJETW8wMytVemNL?= =?utf-8?Q?QSsn8F9pV/kR9TJpOIq3?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc7b5d3-fa4c-4fa5-c25c-08db8018436d X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2023 01:03:10.5033 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0387 Subject: Re: [FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote: >> This is the main entry point for the CTU (Coding Tree Unit) decoder. >> The code will divide the CTU decoder into several stages. >> It will check the stage dependencies and run the stage decoder. >> --- >> libavcodec/vvc/Makefile | 3 +- >> libavcodec/vvc/vvc_thread.c | 804 ++++++++++++++++++++++++++++++++++++ >> libavcodec/vvc/vvc_thread.h | 73 ++++ >> 3 files changed, 879 insertions(+), 1 deletion(-) >> create mode 100644 libavcodec/vvc/vvc_thread.c >> create mode 100644 libavcodec/vvc/vvc_thread.h > > seems not to build with enable-shared > > src/libavcodec/vvc/vvc_thread.c:235:9: error: address argument to atomic operation must be a pointer to non-const _Atomic type ('const atomic_int *' (aka 'const _Atomic(int) *') invalid) > if (atomic_load(&ft->ret)) > ^ ~~~~~~~~ > /usr/lib/llvm-6.0/lib/clang/6.0.0/include/stdatomic.h:134:29: note: expanded from macro 'atomic_load' > #define atomic_load(object) __c11_atomic_load(object, __ATOMIC_SEQ_CST) > ^ ~~~~~~ > 1 error generated. > src/ffbuild/common.mak:81: recipe for target 'libavcodec/vvc/vvc_thread.o' failed > make: *** [libavcodec/vvc/vvc_thread.o] Error 1 > make: *** Waiting for unfinished jobs.... > > atomic_load() does not accept pointers to non-const atomic objects in the original C11 spec (presumably the reason for this was that on systems that lack atomics of the appropriate size an atomic would need to be emulated somehow and this may involve locking and therefore require the object to be writable). Your system is old and abides by the original spec; AFAIK this point has been changed in later specs. The solution is to use a cast. - Andreas PS: Exactly the same thing happened in the HEVC decoder. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".