[FFmpeg-devel] [PATCH] avformat/mov_chan: Use anonymous union

[FFmpeg-devel] [PATCH] avformat/mov_chan: Use anonymous union

[Andreas Rheinhardt]

Fixes many -Wenum-conversion warnings with Clang caused by
e6c2c8703732bc46395c65c530038c8146df0deb.
See e.g.
https://fate.ffmpeg.org/log.cgi?time=20240325033545&slot=aarch64-linux-clang-10&log=compile

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/mov_chan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c
index d5225acddf..287059d65b 100644
--- a/libavformat/mov_chan.c
+++ b/libavformat/mov_chan.c
@@ -30,7 +30,7 @@
 #include "libavcodec/codec_id.h"
 #include "mov_chan.h"
 
-enum ShortChannelName {
+enum {
     c_L      = AV_CHAN_FRONT_LEFT,
     c_R      = AV_CHAN_FRONT_RIGHT,
     c_C      = AV_CHAN_FRONT_CENTER,
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: Use anonymous union

[James Almer]

On 3/25/2024 11:53 AM, Andreas Rheinhardt wrote:
> Fixes many -Wenum-conversion warnings with Clang caused by
> e6c2c8703732bc46395c65c530038c8146df0deb.
> See e.g.
> https://fate.ffmpeg.org/log.cgi?time=20240325033545&slot=aarch64-linux-clang-10&log=compile

Anonymous union, or enum (Re: subject)?

> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavformat/mov_chan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c
> index d5225acddf..287059d65b 100644
> --- a/libavformat/mov_chan.c
> +++ b/libavformat/mov_chan.c
> @@ -30,7 +30,7 @@
>   #include "libavcodec/codec_id.h"
>   #include "mov_chan.h"
>   
> -enum ShortChannelName {
> +enum {
>       c_L      = AV_CHAN_FRONT_LEFT,
>       c_R      = AV_CHAN_FRONT_RIGHT,
>       c_C      = AV_CHAN_FRONT_CENTER,
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: Use anonymous union

[Andreas Rheinhardt]

James Almer:
> On 3/25/2024 11:53 AM, Andreas Rheinhardt wrote:
>> Fixes many -Wenum-conversion warnings with Clang caused by
>> e6c2c8703732bc46395c65c530038c8146df0deb.
>> See e.g.
>> https://fate.ffmpeg.org/log.cgi?time=20240325033545&slot=aarch64-linux-clang-10&log=compile
> 
> Anonymous union, or enum (Re: subject)?
> 

Right, it is an anonymous enum, not union. Amended locally.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: Use anonymous union

[Henrik Gramner via ffmpeg-devel]

On Mon, Mar 25, 2024 at 4:01 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Right, it is an anonymous enum, not union. Amended locally.
>
> - Andreas

Can confirm this eliminates the warnings, lgtm.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".