From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 639734D0EC for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 04:27:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 94A85687D9C; Wed, 16 Apr 2025 07:27:51 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2015.outbound.protection.outlook.com [40.92.90.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 972EE687D79 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 07:27:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rzbZytuvBh6fcNef0VG8k9xkD+yiLZmIssz+vckIcPFctfNhcnnz5ZAHA5Ebm4IDOYTOsXl7Um0V062VnbT3G5CMaRDyeYOBKh71rQGLSGqS73M/iidithitT8EMIez2FgkZTvxKGsXH+uctLyZO6bxNl0AZvRj5BAuL6PDvXSxwwZutVio3S1CuZJvFSM5SBtkDR0Byj5H35rAyenIXdM1+OPzjhcn37XNrT6lUTbtIXBp/KOrm3R5gMrB77+nJu3ERH61nD1iuzAmjmrLucFbvPNXU0CumkOEMnickt4pGF3lnP5U6rBNEuiFAdJaor83K8gpALA2MK9PkLspLAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eXPtHDkWySdoYmJMBUg3q9SbosiDSVQ2h7M3Kuvjq4c=; b=mjYmE4bF9kxxYZUXmmYWwteRwVXrWJ9XRLLvpmxccOWEki+Z9ipl+ORNEZQb7I/hm+g979PBc3jJO/ZN9iCxoeGKnlMbsfV41bCtE1JJNqHT+1yUm/nBQNQml9o8p4HF/336J1Osw8ZHvDXuMhYxMp62mOd1M/7fTOVwVkPJG3/DOjRs0oZgFNGzWuyvU/6bS6xgsQ2mSVqyrWAg2yM5D2nQ+T3aiN6dnwHmkPxcU9WCs18sQ6Yamw+C6ryqUo9u4W2O5DQvzm0dSbNqZVrNFXWYmM1grVwKF1EQvis16weItr4WIqwsQSDfQo5uHx//7yAEVuRPnQQBGEtWl1g7nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXPtHDkWySdoYmJMBUg3q9SbosiDSVQ2h7M3Kuvjq4c=; b=pYKOntc8VNrqsD5yVU1kft0g7vYnyAfXfr+Mbzz600AiaACLQwQMha03nTGPCebqf5VS9VJS9UkrcI9X+Oo4NAs2NtB0VpIfyUcdmEq/y8TUKU4qOJaClQ3cGiv9mcWg+G167vGuhkTlxE88E+ArZF9XF2RIOmMMVVzC791tP+D0O0unNnpCBMhrn/X0q/q3VgQWGdKk1UX0s6PwGRDp48we+r5+GhajPR66Ze1JSlmFOxkqOVaGfYfEPfn53tRKfNucphjjrTOXJuLjZAydpFeKP6QRuO+sTZuP0lE+x1klicMVFAcKLmuXoq9DkkEsecEOgI8ejkiLyiJ3cEn+YA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0118.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:371::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.18; Wed, 16 Apr 2025 04:27:37 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8655.012; Wed, 16 Apr 2025 04:27:37 +0000 Message-ID: <GV1P250MB073782E37FF068C4070974E08FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Date: Wed, 16 Apr 2025 06:27:36 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <GV1P250MB0737FC8C3B89F1100A6324E38FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> <DM8P223MB0365FA00332594FD619AA750BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <GV1P250MB07376B6342E54BFF4FC853378FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> <DM8P223MB0365A746840DC346FCBA543CBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> Content-Language: en-US From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> In-Reply-To: <DM8P223MB0365A746840DC346FCBA543CBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> X-ClientProxiedBy: FR4P281CA0181.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <d8a8023d-6f1e-4606-a135-b491c86cda50@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0118:EE_ X-MS-Office365-Filtering-Correlation-Id: e108cf0c-247a-4404-139c-08dd7c9f0449 X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|461199028|6090799003|8060799006|19110799003|15080799006|7092599003|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WkpNdzVudVRHdHJLZWdVYzREdXJsaUNtZVlLa1QzUThVT1hoYks0UVliTHVy?= =?utf-8?B?djZ1dC82cy82ME55SklreE5sekwvV29IcG5GQmYvSHBjQ1lDU25SUVNjM1Jt?= =?utf-8?B?V2hPeWxPdVoySzVFYU81NktJUlNObVdoV3NkdEFwS0pEaExEdkpHQzlVV2pV?= =?utf-8?B?dXorSUJDdkZNWis3UVNWQ25pR1ZUU09zQzM5OUlnQlBhWlZjbXNYeWV4MXJ1?= =?utf-8?B?eXQzdVpnVWMxcExuOUJYNU5MWisyVDVSTHdJNnJBalR2UWlsajkwM2Y0TFlZ?= =?utf-8?B?RXdBYVJPRThwTDk4OHo2dWtpNG1wZGpiMkVIUUxrVTY1SUZ5NzFybFpzVjZJ?= =?utf-8?B?bWgwbnBOaEdLQ2lDOWhMQ3ByUTU1VnF1QzZpRUdKVXVhYUs1a1NRbG4wOGR2?= =?utf-8?B?YUppM05xTFp2THhKV1JRUEFVaWl0QUlYMndGT3pZRkpPbzhlSHNQREQwNjh1?= =?utf-8?B?ZlJmVHRLcnJsTGdZSlZmT25uVTRjQXBWSDMva3RURWNtK2tsSmkwMkdmbWxL?= =?utf-8?B?bEZvUnVNakxiaDErTnUxYUJ2VnNzU2R5SlBwWTZvSU1DZ1BaL2lvZmdiU1VB?= =?utf-8?B?YmVNT3lvU2YyWlNWZHR5VGJTazIxMTA0dlVxUE81bXFMdk50MHYyZEF1dkww?= =?utf-8?B?TGFlVXRTVUoxWEZxNnVSckZuaEJwRjgvYnptNzl1NjhWSWh1YXFjVUgyWmF5?= =?utf-8?B?ZS9aSTdEb2lzcWJkNld3bWV5bm9HQzNZMGxVRElMLy9EU2t3Mk1hbmxPaGZo?= =?utf-8?B?am5DQUVWWDhrNys1OHpURm81Rkl6Q2thS3hsR1lLZnNpRnBwa2ZYZHBXZGl5?= =?utf-8?B?eUhEUGdUU0RvTmQ1NklHMVZsRlE1SGNlckRvRTVxZ091Z294d3I0YjhHZVRH?= =?utf-8?B?NURQK1o3R0hSald4RU56dnJhU3BYNDl3R0VxeUNEc3R1ajhEVXRPVHFrdUhI?= =?utf-8?B?eGhENkJrNkh6R1NSaHVxTndIR3BVb1JSNzQ0Uy96TGEwS1g5bGFKKyt1YlJW?= =?utf-8?B?Vm9HZ0JmYmNEdHdrSlpjeGc1OGFaWmg5QSt1b0Z5QUsrODFDbUVrWUE4QmxQ?= =?utf-8?B?M0hqVU5wSkFuWmZtem81UUdTc2N3VHNGWXVvWGR5MTBBalRBaEhPOUtMdXk1?= =?utf-8?B?bitOQ0NHRGdpYTNCeUxobStVNWM1UUFFcXhZYlppdmtiR0VPRW55dGF6QkpJ?= =?utf-8?B?Um9rZ25CYk0zTlU4czZRWHZhL2sySGg3UHVZUFl0SC9UQlhDOEVueFZ6NGxp?= =?utf-8?B?UVVRb0NEWDM2RFhTSVltYWFvS0o3REpIaU5Zb2xKYVRaUHB4MXZJTzhrdXNy?= =?utf-8?B?dHIyTnR3dENmcTlqUkVJYTJyNmRFcFRYY0wyT2tzTkZMOS90UE5jVlZyOVRD?= =?utf-8?B?ZndMWk1Pall4OVRWMVZ2MEluMGF5S2ZkRmV0YmVVaXExazYvWkxaODk0REI1?= =?utf-8?B?SWFZeDQvRDdiRWd2bkZOOEs2LzVUVklndU9GQ0padW9wV2piN0FlSlU2Rjl1?= =?utf-8?B?dlJULytOYS9HTkJyMDYvQ2NQNE0xSlExelpJanZ2eHVnVHF4SG9ZWTNXVlgv?= =?utf-8?B?NVg5UT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlYzdGlNUmJ2NkswRHZISzBqSzAvSkJVWTMrczdQQ2JSdGxsUHZQYVE5M01M?= =?utf-8?B?OHh0QjllSEwzNmJQUUtXVVMyS3BDbmRPbWJHeXI2UmZucm01ay82eU1YQWpC?= =?utf-8?B?cUV5bWFOV3NEb0I5b3RrbWxQOGc4N3FOb29rOWZyTndRaTgwSWNuelA3dzN6?= =?utf-8?B?R21PRlNpeTlvVG10SnFLQXA2dHFMUlhVNFcxVndOWjFrUFFIMDl4cEpHMGJt?= =?utf-8?B?WS9wbVFZektOanFnQkk1ZXZsd1I3VmlGWmZkR01PWkQxcmJhQkt6SThKUit1?= =?utf-8?B?QzJhRks3QThVTXpFSElBT1kyNVF1NlZuVVorWUROdHpsWXRzYndqbzZZR1l2?= =?utf-8?B?ZmkvNVZWRUdDcFdadE92ZTdkTkZnOWxNdTVqQmJwK3pYQzJjb3c0aDVMN3Fh?= =?utf-8?B?cEM3ai9tQWFXM0syS1UvcXJuN2tmMnJJaHNXVGd3ZjJqYUVXeXc1QXNQWk42?= =?utf-8?B?dGRoRTd1eFlETXpvM3ZjOGducElQVGpXUWZSL1dzS00zbkc2Y0xBU0VMSTBz?= =?utf-8?B?R0hIY3B4N2J1NVprM0JQZm16NnB4R1dncTMvMTNNY2xYWXRMOTZnSFVvS1pN?= =?utf-8?B?ZnYzZzF6ZWhyVDd2VXhFZ3pIeXcyQnlBWGlMUU9Xc2dYTWFwcUFFUWJaTVI1?= =?utf-8?B?aTZFbWpreXcxWTJoS093cWF1UXlsS01MSkl2UEZBOWh6OTlNOENpRUVFU25T?= =?utf-8?B?ejFSU0swZkk4NEhQc0hnMERoZENMc2dTKzl4WFJjTlkzTFpkTlpqekdOL3pn?= =?utf-8?B?Smpvc2JCRWFBaHRWY1hET2JYQjB2N3FseEtpcUdmK21nNlVocEFJYnkwQStw?= =?utf-8?B?aHhFVmxDTEhPbDZJbHdLVTBHZDNMOGJDQjZGSU1KNG9MbzNISUxKR2JndG9Z?= =?utf-8?B?UnR2bHQycFhPQ0l6RVBWblBqRm84YTJFSUlqcGg0dEVqZ0IwbVlLUE5sYzht?= =?utf-8?B?SitnRlZkN3JvNWNsUXp4Qm11WnVJVmV4TFVGWnB3bU1kK1dqdUgwbnV5d1gx?= =?utf-8?B?TWxpd1hJM3BSWlRMbzRyMC95MlljMmpQZ3kzU0ZrR25JV09wRXRJRkU3MzJM?= =?utf-8?B?WkY1VGhwT2xzRER1Z28zM2QvbWEvL1MwS3pQbmkwNEhjamlTYXoxOEZaazk4?= =?utf-8?B?RmhlYVlDQXF0eWRuVy9aMlJrTTViTEFRNGdrSDdFQzBnaUplbTkvS2VITW1F?= =?utf-8?B?M1VkT2lyYkwvb0pSYUZkSXZOTyt1bzZ3M3BhNUtPbW9jVGh3YytMbXJxRVBk?= =?utf-8?B?cUE3SXJyNjNURFllR3pHUENJTWpNS1FRdkM1Z3psbTdKSTBRbnB2NGxoOFVG?= =?utf-8?B?bHF6bTZMWHlVUzBCbGtINmpCNHFLT25ZVEpwRUN1SG51YVJPMFhQYkRlbGNh?= =?utf-8?B?VTd6YUJRVXZQVUVEaS9GN1V0YmpqTHBxQ1lxRHU0RGp5Vm1hQzBaS2dMeEhI?= =?utf-8?B?NW96c1lnZ1gxSWJTQ09ibjd5Rkp6cEI5eGxmWlg1OXlxSkNQazY3WFpIaFRE?= =?utf-8?B?SmU5eTlUYXQ2cmhSM2Y2dFhhREMwNWVpVW9DWmJwZGpsZG9YcE1GT0dTZVgv?= =?utf-8?B?Z3o2LzFNTk9PTitGd015bU1QdUJIcllXSUpzOGxubGpBZG8rNWd1M3p2UFkz?= =?utf-8?B?cFpiMGVoZ2J4S2JNZHFxblFReFJsOHl2V01RSkpvMjJjNWtmNVdFUWpGMVls?= =?utf-8?B?djY2RXZoV3hVeS9waWFVMC9KeXJWN1VGKy9MVzFmNEZLL2JMdzFNVm1YSGkr?= =?utf-8?Q?lQGM2jCdYAshfaoO5hkcUyUZjMi5XmB1PpIiv4t?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e108cf0c-247a-4404-139c-08dd7c9f0449 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2025 04:27:37.3491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0118 Subject: Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/GV1P250MB073782E37FF068C4070974E08FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> softworkz .: > > >> -----Original Message----- >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of >> Andreas Rheinhardt >> Sent: Dienstag, 15. April 2025 10:36 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 01/12] >> fftools/textformat/avtextformat: Simplify avtext_print_rational() >> >> softworkz .: >>> >>> >>>> -----Original Message----- >>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of >>>> Andreas Rheinhardt >>>> Sent: Dienstag, 15. April 2025 03:00 >>>> To: FFmpeg development discussions and patches <ffmpeg- >>>> devel@ffmpeg.org> >>>> Subject: [FFmpeg-devel] [PATCH 01/12] >> fftools/textformat/avtextformat: >>>> Simplify avtext_print_rational() >>>> >>>> Patches attached. >>>> >>>> - Andreas >>> >>> >>> Hi Andreas, >>> >>> thanks a lot for working through this. I'll go over it tomorrow. >>> >>> As to not waste your time, it's probably best when we get those >>> changes applied in a timely manner so that I can rebase the new >>> patchset on top of it. >>> >>> Since you're sending the patches as attachments: >>> How do you want me to reply with code context? Whole files or >>> just snippets? And quoted? >>> >> >> Snippets is better. So is quoted. >> >> - Andreas >> > > Hi Andreas, > > thanks again for the well-spotted improvements. Just two notes: > > > 0007-fftools-textformat-Use-av_default_item_name.patch > > In the new patchset, those macros are removed from the individual > files. There's now a single macro in tf_internal.h and I've applied > this change there. So you use a move/deduplicate commit to change something? Not good. > > 0008-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch > 0009-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch > > Can this happen? Of course it can. All allocations can fail. That's why we check them. Have you been coding with the assumption that allocations never fail? (You can use av_max_alloc(1); to simulate allocation failures.) > (yet I'm good with it) > > > Everything else LGTM: > > 0001-fftools-textformat-avtextformat-Simplify-avtext_prin.patch > 0002-fftools-textformat-Use-not-for-lavu-headers.patch > 0003-fftools-textformat-tw_avio-Remove-unused-private-cla.patch > 0004-fftools-textformat-tw_avio-Don-t-flush-unnecessarily.patch > 0005-fftools-textformat-tw_avio-Use-avio_closep.patch > 0006-textformat-tw_avio-Remove-close_on_uninit-param-from.patch > > 0010-fftools-textformat-avtextformat-Initialize-stuff-ear.patch > 0011-fftools-textformat-avtextformat-Add-missing-AVERROR.patch > 0012-fftools-textformat-avtextformat-Make-close-functions.patch > > > From my side, it would be great when we can get this merged asap, > then I'll post a rebased version of the patchset, also accounting > for your other review comment. Done (with the exception of the av_default_item_name commit). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".