From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1038D4B7AC for ; Thu, 13 Jun 2024 08:50:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C206768D98C; Thu, 13 Jun 2024 11:50:47 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2105.outbound.protection.outlook.com [40.92.75.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACE3968D95C for ; Thu, 13 Jun 2024 11:50:40 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJvmlutnHhVZaVFGcFz/34yrayDqe/AGbwTnvy2DETK1WUi2nEA7rFVwnTid1zIZDpVQ7i0twRBjHe6ayCxMxgcp8R+KmfTjWIwRxYrAoZ0UXpTDbhFYTYe261DVfdE/VfVyT0wqDlJtOrSz4dwD049QtCL9rZSR+zurtcO/ZMGcXJ8kst3BKlJhFFv5lUrCfDYYGTgQXVefZuKt9AN/U05AGf2Yv0mdHsxUIm/H/ofrGdYOAh9p+1TkWGEccHL1FQSHfVcSoUetU+nIvaY6oo1zQySki5gzVEztQuJ+Z3QgUy/FeLDSo2Rk+g7VVGNUwjx1pXxzeh9/IP2yWLeXhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kgXuYlGFBQwOwbCS/5ZAHTKL0X6a/oz/7PHPWClH+iA=; b=UzJvNr4u1e1G7cRQGrXYqnJFjoSGP627V6s+hDFlcAbkibwH2Q822K6HcWDQfppG3NThgMUKEehHg6+wZMCisd3LYdjowpBivr6uKWWONHASrnuC3uYZcl7eeWQindhKyR9uza5qRjfCpMWRN/6ynHEoVlX6Vdw7CrL5Xu7lSBcoV0qn5x+66FM+d1TUPlSno1niktZPaaJ0Ny7K12dFacGPRlFx18fukzVClWKk+5vrW+T5gULQWah7obV7Yk7xMs7cV7ojx04388/JTMf9sESHIoYg53tmSOYHgscpwxCJPQgl7LMTIfqYPosUhgIYFZWmqUEqUM1I5VuMGt6u9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgXuYlGFBQwOwbCS/5ZAHTKL0X6a/oz/7PHPWClH+iA=; b=lD9707MobBvll55lL+DLINznAjbUNKhIw10mU2yNtnAzxc/o7NYFwJiLAN1cBh6OS6yb01jKeuNC22jCppoJvXwP/fRvJhMJHODZgy/z5XcTm3myRndPKx8PAg7+rV7ZcO9RHy8Me3nRx2XL8lrH7fu6yaUTrBjQRdPHI8E6BWXaGvOHhHet1OY62E/T8H0xAZwQl0f7MSk2dIEdzGiJsg4fGHKMHUR6r3LmPoF/5GP/89oxisfCxKOoCGIzeNwMF0PYFE7nPihE1yYFzofoCTbmIXvCcGc9LmGjNXEkJLwiSqhtE2gbOlAXmUdJ6tiM4A7Q9RGGMNAdpdNRPtb28w== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0282.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:371::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.24; Thu, 13 Jun 2024 08:50:39 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7633.036; Thu, 13 Jun 2024 08:50:39 +0000 Message-ID: Date: Thu, 13 Jun 2024 10:50:36 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240613073654.GB2821752@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240613073654.GB2821752@pb2> X-TMN: [KA7/bmom05NcUfh/Shu/+R5x+LXdlnTyI2A1zviF7rI=] X-ClientProxiedBy: ZR0P278CA0145.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::15) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0282:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f3e8563-d943-42a3-6260-08dc8b85e677 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199022|3412199019|440099022; X-Microsoft-Antispam-Message-Info: C4muhDgNbgxcEJdaskE8e0nBbu9gurs9copp5GzgOJyUKRi0QK4LSC/J2zA0HMRQPdva1Z9OgljzeUiFxt5OEJb/D/N78J/3KH8x7V2w4B5XvAAkgzd4n+m/5Yk34ya2h+SBEWvPH7+Jbag+hY0K4b9C5Z5lAHfOZKhtvJZl+NLKInajewZObZeNnDsdqWfim/JSa9aV/PA1d++LkFq5gbGwYDS/b17BfRQStdlHi8JBU9ORaHfCG/8+UfMHGZrjvVB+rHzS6bp0pH5oJsMRmjvwsiSFnnKpvfZ18nXd+4PVe8/E7+SIuSKZgDcWGgwzo1ZLdi5b8s41gSFlvx9zQB9KOnmp6VzMjyL7/kd7COKkLiKCBw4bty5nFDjyS5E02ZS22zDYIKRZZ/lDSRbL+JDVKXMtyBwHET+wZIIPBjglnLjCR/wmgywe+Zlq3ixBWOU87xcQFTnWRmkiugyKuoWb1gRV8NQo+w/8ReZvgKHrR+Soyd62bHKKVSQ8yr482T1XjLsKRyYDilLiJTduCnLCFmj33voZUfJV/NM8X/1exH6F5Uln9+U6Gp7wzNni X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1ppOFdyZzZKOXhTVzdDN3BPbUF0QjA1aFMrbjk5WmNEMVRreGNMZjJUVXNh?= =?utf-8?B?eGZiTnkxcjJMYXBGYmNTQVoxSVRWN2t4RU4wenl2OE9wOU96d0crTk90NmEr?= =?utf-8?B?RXRDekZ2WVFTTTRYWEszM25KdEdNaVVzb21RdmRWYVB1cW1iTjAzWW0zRFl3?= =?utf-8?B?SVI1V1I2b2h3ZVpBVXQ2NHNVRmIyeTd5OTRIOUtmWmxRUHJDbUZMTjFQOXZs?= =?utf-8?B?azYwVWRSNlJQUWJqN1B1RUJOc24wZ210dXg0K2h3dDIxcVpUZCtBcS9LRlE3?= =?utf-8?B?SWQ0cmU1NlVIUGhNMzJZcVpBVktlOFl0NmxDQ1ZKbkpEZFB4UnFQUUdFOFpX?= =?utf-8?B?SW1OaWlkWWhXRWI4SElPTHUraVl1M29vakRuQnUremxKZkNDQWdrcExHRjdr?= =?utf-8?B?ellMbC95L05LUmNrZTJvYUxobDFuRnp3YnVLOHRVVVErYU53R2NrbE4yVW1B?= =?utf-8?B?N1ozM0FHcmM5Q1NxQW9ITHlXRUd6YThWb3FRTEtqcXQvZ01MTzRFOE1OdEU2?= =?utf-8?B?TDVEdlJWZklRcUlvVFVpakdpTUNXOTVCaHJ6Nk1LbXBpMmxYbUVkSklhVjA1?= =?utf-8?B?UVh0TXdpUmJsQXVIUUREVjdibGsyTERRa3Fhb245a1pqWEZVdDRwanViRXM2?= =?utf-8?B?VS9OOXRIbEVQRDRoa2ZMRlFjOFhjM0ltR2JNanNPcTdNcXQ0KzMyWGcxTVlh?= =?utf-8?B?Q0hQRnBPV0NyeG5xNWJweGhMbklaN1lSb1hFb2QwTUhFM3MrU1pFaUNZblpP?= =?utf-8?B?TEllSVJTdFNYaGR2b1FjVmg0YXpyV1Ayd1dCS2tiNmxka00vOTFxVFZBMnVo?= =?utf-8?B?NklxUkxiZkZKNk96WEVMR0w5WFhqeTdkbFYvaC9ueWYyVTJMUHFaNjhGMldH?= =?utf-8?B?N3dzWjlPb082a1NRRk0yNXc5TlpReDhOSGhYMHYydWNlakw3MmtncUppd0c5?= =?utf-8?B?ekxrZEtCNmpWVlFZTTcxamt5ckRZakcyMUdSMzRLMjNnb3djaHY4NzlIVmFv?= =?utf-8?B?Q1ZGeVVwdTRmaFZCeU1IN0loY1VkV2Z6KzJmZjBrSjFRRkVTS2Ixd3F1K3NW?= =?utf-8?B?SFY0NnJQRjUvT1NuUmd2bWRXN29qRmg4ak4wQitaUGtFcnVoNWx3TjIrU1VL?= =?utf-8?B?Q2pGT0JKVlhXQ2JWaktmSEhKN20vaFNNY3IycFAvenZaT211UklCb2F6dDN6?= =?utf-8?B?eHN5YVF6eGhSWStzd2ZLTEVOdzRSYkNuSlJ4QmZkZkRSUGFoTzR5SnVMcDg2?= =?utf-8?B?cDVmcGlBNGUxMUJDNzRKUVJ6bmp3b3pIaS9rSFVoNEFCZTZhdlI5OEwxdElK?= =?utf-8?B?V1UxUUlBL3dkdnBtTzdQa1BjVnJ3U0dMSG9oa1UyTUtLRFoxMkdKVEp2Mlps?= =?utf-8?B?RTAxQXV5NnJPZVRHZ1lEWE9xZVRCRXNPTnlodU0yQTFKZmkrUldhbGV4eExP?= =?utf-8?B?NktFQ0ZaNXliNTNsUkxmMHpyQlRYQ2t0bU9LU29YVHRvSGtzSEdCTm9pQmlM?= =?utf-8?B?Wk51TFNtYnJiZzJNMmNFL0E4YlIzZU82U2dFNHBhQjF0U2N3M2lRalpBY0dK?= =?utf-8?B?ekZ6YURDdHMyS0hpdFBFM1VBcFJRZ3ZzOVhqa3QvbnI0dXpSZHBXU3BZL1dS?= =?utf-8?B?OGRFTlg3eDZ3amJXWlBOY1lWcGkyeHJFWm5YNktxMzgzWEdQeE9EK2oza2VG?= =?utf-8?B?dWJtOUVwQUNaOFJOWGhpNkxqc0lDQWZWQS9EK0hmRGtuVGMzRmFUZEd3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3e8563-d943-42a3-6260-08dc8b85e677 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 08:50:39.5202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0282 Subject: Re: [FFmpeg-devel] [PATCH 33/57] avcodec/mpv_reconstruct_mb_template: Don't unnecessarily copy data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Jun 12, 2024 at 03:48:29PM +0200, Andreas Rheinhardt wrote: >> There is no reason to use a temporary buffer as destination >> for the new macroblock before copying it into its proper place. >> >> (History: 3994623df2efd2749631c3492184dd8d4ffa9d1b changed >> the precursor of ff_mpv_reconstruct_mb() to always decode >> to the first row of macroblocks for B pictures when >> a draw_horiz_band callback is set (they are exported to the caller >> via said callback and each row overwrites the previously decoded >> row; this was probably intended as a cache-optimization). >> Later b68ab2609c67d07b6f12ed65125d76bf9a054479 changed this >> to the current form in which a scratchpad buffer is used when >> decoding B-pictures without draw_horiz_band callback, followed >> by copying the block from the scratchpad buffer to the actual >> destination. I do not know what the aim of this was. When thinking >> of it as a cache optimization, it makes sense to not use it >> when the aforementioned draw_horiz_band optimization is in effect, >> because then the destination row can be presumed to be hot >> already. But then it makes no sense to restrict this optimization >> to B-frames.) > > IIRC > The B frames where directly placed in GPU memory, which is slow to read > from, so building up MC + IDCT (which could read depending on caches) > was avoided by a a scratchpad but its really long ago so i might remember > this only partly > The code here is not executed for hardware acceleration at all. For the ordinary case, this copy incurs overhead; furthermore it increases complexity (and for these reasons no other codec has similar code). So I'd like to remove it (with an amended commit message that says that this was done due to concerns about reading from GPU memory). Do you object to this? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".