Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Don't copy A53 closed captions by default

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Don't copy A53 closed captions by default
Date: Tue, 11 Jun 2024 10:05:54 +0200
Message-ID: <GV1P250MB073780FE5472D0DA0CC78A598FC72@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <501e38d3c8a0ebbdf518ccef459cc17fd97ed589.camel@haerdin.se>

Tomas Härdin:
> tis 2024-06-11 klockan 09:42 +0200 skrev Andreas Rheinhardt:
>> The SEI handling of libx265 is buggy and can easily lead
>> to memory corruption: It reuses certain buffers, but when
>> reusing them it presumes that it is enough for these buffers
>> to exist and does not check whether they are actually large
>> enough to hold what is intended to be stored in them.*
>>
>> Our users are exposed to this because forwarding A53 CC data
>> is enabled by default. Change this to make it disabled
>> by default.
>>
>> "Fixes" tickets #9666, #10411, #11052 and (presumably) #10906.
> 
> Shouldn't users use non-buggy versions of libx26? I've had people ask
> about CC, and I'm sure many users would be annoyed at them suddenly
> breaking. I suggest complaining loudly at compile time and/or when
> loading libx265 instead

Non-buggy versions of libx265? People use what they have because it exists.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".