From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dsp: Use unsigned to avoid overflow
Date: Tue, 27 Sep 2022 03:47:29 +0200
Message-ID: <GV1P250MB07377FF4AAC085EC65213D3B8F559@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
Affected the jpeg2000dsp checkasm test.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/jpeg2000dsp.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavcodec/jpeg2000dsp.c b/libavcodec/jpeg2000dsp.c
index b61be3b72f..b1bff6d5b1 100644
--- a/libavcodec/jpeg2000dsp.c
+++ b/libavcodec/jpeg2000dsp.c
@@ -76,14 +76,13 @@ static void ict_int(void *_src0, void *_src1, void *_src2, int csize)
static void rct_int(void *_src0, void *_src1, void *_src2, int csize)
{
- int32_t *src0 = _src0, *src1 = _src1, *src2 = _src2;
- int32_t i0, i1, i2;
+ uint32_t *src0 = _src0, *src1 = _src1, *src2 = _src2;
int i;
for (i = 0; i < csize; i++) {
- i1 = *src0 - (*src2 + *src1 >> 2);
- i0 = i1 + *src2;
- i2 = i1 + *src1;
+ uint32_t i1 = *src0 - ((int32_t)(*src2 + *src1) >> 2);
+ int32_t i0 = i1 + *src2;
+ int32_t i2 = i1 + *src1;
*src0++ = i0;
*src1++ = i1;
*src2++ = i2;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-09-27 1:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 1:47 Andreas Rheinhardt [this message]
2022-09-27 8:07 ` Tomas Härdin
2022-09-27 11:20 ` Andreas Rheinhardt
2022-09-27 11:38 ` Tomas Härdin
2022-09-27 11:41 ` Andreas Rheinhardt
2022-10-02 17:18 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07377FF4AAC085EC65213D3B8F559@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git