From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 03/10] avfilter/avfilter: Use AV_DICT_DONT_STRDUP_(KEY|VAL) when possible
Date: Sun, 31 Mar 2024 07:31:16 +0200
Message-ID: <GV1P250MB07377F11351AF5D827277D3E8F382@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737617682B4E58E89589F5E8F382@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavfilter/avfilter.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index 856862a393..508fe1b26b 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -844,6 +844,7 @@ int ff_filter_opt_parse(void *logctx, const AVClass *priv_class,
while (*args) {
const char *shorthand = NULL;
+ int additional_flags = 0;
if (priv_class)
o = av_opt_next(&priv_class, o);
@@ -869,7 +870,7 @@ int ff_filter_opt_parse(void *logctx, const AVClass *priv_class,
args++;
if (parsed_key) {
key = parsed_key;
-
+ additional_flags = AV_DICT_DONT_STRDUP_KEY;
/* discard all remaining shorthand */
if (priv_class)
while ((o = av_opt_next(&priv_class, o)));
@@ -879,10 +880,8 @@ int ff_filter_opt_parse(void *logctx, const AVClass *priv_class,
av_log(logctx, AV_LOG_DEBUG, "Setting '%s' to value '%s'\n", key, value);
- av_dict_set(options, key, value, AV_DICT_MULTIKEY);
-
- av_free(value);
- av_free(parsed_key);
+ av_dict_set(options, key, value,
+ additional_flags | AV_DICT_DONT_STRDUP_VAL | AV_DICT_MULTIKEY);
}
return 0;
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-31 5:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 5:30 [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 02/10] avcodec/tiff: Don't cast const away via bsearch Andreas Rheinhardt
2024-03-31 5:31 ` Andreas Rheinhardt [this message]
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 04/10] avfilter/avfilter: Honour the short options documentation Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 05/10] avfilter/vf_swapuv: Remove empty options and AVClass Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 06/10] avfilter/vf_vflip: " Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 07/10] avfilter/vf_hflip: " Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 08/10] avfilter/vf_grayworld: " Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 09/10] avfilter/avfilter: Don't use av_uninit Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 10/10] all: " Andreas Rheinhardt
2024-04-01 18:21 ` [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled James Zern via ffmpeg-devel
2024-04-01 18:28 ` Andreas Rheinhardt
2024-04-02 18:32 ` James Zern via ffmpeg-devel
2024-04-03 8:36 ` Anton Khirnov
2024-04-03 15:28 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07377F11351AF5D827277D3E8F382@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git