From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D23F344AB3 for ; Wed, 2 Nov 2022 21:16:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6FD9468BEC5; Wed, 2 Nov 2022 23:16:54 +0200 (EET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066030.outbound.protection.outlook.com [40.92.66.30]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42C5C68BD43 for ; Wed, 2 Nov 2022 23:16:48 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MAUt8bDjj+s3psRPCYPwjLiodnjhdA8pfD1Z53iLn9gPjcLRgTnhrloPr1hl/BSlGEBnjQhjU8994m0NSs41C7lmv6P9U/+jIlLyu5P21+KwGCh6FM4N6iJvsFT/Q+kKtAKxwudilTHzzsgqswkGRX5PfuJivtQqjqO1g+9bT1qjFC3RB6WAGJ+r8a+GIFnan2MiE6YCR2xqZjZrlOiFMxBsF9xmVPM7+NAV5GKlqiJuKThvLGK3SVgMdTpDY5n1op+zlsVqLSrZFqgB+V62qbOlFX/1l3K49LmeGGk1O12GoXrOtxe4NF4v2suGSMRbm31Y4UciYGiuw1/S/GmlyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X+PTF4fpDYR1ih8ZG2QnFMx4ukt5WnwVgC9Wa2M6Fmo=; b=GRb2NLyBTQyiP7bb46syf/Z6ymC1ssm1cJnyTtsARUZrUe9dXhm22AFAn3JL7EHXV5458I2EXGbyPC3nIY9TXftF0Z8tf6Hn6CgQXJUBTGl7t5al1wWUm2IiOTTLXMgDu/UXlkZlKhhM+7uCHg32nh4qBzUPcESqb4YBwlsODiCqVw/GbJMKHwsPNHFrreVUYm2P/A0S52U87Uo5OoNFihDt1Vo7DRB/mpKeNMmwxN3pu0DE1nCAuVDNym1oeKGKrreaK3A77yH/AxkKXZVN+LIrRH1GIaze8nqS0YXJmTIAl46UaRqj3exzwKcWUG4jNjx1RhN5d9f+PZXvuCC67w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X+PTF4fpDYR1ih8ZG2QnFMx4ukt5WnwVgC9Wa2M6Fmo=; b=RZqWTakktspiMpFuMAkyPJAHLXpf4Y/yX0mVHy6C6qk8Lp2BQAKQVxXRNXCwNbRQb8TIQPG9csWepJg4rg1xpJXNoUT4cbalKfU8uL6W5Qna1RXmXDV0/V5qIc8qBZPlKBAZIQxvYJLmSmGc2GgY4wKxRRiIzFS1Pcy/Tpx36/P/6cyy+w0OjmnRHXTopqs3sCpuZQHpRWn4phlyyW2PLey/a4a0LraKhqEECg5TWwoAQaBuiCoXvdM3eK4MOF4euHh9ZVb4BlhFV1S3VsEwRFC4Aym77MhklCV/82r//i8qGy1Oa51P86yr5wGExZWYtRVdvM8sCqLZQt3zUclSuw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0813.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:535::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 21:16:47 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::739a:8740:19c5:925c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::739a:8740:19c5:925c%5]) with mapi id 15.20.5769.019; Wed, 2 Nov 2022 21:16:47 +0000 Message-ID: Date: Wed, 2 Nov 2022 22:16:57 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221102210239.1689-1-michael@niedermayer.cc> <20221102210239.1689-2-michael@niedermayer.cc> <20221102210714.GI1814017@pb2> From: Andreas Rheinhardt In-Reply-To: <20221102210714.GI1814017@pb2> X-TMN: [K99heAlAvHebcv+RxQoI6QySM9ARRTSRwG//+JS6sAU=] X-ClientProxiedBy: AM6PR02CA0012.eurprd02.prod.outlook.com (2603:10a6:20b:6e::25) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0813:EE_ X-MS-Office365-Filtering-Correlation-Id: 26fa7184-e6eb-43b9-db6a-08dabd178c9e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dGhnntipagZrIqr/Fp7FiMF4EoBhxy9NxGwh7Em3v2amrK7AZZoR5OagzRBdxwMIKr49PUPIXyZUyPpc8HieNtWCkjvAGrHQQAkQD5XLaCRXzimOFICSvRAaYeVv19hwVmifDLq75eUM7Zrg7A1tNDWavZ3DAbWPRd95DWSLnPoAfWt93zqoopWWAd42/H/vZV4AWg2/Zte+3htfylLxNPmfvnJojBToOIIGvMicm3PRUIJb8LLkhr3x5RVFcFxiIS1g3wAVEMaNY5W40NqUGRAapMDxR1/t2mLwXfl4DZR/LgNo9QDTnjV33VXA6Z3TUccNTsxcBM5ulDoP5G6Rti/jgbDX9S0kTzcTaUjyUs6/dAr+JLWWKltx5ReiYLqXJB9Jrhfhbq70qJ+4Tl+OqIP2oWf/N6AQPtJr7ZxdSbeqBqqNeLlPEjzQBXuI/3rtVg/8ykkjCeY2/WN/xwAtW1KirS2WMgcmuAe0xjkDX2UoBI1MXNVUGk+kL0RQj2DP9R4g4bO3TDriO597TF38CHPdjGtZCtOG8kTheA5D9+bYyFb0PgnH/0OGQf1JuU9U0u9dgh/0ZxmAOnS42Y+NIFiim8SS2p17GhUdP8slx2ZY1owk4XGNOrP7Isp4eDJR9mK60qPwV3FYWtgOAroE9Vr212iM1gbm/mXylzhMLFVEmFzawRT6zJe/NneqhAS3 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0V3K0V0MENqcFMybkdkUWlEZ2JQa1Z6eHJEMG5XL0FDdEtzUlYyTkxhVWVt?= =?utf-8?B?L0pLWCtKdGhpQmxyMCtTdW42R2xzQzNVUFpsU2ZvT2FucHZ5dVNYc2pnVlZD?= =?utf-8?B?WmpncU5TWWFIZ2NhWGlnbjVSTTdoR1g2V3Y2azZudkR6aFVVY09vLzFleVNB?= =?utf-8?B?R0ZmSUQ1aXUxVUVQQ21rR1A4d2VPOUZWSkwzZWJqMU9QMmN0VjVxZHM4VG9x?= =?utf-8?B?UzYrSzBway91NzZQOENhQ1lrakFxMUx1QmIxbkM0NCttaGZ1V1B2T0RvRXZh?= =?utf-8?B?bnNqdzF6NHd1M3c3RjF4a0NlZkYrZERjaTE1RDFQeW5ibU1ZWGJWcXB1NGl3?= =?utf-8?B?bDU2Yi8rTmJJaDhsZXdLZUNQNlJSWUI5S2RpQUxieTQ4b0xKcmdBYzV2V0RR?= =?utf-8?B?bjFmU0FjTCtIWCtyRG5VbExvRkVQMzl3UXZFSlphQkRCbUdDQ1JTcGpsdmJm?= =?utf-8?B?YThZcmRpelNBUTl2TlBBUTEya2ZmQVIrNlBpU2pLdnJOblJ6cC9jY3g2anNj?= =?utf-8?B?U3VCNEdSYW5aOS9QNmM5TDFnaHhLOGZ3bGxORDFHaE1HcVF6WHpqRnpxR3Vp?= =?utf-8?B?WERzWG5OcGNlMmd5TUl0MElKdlAvY3IzWjVPZEt4U1k4bUNsYVVhNWdQS2RG?= =?utf-8?B?SGRxaU9RTkZxS1A2Z0tSRGpwc2RXTHAzUVk0UlpWTU04QlJIS3pzcVEyT3F3?= =?utf-8?B?WGRjTktLaVN5K0o5UTgxbW42MU9RRTBnTVJpQWdlTW5LL3FnSXNzdDE0dWpT?= =?utf-8?B?blZGVjJqOUluZ011YmJ4T1cvTXBTejlRZlFuWERUK3JnVkduQmN3b05RZjdS?= =?utf-8?B?UEQ3S0dFdWtib2hCbkZMMVFlYzJzRFM4NkcweGMrcmlIK0FpZzVYUVROeUZQ?= =?utf-8?B?TTlCRG5ERlJuZWkxOFFzWWl1Q2tTVkpIcHZZWDNSZEttQ01GYnc2YkNQVCtx?= =?utf-8?B?N2tFSVhwSHRFZExvZmFKNEhRSi9kekZGeFRkL01NL2JZTllrVVhEYjNqZFRN?= =?utf-8?B?SUN4RTVmeHBPSlUvVlFka0hYc3pwVHoyTVFPME4wb3A3R2E3NkJjM1R4eUp2?= =?utf-8?B?dnk4Y0xJVEtMK1JidTZyU01PWDFlOVF3Z21NdU9XeUZqcXlucUVqL2FYWFdS?= =?utf-8?B?UENLVHhjVEtKSStheHowYXNwWnI5NDNubytkSHRyQnVsdEJlRVFzTTg2UU5i?= =?utf-8?B?UUQzR2h5dHRRS0dDaUF1VU5XbVp4SE1OWlhFNVhZSW5GVEowWTFHVVdPMWJP?= =?utf-8?B?THVMVlZ6UXQvNXBLZDgwNVM4cHJVaG01THYyMmdnWWRWQzN1RHNJVjIvVFlG?= =?utf-8?B?dHc1MWhPSWFxMUduR251ME4rQzd6VUJlNkE3ZnpDRHVmTndxa1VrclR0Yzdi?= =?utf-8?B?cjgrVHhpRCtNSS9IRmNUNXNFbGVuV1J5SEh4TmJ6VmluR2FzcllZTzNKZmlS?= =?utf-8?B?dGpVd1RLSjFNdFc2enFSNjRJK2xtbVJjOXBQRzYrUlYrdGp3bmFkREUvSjBY?= =?utf-8?B?Y3pzaDVYdFVPek00ZnUyNDdYWmJWMFVYdlp2T0g5cXFhZmJTVG1xZXBmcHZG?= =?utf-8?B?WXVVSG9RSVZhc2doNjJraDNpMXFvcWU2ZDMzc2R2V2ZzUmFYMzJaN2Z5M3B0?= =?utf-8?B?aEpLcXNWQVVZZ1hZanZITnJqclFkQkRNekVqalZwVmV5TDhCTEZnS0dvUm13?= =?utf-8?B?dWo4K1YzOGRlVlhGanBuemNBQmJBRUZKN1A1Ukt1bDRyNnR2dGZDOEd4MkhS?= =?utf-8?Q?LGRW0tUhTIqQM7C2xkduqlI19Ugq/UteLw4KjxN?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26fa7184-e6eb-43b9-db6a-08dabd178c9e X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 21:16:46.9964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0813 Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/output: Bias 16bps output calculations to improve non overflowing range for GBRP16/GBRPF32 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Nov 02, 2022 at 10:02:39PM +0100, Michael Niedermayer wrote: >> Fixes: integer overflow >> Signed-off-by: Michael Niedermayer >> --- >> libswscale/output.c | 25 +++++++++++-------------- >> libswscale/x86/output.asm | 16 +++++++++++++++- >> 2 files changed, 26 insertions(+), 15 deletions(-) > > Note, these corner case overflows could affect some of the similary > implemented cases that are not depth 16 too > > ill fix them if issues are replicated > The checkasm-sw_gbrp runs into many overflows (when run under UBSan); e.g. fate.ffmpeg.org tells me of an issue in line 2289. Said line is not touched in your commits. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".