From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0DC27492F4 for ; Sun, 7 Apr 2024 22:51:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7F4568D233; Mon, 8 Apr 2024 01:51:18 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2013.outbound.protection.outlook.com [40.92.59.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C9B0668CD3F for ; Mon, 8 Apr 2024 01:51:11 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V20x9g5m9XtQ84aXvmCC4yy68qEOam+sgXsqzVmOVmvy7M675kugVN5u4M/VCQ9jZWG6UfxEmhRU5VRQxRFJf26kpyowCE0Q1mjrBP2JGNil2MN3aFUgx3KZkZfBMd0H3HYwlwejuxRn5mktaQZ5WQd8cLV0ae2CXHBwXH0AuUOY3nu0e9r2q6y9mtqcPyUnf4/5w3kuk6/YWUttxcYMABa6LfLpdMzscW2b1dOEjphKfvKwk1Jz9lMRTZMruH0JhHkLGi0iimGmQpcBujA0N4YtaAqeScIRgIIXWRDQD6SQnO1jV6o/9q1wZDPfclivZtvfZiVDDThvBYc5xnDALQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zeyeIpGKHPOs/J/G6HkZ4PRVTTZnEYQwak//iO0Oirw=; b=YWn+ZZrYFLYwXw1r8ua5MmH1EmWLGmUp7DdKlAcrP+HIuB1GyClGCLR0vzYUjmdQErna1yC1zSk+m4Hhni17LD7lq3II4eeQ4A+P81IU6I+V8+apkeQKDHC3QiJ7C50cWLLYnKEe38wrknmXcjfvKNDcIQovPLyMsDB4aeZLoVG2wYqxtSKElnIiBm8NQNv4A7dUzgwbiczvPF+XOa4WSjxz5DKxdWAMZabHDwOp8IK786WF7oUOyWYJGahkxHWuVoKxpgw4/+w6FutyRqORmD+8xGPXxLDq0ve1l6wtnm5THDy2j3+1wXCa0BaNkRvOuAQjxCa2hRs4qZIeoFq35A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zeyeIpGKHPOs/J/G6HkZ4PRVTTZnEYQwak//iO0Oirw=; b=DtsOBmPJZXNFU9+bYaF566OMAwvB1iNVZvjj9VFZMUTzO6Yy83+nqF9GqoSZKYpBjUjEPzEeG2/wFp01skGAPuDd959p+UVzCzrqGNDGjprn6EFulM349e+1BzHsPhkZ2M7/pUX1CLwyeDeF4Ezj0WK4na/md1nCIRkJsCLgMF3cRiKyPd9HJBUWCNs4HG15MPuGGoEhakvnxolyKrBCDFdkWvW2tTHA4zEtzyCfwL968+Swzp/aDm7B5L1cv7Jib+vzdDNB8N6HCrcGgm0sqTueS1MYL3gZ4tD9LbtOMcq6LGvGCPs7QCIujmsLt3o25MwosNdEc2kng3h+NX5cAw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS1P250MB0525.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4a2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sun, 7 Apr 2024 22:51:10 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Sun, 7 Apr 2024 22:51:10 +0000 Message-ID: Date: Mon, 8 Apr 2024 00:51:08 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [FbVBZJ62eUv9EbvqL4d51F628zfLK30InJpG1auEp+8=] X-ClientProxiedBy: FR3P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS1P250MB0525:EE_ X-MS-Office365-Filtering-Correlation-Id: 17cb324d-c50b-4bf0-611d-08dc575537da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ny1pDCG5IASU1PuTE4F9u1YbbE90BGcNPb48QlHQffbS6Jfxhj5CS9rEauhJCmKspNJwq5v8GrtLaZ108p1AMERHHeQ9n20ns9M5c2JgauqFzCrJuWDOMrvYv4WsoNIothUKbMVDxcHct+WtjsX7CX0YTexcfYTtub8VUqvLUShHdHxw9iqr1Q9BIkphZ7CDBoXSRe0lZvkcH8qpp6rswGNI6+qpSDz3ACxtCZRsuE64uJy9PM+4YJgbrZ3v/cEo+VjhzUXwM80nw6aBsWTj4KUbrUM847KU7EaK90xQfWDZKU87fUH4GL93I5WFCpunsfWezeU7TGRynjWGlmLUy1JxctBWHVhaKv4ZcEyOyc1W4bETaybRmou4jzLKTsJF0Pr2XVY966tyIO7ru1wePyBR+eC4k39/hP3Ge2L0wKoxKp/2uJh+YCQb7pu/MtBT+fDnkfLy8YtjEedD0WXaMNGIlcbpaU+ajGN3TuRlvYp8yBaReTLp6CN++deV8EKrLhAURW0NwVGMI9/oXcP3PjJStEdOBt+hEduUY1oVwSUuWD2X66wyma4fU8ItV5xi X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEpROWNERlQreE1hMTVCcDQ3cGJnaUFNZmMzNlJXZURDbCtudXdSN28yVng5?= =?utf-8?B?QUFxTDE2b1FHYk9xekF5b0xCZnhxL2NqaHdHenBxV1ZsdDFpYVdwUHd3amhL?= =?utf-8?B?aUZaNUNGcVI1NEk3YVZ0TVdLay9kSHNjVmRhR1NQNm1RNGlzTVlRRTFQRFdC?= =?utf-8?B?VlIyQ3pkMjhMVEpvNG9mTTJpUTdHczh3RDErbHhNK0JHZWFFczUzOU5pbXhU?= =?utf-8?B?Y2w2RWdnVDYzT3VoV1dtWFp4VXhsTE5qL2JnYnZYVm1McERmVlFYZDZlK3hj?= =?utf-8?B?M3B0YWNyMnp2Q3VPZzJtNWh2UmxnZ1hGbG9MRTN1bTdyNzhmUHQ4K2NwV2Fl?= =?utf-8?B?TTZubGdBbzZTN1o1TU5Vazg2U2VBNHk5cyt2TnVjbDBRUEhwV09vS0h0WHFI?= =?utf-8?B?ZmxVSWZvQno5d29GdVN1SUswNkI1NTkzRnhzL1RhMHdsUnpkN3l3cklGb3Mv?= =?utf-8?B?bEhKdHcyUTFZRHF6RlN0Q1REUEwvdkZNVG5YKzFoakJYeXIya0x4SDQwcU5i?= =?utf-8?B?UUJiWFJlMjlNajRHWjBZN3Jjam5aaFM4ZGRDQksrWE5WbU9mQnl3eGhZSnhF?= =?utf-8?B?a3daaXY3bXl5eUt4SGxFc21GNHR0Nk5CNXp2aVFiZ1ZEQkk0eG8rS1ZHMjNQ?= =?utf-8?B?Y0I1UHdVdXg3dXZYL3JoZjZ4WHUrY1plZVpycStsZmxSSTZvRDZoSU1OK2ZY?= =?utf-8?B?cmFVdW5Jb1ZjU0tFQWdnbVFjUWNkSE45RWI2dndsd1ArV1BRL0VDa1VLZ2VF?= =?utf-8?B?TjBUTUtKMlM5Sml6ME5qU3YwZUY0SVFwcDh5anNGSXJxMzE5OEtaRTJwcSti?= =?utf-8?B?ME1XSzYyczloMm82S2trSkZLMlVySHZFcGgyUVFpN2tjYzBya1d0QVJiT0s0?= =?utf-8?B?M05oamtzZW5yckUzOXJsKytZSUdqY1pGODB1MDFISDJIZ2hxOFBvSjhDblc2?= =?utf-8?B?bXZpUUlPd1NWZ0lKUXYrNXdMSVozQXU3WVNWQjlnbGw4b252K1NKUjdaanJ6?= =?utf-8?B?ejJMUko5K0Q1dlF4c0tidHhOSkJzR2Raanl4KzJNMFUvcmtmcUhXcnQ4dVVN?= =?utf-8?B?ZEtxL2pBSStrTFJNa0JzOU0vR1pVSW5tdDVlVmprdEI2WlVyaGp5cWJmdmsw?= =?utf-8?B?WDIvMjRQMy9vYXFJK1lNWFgrKzlHQ1BOU2d3Z1VvV3M3TjJERUdmcGp1TUpW?= =?utf-8?B?dDVyaTIrNlZhd0diN0I5SkY1S3BsVE4weG53T0p4Vm40c2hmQnowek9FcXNm?= =?utf-8?B?Y0FoYVN1NVpUNWpWd2xXcVRWSWdmMmg0Zy90M3lUMm9YczJhcFU1V1EzWWZZ?= =?utf-8?B?NytYbGdxVFFJRWU5WmRjZzFmTmJuajVGSnBDNCsybUpoRHNHQXJjU1lOdTVV?= =?utf-8?B?L1o0WVk1UHBDMWJJNEFUQkVZbUdMbkZsemZFQ0tXZU5NbHIra1dNSEhJS1VR?= =?utf-8?B?RWYwaVVYTXNyb2xtL25wcU9yQTQwUjIyb1J6d3hoNkJEdlpDSGM0NXcxVWRZ?= =?utf-8?B?ZlhFTkRNYk55TzlhM0JiYXk5Slg0WjFlVW1zT3ZkUHZWK0VhaXFsOUdlcFk0?= =?utf-8?B?Y1AyTVN6azluK2N1ZWpGZDZ1T2hiMUhsV1JnVW92c29UYUNiNXp2UVJ5MGlU?= =?utf-8?B?T0o5MlBId1NEd3hTbk95b0x4dEJJZVcyVWxqTmNpbHMvbzJyOUFVTzdnWDhw?= =?utf-8?B?S24yc3pUUmdjdVlrY1paUHp2VVdHVGc0eWl1RGlJcmtlWjE4TkhnNWlRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17cb324d-c50b-4bf0-611d-08dc575537da X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2024 22:51:10.2402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0525 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: Reject input incompatible with chroma subsampling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Fixes ticket #10952. > > Discovered by: Zeng Yunxiang > Signed-off-by: Andreas Rheinhardt > --- > I am pretty sure that a lot of other encoders don't handle this well > either. Maybe we should handle this more generically in > ff_encode_preinit? > > libavcodec/mpegvideo_enc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index d1b1917824..a65ecc6839 100644 > --- a/libavcodec/mpegvideo_enc.c > +++ b/libavcodec/mpegvideo_enc.c > @@ -314,6 +314,7 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx) > AVCPBProperties *cpb_props; > int i, ret; > int mb_array_size, mv_table_size; > + int chroma_h_subsampling = 1, chroma_v_subsampling = 1; > > mpv_encode_defaults(s); > > @@ -325,14 +326,25 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx) > case AV_PIX_FMT_YUVJ422P: > case AV_PIX_FMT_YUV422P: > s->chroma_format = CHROMA_422; > + chroma_h_subsampling = 2; > break; > case AV_PIX_FMT_YUVJ420P: > case AV_PIX_FMT_YUV420P: > default: > s->chroma_format = CHROMA_420; > + chroma_h_subsampling = 2; > + chroma_v_subsampling = 2; > break; > } > > + if (avctx->width & (chroma_h_subsampling - 1) || > + avctx->height & (chroma_v_subsampling - 1)) { > + av_log(avctx, AV_LOG_ERROR, > + "Dimensions %dx%d incompatible with chroma subsampling.\n", > + avctx->width, avctx->height); > + return AVERROR(EINVAL); > + } > + > avctx->bits_per_raw_sample = av_clip(avctx->bits_per_raw_sample, 0, 8); > > s->bit_rate = avctx->bit_rate; Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".