From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E52046275 for ; Tue, 13 Jun 2023 16:56:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0908168C334; Tue, 13 Jun 2023 19:56:27 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2035.outbound.protection.outlook.com [40.92.91.35]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C48268BA73 for ; Tue, 13 Jun 2023 19:56:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XfY1IEdlfd2JqiBiKnEyXqolwbUcz9RIkIM+rx8JemzfD+RBr37d91zXQBjkgX7K+a2CYtd9SqBB1y0JfiDLjpLvj9ZNpZdSVQa07z6qf7uVeM2KZ0FAbmmJKM3WgbVfr3oOR5vPk6wKEtROBizWS0TZA6kjWEh4vLY0pk2oAeyPuCQN8oe8922SSYZsrlKiwlXulpwnykRyQJ8bGMl6/LRV12qferU9on7PHbE9JeomTyIwiRajTR/R1I6pWowlHlrBT0+bXpL0kdYfHO051w0BDBSpAoo6X1BB3Cy5zKnFsIESgzv6cNxW6zu/2RLCsljL0tRQIu5YKK7Jz7ggGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6zc7Qk44VJ3BLxl15mgfQLjZjMxWGTMGkkX9qXGpK2M=; b=j1b3FiipgktR0g/nqt/yn8EMS8GyPzEXd7Oxds9xwqQ1ckKvXqqjiKFAh2fIT77du0Q7AbXn74x/DH5tMUX+kurY3aHvc9n3zFuaNShanZyGVH3212PcSlCv7KyJ503FluU4t8dc0JsKNQQbK55AVBFm7oAPQcurUPJEqcMZ9iYSKECBVPSPjtuXtddM7xfJY00bv+YO5NA0DmPG4QKgs+dFu7MD+C9chbC7lU2xIEkaPp6S3VmlGhCCr3+A/UhOPaILGgdN9iif9383JfjrueHFfFScEttFMAUJ7gXHKhmyZhMA9B8Tl/edFmGOw+iFE5ft7++9Ne8aSbzLGWYQbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6zc7Qk44VJ3BLxl15mgfQLjZjMxWGTMGkkX9qXGpK2M=; b=acInLkVRm9OvvLenQphGGlKgFfcblj6KU4JvHJGX6e6rDl/TM8ZUIUMPvE5/gvw2kbKjTYthtQ4DYr4VLjexwDQIZj0do3gACPiwCZ/R5ZTOtJInTyp7lrqE5yxea7HTUDo7O9wuDsLn5RxhHWcklvOK09VLtweoqvs+TzJpPMLKUZuVSUfl9WjLi/1qrVlm+llEPIM1NTWO8B2H/FosP0jTenJK8z2xxgeg6KD08ZX2V1DGzgZw8xm9fT/t9P6MnM0okPKdLpVlOrLbNThiEJioZefViXxR4ACOkzZBHM30BGUdV/emjwPZOmC9QlRQQMSJQKN4O8qa5CLHQgQZjw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0019.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3da::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Tue, 13 Jun 2023 16:56:17 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::6328:a667:5a29:f1e1]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::6328:a667:5a29:f1e1%5]) with mapi id 15.20.6455.045; Tue, 13 Jun 2023 16:56:17 +0000 Message-ID: Date: Tue, 13 Jun 2023 18:57:05 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [prkQZ17MWE4YzXBZtx9I8icWAGF+iNlB] X-ClientProxiedBy: ZR0P278CA0006.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <3fb73630-42aa-44b3-2bc1-08b0273fee97@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0019:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a32f0af-0a6a-4bef-5cc8-08db6c2f1af9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XCn4hhEj6lb2AZ2GHK15oYIrTMIYPLE7PkrM3PAN98I8I77hK22oZD4eQzIWzjaaGjbWVNudAJOjN2+jHQFKZ9Nx/0w0t20couGCZetdEB/gNw3ajQre/urwnO0q+JQOliR4wnqG9J8RTR6xAqtPT43J+otJ02O6MVUgU90h2XT0Yjp/FIasX6qFsrdu607Ghq5AdsS7JfRt/41D2Z6/Tcx8i6PCTYC8pOEezBjXkOjmilRyvkb9Z17SAWbKN5X17McRlmn9KN0aiPwWNaVjb6uGvPZpmIDcP9ZU4KVjTLIKGkbRmGCkBZWsE80NSkIgLDis/oXRcb7TcsDIh5XLGUECJUo/ZkdvLTB9RuxPxKcg8eaQ6HP5fEqub+uP0D+DP8AxCYnzxkwEsCtsBZ0AGSZBW1KpOKEGAq4zDqzjp2uhY21PH2D+50SVwMG07xPyadSiLOYKxrXA4zym00bVUAnfOiPd9eiDbGoiKtapXcaxDRlhLN4RxjbN9B8zT5RATMopxZYghdmW+jOdzjQThvdIJgX3fjCE3b+eHC7ukjIONNRtQ9lkrS/qv4Hj6AXRfWF0tFn2LIquui4pYfsfIuNM0dgap8bmL+f0Q1gW9q8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW9mUjloYTIzdTRYSUptVFB4S091TXJxTldsaktVQit0SnpNSXN1cVVrY1cr?= =?utf-8?B?NTZRaVhnWnZLUU9RcCtwVEhQVis4aXg5Y081WW5waGRLc1cydmUzbkJqY09u?= =?utf-8?B?ZUovU1hBeDE1YWhtK3Vqa1BqOW5mMDU2N0hpZWpubXRxYkNrWTJRSm54bmNs?= =?utf-8?B?Z014bjFwekhHMTZnYjZWVUZYOXRoQUFjcUFnMUZYKzdWRWNGa01icVJsdlFi?= =?utf-8?B?dzROVGl6TDE2RGF4eE5CTkJnNnk2WGppOTNBeVJHdFNyMzlYZEl0R1J3U2xL?= =?utf-8?B?RlJwL0pKWFNFYjdVY0VYYTREVEthTTBPd0liaW5aaGMwczVLbHh1VEFJNVJo?= =?utf-8?B?anpjOGtzYW8vbzlFeU5tcnA3b25jd1RESkJ3ZVhpUFJ1QUladDgyaXRrSUdT?= =?utf-8?B?S2RLY2hGcVVUdE1UMlMxWWpTNnBVejZMbGx3czhEaVc2SEVYMWwyVnprR3g5?= =?utf-8?B?eHdQdkFIWVFNd0ZDdXRoRVM2QXFNc3dhME1sNDZnWUp0ZUhuU2xkbXRjTmRG?= =?utf-8?B?V3FaQ0szNjN4c3Y5b2tNaXhZNnUxd0RVNHQzUTdCeFVUcExaZUtIMGZERnhx?= =?utf-8?B?TTEvMys5aktOTC85Slh4RytZbnpPUExKbkJQR3ZGbzI3SW9pdDdFSER1cCtL?= =?utf-8?B?K21CRzIxT0E4M0dLcnliNVV3R3B5dUhhWXcyeDdWV3pPTnVFZDI3SzBxL0ty?= =?utf-8?B?Ni9HbUJoZjkwL1Y0SlZzUy82TlpGQ04rZHdnY3hXbTBEZ3ZQdzR2STczM0JJ?= =?utf-8?B?dnphMERqMDN6Y0tDUys1VkJaZ1VIOHBKWFFXdU1kVTZRNWRTdWY0eCsvUzlU?= =?utf-8?B?aWVmS0pkc2Y3YXJSc05QL0paeW1xdmNUK2RJazdQbFdBdHdJM3pvRjdpSURh?= =?utf-8?B?c3VPRjZXWHJMQ3M0VWF1ejM5Z2R3OU45ZEJ2Y1psempSYlJOU05rSEs5WXhJ?= =?utf-8?B?eUhPL2NNL2NyRURxN3R5b2E4NnAxbDZ2aU9pS1ZxRm5YaUFCdmlpZ3lCZHkw?= =?utf-8?B?Z2ZGQ1p1eXZ5aTk2SGJPUnJEVHZOZndQcHBzT25ac3dXeGEyN0pRYmJ4VkpI?= =?utf-8?B?WkNuL2tSL3gyV24wampYR1NCNmQ3Z3dHWVozWXJFR1N1Q0VYSEFTV2dWeWFa?= =?utf-8?B?Y0x1TmU1MmJHVGZJU2ZCcWJRMUY0blpiUTBKNEY4UWljK1F5SnRXMzRMUjZS?= =?utf-8?B?VlB6TThTcDViaFQvRG1mcE5KbC9EQjJPUUF5VDd1NWpUd3MxYk5YRmxDT1lY?= =?utf-8?B?ZGd3a25hOEVPbWxicG1zb1NzR0lNUkxBK1M4S2Q5dFFhdHV5RnZEYnliT3h0?= =?utf-8?B?azFabGdGUllWLzduWDlHUVBUc1R3ZXZzakNZaFdJeE1Yb08rZjRzVXJ6QkUz?= =?utf-8?B?WHFXc2lhNjBLUUpSdDl1MnJtZGlvTzNSUTlPMDBCZnZ5RnVDdGxLZnRuWGI5?= =?utf-8?B?U01CbnpnSDdOaGJWOEREWDNmV2FlQXk3ckM1eFg0WmdPQXRZOFBDc1lIYjNn?= =?utf-8?B?ODZCOTE4aGdLQlVnT2p1cndlUmJleS9BYXdiRE9ka1N2TDFMdnRUWE43MldN?= =?utf-8?B?dDM0MlZGTDA2bWpHdW1SWmtiTU56SE9KY3hUL3NKZ25nRmpsK3padnBmbDdY?= =?utf-8?B?MERzYWFBMG5GVFdhQi93MWJrZ2dQUmV2YUNmMEdBR3Yva3RLekxtRWVLT1Rw?= =?utf-8?Q?Ja8KmqtDZVdzJL8z+mlI?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a32f0af-0a6a-4bef-5cc8-08db6c2f1af9 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 16:56:17.8441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0019 Subject: Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > + dst->opaque = av_buffer_ref(src->opaque); > + if (!dst->opaque) { > + ret = AVERROR(ENOMEM); > + goto fail; > + } According to the doxy, opaque can be left unset (and will be given that it is a new field), yet av_buffer_ref(NULL) will crash. We have av_buffer_replace() for something like that. How has this even been tested? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".